polaris_view_components 2.5.1 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 844772037383b5a3a5948abf382bdac0457cb176c69aa4076c6438755a21a9fb
-  data.tar.gz: dd5815857d18332ea24ba3a2bf8527dd3db33edc1aa7894a0da71914e001a2d2
+  metadata.gz: ca5d44863ed4e92c96355b43938b83e3d6c35faf836f21ec8d30cfbe4bf955a3
+  data.tar.gz: 569be82094984c0afb8ebaa30950aef78f11e5365ebcdebeb3d1bde5da03311e
 SHA512:
-  metadata.gz: 3bd6225b38f0cd3dd925702f02fe002a3ee6a93bfb4c008b06894f311b854b8a064ef718e3abeae87e319d8777007441dee3807b06f8124b9335f0a6791ad54f
-  data.tar.gz: 9b1a0770e4197dafcda10628ca04e664b386857bf1ea33722f130cb583ec2cd52bc150919e94dbcbce65fb87f8acfd5cec689cf65043e159849a7eeb8963f697
+  metadata.gz: f9cac7d32e9bce452bdd695c371fe9a91cd6ce79be8579abdf01b6d73deecda3f347370931343ee932c79e7ab093eb5989006c6e02014f80a9e35b403d66a605
+  data.tar.gz: 4350c590a31131ec013cfe3982c397005d05e52bee58b996bb6cfa48553605765bcbd97dcd183c9b6dea8475f2bc6a8f49eee95d86053ee9e1717caf31875d4c

data/README.md

@@ -73,6 +73,18 @@ npm run release
 
 After that make sure to commit changes in package.json.
 
+## Deploy
+
+Before deploying make sure to:
+
+1. Copy `demo/config/master.key` from 1Password
+2. Set `KAMAL_REGISTRY_PASSWORD` in `.env`
+
+Then run:
+```bash
+kamal deploy
+```
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/app/assets/javascripts/polaris_view_components/modal_controller.js

@@ -17,10 +17,14 @@ export default class extends Controller {
     const dropElement = `<div class="${this.backdropClass}" data-controller="polaris" data-target="#${this.element.id}" data-action="click->polaris#closeModal"></div>`
     this.element.insertAdjacentHTML('afterend', dropElement)
     this.backdrop = this.element.nextElementSibling
+    const event = new CustomEvent("polarisModalOpened");
+    window.dispatchEvent(event);
   }
 
   close() {
     this.element.classList.add(this.hiddenClass)
     this.backdrop.remove()
+    const event = new CustomEvent("polarisModalClosed");
+    window.dispatchEvent(event);
   }
 }

data/app/assets/javascripts/polaris_view_components.js

@@ -839,10 +839,14 @@ class Modal extends Controller {
     const dropElement = `<div class="${this.backdropClass}" data-controller="polaris" data-target="#${this.element.id}" data-action="click->polaris#closeModal"></div>`;
     this.element.insertAdjacentHTML("afterend", dropElement);
     this.backdrop = this.element.nextElementSibling;
+    const event = new CustomEvent("polarisModalOpened");
+    window.dispatchEvent(event);
   }
   close() {
     this.element.classList.add(this.hiddenClass);
     this.backdrop.remove();
+    const event = new CustomEvent("polarisModalClosed");
+    window.dispatchEvent(event);
   }
 }
 

data/app/components/polaris/action_list/section_component.html.erb

@@ -36,6 +36,6 @@
   ) do %>
     <%= section_markup %>
   <% end %>
-<% else%>
+<% else %>
   <%= section_markup %>
 <% end %>

data/app/components/polaris/avatar_component.html.erb

@@ -1,6 +1,6 @@
 <%= render Polaris::BaseComponent.new(**system_arguments) do %>
   <% if @source %>
-    <img src="<%= @source %>" class="Polaris-Avatar__Image" role="presentation" onerror="this.src=''" />
+    <img src="<%= @source %>" class="Polaris-Avatar__Image" role="presentation" onerror="this.src=''" alt="">
   <% else %>
     <span class="Polaris-Avatar__Initials">
       <% if @initials %>

data/app/components/polaris/character_count.rb

@@ -22,9 +22,9 @@ module Polaris
     def label_template
       if max_length?
         "{count} of #{@max_length} characters used"
+      else
+        "{count} characters"
       end
-
-      "{count} characters"
     end
 
     def text_template
@@ -40,7 +40,7 @@ module Polaris
     end
 
     def normalized_value
-      @text_field.value.to_s || ""
+      @text_field.value.to_s
     end
 
     def count

data/app/components/polaris/divider_component.rb

@@ -2,9 +2,16 @@
 
 module Polaris
   class DividerComponent < Polaris::Component
+    include ActiveModel::Validations
+
+    SUPPORTED_DIRECTIONS = %w[inline block].freeze
+
+    validates :direction, inclusion: {in: SUPPORTED_DIRECTIONS}
+
     def initialize(
       border_color: "border-subdued",
       border_width: "1",
+      direction: "inline",
       **system_arguments
     )
       @system_arguments = system_arguments.tap do |args|
@@ -15,7 +22,7 @@ module Polaris
         )
         args[:style] = styles_list(
           args[:style],
-          "border-block-start": "var(--p-border-width-#{fetch_or_fallback(Tokens::Border::WIDTH_SCALE, border_width)}) solid #{border_color_value(border_color)}"
+          **border_styles(direction, border_color, border_width)
         )
       end
     end
@@ -31,5 +38,21 @@ module Polaris
       return "transparent" if border_color == "transparent"
       "var(--p-color-#{fetch_or_fallback(Tokens::Color::BORDER_ALIAS, border_color)})"
     end
+
+    def border_styles(direction, border_color, border_width)
+      border_direction = fetch_or_fallback(SUPPORTED_DIRECTIONS, direction, "inline")
+
+      if border_direction == "block"
+        {
+          "border-inline-start": "var(--p-border-width-#{fetch_or_fallback(Tokens::Border::WIDTH_SCALE, border_width)}) solid #{border_color_value(border_color)}",
+          "inline-size": "auto",
+          "min-block-size": "100%"
+        }
+      else
+        {
+          "border-block-start": "var(--p-border-width-#{fetch_or_fallback(Tokens::Border::WIDTH_SCALE, border_width)}) solid #{border_color_value(border_color)}"
+        }
+      end
+    end
   end
 end

data/app/components/polaris/empty_state_component.html.erb

@@ -6,7 +6,7 @@
   **@system_arguments
 ) do %>
   <%= polaris_vertical_stack(inline_align: :center) do %>
-    <img src="<%= @image %>" role="presentation" class="<%= @image_contained_class %>">
+    <img src="<%= @image %>" role="presentation" class="<%= @image_contained_class %>" alt="">
 
     <%= polaris_box(max_width: @full_width? "100%" : "400px") do %>
       <%= polaris_vertical_stack(inline_align: :center) do %>

data/app/components/polaris/index_table_component.html.erb

@@ -23,8 +23,8 @@
               <% end %>
             <% end %>
           <% end %>
-        <% end %>
-      </tbody>
-    </table>
-  </div>
+        </tbody>
+      </table>
+    </div>
+  <% end %>
 <% end %>

data/lib/polaris/view_components/version.rb

@@ -1,5 +1,5 @@
 module Polaris
   module ViewComponents
-    VERSION = "2.5.1"
+    VERSION = "3.1.0"
   end
 end

data/lib/tasks/polaris_view_components_tasks.rake

@@ -1,20 +1,6 @@
-require "polaris/view_components/codemods/v3_slot_setters"
-
 namespace :polaris_view_components do
   desc "Setup Polaris::ViewComponents for the app"
   task :install do
     system "#{RbConfig.ruby} ./bin/rails app:template LOCATION=#{File.expand_path("../install/install.rb", __dir__)}"
   end
-
-  task detect_legacy_slots: :environment do
-    ARGV.each { |a| task a.to_sym {} }
-    custom_paths = ARGV.compact.map { |path| Rails.root.join(path) }
-    Polaris::ViewComponents::Codemods::V3SlotSetters.new(view_path: custom_paths).call
-  end
-
-  task migrate_legacy_slots: :environment do
-    ARGV.each { |a| task a.to_sym {} }
-    custom_paths = ARGV.compact.map { |path| Rails.root.join(path) }
-    Polaris::ViewComponents::Codemods::V3SlotSetters.new(view_path: custom_paths, migrate: true).call
-  end
 end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: polaris_view_components
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Dan Gamble
 - Kirill Platonov
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -17,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 7.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 7.1.0
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -34,7 +33,7 @@ dependencies:
         version: 3.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -44,7 +43,7 @@ dependencies:
         version: 3.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.2.0
 - !ruby/object:Gem::Dependency
   name: webdrivers
   requirement: !ruby/object:Gem::Requirement
@@ -65,14 +64,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: 4.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: 4.9.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -121,14 +120,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '2.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
@@ -143,7 +142,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
 email:
 - dan@dangamble.co.uk
 executables: []
@@ -929,7 +927,6 @@ files:
 - config/locales/en.yml
 - lib/install/install.rb
 - lib/polaris/view_components.rb
-- lib/polaris/view_components/codemods/v3_slot_setters.rb
 - lib/polaris/view_components/engine.rb
 - lib/polaris/view_components/version.rb
 - lib/polaris_view_components.rb
@@ -939,7 +936,6 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -947,15 +943,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.10
-signing_key:
+rubygems_version: 4.0.3
 specification_version: 4
 summary: ViewComponents for Polaris Design System
 test_files: []

data/lib/polaris/view_components/codemods/v3_slot_setters.rb

@@ -1,222 +0,0 @@
-# frozen_string_literal: true
-
-module Polaris
-  module ViewComponents
-    # Usage:
-    #
-    # Run via rake task:
-    #
-    #     bin/rails polaris_view_components:detect_legacy_slots
-    #     bin/rails polaris_view_components:migrate_legacy_slots
-    #     bin/rails polaris_view_components:migrate_legacy_slots app/views
-    #
-    # Or run via rails console if you need to pass custom paths:
-    #
-    #     Polaris::ViewComponents::Codemods::V3SlotSetters.new(
-    #       view_path: Rails.root.join("app/views"),
-    #     ).call
-    module Codemods
-      class V3SlotSetters
-        TEMPLATE_LANGUAGES = %w[erb slim haml].join(",").freeze
-        RENDER_REGEX = /render[( ](?<component>\w+(?:::\w+)*)\.new[) ]+(do|\{) \|(?<arg>\w+)\b/ # standard:disable Lint/MixedRegexpCaptureTypes
-
-        Suggestion = Struct.new(:file, :line, :message)
-
-        def initialize(view_component_path: [], view_path: [], migrate: false)
-          Rails.application.eager_load!
-
-          @view_component_path = view_component_path
-          @view_path = view_path
-          @migrate = migrate
-        end
-
-        def call
-          puts "Using ViewComponent path: #{view_component_paths.join(", ")}"
-          puts "Using Views path: #{view_paths.join(", ")}"
-          puts "#{view_components.size} ViewComponents found"
-          puts "#{slottable_components.size} ViewComponents using Slots found"
-          puts "#{view_component_files.size} ViewComponent templates found"
-          puts "#{view_files.size} view files found"
-          process_all_files
-        end
-
-        def process_all_files
-          all_files.each do |file|
-            process_file(file)
-          end
-        end
-
-        def process_file(file)
-          @suggestions = []
-          @suggestions += scan_exact_matches(file)
-          @suggestions += scan_uncertain_matches(file)
-
-          if @suggestions.any?
-            puts
-            puts "File: #{file}"
-            @suggestions.each do |s|
-              puts "=> line #{s.line}: #{s.message}"
-            end
-          end
-        end
-
-        private
-
-        def scan_exact_matches(file)
-          [].tap do |suggestions|
-            rendered_components = []
-            content = File.read(file)
-
-            if (render_match = content.match(RENDER_REGEX))
-              component = render_match[:component]
-              arg = render_match[:arg]
-
-              if registered_slots.key?(component.constantize)
-                used_slots_names = registered_slots[component.constantize]
-                rendered_components << {component: component, arg: arg, slots: used_slots_names}
-              end
-            end
-
-            File.open(file, "r+") do |f|
-              lines = []
-              f.each_line do |line|
-                rendered_components.each do |rendered_component|
-                  arg = rendered_component[:arg]
-                  slots = rendered_component[:slots]
-
-                  if (matches = line.scan(/#{arg}\.#{Regexp.union(slots)}/))
-                    matches.each do |match|
-                      new_value = match.gsub("#{arg}.", "#{arg}.with_")
-                      message = if @migrate
-                        "replaced `#{match}` with `#{new_value}`"
-                      else
-                        "probably replace `#{match}` with `#{new_value}`"
-                      end
-                      suggestions << Suggestion.new(file, f.lineno, message)
-                      if @migrate
-                        line.gsub!("#{arg}.", "#{arg}.with_")
-                      end
-                    end
-                  end
-                end
-                lines << line
-              end
-
-              if @migrate
-                f.rewind
-                f.write(lines.join)
-              end
-            end
-          end
-        end
-
-        def scan_uncertain_matches(file)
-          [].tap do |suggestions|
-            File.open(file, "r+") do |f|
-              lines = []
-              f.each_line do |line|
-                if (matches = line.scan(/(?<!\s)\.(?<slot>#{Regexp.union(all_registered_slot_names)})\b/))
-                  matches.flatten.each do |match|
-                    next if @suggestions.find { |s| s.file == file && s.line == f.lineno }
-
-                    message = if @migrate
-                      "replaced `#{match}` with `with_#{match}`"
-                    else
-                      "maybe replace `#{match}` with `with_#{match}`"
-                    end
-                    suggestions << Suggestion.new(file, f.lineno, message)
-                    if @migrate
-                      line.gsub!(/(?<!\s)\.(#{match})\b/, ".with_\\1")
-                    end
-                  end
-                end
-                lines << line
-              end
-
-              if @migrate
-                f.rewind
-                f.write(lines.join)
-              end
-            end
-          end
-        end
-
-        def view_components
-          ViewComponent::Base.descendants
-        end
-
-        def slottable_components
-          view_components.select do |comp|
-            comp.registered_slots.any?
-          end
-        end
-
-        def registered_slots
-          @registered_slots ||= {}.tap do |slots|
-            puts
-            puts "Detected slots:"
-            slottable_components.each do |comp|
-              puts "- `#{comp}` has slots: #{comp.registered_slots.keys.join(", ")}"
-              slots[comp] = comp.registered_slots.map do |slot_name, slot|
-                normalized_slot_name(slot_name, slot)
-              end
-            end
-          end
-        end
-
-        def all_registered_slot_names
-          @all_registered_slot_names ||= registered_slots.values.flatten.uniq
-        end
-
-        def view_component_files
-          Dir.glob(Pathname.new(File.join(view_component_path_glob, "**", "*.{rb,#{TEMPLATE_LANGUAGES}}")))
-        end
-
-        def view_files
-          Dir.glob(Pathname.new(File.join(view_path_glob, "**", "*.{#{TEMPLATE_LANGUAGES}}")))
-        end
-
-        def all_files
-          view_component_files + view_files
-        end
-
-        def view_component_paths
-          @view_component_paths ||= [
-            Rails.application.config.view_component.view_component_path,
-            @view_component_path
-          ].flatten.compact.uniq
-        end
-
-        def view_component_path_glob
-          return view_component_paths.first if view_component_paths.size == 1
-
-          "{#{view_component_paths.join(",")}}"
-        end
-
-        def rails_view_paths
-          ActionController::Base.view_paths.select do |path|
-            path.to_s.include?(Rails.root.to_s)
-          end.map(&:to_s)
-        end
-
-        def view_paths
-          @view_paths ||= [
-            rails_view_paths,
-            Rails.application.config.view_component.preview_paths,
-            @view_path
-          ].flatten.compact.uniq
-        end
-
-        def view_path_glob
-          return view_paths.first if view_paths.size == 1
-
-          "{#{view_paths.join(",")}}"
-        end
-
-        def normalized_slot_name(slot_name, slot)
-          slot[:collection] ? ActiveSupport::Inflector.singularize(slot_name) : slot_name.to_s
-        end
-      end
-    end
-  end
-end