polaris_view_components 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afe73c510dcccbc175a32899246cbc0086d7beb9f951badfd6a2f4696ae06932
-  data.tar.gz: ade6fa42a44a20ff391d441fd432ab5d078f565aecf6bae9bd05af2fdc4bb1f7
+  metadata.gz: 84f1b013b1c1b56632fecca163692825151171015df3b9edca221b21c12e87d2
+  data.tar.gz: 6ca879737c1a5e7730dc6299feb6101ec53cfe35bc929a632a8b1950157cd7f3
 SHA512:
-  metadata.gz: c2eeffc04f4f14c24791f8411d38cefb70bb5d55b12e3ea58aa0ede26e1cf503648ebd3945f8a531c0e00cedbcad180036be7a2a6ac689e39d8ca317a241cfc2
-  data.tar.gz: e8c79131fde3961768bece82c91b084d9dc67df9d809665146545e0fdae2fefb0de040e45770d2451eab1029eeef09224bb9ed433e1f1ee7bab40e2cf0427797
+  metadata.gz: 0ad985b0add0dd115eefb5e94a64d5c53c8e5966bdfee188eec8e93da1c23ee327cc0bd0d35f62b11b178c6588bbc76cfeefb06de06d7eef1ac3faf0ff4cb50f
+  data.tar.gz: 25f136409d1e0c9aec94f43fc403a040f7f357cf1c53f5d9a1fe5ea567d6543cd9e0168b4d7b913e92c7842e5ee9efcf3fcafe5e064b79f4e9d17e6d429e2b97

data/app/assets/javascripts/polaris_view_components/autocomplete_controller.js

@@ -31,14 +31,14 @@ export default class extends Controller {
       detail: { value: input.value, label, selected: input.checked }
     })
 
-    this.element.dispatchEvent(changeEvent)
-
     if (!this.multipleValue) {
       this.popoverController.forceHide()
       this.inputTarget.value = label
       if (this.hasHiddenInputTarget)
         this.hiddenInputTarget.value = input.value
     }
+
+    this.element.dispatchEvent(changeEvent)
   }
 
   onInputChange = debounce(() => {

data/app/assets/javascripts/polaris_view_components.js

@@ -203,12 +203,12 @@ class Autocomplete extends Controller {
         selected: input.checked
       }
     });
-    this.element.dispatchEvent(changeEvent);
     if (!this.multipleValue) {
       this.popoverController.forceHide();
       this.inputTarget.value = label;
       if (this.hasHiddenInputTarget) this.hiddenInputTarget.value = input.value;
     }
+    this.element.dispatchEvent(changeEvent);
   }
   onInputChange=debounce((() => {
     if (this.isRemote) {

data/app/helpers/polaris/form_builder.rb

@@ -50,18 +50,14 @@ module Polaris
     end
 
     def polaris_text_field(method, **options, &block)
-      options[:error] ||= error_for(method)
-      if options[:error_hidden] && options[:error]
-        options[:error] = !!options[:error]
-      end
+      apply_error_options(options, method)
+
       render Polaris::TextFieldComponent.new(form: self, attribute: method, **options), &block
     end
 
     def polaris_select(method, **options, &block)
-      options[:error] ||= error_for(method)
-      if options[:error_hidden] && options[:error]
-        options[:error] = !!options[:error]
-      end
+      apply_error_options(options, method)
+
       value = object&.public_send(method)
       if value.present?
         options[:selected] = value
@@ -70,34 +66,25 @@ module Polaris
     end
 
     def polaris_check_box(method, **options, &block)
-      options[:error] ||= error_for(method)
-      if options[:error_hidden] && options[:error]
-        options[:error] = !!options[:error]
-      end
+      apply_error_options(options, method)
+
       render Polaris::CheckboxComponent.new(form: self, attribute: method, **options, &block)
     end
 
     def polaris_radio_button(method, **options, &block)
-      options[:error] ||= error_for(method)
-      if options[:error_hidden] && options[:error]
-        options[:error] = !!options[:error]
-      end
+      apply_error_options(options, method)
+
       render Polaris::RadioButtonComponent.new(form: self, attribute: method, **options, &block)
     end
 
     def polaris_dropzone(method, **options, &block)
-      options[:error] ||= error_for(method)
-      if options[:error_hidden] && options[:error]
-        options[:error] = !!options[:error]
-      end
+      apply_error_options(options, method)
+
       render Polaris::DropzoneComponent.new(form: self, attribute: method, **options, &block)
     end
 
     def polaris_collection_check_boxes(method, collection, value_method, text_method, **options, &block)
-      options[:error] ||= error_for(method)
-      if options[:error_hidden] && options[:error]
-        options[:error] = !!options[:error]
-      end
+      apply_error_options(options, method)
 
       value = object&.public_send(method)
       if value.present?
@@ -124,11 +111,19 @@ module Polaris
     end
 
     def polaris_autocomplete(method, **options, &block)
-      options[:error] ||= error_for(method)
+      apply_error_options(options, method)
+
+      render Polaris::AutocompleteComponent.new(form: self, attribute: method, name: method, **options), &block
+    end
+
+    private
+
+    def apply_error_options(options, method)
+      options[:error] ||= error_for(method) unless options.has_key?(:error)
+
       if options[:error_hidden] && options[:error]
         options[:error] = !!options[:error]
       end
-      render Polaris::AutocompleteComponent.new(form: self, attribute: method, name: method, **options), &block
     end
   end
 end

data/lib/polaris/view_components/version.rb

@@ -1,5 +1,5 @@
 module Polaris
   module ViewComponents
-    VERSION = "2.4.0"
+    VERSION = "2.5.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polaris_view_components
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Dan Gamble
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-15 00:00:00.000000000 Z
+date: 2025-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails