pokemoves-cli 1.0.3 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c14c3e3b3d4cb10f712588c038e64eb8af0693412c651a87885fb10c5ac5bd4
-  data.tar.gz: 07f67a2b3dea25672c5934c3b1c7e06319006df5ed6315b583d764e219de365b
+  metadata.gz: cb8cb7108327718cdb80a49954b547282c2590b999398e33d22767a76aab9956
+  data.tar.gz: 03077af2c10f6cb231417002d5d9c9dc514f35327cc66b7878893e06351bc28b
 SHA512:
-  metadata.gz: bc6b737b3ce69e2a6ed8c5ae6711df15d2028563c5814b75946b422990f3a74e9fb98b8f3d7301cb040848462afe177ae5943f25ac4f743e2eafb57001491747
-  data.tar.gz: f795ce047298109524186e97ef2ed445001debc202583c5d78f93aecb3977078418a751573f416f0d85fb7903d54dff276b700c96e5628c49abbaebbe9994097
+  metadata.gz: 83475f7b57df6097d9616451b67d44a9a019c1306ffa804a62a0ca56282eb10dcd7c16e4ddfc51481f9348dfd5a8915f335bc764e9e83b21b806db634ec878d3
+  data.tar.gz: 44624204c1f2c53f05f812d97790949175f0a3456cb97e4aa5a90a5c68c02520b98a69ad8bbd45bc21d4f24ea3d2006cde46c56012b0f624c8a1250d851dd3a7

data/Gemfile

@@ -1,7 +1,6 @@
 source "https://rubygems.org"
 
 gem "httparty"
-gem "pry"
 
 # Specify your gem's dependencies in pokemoves-cli.gemspec
 gemspec

data/Gemfile.lock

@@ -1,23 +1,19 @@
 PATH
   remote: .
   specs:
-    pokemoves-cli (1.0.3)
+    pokemoves-cli (1.0.8)
+      httparty
 
 GEM
   remote: https://rubygems.org/
   specs:
-    coderay (1.1.3)
     httparty (0.18.1)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
-    method_source (1.0.0)
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2020.0512)
     multi_xml (0.6.0)
-    pry (0.13.1)
-      coderay (~> 1.1)
-      method_source (~> 1.0)
     rake (12.3.3)
 
 PLATFORMS
@@ -27,7 +23,6 @@ DEPENDENCIES
   bundler (~> 2.0)
   httparty
   pokemoves-cli!
-  pry
   rake (~> 12.3.3)
 
 BUNDLED WITH

data/README.md

@@ -1,4 +1,3 @@
-<<<<<<< HEAD
 # Pokemoves-cli
 
 Pokemoves allows you to easily check which moves pokemon can learn, as well as which pokemon can learn a specific move. You can also check a move's given type.

data/bin/pokemoves

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-require "./lib/pokemoves.rb"
+require "pokemoves"
 
 cli = Pokemoves::CLI.new
 

data/lib/move.rb

@@ -2,15 +2,23 @@ require_relative "scraper.rb"
 require_relative "pokemon.rb"
 
 class Move
-  attr_reader :name, :type
+  attr_reader :name, :pretty_name
   @@all = []
   
   def initialize(name)
     @name = name
-    @type = Scraper.get_move_by_name(name)["type"]["name"]
+    @pretty_name = name.split("-").collect{|word| word.capitalize}.join(" ")
+    
     @@all << self
   end
   
+  def type
+    if @type == nil
+      @type = Scraper.get_move_by_name(name)["type"]["name"]
+    end
+    @type
+  end
+  
   def self.all
     @@all
   end
@@ -22,4 +30,8 @@ class Move
     end
     return nil
   end
+  
+  def self.find_or_create_by_pretty_name(pretty_name)
+    self.find_or_create_by_name(pretty_name.split(" ").collect{|word| word.downcase}.join("-"))
+  end
 end

data/lib/pokemon.rb

@@ -11,11 +11,11 @@ class Pokemon
   end
   
   def get_moves
-    moves = Scraper.get_pokemon_by_name(@name)["moves"].collect{|move_hash| move_hash["move"]["name"]}
+    moves = Scraper.get_pokemon_by_name(@name)["moves"].collect{|move_hash| Move.new(move_hash["move"]["name"])}
   end
   
-  def can_learn_move?(move_name)
-    self.get_moves.include?(move_name)
+  def can_learn_move?(move)
+    self.get_moves.collect{|m| m.name}.include?(move.name)
   end
   
   def self.all

data/lib/pokemoves.rb

@@ -24,7 +24,7 @@ require "pokemoves/cli/version"
           gets
           counter = 1
           current_pokemon.get_moves.each{|move|
-            puts "#{counter}. #{move.split("-").collect{|word| word.capitalize}.join(" ")}"
+            puts "#{counter}. #{move.pretty_name}"
           counter += 1
           }
           puts "Enter the number of the move you'd like to know the type of."
@@ -32,8 +32,8 @@ require "pokemoves/cli/version"
           num = gets.to_i
           until num <= 0
             if(num <= current_pokemon.get_moves.size)
-              current_move = Move.find_or_create_by_name(current_pokemon.get_moves[num - 1])
-              puts "The move #{current_move.name.capitalize} is a #{current_move.type} type move."
+              current_move = Move.find_or_create_by_name(current_pokemon.get_moves[num - 1].name)
+              puts "The move #{current_move.pretty_name} is a #{current_move.type} type move."
             else
               puts "That number is not in the list of moves."
             end
@@ -45,13 +45,13 @@ require "pokemoves/cli/version"
         elsif input == 2
           puts "Enter the name of a move!"
           move_name = gets.chomp
-          until Move.find_or_create_by_name(move_name.split(" ").collect{|word| word.downcase}.join("-")) != nil
+          until Move.find_or_create_by_pretty_name(move_name) != nil
             puts "It doesn't look like we have that move stored."
             puts "Try a different one."
             move_name = gets.chomp
           end
-          current_move = Move.find_or_create_by_name(move_name.split(" ").collect{|word| word.downcase}.join("-"))
-          puts "Enter the name of a pokemon to see if they can learn #{current_move.name.split("-").collect{|word|  word.capitalize}.join(" ")}"
+          current_move = Move.find_or_create_by_pretty_name(move_name)
+          puts "Enter the name of a pokemon to see if they can learn #{current_move.pretty_name}"
           pokemon_name = gets.chomp
           until Pokemon.find_or_create_by_name(pokemon_name.downcase) != nil
             puts "It doesn't look like we have that pokemon stored."
@@ -60,12 +60,12 @@ require "pokemoves/cli/version"
           end
           until pokemon_name == "exit"
             current_pokemon = Pokemon.find_or_create_by_name(pokemon_name.downcase)
-            if current_pokemon.can_learn_move?(current_move.name)
-              puts "It looks like #{current_pokemon.name.capitalize} can learn #{current_move.name.split("-").collect{|word| word.capitalize}.join(" ")}."
+            if current_pokemon.can_learn_move?(current_move)
+              puts "It looks like #{current_pokemon.name.capitalize} can learn #{current_move.pretty_name}."
             else
-              puts "It looks like #{current_pokemon.name.capitalize} can't learn #{current_move.name.split("-").collect{|word| word.capitalize}.join(" ")}."
+              puts "It looks like #{current_pokemon.name.capitalize} can't learn #{current_move.pretty_name}."
             end
-            puts "Enter the name of another pokemon to see if they can learn #{current_move.name.split("-").collect{|word| word.capitalize}.join(" ")}."
+            puts "Enter the name of another pokemon to see if they can learn #{current_move.pretty_name}."
             puts "Enter \"exit\" to continue to the main menu."
             pokemon_name = gets.chomp
             until Pokemon.find_or_create_by_name(pokemon_name.downcase) != nil || pokemon_name == "exit"

data/lib/pokemoves/cli/version.rb

@@ -1,5 +1,5 @@
 module Pokemoves
   module Cli
-    VERSION = "1.0.3"
+    VERSION = "1.0.8"
   end
 end

data/lib/scraper.rb

@@ -1,5 +1,4 @@
 require "httparty"
-require "pry"
 
 class Scraper
   

data/pokemoves-cli.gemspec

@@ -38,4 +38,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 12.3.3"
+  spec.add_runtime_dependency "httparty"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pokemoves-cli
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.8
 platform: ruby
 authors:
 - "'Andrew Ribas'"
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-31 00:00:00.000000000 Z
+date: 2020-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 12.3.3
+- !ruby/object:Gem::Dependency
+  name: httparty
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: '"Pokemoves allows you to easily check which moves pokemon can learn,
   as well as which pokemon can learn a specific move. You can also check a move''s
   given type."'