pokeedex 0.1.0 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 382f9b5be3017a1dffe7593e87a9796bd5f40290fb327a3af372ad8f4827e36b
-  data.tar.gz: 124be03f7980740fbf261ae89c14f65a2cb2e02799946938f558e73d1a1da78b
+  metadata.gz: 2913e7d015a1b6b0e5da671bac41ae265b82cf4e6406aad1ef36ef328f69fefd
+  data.tar.gz: 210a7e097e29e14edcaf0fa8f1dcae12e066d74ac8038a8cbdfe9a9ef3a90eda
 SHA512:
-  metadata.gz: dc990233c6110229b1092e699150eb2cbb4df3a51e4199e95e2ea73d4f051deda1b08f1d0f9e038b9e500ee5d03bf30b935ab43ff80296b54c46143c9ed54492
-  data.tar.gz: 11fe94444e00595daffbba2612de92b2c49b7f17dc292ffc35362658c33df9622406eaca6667b61bad2e0f15b209f8f296d80d2f76286d916b5e5ae2ac4115ba
+  metadata.gz: 3a31ad260ec75a7ef415624192455b16a9e8753951d72b53a490d8cc30cab79973fc9d8af24ee74bb6dd5f87895562ec8a5cd028f098f016757d148a5a3e4b91
+  data.tar.gz: 8969f57317635d4b9ac2f7a21ead914f53c4b780954e5c4417dcb37b355461597e3bc277d221bc2e801316a4a06c71f32540c9f7f1a78f14b38884d1ec17742a

data/README.md

@@ -16,13 +16,11 @@ Pokeedex is a Ruby gem that provides an interface to interact with the [Pokémon
 
 ## Requirements
 
-- Python 3.9^
 - NodeJS v18^
-- Yarn 1.22^
 
 Pokedex requires [Playwright](https://playwright.dev/) to perform Web Scraping to obtain information about a Pokemon from [https://www.pokemon.com/el/pokedex](https://www.pokemon.com/el/pokedex). For Ruby, use the [playwright-ruby-client](https://playwright-ruby-client.vercel.app/) gem client to be able to interact with Playwright and use the browser that is part of the library installed. For the use of the browser, use an executable to be able to use the browser in Headless mode.
 
-For default Pokeedex use Chronium browser (You don't need install any browser).
+For default Pokeedex use Chronium browser (You don't need install a browser).
 
 ## Installation
 
@@ -63,7 +61,7 @@ Usage: pokeedex [number|name]
 
 ```
 
-NOTE: If you do not have Python, NodeJS and Yarn installed you may be prompted that they need to be installed, please check the requirements and try again.
+NOTE: If you do not have NodeJS installed you may be prompted that they need to be installed, please check the requirements and try again.
 
 ### API
 
@@ -72,7 +70,7 @@ NOTE: If you do not have Python, NodeJS and Yarn installed you may be prompted t
 
 require 'pokeedex'
 
-Pokeedex.boot
+Pokeedex.init
 
 begin
   query = 'pikachu'

data/bin/pokeedex

@@ -2,49 +2,6 @@
 
 require 'optparse'
 
-def check_python_installed
-  `python --version`
-  $?.success? || `python3 --version`
-end
-
-def check_node_installed
-  node_version = `node --version`
-  return [false, nil] unless $?.success?
-
-  version = node_version.match(/^v(\d+)\.(\d+)\.(\d+)/)
-  return [true, version] if version
-
-  [false, nil]
-end
-
-def check_node_version(version)
-  major = version[1].to_i
-  minor = version[2].to_i
-  major > 18 || (major == 18 && minor >= 0)
-end
-
-def check_dependencies
-  unless check_python_installed
-    puts 'Hi! Sorry =( Pokeedex needs Python and Node.js to work. Please install them before running the program.'
-    return
-  end
-
-  node_installed, node_version = check_node_installed
-  unless node_installed
-    puts 'Hi! Sorry =( Pokeedex needs Python and Node.js to work. Please install them before running the program.'
-    return
-  end
-
-  unless check_node_version(node_version)
-    puts "It's Require Node.js 18 version or lastest. Your current version is #{node_version}."
-    return
-  end
-
-  `playwright install`
-end
-
-check_dependencies
-
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '/../lib'))
 
 require 'pokeedex'
@@ -66,7 +23,7 @@ if ARGV.empty?
   exit 1
 end
 
-Pokeedex.boot
+Pokeedex.init
 
 begin
   pokemons = Pokeedex::Pokemon::Base.search(options[:query])

data/lib/pokeedex/configuration.rb

@@ -7,10 +7,6 @@ module Pokeedex # :nodoc:
   # Class that holds the configuration of the gem and the database connection information
   # and methods to connect to the database and run the migrations if needed
   class Configuration
-    ##
-    # The path to the Playwright CLI executable
-    attr_accessor :playwright_cli_executable_path
-
     ##
     # The name of the database file to use for the gem (default: pokeedex_local.sqlite3)
     attr_reader :db_name
@@ -20,8 +16,6 @@ module Pokeedex # :nodoc:
     attr_writer :db_path
 
     def initialize
-      @playwright_cli_executable_path = File.join(Pokeedex.root_path, 'node_modules', '.bin', 'playwright')
-
       @db_name = 'pokeedex_local.sqlite3'
     end
 

data/lib/pokeedex/install_playwright.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+module Pokeedex
+  class InstallPlaywright
+    NODE_VERSION_REQUIRED = 18
+
+    def self.run!
+      new.run
+    end
+
+    def run
+      check_dependencies!
+
+      install_playwright unless playwright_installed?
+    end
+
+    private
+
+    def check_node_installed
+      node_version = `node --version`
+      return [false, nil] unless $?.success?
+
+      version = node_version.match(/^v(\d+)\.(\d+)\.(\d+)/)
+      return [true, version] if version
+
+      [false, nil]
+    end
+
+    def check_node_version(version)
+      major = version[1].to_i
+      minor = version[2].to_i
+      major > NODE_VERSION_REQUIRED || (major == NODE_VERSION_REQUIRED && minor >= 0)
+    end
+
+    def check_dependencies!
+      node_installed, node_version = check_node_installed
+
+      unless node_installed
+        warn 'Hi! Sorry =( Pokeedex needs Node.js 18 version or lastest to work. Please install them before running the program.'
+
+        exit 1
+      end
+
+      return if check_node_version(node_version)
+
+      warn "Please use Node.js 18 version or lastest. Your current version is #{node_version}."
+
+      exit 1
+    end
+
+    def playwright_installed?
+      system('npm list -g playwright > /dev/null 2>&1')
+    end
+
+    def install_playwright
+      puts 'Installing Playwright...'
+
+      system('npm install -g playwright')
+      system('npx playwright install')
+    end
+  end
+end

data/lib/pokeedex/pokemon/scrapper/fetchers/base.rb

@@ -25,7 +25,7 @@ module Pokeedex # :nodoc:
 
           def initialize(url:)
             @url = url
-            @playwright_exec = Playwright.create(playwright_cli_executable_path: Pokeedex.configuration.playwright_cli_executable_path)
+            @playwright_exec = Playwright.create(playwright_cli_executable_path: 'npx playwright')
             @playwright = playwright_exec.playwright
           end
 

data/lib/pokeedex/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pokeedex
-  VERSION = '0.1.0'
+  VERSION = '0.1.5'
 end

data/lib/pokeedex.rb

@@ -4,6 +4,7 @@ require 'base64'
 
 require_relative 'pokeedex/exceptions'
 require_relative 'pokeedex/version'
+require_relative 'pokeedex/install_playwright'
 require_relative 'pokeedex/configuration'
 require_relative 'pokeedex/database'
 require_relative 'pokeedex/pokemon/decorators/base'
@@ -48,8 +49,10 @@ module Pokeedex # :nodoc:
   end
 
   ##
-  # Boot the gem by connecting to the database and running the migrations if needed and loading the models
-  def self.boot
+  # Init the gem by connecting to the database and running the migrations if needed and loading the models
+  def self.init
+    InstallPlaywright.run!
+
     connect_to_database
   end
 end

data/spec/pokeedex/configuration_spec.rb

@@ -7,13 +7,6 @@ RSpec.describe Pokeedex::Configuration do
     it 'returns a Configuration instance' do
       is_expected.to be_instance_of(described_class)
     end
-
-    it 'returns the default values' do
-      expect(subject.playwright_cli_executable_path).to eq(
-        File.join(Pokeedex.root_path, 'node_modules', '.bin', 'playwright')
-      )
-      expect(subject.db_name).to eq('pokeedex_local.sqlite3')
-    end
   end
 
   describe '#db_name=' do

data/spec/spec_helper.rb

@@ -7,7 +7,7 @@ Pokeedex.configure do |config|
   config.db_name = 'pokeedex_test.sqlite3'
 end
 
-Pokeedex.boot
+Pokeedex.init
 
 def file_fixture(filename)
   open(File.join(File.dirname(__FILE__), 'fixtures', "#{filename}")).read