poise-languages 2.1.0 → 2.1.1

data/lib/poise_languages/scl/resource.rb

@@ -108,7 +108,7 @@ module PoiseLanguages
           # KNOW BY FILING A GITHUB ISSUE AT http://github.com/poise/poise-languages/issues/new.
           repo_name = "rhel-server-rhscl-#{node['platform_version'][0]}-rpms"
           execute "subscription-manager repos --enable #{repo_name}" do
-            not_if { shell_out!('subscription-manager repos --list').stdout.include?(repo_name) }
+            not_if { shell_out!('subscription-manager repos --list-enabled').stdout.include?(repo_name) }
           end
         else
           package 'centos-release-scl-rh' do

data/lib/poise_languages/system/resource.rb

@@ -97,60 +97,86 @@ module PoiseLanguages
       #
       # @return [void]
       def action_install
-        run_package_action(:install)
+        notifying_block do
+          install_packages
+          run_action_hack
+        end
       end
 
       # The `upgrade` action for the `poise_languages_system` resource.
       #
       # @return [void]
       def action_upgrade
-        run_package_action(:upgrade)
+        notifying_block do
+          upgrade_packages
+          run_action_hack
+        end
       end
 
       # The `uninstall` action for the `poise_languages_system` resource.
       #
       # @return [void]
       def action_uninstall
-        action = node.platform_family?('debian') ? :purge : :remove
-        package_resources(action).each do |resource|
-          resource.run_action(action)
-          new_resource.updated_by_last_action(true) if resource.updated_by_last_action?
+        notifying_block do
+          uninstall_packages
         end
       end
 
       private
 
-      # Create package resource objects for all needed packages. These are created
-      # directly and not added to the resource collection.
+      # Install the needed language packages.
       #
-      # @return [Array<Chef::Resource::Package>]
-      def package_resources(action)
+      # @api private
+      # @return [Array<Chef::Resource>]
+      def install_packages
         packages = {new_resource.package_name => new_resource.package_version}
         # If we are supposed to install the dev package, grab it using the same
         # version as the main package.
         if new_resource.dev_package
           packages[new_resource.dev_package] = new_resource.package_version
         end
-
         Chef::Log.debug("[#{new_resource.parent}] Building package resource using #{packages.inspect}.")
+
+        # Check for multi-package support.
         package_resource_class = Chef::Resource.resource_for_node(:package, node)
-        @package_resource ||= if node.platform_family?('rhel', 'fedora', 'amazon', 'mac_os_x')
-          # @todo Can't use multi-package mode with yum pending https://github.com/chef/chef/issues/3476.
-          packages.map do |name, version|
-            package_resource_class.new(name, run_context).tap do |r|
-              r.version(version)
-              r.action(action)
-              r.declared_type = :package
-              r.retries(5)
-            end
+        package_provider_class = package_resource_class.new('multipackage_check', run_context).provider_for_action(:install)
+        package_resources = if package_provider_class.respond_to?(:use_multipackage_api?) && package_provider_class.use_multipackage_api?
+          package packages.keys do
+            version packages.values
           end
         else
-          [package_resource_class.new(packages.keys, run_context).tap do |r|
-            r.version(packages.values)
-            r.action(action)
-            r.declared_type = :package
-            r.retries(5)
-          end]
+          # Fallback for non-multipackage.
+          packages.map do |pkg_name, pkg_version|
+            package pkg_name do
+              version pkg_version
+            end
+          end
+        end
+
+        # Apply some settings to all of the resources.
+        Array(package_resources).each do |res|
+          res.retries(5)
+          res.define_singleton_method(:apply_action_hack?) { true }
+        end
+      end
+
+      # Upgrade the needed language packages.
+      #
+      # @api private
+      # @return [Array<Chef::Resource>]
+      def upgrade_packages
+        install_packages.each do |res|
+          res.action(:upgrade)
+        end
+      end
+
+      # Uninstall the needed language packages.
+      #
+      # @api private
+      # @return [Array<Chef::Resource>]
+      def uninstall_packages
+        install_packages.each do |res|
+          res.action(node.platform_family?('debian') ? :purge : :remove)
         end
       end
 
@@ -161,21 +187,34 @@ module PoiseLanguages
       #
       # @param action [Symbol] Action to run on all package resources.
       # @return [void]
-      def run_package_action(action)
-        package_resources(action).each do |resource|
-          # Reset it so we have a clean baseline.
-          resource.updated_by_last_action(false)
-          # Grab the provider.
-          provider = resource.provider_for_action(action)
-          provider.action = action
-          # Check the candidate version if needed. With a manual package_version
-          # you get whatever you asked for.
-          patch_load_current_resource!(provider, new_resource.version) unless new_resource.package_version
-          # Run our action.
-          Chef::Log.debug("[#{new_resource.parent}] Running #{provider} with #{action}")
-          provider.run_action(action)
-          # Check updated flag.
-          new_resource.updated_by_last_action(true) if resource.updated_by_last_action?
+      def run_action_hack
+        # If new_resource.package_version is set, skip this madness.
+        return if new_resource.package_version
+
+        # Process every resource in the current collection, which is bounded
+        # by notifying_block.
+        run_context.resource_collection.each do |resource|
+          # Only apply to things we tagged above.
+          next unless resource.respond_to?(:apply_action_hack?) && resource.apply_action_hack?
+
+          Array(resource.action).each do |action|
+            # Reset it so we have a clean baseline.
+            resource.updated_by_last_action(false)
+            # Grab the provider.
+            provider = resource.provider_for_action(action)
+            provider.action = action
+            # Inject our check for the candidate version. This will actually
+            # get run during run_action below.
+            patch_load_current_resource!(provider, new_resource.version)
+            # Run our action.
+            Chef::Log.debug("[#{new_resource.parent}] Running #{provider} with #{action}")
+            provider.run_action(action)
+            # Check updated flag.
+            new_resource.updated_by_last_action(true) if resource.updated_by_last_action?
+          end
+
+          # Make sure the resource doesn't run again when notifying_block ends.
+          resource.action(:nothing)
         end
       end
 

data/lib/poise_languages/version.rb

@@ -16,5 +16,5 @@
 
 
 module PoiseLanguages
-  VERSION = '2.1.0'
+  VERSION = '2.1.1'
 end

data/poise-languages.gemspec

@@ -26,7 +26,8 @@ Gem::Specification.new do |spec|
   spec.description = "A Chef cookbook to help writing language cookbooks."
   spec.summary = spec.description
   spec.homepage = 'https://github.com/poise/poise-languages'
-  spec.license = 'Apache 2.0'
+  spec.license = 'Apache-2.0'
+  spec.metadata['platforms'] = 'any'
 
   spec.files = `git ls-files`.split($/)
   spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }

data/test/gemfiles/chef-12.1.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.1.2'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.10.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.10.24'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.11.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.11.18'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.12.gemfile

@@ -17,5 +17,6 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.12.15'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'

data/test/gemfiles/chef-12.13.gemfile

@@ -17,5 +17,6 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.13.37'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'

data/test/gemfiles/chef-12.18.gemfile

@@ -0,0 +1,19 @@
+#
+# Copyright 2017, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
+
+gem 'chef', '~> 12.18.31'

data/test/gemfiles/chef-12.19.gemfile

@@ -0,0 +1,19 @@
+#
+# Copyright 2017, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
+
+gem 'chef', '~> 12.19.36'

data/test/gemfiles/chef-12.2.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.2.1'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.3.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.3.0'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.4.gemfile

@@ -17,7 +17,8 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.4.3'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
 gem 'gh', '0.14.0'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.5.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.5.1'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.6.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.6.0'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.7.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.7.2'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.8.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.8.1'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.9.gemfile

@@ -17,6 +17,7 @@
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
 gem 'chef', '~> 12.9.41'
-gem 'rack', '< 2'
-gem 'foodcritic', '< 8'
+gem 'chefspec', '< 6'
 gem 'fauxhai', '<= 3.9.0'
+gem 'foodcritic', '< 8'
+gem 'rack', '< 2'

data/test/gemfiles/chef-12.gemfile

@@ -16,4 +16,4 @@
 
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
-gem 'chef', '~> 12.17'
+gem 'chef', '~> 12.19'

data/test/gemfiles/chef-13.0.gemfile

@@ -0,0 +1,19 @@
+#
+# Copyright 2017, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
+
+gem 'chef', '~> 13.0.118'

data/test/gemfiles/chef-13.gemfile

@@ -0,0 +1,19 @@
+#
+# Copyright 2017, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
+
+gem 'chef', '~> 13.0'

data/test/gemfiles/master.gemfile

@@ -16,10 +16,13 @@
 
 eval_gemfile File.expand_path('../../../Gemfile', __FILE__)
 
-gem 'chef', github: 'chef/chef'
-gem 'halite', github: 'poise/halite'
-gem 'ohai', github: 'chef/ohai'
-gem 'poise', github: 'poise/poise'
-gem 'poise-archive', github: 'poise/poise-archive'
-gem 'poise-boiler', github: 'poise/poise-boiler'
-gem 'poise-profiler', github: 'poise/poise-profiler'
+gem 'chef', git: 'https://github.com/chef/chef.git'
+gem 'chefspec', git: 'https://github.com/sethvargo/chefspec.git'
+gem 'fauxhai', git: 'https://github.com/customink/fauxhai.git'
+gem 'foodcritic', git: 'https://github.com/foodcritic/foodcritic.git'
+gem 'halite', git: 'https://github.com/poise/halite.git'
+gem 'ohai', git: 'https://github.com/chef/ohai.git'
+gem 'poise', git: 'https://github.com/poise/poise.git'
+gem 'poise-archive', git: 'https://github.com/poise/poise-archive.git'
+gem 'poise-boiler', git: 'https://github.com/poise/poise-boiler.git'
+gem 'poise-profiler', git: 'https://github.com/poise/poise-profiler.git'

data/test/spec/system/resource_spec.rb

@@ -15,110 +15,258 @@
 #
 
 require 'spec_helper'
+require 'chef/version'
+require 'shellwords'
 
 describe PoiseLanguages::System::Resource do
-  let(:chefspec_options) { {platform: 'ubuntu', version: '14.04'} }
   step_into(:poise_languages_system)
-  step_into(:package, unwrap_notifying_block: false)
-  provider(:package_hack, parent: Chef::Provider::Package) do
-    def load_current_resource
-      @current_resource = new_resource.class.new(new_resource.name, run_context)
-      current_resource.package_name(new_resource.package_name)
-      candidate = node['poise_candidate']
-      current = node['poise_current']
-      @candidate_version = if new_resource.package_name.is_a?(Array)
-        current_resource.version([current] * new_resource.package_name.length)
-        [candidate] * new_resource.package_name.length
-      else
-        current_resource.version(current)
-        candidate
-      end
-      current_resource
-    end
-    def install_package(name, version)
-      rc = defined?(Chef.run_context) ? Chef.run_context : self.run_context
-      rc.resource_collection << new_resource unless rc.resource_collection.keys.include?(new_resource.to_s)
-    end
-    alias_method :upgrade_package, :install_package
-    alias_method :remove_package, :install_package
-    alias_method :purge_package, :install_package
-  end
-  recipe do
-    r = ruby_block 'parent'
-    poise_languages_system 'mylang' do
-      parent r
-      version ''
-    end
-  end
   before do
-    # I can't use the provider resolver system easily because overrides like this
-    # don't work well with the Halite patcher.
-    allow_any_instance_of(Chef::Resource::Package).to receive(:provider).and_return(provider(:package_hack))
-    # Set our candidate version.
-    default_attributes[:poise_candidate] = '1.0'
+    # Don't actually run any installs. The package hack prevents the usual
+    # ChefSpec stubbing from working. This fakes it.
+    [Chef::Provider::Package::Apt, Chef::Provider::Package::Yum].each do |klass|
+      allow_any_instance_of(klass).to receive(:install_package) {|this| this.new_resource.perform_action(:install, converge_time: true) }
+      allow_any_instance_of(klass).to receive(:upgrade_package) {|this| this.new_resource.perform_action(:upgrade, converge_time: true) }
+      allow_any_instance_of(klass).to receive(:remove_package) {|this| this.new_resource.perform_action(:remove, converge_time: true) }
+      allow_any_instance_of(klass).to receive(:purge_package) {|this| this.new_resource.perform_action(:purge, converge_time: true) }
+    end
   end
 
   context 'on Ubuntu' do
-    it { is_expected.to install_apt_package('mylang, mylang-dev') }
+    let(:chefspec_options) { {platform: 'ubuntu', version: '16.04'} }
+    before do
+      # Stubs load load_current_resource for apt_package.
+      allow_any_instance_of(Chef::Provider::Package::Apt).to receive(:shell_out) do |this, *args|
+        args.pop if args.last.is_a?(Hash)
+        args = Shellwords.split(args.first) if args.size == 1 && args.first.is_a?(String)
+        if args[0..1] == %w{apt-cache policy}
+          double(stdout: <<-EOH, error!: nil)
+#{args[2]}:
+  Installed: (none)
+  Candidate: 1.2.3-1
+  Version table:
+     1.2.3-1 500
+        500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages
+EOH
+        else
+          raise "unstubbed command #{args.inspect}"
+        end
+      end
+    end
+
+    context 'action :install' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version ''
+        end
+      end
+
+      if Gem::Requirement.create('>= 12.11').satisfied_by?(Gem::Version.create(Chef::VERSION))
+        it { is_expected.to install_package('mylang, mylang-dev') }
+      else
+        it { is_expected.to install_package('mylang') }
+        it { is_expected.to install_package('mylang-dev') }
+      end
+    end # /context action :upgrade
+
+    context 'action :upgrade' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          action :upgrade
+          parent r
+          version ''
+        end
+      end
+
+      if Gem::Requirement.create('>= 12.11').satisfied_by?(Gem::Version.create(Chef::VERSION))
+        it { is_expected.to upgrade_package('mylang, mylang-dev') }
+      else
+        it { is_expected.to upgrade_package('mylang') }
+        it { is_expected.to upgrade_package('mylang-dev') }
+      end
+    end # /context action :upgrade
+
+    context 'action :uninstall' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          action :uninstall
+          parent r
+          version ''
+        end
+      end
+
+      if Gem::Requirement.create('>= 12.11').satisfied_by?(Gem::Version.create(Chef::VERSION))
+        it { is_expected.to purge_package('mylang, mylang-dev') }
+      else
+        it { is_expected.to purge_package('mylang') }
+        it { is_expected.to purge_package('mylang-dev') }
+      end
+    end # /context action :uninstall
+
+    context 'with a matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '1'
+        end
+      end
+
+      it { expect { subject }.to_not raise_error }
+    end # /context with a matching version
+
+    context 'with an exact matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '1.2.3'
+        end
+      end
+
+      it { expect { subject }.to_not raise_error }
+    end # /context with an exact matching version
+
+    context 'with a non-matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '2'
+        end
+      end
+
+      it { expect { subject }.to raise_error PoiseLanguages::Error }
+    end # /context with a non-matching version
+
+    context 'with a nearby non-matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '1.2.4'
+        end
+      end
+
+      it { expect { subject }.to raise_error PoiseLanguages::Error }
+    end # /context with a nearby non-matching version
   end # /context on Ubuntu
 
   context 'on CentOS' do
     let(:chefspec_options) { {platform: 'centos', version: '7.0'} }
+    before do
+      yum_cache = double('YumCache')
+      allow(yum_cache).to receive(:yum_binary=)
+      allow(yum_cache).to receive(:disable_extra_repo_control)
+      allow(yum_cache).to receive(:package_available?).and_return(false)
+      allow(yum_cache).to receive(:package_available?).with(/^mylang(-devel)?$/).and_return(true)
+      allow(yum_cache).to receive(:installed_version).with(/^mylang(-devel)?$/, nil).and_return(nil)
+      allow(yum_cache).to receive(:candidate_version).with(/^mylang(-devel)?$/, nil).and_return('1.2.3')
+      allow(Chef::Provider::Package::Yum::YumCache).to receive(:instance).and_return(yum_cache)
+    end
 
-    it { is_expected.to install_yum_package('mylang') }
-    it { is_expected.to install_yum_package('mylang-devel') }
-  end # /context on Ubuntu
+    context 'action :install' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version ''
+        end
+      end
 
-  context 'action :upgrade' do
-    recipe do
-      r = ruby_block 'parent'
-      poise_languages_system 'mylang' do
-        action :upgrade
-        parent r
-        version ''
+      if Gem::Requirement.create('>= 12.19').satisfied_by?(Gem::Version.create(Chef::VERSION))
+        it { is_expected.to install_package('mylang, mylang-devel') }
+      else
+        it { is_expected.to install_package('mylang') }
+        it { is_expected.to install_package('mylang-devel') }
+      end
+    end # /context action :upgrade
+
+    context 'action :upgrade' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          action :upgrade
+          parent r
+          version ''
+        end
       end
-    end
 
-    it { is_expected.to upgrade_apt_package('mylang, mylang-dev') }
-  end # /context action :upgrade
+      if Gem::Requirement.create('>= 12.19').satisfied_by?(Gem::Version.create(Chef::VERSION))
+        it { is_expected.to upgrade_package('mylang, mylang-devel') }
+      else
+        it { is_expected.to upgrade_package('mylang') }
+        it { is_expected.to upgrade_package('mylang-devel') }
+      end
+    end # /context action :upgrade
 
-  context 'action :uninstall' do
-    recipe do
-      r = ruby_block 'parent'
-      poise_languages_system 'mylang' do
-        action :uninstall
-        parent r
-        version ''
+    context 'action :uninstall' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          action :uninstall
+          parent r
+          version ''
+        end
       end
-    end
-    before do
-      default_attributes[:poise_current] = '2.0'
-    end
 
-    it { is_expected.to purge_apt_package('mylang, mylang-dev') }
-  end # /context action :uninstall
+      if Gem::Requirement.create('>= 12.19').satisfied_by?(Gem::Version.create(Chef::VERSION))
+        it { is_expected.to remove_package('mylang, mylang-devel') }
+      else
+        it { is_expected.to remove_package('mylang') }
+        it { is_expected.to remove_package('mylang-devel') }
+      end
+    end # /context action :uninstall
 
-  context 'with a matching version' do
-    recipe do
-      r = ruby_block 'parent'
-      poise_languages_system 'mylang' do
-        parent r
-        version '1'
+    context 'with a matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '1'
+        end
       end
-    end
 
-    it { is_expected.to install_apt_package('mylang, mylang-dev') }
-  end # /context with a matching version
+      it { expect { subject }.to_not raise_error }
+    end # /context with a matching version
 
-  context 'with a non-matching version' do
-    recipe do
-      r = ruby_block 'parent'
-      poise_languages_system 'mylang' do
-        parent r
-        version '2'
+    context 'with an exact matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '1.2.3'
+        end
+      end
+
+      it { expect { subject }.to_not raise_error }
+    end # /context with an exact matching version
+
+    context 'with a non-matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '2'
+        end
+      end
+
+      it { expect { subject }.to raise_error PoiseLanguages::Error }
+    end # /context with a non-matching version
+
+    context 'with a nearby non-matching version' do
+      recipe do
+        r = ruby_block 'parent'
+        poise_languages_system 'mylang' do
+          parent r
+          version '1.2.4'
+        end
       end
-    end
 
-    it { expect { subject }.to raise_error PoiseLanguages::Error }
-  end # /context with a non-matching version
+      it { expect { subject }.to raise_error PoiseLanguages::Error }
+    end # /context with a nearby non-matching version
+  end # /context on CentOS
 end