pod4 0.7.1 → 0.7.2

data/lib/pod4/nebulous_interface.rb

@@ -8,25 +8,22 @@ module Pod4
   ##
   # An interface to talk to a Nebulous Target.
   #
-  # Each interface can only speak with one target, designated with #set_target.
-  # The developer must also set a unique ID key using #set_id_fld.
+  # Each interface can only speak with one target, designated with #set_target.# The developer must
+  # also set a unique ID key using #set_id_fld.
   #
-  # The primary challenge here is to map the CRUDL methods (which interfaces
-  # contract to implement) to nebulous verbs. The programmer uses #set_verb for
-  # this purpose: the first parameter indicates the CRUDL method, the next is
-  # the verb name, and the rest are hash keys.
+  # The primary challenge here is to map the CRUDL methods (which interfaces contract to implement)
+  # to nebulous verbs. The programmer uses #set_verb for this purpose: the first parameter
+  # indicates the CRUDL method, the next is the verb name, and the rest are hash keys.
   #
-  # In the case of the #create and #update methods, the list of keys controls
-  # which parts of the incoming hash end up in the verb parameters, and in what
-  # order. For #update, the list must include the ID key that you gave to
-  # #set_id_fld.  
+  # In the case of the #create and #update methods, the list of keys controls which parts of the
+  # incoming hash end up in the verb parameters, and in what order. For #update, the list must
+  # include the ID key that you gave to #set_id_fld.  
   #
-  # Parameters for the #list method similarly constrain how its selection
-  # parameter is translated to a nebulous verb parameter string.  
+  # Parameters for the #list method similarly constrain how its selection parameter is translated
+  # to a nebulous verb parameter string.  
   #
-  # Parameters for #read and #delete can be whatever you like, but since the
-  # only value passed to read is the ID, the only symbol there should be the
-  # same as the one in #set_id_fld.
+  # Parameters for #read and #delete can be whatever you like, but since the only value passed to
+  # read is the ID, the only symbol there should be the same as the one in #set_id_fld.
   #
   #     class CustomerInterface < SwingShift::NebulousInterface
   #       set_target 'accord'
@@ -41,21 +38,20 @@ module Pod4
   #       end
   #     end
   #
-  # In this example both the create and update methods point to the same
-  # nebulous verb. Note that only keys which are symbols are translated to the
-  # corresponding values in the record or selection hash; anything else is
-  # passed literally in the Nebulous parameter string.
+  # In this example both the create and update methods point to the same nebulous verb. Note that
+  # only keys which are symbols are translated to the corresponding values in the record or
+  # selection hash; anything else is passed literally in the Nebulous parameter string.
   #
-  # When you subclass NebulousInterfce, you may want to override some or all of
-  # the CRUDL methods so that your callers can pass specific parameters rather
-  # than a hash; the above example demonstrates this.
+  # When you subclass NebulousInterfce, you may want to override some or all of the CRUDL methods
+  # so that your callers can pass specific parameters rather than a hash; the above example
+  # demonstrates this.
   #
-  # We assume that the response to the #create message returns the ID as the
-  # parameter part of the success verb. If that's not true, then you will have
-  # to override #create and sort this out yourself.
+  # We assume that the response to the #create message returns the ID as the parameter part of the
+  # success verb. If that's not true, then you will have to override #create and sort this out
+  # yourself.
   #
-  # Finally, note that all values are returned as strings; there is no
-  # typecasting. This is a given limitation for Nebulous as a whole.
+  # Finally, note that all values are returned as strings; there is no typecasting. This is a given
+  # limitation for Nebulous as a whole.
   #
   class NebulousInterface < Interface
 
@@ -72,8 +68,8 @@ module Pod4
     # * :verbsuccess - we got a success verb in response
     # * :response - we got some response that doesn't follow The Protocol
     #
-    # NB: if we got an exception sending the message, we raised it on the
-    # caller, so there is no status for that.
+    # NB: if we got an exception sending the message, we raised it on the caller, so there is no
+    # status for that.
     attr_reader :response_status
 
 
@@ -82,9 +78,8 @@ module Pod4
 
     class << self
       #--
-      # These are set in the class because it keeps the model code cleaner: the
-      # definition of the interface stays in the interface, and doesn't leak
-      # out into the model.
+      # These are set in the class because it keeps the model code cleaner: the definition of the
+      # interface stays in the interface, and doesn't leak out into the model.
       #++
 
       ##
@@ -94,8 +89,7 @@ module Pod4
       # * parameters - array of symbols to order the hash passed to create, etc
       #
       def set_verb(action, verb, *paramKeys)
-        raise ArgumentError, "Bad action" \
-          unless Interface::ACTIONS.include? action
+        raise ArgumentError, "Bad action" unless Interface::ACTIONS.include? action
 
         v = verbs.dup
         v[action] = Verb.new( verb, paramKeys.flatten )
@@ -110,6 +104,7 @@ module Pod4
       # Set the name of the Nebulous target in the interface definition
       #
       # a reference to the interface object.
+      #
       def set_target(target)
         define_class_method(:target) {target.to_s}
       end
@@ -120,8 +115,7 @@ module Pod4
 
 
       ##
-      # Set the name of the ID parameter (needs to be in the CRUD verbs param
-      # list)
+      # Set the name of the ID parameter (needs to be in the CRUD verbs param list)
       def set_id_fld(idFld)
         define_class_method(:id_fld) {idFld}
       end
@@ -159,11 +153,10 @@ module Pod4
     ##
     # In normal operation, takes no parameters.
     #
-    # For testing purposes you may pass an instance of a class here. It must
-    # respond to a #send method with parameters (verb, parameter string, cache
-    # yes/no) by returning some kind of NebRequest (presumably either a double
-    # or an instance of NebRequestNull). This method will be called instead of
-    # creating a NebRequest directly.
+    # For testing purposes you may pass an instance of a class here. It must respond to a #send
+    # method with parameters (verb, parameter string, cache yes/no) by returning some kind of
+    # NebRequest (presumably either a double or an instance of NebRequestNull). This method will be
+    # called instead of creating a NebRequest directly.
     #
     def initialize(requestObj=nil)
       @request_object  = requestObj # might as well be a reference 
@@ -176,12 +169,12 @@ module Pod4
 
 
     ##
-    # Pass a parameter string or array (which will be taken as the literal
-    # Nebulous parameter) or a Hash or Octothorpe (which will be interpreted as
-    # per your list of keys set in add_verb :list).
+    # Pass a parameter string or array (which will be taken as the literal Nebulous parameter) or a
+    # Hash or Octothorpe (which will be interpreted as per your list of keys set in add_verb
+    # :list).
     #
-    # Returns an array of Octothorpes, or an empty array if the responder could
-    # not make any records out of our message.
+    # Returns an array of Octothorpes, or an empty array if the responder could not make any
+    # records out of our message.
     #
     def list(selection=nil)
       sel = 
@@ -193,7 +186,7 @@ module Pod4
       send_message( verb_for(:list), sel )
 
       @response.body_to_h # should be an array irrespective of the method name
-          .map{|e| Octothorpe.new(e) }
+        .map{|e| Octothorpe.new(e) }
 
     rescue => e
       handle_error(e)
@@ -201,17 +194,14 @@ module Pod4
 
 
     ##
-    # Pass a parameter string or an array as the record. returns the ID.
-    # We assume that the response to the create message returns the ID as the
-    # parameter part of the success verb. If that's not true, then you will
-    # have to override #create and sort this out yourself.
+    # Pass a parameter string or an array as the record. returns the ID.# We assume that the
+    # response to the create message returns the ID as the parameter part of the success verb. If
+    # that's not true, then you will have to override #create and sort this out yourself.
     #
     def create(record)
-      raise ArgumentError, 'create takes a Hash or an Octothorpe' \
-        unless hashy?(record)
+      raise ArgumentError, 'create takes a Hash or an Octothorpe' unless hashy?(record)
 
       send_message( verb_for(:create), param_string(:create, record) )
-
       @response.params
 
     rescue => e
@@ -234,13 +224,11 @@ module Pod4
 
 
     ##
-    # Given an id an a record (Octothorpe or Hash), update the record.  Returns
-    # self.
+    # Given an id an a record (Octothorpe or Hash), update the record. Returns self.
     #
     def update(id, record)
       raise ArgumentError, 'You must pass an ID to update' unless id
-      raise ArgumentError, 'update record takes a Hash or an Octothorpe' \
-        unless hashy?(record)
+      raise ArgumentError, 'update record takes a Hash or an Octothorpe' unless hashy?(record)
 
       send_message( verb_for(:update), 
                     param_string(:update, record, id), 
@@ -267,8 +255,9 @@ module Pod4
 
     
     ##
-    # Bonus method: chain this method before a CRUDL method to clear the cache
-    # for that parameter string:
+    # Bonus method: chain this method before a CRUDL method to clear the cache for that parameter
+    # string:
+    #
     #     @interface.clearing_cache.read(14)
     #
     def clearing_cache
@@ -278,11 +267,10 @@ module Pod4
 
 
     ##
-    # Bonus method: send an arbitrary Nebulous message to the target and return
-    # the response object.
+    # Bonus method: send an arbitrary Nebulous message to the target and return the response object.
     #
-    # We don't trap errors here - see #handle_error - but we raise extra ones
-    # if we think things look fishy.
+    # We don't trap errors here - see #handle_error - but we raise extra ones if we think things
+    # look fishy.
     #
     def send_message(verb, paramStr, with_cache=true)
       unless NebulousStomp.on? 
@@ -305,8 +293,7 @@ module Pod4
           else                :response
         end
 
-      raise Pod4::CantContinue, "Nebulous returned an error verb" \
-        if @response_status == :verberror
+      raise Pod4::CantContinue, "Nebulous returned an error verb" if @response_status == :verberror
 
       self
 
@@ -327,8 +314,8 @@ module Pod4
 
 
     ##
-    # Work out the parameter string based on the corresponding #set_Verb call.
-    # Insert the ID value if given
+    # Work out the parameter string based on the corresponding #set_Verb call. Insert the ID value
+    # if given
     #
     def param_string(action, hashParam, id=nil)
       hash = hashParam ? hashParam.dup : {}
@@ -346,8 +333,8 @@ module Pod4
     ##
     # Deal with any exceptions that are raised.
     #
-    # Our contract says that we should throw errors to the model, but those
-    # errors should be Pod4 errors. 
+    # Our contract says that we should throw errors to the model, but those errors should be Pod4
+    # errors. 
     #
     def handle_error(err, kaller=caller[1..-1])
       Pod4.logger.error(__FILE__){ err.message }
@@ -372,9 +359,8 @@ module Pod4
 
 
     ##
-    # A little helper method to create a response object (unless we were given
-    # one for testing purposes), clear the cache if we are supposed to, and
-    # then send the message.
+    # A little helper method to create a response object (unless we were given one for testing
+    # purposes), clear the cache if we are supposed to, and then send the message.
     #
     # returns the response to the request.
     #
@@ -399,7 +385,6 @@ module Pod4
       obj.kind_of?(Hash) || obj.kind_of?(Octothorpe)
     end
 
-
   end
 
 

data/lib/pod4/null_interface.rb

@@ -16,8 +16,8 @@ module Pod4
   #       set_interface NullInterface.new( :one, :two [ {one: 1, two: 2} ] )
   #       ...
   #
-  # The first column passed is taken to be the ID.
-  # Note that ID is not auto-assigned; you need to specify it in the record.
+  # The first column passed is taken to be the ID. Note that ID is not auto-assigned; you need to
+  # specify it in the record.
   #
   class NullInterface < Interface
 
@@ -25,8 +25,7 @@ module Pod4
 
 
     ##
-    # Initialise the interface by passing it a list of columns and an array of
-    # hashes to fill them.
+    # Initialise the interface by passing it a list of columns and an array of hashes to fill them.
     #
     def initialize(*cols, data)
       raise ArgumentError, "no columns"  if cols.nil? || cols == []
@@ -60,12 +59,11 @@ module Pod4
 
     ##
     # Record is a hash of field: value
-    # Note that we will store any old crap, not just the fields you named in
-    # new().
+    #
+    # Note that we will store any old crap, not just the fields you named in new().
     #
     def create(record)
-      raise(ArgumentError, "Create requires an ID") \
-        if record.nil? || ! record.respond_to?(:to_h)
+      raise(ArgumentError, "Create requires an ID") if record.nil? || ! record.respond_to?(:to_h)
 
       @data << record.to_h
       record[@id_fld]
@@ -90,8 +88,7 @@ module Pod4
 
 
     ##
-    # ID is the first column you named in new()
-    # record should be a Hash or Octothorpe.
+    # ID is the first column you named in new(). Record should be a Hash or Octothorpe.
     # Again, note that we don't care what columns you send us.
     #
     def update(id, record)
@@ -112,9 +109,7 @@ module Pod4
     #
     def delete(id)
       raise(ArgumentError, "Delete requires an ID")  if id.nil?
-
-      raise Pod4::CantContinue, "'No record found with ID '#{id}'" \
-        if read(id).empty?
+      raise(Pod4::CantContinue, "'No record found with ID '#{id}'") if read(id).empty?
 
       @data.delete_if {|r| r[@id_fld] == id }
       self

data/lib/pod4/param.rb

@@ -5,8 +5,8 @@ module Pod4
 
 
   ##
-  # This module implements the singleton pattern and is used internally to
-  # store parameters passed to it from outside of Pod4
+  # This module implements the singleton pattern and is used internally to store parameters passed
+  # to it from outside of Pod4
   #
   module Param
     extend self

data/lib/pod4/pg_interface.rb

@@ -13,10 +13,9 @@ module Pod4
   ##
   # Pod4 Interface for requests on a SQL table via pg, the PostgresQL adapter.
   #
-  # If your DB table is one-one with your model, you shouldn't need to override
-  # anything.
-  #
+  # If your DB table is one-one with your model, you shouldn't need to override anything.
   # Example:
+  #
   #     class CustomerInterface < SwingShift::PgInterface
   #       set_schema :public    # optional
   #       set_table  :customer
@@ -30,9 +29,8 @@ module Pod4
 
     class << self
       #--
-      # These are set in the class because it keeps the model code cleaner: the
-      # definition of the interface stays in the interface, and doesn't leak
-      # out into the model.
+      # These are set in the class because it keeps the model code cleaner: the definition of the
+      # interface stays in the interface, and doesn't leak out into the model.
       #++
 
       ## 
@@ -73,13 +71,12 @@ module Pod4
 
 
     ##
-    # Initialise the interface by passing it a Pg connection hash.
-    # For testing ONLY you can also pass an object which pretends to be a
-    # Pg client, in which case the hash is pretty much ignored.
+    # Initialise the interface by passing it a Pg connection hash. For testing ONLY you can also
+    # pass an object which pretends to be a Pg client, in which case the hash is pretty much
+    # ignored.
     #
     def initialize(connectHash, testClient=nil)
-      raise(ArgumentError, 'invalid connection hash') \
-        unless connectHash.kind_of?(Hash)
+      raise(ArgumentError, 'invalid connection hash') unless connectHash.kind_of?(Hash)
 
       @connect_hash = connectHash.dup
       @test_client  = testClient 
@@ -125,8 +122,9 @@ module Pod4
 
     ##
     # Record is a hash of field: value
-    # By a happy coincidence, insert returns the unique ID for the record,
-    # which is just what we want to do, too.
+    #
+    # By a happy coincidence, insert returns the unique ID for the record, which is just what we
+    # want to do, too.
     #
     def create(record)
       raise(ArgumentError, "Bad type for record parameter") \
@@ -161,8 +159,8 @@ module Pod4
       Octothorpe.new( select(sql).first )
 
     rescue => e
-      # Select has already wrapped the error in a Pod4Error, but in this case
-      # we want to catch something
+      # Select has already wrapped the error in a Pod4Error, but in this case we want to catch
+      # something
       raise CantContinue, "That doesn't look like an ID" \
         if e.cause.class == PG::InvalidTextRepresentation
 
@@ -171,8 +169,8 @@ module Pod4
 
 
     ##
-    # ID is whatever you set in the interface using set_id_fld
-    # record should be a Hash or Octothorpe.
+    # ID is whatever you set in the interface using set_id_fld record should be a Hash or
+    # Octothorpe.
     #
     def update(id, record)
       raise(ArgumentError, "Bad type for record parameter") \
@@ -211,15 +209,14 @@ module Pod4
     ##
     # Run SQL code on the server. Return the results.
     #
-    # Will return an array of records, or you can use it in block mode, like
-    # this:
+    # Will return an array of records, or you can use it in block mode, like this:
     #
     #     select("select * from customer") do |r|
     #       # r is a single record
     #     end
     #
-    # The returned results will be an array of hashes (or if you passed a
-    # block, of whatever you returned from the block).
+    # The returned results will be an array of hashes (or if you passed a block, of whatever you
+    # returned from the block).
     #
     def select(sql)
       raise(ArgumentError, "Bad SQL parameter") unless sql.kind_of?(String)
@@ -284,21 +281,19 @@ module Pod4
       raise DataBaseError, "Bad Connection" \
         unless client.status == PG::CONNECTION_OK
 
-      # This gives us type mapping for integers, floats, booleans, and dates
-      # -- but annoyingly the PostgreSQL types 'numeric' and 'money' remain as
-      # strings... we fudge that elsewhere.
+      # This gives us type mapping for integers, floats, booleans, and dates -- but annoyingly the
+      # PostgreSQL types 'numeric' and 'money' remain as strings... we fudge that elsewhere.
       #
-      # NOTE we now deal with ALL mapping elsewhere, since pg_jruby does
-      # not support type mapping. Also: no annoying error messages, and it
-      # seems to be a hell of a lot faster now...
+      # NOTE we now deal with ALL mapping elsewhere, since pg_jruby does not support type mapping.
+      # Also: no annoying error messages, and it seems to be a hell of a lot faster now...
       # 
-      # if defined?(PG::BasicTypeMapForQueries)
-      #   client.type_map_for_queries = PG::BasicTypeMapForQueries.new(client)
-      # end
+      #     if defined?(PG::BasicTypeMapForQueries)
+      #       client.type_map_for_queries = PG::BasicTypeMapForQueries.new(client)
+      #     end
       #
-      # if defined?(PG::BasicTypeMapForResults)
-      #   client.type_map_for_results = PG::BasicTypeMapForResults.new(client)
-      # end
+      #     if defined?(PG::BasicTypeMapForResults)
+      #       client.type_map_for_results = PG::BasicTypeMapForResults.new(client)
+      #     end
 
       @client = client
       self
@@ -310,8 +305,9 @@ module Pod4
 
     ##
     # Close the connection to the database.
-    # We don't actually use this, but it's here for completeness. Maybe a
-    # caller will find it useful.
+    #
+    # We don't actually use this, but it's here for completeness. Maybe a caller will find it
+    # useful.
     #
     def close
       Pod4.logger.info(__FILE__){ "Closing connection to DB" }
@@ -339,8 +335,7 @@ module Pod4
 
 
     ##
-    # Since pg gives us @client.reset to reconnect, we should use it rather
-    # than just call open
+    # Since pg gives us @client.reset to reconnect, we should use it rather than just call open
     #
     def ensure_connection
 
@@ -377,8 +372,12 @@ module Pod4
     def quote(fld)
 
       case fld
-        when String, Date, Time, Symbol
+        when Date, Time
           "'#{fld}'" 
+        when String
+          "'#{fld.gsub("'", "''")}'" 
+        when Symbol
+          "'#{fld.to_s.gsub("'", "''")}'" 
         when BigDecimal
           fld.to_f
         when nil
@@ -407,9 +406,9 @@ module Pod4
 
     ##
     # Cast a query row
-    # This is to step around problems with pg type mapping
-    # There is definitely a way to tell pg to cast money and numeric as
-    # BigDecimal, but, it's not documented and no one can tell me how to do it!
+    #
+    # This is to step around problems with pg type mapping There is definitely a way to tell pg to
+    # cast money and numeric as BigDecimal, but, it's not documented...
     #
     # Also, for the pg_jruby gem, type mapping doesn't work at all?
     #
@@ -447,13 +446,10 @@ module Pod4
 
 
     def read_or_die(id)
-      raise CantContinue, "'No record found with ID '#{id}'" \
-        if read(id).empty?
-
+      raise CantContinue, "'No record found with ID '#{id}'" if read(id).empty?
     end
 
-
-
   end
 
+
 end

data/lib/pod4/sequel_interface.rb

@@ -10,8 +10,7 @@ module Pod4
   ##
   # Pod4 Interface for a Sequel table.
   #
-  # If your DB table is one-one with your model, you shouldn't need to override
-  # anything.
+  # If your DB table is one-one with your model, you shouldn't need to override anything.
   #
   # Example:
   #     class CustomerInterface < SwingShift::SequelInterface
@@ -19,9 +18,9 @@ module Pod4
   #       set_id_fld :id
   #     end
   #
-  # Data types: Sequel itself will translate to BigDecimal, Float, Integer,
-  # date, and datetime as appropriate -- but it also depends on the underlying
-  # adapter.  TinyTds maps dates to strings, for example. 
+  # Data types: Sequel itself will translate to BigDecimal, Float, Integer, date, and datetime as
+  # appropriate -- but it also depends on the underlying adapter.  TinyTds maps dates to strings,
+  # for example. 
   #
   class SequelInterface < Interface
 
@@ -30,9 +29,8 @@ module Pod4
 
     class << self
       #---
-      # These are set in the class because it keeps the model code cleaner: the
-      # definition of the interface stays in the interface, and doesn't leak
-      # out into the model.
+      # These are set in the class because it keeps the model code cleaner: the definition of the
+      # interface stays in the interface, and doesn't leak out into the model.
       #+++
 
 
@@ -78,12 +76,8 @@ module Pod4
     #
     def initialize(db)
       raise(ArgumentError, "Bad database") unless db.kind_of? Sequel::Database
-
-      raise(Pod4Error, 'no call to set_table in the interface definition') \
-        if self.class.table.nil?
-
-      raise(Pod4Error, 'no call to set_id_fld in the interface definition') \
-        if self.class.id_fld.nil?
+      raise(Pod4Error, 'no call to set_table in the interface definition') if self.class.table.nil?
+      raise(Pod4Error, 'no call to set_id_fld in the interface definition') if self.class.id_fld.nil?
 
       @db     = db # referemce to the db object
       @table  = db[schema ? "#{schema}__#{table}".to_sym : table]
@@ -113,10 +107,7 @@ module Pod4
     #
     def list(selection=nil)
       sel = sanitise_hash(selection)
-
-      Pod4.logger.debug(__FILE__) do
-        "Listing #{self.class.table}: #{sel.inspect}"
-      end
+      Pod4.logger.debug(__FILE__) { "Listing #{self.class.table}: #{sel.inspect}" }
 
       (sel ? @table.where(sel) : @table.all).map {|x| Octothorpe.new(x) }
     rescue => e
@@ -126,16 +117,15 @@ module Pod4
 
     ##
     # Record is a hash of field: value
-    # By a happy coincidence, insert returns the unique ID for the record,
-    # which is just what we want to do, too.
+    #
+    # By a happy coincidence, insert returns the unique ID for the record, which is just what we
+    # want to do, too.
     #
     def create(record)
       raise(ArgumentError, "Bad type for record parameter") \
         unless record.kind_of?(Hash) || record.kind_of?(Octothorpe)
 
-      Pod4.logger.debug(__FILE__) do
-        "Creating #{self.class.table}: #{record.inspect}"
-      end
+      Pod4.logger.debug(__FILE__) { "Creating #{self.class.table}: #{record.inspect}" }
 
       @table.insert( sanitise_hash(record.to_h) )
 
@@ -149,10 +139,7 @@ module Pod4
     #
     def read(id)
       raise(ArgumentError, "ID parameter is nil") if id.nil?
-
-      Pod4.logger.debug(__FILE__) do
-        "Reading #{self.class.table} where #{@id_fld}=#{id}"
-      end
+      Pod4.logger.debug(__FILE__) { "Reading #{self.class.table} where #{@id_fld}=#{id}" }
 
       Octothorpe.new( @table[@id_fld => id] )
 
@@ -165,8 +152,8 @@ module Pod4
 
 
     ##
-    # ID is whatever you set in the interface using set_id_fld
-    # record should be a Hash or Octothorpe.
+    # ID is whatever you set in the interface using set_id_fld record should be a Hash or
+    # Octothorpe.
     #
     def update(id, record)
       read_or_die(id)
@@ -213,8 +200,7 @@ module Pod4
 
 
     ## 
-    # Bonus method: execute arbitrary SQL and return the resulting dataset as a
-    # Hash.
+    # Bonus method: execute arbitrary SQL and return the resulting dataset as a Hash.
     #
     def select(sql)
       raise(ArgumentError, "Bad sql parameter") unless sql.kind_of?(String)
@@ -231,8 +217,9 @@ module Pod4
 
     ##
     # Helper routine to handle or re-raise the right exception.
-    # Unless kaller is passed, we re-raise on the caller of the caller, which
-    # is likely the original bug
+    #
+    # Unless kaller is passed, we re-raise on the caller of the caller, which is likely the
+    # original bug
     # 
     def handle_error(err, kaller=nil)
       kaller ||= caller[1..-1]
@@ -269,9 +256,9 @@ module Pod4
 
 
     ##
-    # Sequel behaves VERY oddly if you pass a symbol as a value to the hash you
-    # give to a selection,etc on a dataset. (It raises an error complaining that
-    # the symbol does not exist as a column in the table...)
+    # Sequel behaves VERY oddly if you pass a symbol as a value to the hash you give to a
+    # selection,etc on a dataset. (It raises an error complaining that the symbol does not exist as
+    # a column in the table...)
     #
     def sanitise_hash(sel)
 
@@ -300,3 +287,4 @@ module Pod4
 
 
 end
+