po_box 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a96717f6fc9f8aee68cbf574b60c2da573d7693a1173279a84b16e1a1666d38
-  data.tar.gz: b5b7dcb9dcea500041f806517edc8ece9cdc18af18241900ce28adc43dd525de
+  metadata.gz: cf5765334ed345c096a6e2432f6775772afc81d3830e9d668e3df23fb782a45f
+  data.tar.gz: bb13be4eaf786de61adf885bb0b3bc0df69c6740f3a94b5067512465c73d656c
 SHA512:
-  metadata.gz: 5522631b60e572e57049274c7c730d257c44eb94d0ef900b528c628329dfd0ac68e0ea166be00c8773ae3c9d3c46693c6336971881205553228760259a637b9e
-  data.tar.gz: d6209dc03e50daa7ff937fee1ae5b39075a4a54b7215a7e80ec9290b9502864f5e1fc341e0a3585eacdfa7d9baa7de34ee8c644032a4627c337ff649ed96fede
+  metadata.gz: 688da89cf7a2dc81c270580a85ebf838aeb9209c14644ccb297dd90faa81743a3631981b43f057a3637e484bb6ea88d1f3b5f19baa249fc3823c8436410854d1
+  data.tar.gz: 9c82e7fdbd57649e2f2e0cdd93d56ffa3532216dcc2bd9df123d3c8f79e5340acfed35acb0c606b3b86cf9dbc7365e9d7c807e774f3ab34328db6a6087d4f181

data/README.md

@@ -4,8 +4,8 @@ PoBox is a Ruby on Rails engine that provides inboxes and email addresses for yo
 
 ## Requirements
 
-1. [ActiveStorage](https://edgeguides.rubyonrails.org/active_storage_overview.html) needs to be installed and configured.
-2. [ActionMailbox](https://edgeguides.rubyonrails.org/action_mailbox_basics.html) needs to be installed and configured.
+1. [ActiveStorage](https://edgeguides.rubyonrails.org/active_storage_overview.html) needs to be configured.
+2. [ActionMailbox](https://edgeguides.rubyonrails.org/action_mailbox_basics.html) needs to be configured.
 3. A model that the inbox and emails will be associated with needs to exist in the host application. e.g. `User` or `Account`.
 
 ## Installation
@@ -33,7 +33,7 @@ $ gem install po_box
 **IMPORTANT:** Make sure you have ActiveStorage and ActionMailbox installed and configured.
 
 1. `bin/rails po_box:install:migrations`
-2. `bin/rails g po_box emailable_model` (where `emailable_model` is the name of the model you want to make emailable, e.g. `user`)
+2. `bin/rails g po_box emailable_model` (where `emailable_model` is the name of the model in your application you want to associate inboxes and email addresses to, e.g. `user`)
 3. `bin/rails db:migrate`
 4. `bin/rails po_box:backfill_emailables`
 
@@ -50,7 +50,7 @@ Send the email to the address that is associated with the emailable model. e.g.
 ```ruby
   User.inboxes.first.address
 
-  # => "some#64b0@yourapp"
+  # => "some#64b0@yourapp.com"
 ```
 
 <!-- If your emailable_class is a User -->

data/app/controllers/po_box/inboxes_controller.rb

@@ -42,13 +42,13 @@ module PoBox
     private
 
     def inbox_params
-      params.require(:inbox).permit(:name, :address)
+      params.require(:inbox).permit(:emailable_type, :emailable_id, :address)
     end
 
     def set_inbox
       @inbox = Inbox.find(params[:id])
     rescue ActiveRecord::RecordNotFound
-      redirect_to po_box_inboxes_path, notice: "Inbox not found"
+      redirect_to inboxes_path, notice: "Inbox not found"
     end
   end
 end

data/app/models/concerns/po_box/emailable.rb

@@ -5,13 +5,13 @@ module PoBox
     included do
       has_many :inboxes, as: :emailable, class_name: "PoBox::Inbox", dependent: :destroy
 
-      after_create_commit :set_inbox
+      after_create_commit :generate_inbox
 
       accepts_nested_attributes_for :inboxes, allow_destroy: true
 
       private
 
-      def set_inbox
+      def generate_inbox
         return if inboxes.any?
 
         inbox_address = if email.present?
@@ -23,7 +23,7 @@ module PoBox
         inbox = inboxes.new
         loop do
           inbox.address = inbox_address
-          break unless PoBox.emailable_class.joins(:inboxes).where(po_box_inboxes: {address: inbox.address}).exists?
+          break unless PoBox::Inbox.find_by(address: inbox.address).present?
         end
 
         save

data/app/models/po_box/application_record.rb

@@ -1,5 +1,18 @@
 module PoBox
-  class ApplicationRecord < ActiveRecord::Base
+  class ApplicationRecord < ::ActiveRecord::Base
     self.abstract_class = true
+
+    def self.sort_by_params(column, direction)
+      sortable_column = column.presence_in(sortable_columns) || "created_at"
+      order(sortable_column => direction)
+    end
+
+    # Returns an array of sortable columns on the model
+    # Used with the Sortable controller concern
+    #
+    # Override this method to add/remove sortable columns
+    def self.sortable_columns
+      @sortable_columns ||= columns.map(&:name)
+    end
   end
 end

data/app/models/po_box/email.rb

@@ -7,5 +7,7 @@ module PoBox
     validates :from, presence: true
 
     delegate :raw_source, to: :body
+
+    scope :for_emailable, ->(emailable) { joins(:inbox).where(po_box_inboxes: {emailable: emailable}) }
   end
 end

data/app/models/po_box/inbox.rb

@@ -2,6 +2,8 @@ module PoBox
   class Inbox < ApplicationRecord
     belongs_to :emailable, polymorphic: true, class_name: PoBox.emailable_class.to_s
 
+    validates :address, presence: true, uniqueness: true
+
     has_many :emails, class_name: "PoBox::Email", dependent: :destroy
 
     define_method PoBox.emailable_class.to_s.underscore do

data/app/views/po_box/inboxes/_form.html.erb

@@ -9,6 +9,11 @@
       </ul>
     </div>
   <% end %>
+  <div>
+    <%= form.label "Emailable ID", style: "display: block" %>
+    <%= form.number_field :emailable_id %>
+    <%= form.hidden_field :emailable_type, value: PoBox.emailable_class %>
+  </div>
   <div>
     <%= form.label :address, style: "display: block" %>
     <%= form.text_field :address %>

data/lib/po_box/version.rb

@@ -1,3 +1,3 @@
 module PoBox
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: po_box
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Leo Policastro