pntfr 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 155bd001219b0ae71b13a93d84e11bd6dcc2fb4d
-  data.tar.gz: 60619eb1816e9f0296913de087e7a07465ec7161
+  metadata.gz: 2050d1fa6a4e3cecd3fb3772478b0510daafeb4a
+  data.tar.gz: 220bbae6b5b10ecc513ded32c49eb9b884b6d298
 SHA512:
-  metadata.gz: 45e32abce7a6d7cf38ab4f5b1b2cd809263322ecffbbeb56f35ce0c555d8fef89367f9ebde6ebf46caa8ea9982b2f806a1e558874d4b1971aa1a7611a8bdc45b
-  data.tar.gz: 6b43d884c55d5d9d5705dfb9afa6eb6f15659f8f5675fc5d60f02188f2d821a219cca2f9d6aa44aa7fed115939965e7d20773b62de79dfe9ecedf8dd45fca35a
+  metadata.gz: 5d2bff68fd2e597f4bb74dfe7092ccfd6397ad0084e6c5ba8ba1d404c34e5d7604b94aa0ce9eb774b049470dcffd345a907a3a39aff3db0d0ef5272b281e4e8c
+  data.tar.gz: 3fd175f1d640ec77c87cf19d344eef86958dbd2aba4aa5a5f91e69fa135697388d0e6e7eda2ef76e152c35ef8aa7f17dc3e2328cbea5f2ed806f6f1900d6fa7c

data/lib/pntfr/session/ios.rb

@@ -15,22 +15,23 @@ module Pntfr
       def notify devices, notification
         apns_notifications= []
         devices.each do |device|
+          dev_notif= notification.dup
           if device_controls_badge(device)
-            if !notification[:badge].nil?
-              device.num_notifs= notification[:badge]
+            if !dev_notif[:badge].nil?
+              device.num_notifs= dev_notif[:badge]
             else
               if device.methods.include?(:increment!)
                 device.increment!(:num_notifs)
               else
                 device.num_notifs+= 1
               end
-              notification[:badge]= device.num_notifs
+              dev_notif[:badge]= device.num_notifs
             end
           end
           if Pntfr.test_env?
-            Pntfr.add_delivery(device.push_id, notification)
+            Pntfr.add_delivery(device.push_id, dev_notif)
           else
-            apns_notif= APNS::Notification.new(device.push_id, notification)
+            apns_notif= APNS::Notification.new(device.push_id, dev_notif)
             apns_notifications << apns_notif
           end
         end

data/lib/pntfr/version.rb

@@ -2,6 +2,9 @@
 # Let's follow Semantic Versioning: http://semver.org/
 #
 module Pntfr
+  #
+  # PATCH v0.5.2
+  # - Fix. [FIX] Increase badge independently for each device.
   #
   # PATCH v0.5.1
   # - Use increment! instead of increment when incrementing badge on a device object
@@ -22,5 +25,5 @@ module Pntfr
   # - Allow overriding general configuration credentials when instantiating each
   # Notifier (on both platforms).
   # - Internal refactoring.
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

data/test/pntfr/device.rb

@@ -7,6 +7,7 @@ Pntfr::IosDevice= Struct.new(:platform, :push_id, :num_notifs)
 # A device class that quacks like ActiveRecord with num_notifs which will be autoincremented on each sent msg
 class Pntfr::ArIosDevice < Pntfr::IosDevice
   def increment!(attr_name, by=1)
-    self.send("#{attr_name}=", by)
+    val= self.send("#{attr_name}")
+    self.send("#{attr_name}=", val.to_i + by)
   end
 end

data/test/pntfr/ios_badge_test.rb

@@ -7,9 +7,7 @@ module Pntfr
 
       Pntfr::Notifier.to(device).msg({:title => 't', :description => 'd'}).notify
 
-      notifs= Pntfr.deliveries['1id2id3id4id5id']
-      notif= notifs.last
-      assert_equal 1, notif[:badge]
+      check_badge(1, '1id2id3id4id5id')
       assert_equal 1, device.num_notifs
     end
     def test_sending_a_notification_increments_notifier_notifications_num_on_active_record_devices
@@ -17,10 +15,25 @@ module Pntfr
 
       Pntfr::Notifier.to(device).msg({:title => 't', :description => 'd'}).notify
 
-      notifs= Pntfr.deliveries['1ar2ar3ar4ar5ar']
-      notif= notifs.last
-      assert_equal 1, notif[:badge]
+      check_badge(1, '1ar2ar3ar4ar5ar')
       assert_equal 1, device.num_notifs
     end
+    def test_sending_a_notification_to_devices_with_different_badge_should_send_different_badge_for_each_device
+      devices= [Pntfr::ArIosDevice.new(Pntfr::Platforms::IOS, '1badge', 1),
+        Pntfr::ArIosDevice.new(Pntfr::Platforms::IOS, '2badge', 2)]
+
+      Pntfr::Notifier.to(devices).msg({:title => 'MultiBadge', :description => 'Test'}).notify
+
+      check_badge(2, '1badge')
+      check_badge(3, '2badge')
+    end
+    ###################################################
+    private
+    ###################################################
+    def check_badge(expected_badge, push_id)
+      notifs= Pntfr.deliveries[push_id]
+      notif= notifs.last
+      assert_equal expected_badge, notif[:badge], "Nofication for device [#{push_id}] should have expected badge"
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pntfr
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - oliver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-22 00:00:00.000000000 Z
+date: 2015-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apns