png_quantizator 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d7dc995617bb0d74176532d50d16c6c1c1b94a8b
-  data.tar.gz: d93546109649a9f7047e55fdc666c96d27d2048f
+  metadata.gz: 302f575beeda78b881993fda239f4d1fff9c114b
+  data.tar.gz: 633bb61eee57d2fba8a95774e867fe6a2582735f
 SHA512:
-  metadata.gz: 5b075ad74169d8cd4ab45b5dd4f858275c036312512c037588c0f07684d14ec4620aed564e41e536be7549a40e4f582e8488a0465c5e5ec084143e260e6d6542
-  data.tar.gz: 6a9aa1b6dfd5c25f9687c690b32e34093add1309981ec4311654929248f56a349b27009ec54a6477dce05b3c24100845b582a4fe575c9b3c9fad08537b347ca8
+  metadata.gz: 760f8e771bc53a8ffe14506e317c9bc6bc1cafb402b92ddbc528c93ee595962f65d132f6a6308f4156d89d1d84b764954b4190d4a174d21714d3d943c7abc403
+  data.tar.gz: 414a959102aba631a7176b4957a6cacb623e4c7ef6b3278d93a2520866ad190902d5b0e17166f4752f10f55057b9b52940ba221501df063fb2f956a2b0ef9ba8

data/lib/png_quantizator.rb

@@ -3,6 +3,7 @@ require 'open3'
 require 'fileutils'
 require 'securerandom'
 require 'tempfile'
+require 'shellwords'
 
 module PngQuantizator
   class PngQuantError < StandardError; end
@@ -30,8 +31,9 @@ module PngQuantizator
 
       exit_code, err_msg = Open3.popen3("pngquant #{colors}") do |stdin, stdout, stderr, wait_thr|
         stdin.write(File.read(@file_path))
+        stdin.close
 
-        File.open(destination_path, "w") do |f|
+        File.open(Shellwords.escape(destination_path), "w") do |f|
           f.write stdout.gets(nil)
           f.flush
         end

data/lib/png_quantizator/version.rb

@@ -1,3 +1,3 @@
 module PngQuantizator
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/spec/png_quantizator/image_spec.rb

@@ -4,25 +4,32 @@ describe PngQuantizator::Image do
   let(:test_jpg) { File.join(File.dirname(__FILE__), "../data/sample.jpg") }
   let(:test_png) { File.join(File.dirname(__FILE__), "../data/sample.png") }
 
+  around do |block|
+    Dir.mktmpdir do |dir|
+      @tmpdir = dir
+      block.run
+    end
+  end
+
   describe "#quantize_to" do
     it "should not work with jpg files" do
       quantized = PngQuantizator::Image.new(test_jpg)
-      expect { quantized.quantize_to("/tmp/cucota.png") }.to raise_error(PngQuantizator::PngQuantError)
+      expect { quantized.quantize_to("#{@tmpdir}/cucota.png") }.to raise_error(PngQuantizator::PngQuantError)
     end
 
     it "should work with png files" do
       quantized = PngQuantizator::Image.new(test_png)
-      quantized.quantize_to("/tmp/cucota.png").should be_true
+      quantized.quantize_to("#{@tmpdir}/cucota.png").should be_true
 
-      File.file?("/tmp/cucota.png").should be_true
-      File.size("/tmp/cucota.png").should < File.size(test_png)
+      File.file?("#{@tmpdir}/cucota.png").should be_true
+      File.size("#{@tmpdir}/cucota.png").should < File.size(test_png)
 
-      FileUtils.rm_rf("/tmp/cucota.png")
+      FileUtils.rm_rf("#{@tmpdir}/cucota.png")
     end
   end
 
   describe "#quantize!" do
-    let(:original_file_path) { "/tmp/abracadabra.png" }
+    let(:original_file_path) { "#{@tmpdir}/abracadabra.png" }
 
     before do
       FileUtils.cp(test_png, original_file_path)
@@ -41,9 +48,9 @@ describe PngQuantizator::Image do
     end
 
     it "should not leave residual files in tmp" do
-      foo = `ls -1 /tmp/*.png | wc -l`
+      foo = `ls -1 #{@tmpdir}/*.png | wc -l`
       PngQuantizator::Image.new(original_file_path).quantize!
-      foo.should == `ls -1 /tmp/*.png | wc -l`
+      foo.should == `ls -1 #{@tmpdir}/*.png | wc -l`
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: png_quantizator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Roger Campos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-04 00:00:00.000000000 Z
+date: 2015-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec