png_conform 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9838bb140397822f351596fc1ff51179969ba68ac9d4310718a6ddcd549acb67
-  data.tar.gz: b88887d300166cb6aa8d38db1d277450a9ddec7d3662498b8529ec3d5eb1f168
+  metadata.gz: f40907ca0fa307f62da38b9fecdd97fa05e6f9953315d3bc197a6c1385c1c490
+  data.tar.gz: 27891ced82861b1ff72ac09ef12fcc6801c1f28b46cb849e1a4d6100a6ad9f6c
 SHA512:
-  metadata.gz: ab5ec06d2d129c872e75fe3002129ce258eb6faa80519f147a358be32cad5c16a49e88592226bab55391c274512a17f76679ac51e031dd1e296e949d12d981d2
-  data.tar.gz: dbc3ceb3ceafc05d1f92e22c6693668249759fc7a1a54b2191854fb944e11c4445171fae162b0b145d7016afe9287afb9f278d6fc7d4e6cb0b71dc2957e56f40
+  metadata.gz: f58ca78ca13ca9934b677118c06cd67d362b96af38863b943dc0f60b757d0685435c450261ee1107d4eebbc5aa95e494c877cf6f55faccccb0dc89fdb0dd9bfc
+  data.tar.gz: 4479d1b4a79ee5d97fc49c297297f11818443e1f7c29e612131520d7037293951488a8fc8ec6af8772d7b49f833d45973ee21817e4bcaa34f98a4f88117818ff

data/.rubocop_todo.yml

@@ -1,18 +1,64 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-11-23 07:50:45 UTC using RuboCop version 1.81.1.
+# on 2026-04-04 06:26:35 UTC using RuboCop version 1.86.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 231
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Gemspec/RequireMFA:
+  Exclude:
+    - 'png_conform.gemspec'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
+  Exclude:
+    - 'spec/png_conform/validators/ancillary/bkgd_validator_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: normal, indented_internal_methods
+Layout/IndentationConsistency:
+  Exclude:
+    - 'png_conform.gemspec'
+
+# Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: aligned, indented
+Layout/LineEndStringConcatenationIndentation:
+  Exclude:
+    - 'lib/png_conform/analyzers/optimization_analyzer.rb'
+
+# Offense count: 263
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Enabled: false
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowInHeredoc.
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'spec/png_conform/validators/ancillary/bkgd_validator_spec.rb'
+
+# Offense count: 14
+# This cop supports safe autocorrection (--autocorrect).
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'benchmarks/lib/benchmark_runner.rb'
+    - 'benchmarks/lib/report_generator.rb'
+    - 'lib/png_conform/services/result_builder.rb'
+    - 'lib/png_conform/services/zlib_validator.rb'
+    - 'lib/png_conform/validators/critical/ihdr_validator.rb'
+
 # Offense count: 1
 Lint/BinaryOperatorWithIdenticalOperands:
   Exclude:
@@ -27,7 +73,22 @@ Lint/DuplicateBranch:
     - 'lib/png_conform/validators/ancillary/sbit_validator.rb'
     - 'spec/pngsuite/helpers/semantic_validator.rb'
 
-# Offense count: 113
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/png_conform/validators/ancillary/bkgd_validator_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: AllowedParentClasses.
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/png_conform/pipelines/stages/analysis_stage.rb'
+    - 'lib/png_conform/pipelines/stages/chunk_validation_stage.rb'
+    - 'lib/png_conform/pipelines/stages/sequence_validation_stage.rb'
+    - 'lib/png_conform/pipelines/stages/signature_validation_stage.rb'
+
+# Offense count: 124
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Enabled: false
@@ -36,14 +97,14 @@ Metrics/AbcSize:
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 54
+  Max: 52
 
-# Offense count: 57
+# Offense count: 62
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-# Offense count: 171
+# Offense count: 193
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 66
@@ -58,6 +119,13 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Enabled: false
 
+# Offense count: 132
+# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
+# AllowedMethods: call
+# WaywardPredicates: infinite?, nonzero?
+Naming/PredicateMethod:
+  Enabled: false
+
 # Offense count: 1
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
@@ -72,6 +140,13 @@ Performance/CollectionLiteralInLoop:
   Exclude:
     - 'examples/advanced_usage.rb'
 
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/MapCompact:
+  Exclude:
+    - 'benchmarks/lib/metrics_collector.rb'
+    - 'lib/png_conform/services/file_signature.rb'
+
 # Offense count: 70
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
@@ -103,25 +178,81 @@ RSpec/MultipleMemoizedHelpers:
   Max: 6
 
 # Offense count: 2
-# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata.
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/Output:
+  Exclude:
+    - 'spec/png_conform/validators/ancillary/bkgd_validator_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata, InflectorPath, EnforcedInflector.
+# SupportedInflectors: default, active_support
 RSpec/SpecFilePathFormat:
   Exclude:
     - 'spec/png_conform/bindata/chunk_structure_spec.rb'
     - 'spec/png_conform/bindata/png_file_spec.rb'
 
-# Offense count: 45
+# Offense count: 44
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
 
-# Offense count: 41
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/BitwisePredicate:
+  Exclude:
+    - 'lib/png_conform/bindata/chunk_structure.rb'
+    - 'lib/png_conform/services/chunk_processor.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ComparableBetween:
+  Exclude:
+    - 'lib/png_conform/validators/ancillary/trns_validator.rb'
+    - 'lib/png_conform/validators/base_validator.rb'
+
+# Offense count: 1
+Style/FileOpen:
+  Exclude:
+    - 'lib/png_conform/container.rb'
+
+# Offense count: 36
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, Mode, AllowedMethods, AllowedPatterns.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   EnforcedStyle: unannotated
 
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/MapToSet:
+  Exclude:
+    - 'lib/png_conform/analyzers/comparison_analyzer.rb'
+
 # Offense count: 1
-Style/MissingRespondToMissing:
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/RedundantFormat:
+  Exclude:
+    - 'benchmarks/lib/report_generator.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Style/ReturnNilInPredicateMethodDefinition:
+  Exclude:
+    - 'lib/png_conform/analyzers/comparison_analyzer.rb'
+    - 'spec/pngsuite/helpers/pngcheck_parser.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'png_conform.gemspec'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/SuperArguments:
   Exclude:
-    - 'lib/png_conform/cli.rb'
+    - 'lib/png_conform/models/chunk_info.rb'
+    - 'lib/png_conform/models/validation_result.rb'

data/Gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in png_conform.gemspec
 gemspec
 
-gem "openssl"
+gem "openssl", "~> 3.0"
 gem "rake"
 gem "rspec"
 gem "rubocop"

data/benchmarks/lib/benchmark_runner.rb

@@ -165,7 +165,7 @@ class BenchmarkRunner
     pct = (current.to_f / total * 100).round(1)
     bar_width = 40
     filled = (bar_width * current / total).to_i
-    bar = "=" * filled + " " * (bar_width - filled)
+    bar = ("=" * filled) + (" " * (bar_width - filled))
 
     print "\r  [#{bar}] #{pct}% (#{current}/#{total}) #{label}     "
     $stdout.flush

data/benchmarks/lib/metrics_collector.rb

@@ -46,8 +46,8 @@ class MetricsCollector
     tool_runs = runs_for_tool(tool)
     return nil if tool_runs.empty?
 
-    execution_times = tool_runs.map { |r| r[:execution_time] }.compact
-    memory_values = tool_runs.map { |r| r[:peak_memory] }.compact
+    execution_times = tool_runs.filter_map { |r| r[:execution_time] }
+    memory_values = tool_runs.filter_map { |r| r[:peak_memory] }
 
     {
       tool: tool,
@@ -118,7 +118,7 @@ class MetricsCollector
       total_runs: @runs.size,
       tools: tools,
       files_tested: @runs.map { |r| r[:file] }.uniq.size,
-      tool_statistics: tools.map { |tool| calculate_statistics(tool) }.compact,
+      tool_statistics: tools.filter_map { |tool| calculate_statistics(tool) },
     }
   end
 

data/benchmarks/lib/report_generator.rb

@@ -42,9 +42,9 @@ class ReportGenerator
     return "No benchmark data available.\n" if tools.empty?
 
     output = []
-    output << "=" * 80
+    output << ("=" * 80)
     output << "PNG Validation Tool Benchmark Comparison"
-    output << "=" * 80
+    output << ("=" * 80)
     output << ""
     output << "Configuration:"
     output << "  Files tested:     #{summary[:files_tested]} PNG files"
@@ -62,9 +62,9 @@ class ReportGenerator
     # Performance comparison (if we have 2 tools)
     if tools.size == 2
       comparison = metrics_collector.compare_tools(tools[0], tools[1])
-      output << "-" * 80
+      output << ("-" * 80)
       output << "PERFORMANCE SUMMARY"
-      output << "-" * 80
+      output << ("-" * 80)
       output << ""
       output << format_comparison_table(comparison)
       output << ""
@@ -73,9 +73,9 @@ class ReportGenerator
     end
 
     # Detailed statistics per tool
-    output << "-" * 80
+    output << ("-" * 80)
     output << "DETAILED STATISTICS"
-    output << "-" * 80
+    output << ("-" * 80)
     output << ""
 
     tools.each do |tool|
@@ -176,9 +176,8 @@ class ReportGenerator
   # Format comparison table for text output.
   def format_comparison_table(comparison)
     lines = []
-    lines << sprintf("%-15s %12s %12s %12s %8s",
-                     "Tool", "Avg Time", "Files/sec", "Peak Memory", "Winner")
-    lines << "-" * 80
+    lines << "Tool                Avg Time    Files/sec  Peak Memory   Winner"
+    lines << ("-" * 80)
 
     [comparison[:tool1], comparison[:tool2]].each do |tool|
       stats = comparison[:stats][tool]

data/config/validation_profiles.yml

@@ -0,0 +1,105 @@
+# PNG Conform Validation Profiles
+#
+# This file defines validation profiles for PNG files. Each profile specifies
+# which chunks are required, optional, or prohibited.
+#
+# Profile structure:
+#   name: Display name
+#   description: Human-readable description
+#   required_chunks: List of chunk types that MUST be present
+#   optional_chunks: List of chunk types that MAY be present (use "*" for all)
+#   prohibited_chunks: List of chunk types that MUST NOT be present
+#
+
+minimal:
+  name: "Minimal validation"
+  description: "Only critical chunks required"
+  required_chunks:
+    - IHDR
+    - IDAT
+    - IEND
+  optional_chunks: "*"
+  prohibited_chunks: []
+
+web:
+  name: "Web-optimized"
+  description: "Recommended for web images"
+  required_chunks:
+    - IHDR
+    - IDAT
+    - IEND
+    - gAMA
+    - sRGB
+  optional_chunks:
+    - tRNS
+    - bKGD
+    - tEXt
+    - iTXt
+    - zTXt
+    - pHYs
+  prohibited_chunks: []
+
+print:
+  name: "Print-ready"
+  description: "For high-quality print output"
+  required_chunks:
+    - IHDR
+    - IDAT
+    - IEND
+    - pHYs
+  optional_chunks:
+    - gAMA
+    - cHRM
+    - sRGB
+    - iCCP
+    - tRNS
+    - bKGD
+  prohibited_chunks: []
+
+archive:
+  name: "Archive quality"
+  description: "For long-term image storage"
+  required_chunks:
+    - IHDR
+    - IDAT
+    - IEND
+  optional_chunks:
+    - gAMA
+    - cHRM
+    - sRGB
+    - iCCP
+    - tEXt
+    - iTXt
+    - zTXt
+    - tIME
+  prohibited_chunks: []
+
+strict:
+  name: "Strict PNG specification"
+  description: "Full compliance with PNG specification"
+  required_chunks:
+    - IHDR
+    - IDAT
+    - IEND
+  optional_chunks:
+    - PLTE
+    - gAMA
+    - cHRM
+    - sRGB
+    - iCCP
+    - tRNS
+    - bKGD
+    - hIST
+    - tEXt
+    - zTXt
+    - iTXt
+    - pHYs
+    - sPLT
+    - sBIT
+    - oFFs
+    - pCAL
+    - sCAL
+    - tIME
+    - cICP
+    - mDCv
+  prohibited_chunks: []

data/lib/png_conform/analyzers/comparison_analyzer.rb

@@ -1,18 +1,51 @@
 # frozen_string_literal: true
 
+require_relative "../configuration"
+require_relative "../services/file_signature"
+
 module PngConform
   module Analyzers
     # Compares two PNG files and reports differences
     class ComparisonAnalyzer
-      # Metadata chunk types
-      METADATA_CHUNKS = %w[tEXt zTXt iTXt tIME].freeze
-
-      def initialize(result1, result2)
+      def initialize(result1, result2, config: Configuration.instance)
         @result1 = result1
         @result2 = result2
+        @config = config
+
+        # Fast path: compute signatures for quick equality check
+        @sig1 = Services::FileSignature.from_result(result1).compute_signature
+        @sig2 = Services::FileSignature.from_result(result2).compute_signature
       end
 
       def analyze
+        # Fast return if signatures are identical
+        return identical_result if @sig1 == @sig2
+
+        # Full comparison for different files
+        full_comparison
+      end
+
+      private
+
+      # Return result for identical files
+      #
+      # @return [Hash] Analysis result for identical files
+      def identical_result
+        {
+          files: {
+            file1: @result1.filename,
+            file2: @result2.filename,
+            identical: true,
+            signature: @sig1.short_signature,
+          },
+          summary: ["Files are binary identical"],
+        }
+      end
+
+      # Full comparison for different files
+      #
+      # @return [Hash] Complete comparison analysis
+      def full_comparison
         {
           files: file_comparison,
           image: image_comparison,
@@ -23,8 +56,6 @@ module PngConform
         }
       end
 
-      private
-
       def file_comparison
         size1 = @result1.file_size
         size2 = @result2.file_size
@@ -144,19 +175,19 @@ module PngConform
       end
 
       def new_errors
-        errors1 = @result1.errors.map(&:message).to_set
-        errors2 = @result2.errors.map(&:message).to_set
+        errors1 = @result1.errors.to_set(&:message)
+        errors2 = @result2.errors.to_set(&:message)
         (errors2 - errors1).to_a
       end
 
       def resolved_errors
-        errors1 = @result1.errors.map(&:message).to_set
-        errors2 = @result2.errors.map(&:message).to_set
+        errors1 = @result1.errors.to_set(&:message)
+        errors2 = @result2.errors.to_set(&:message)
         (errors1 - errors2).to_a
       end
 
       def compression_improved?
-        return nil unless @result1.compression_ratio && @result2.compression_ratio
+        return false unless @result1.compression_ratio && @result2.compression_ratio
 
         @result2.compression_ratio > @result1.compression_ratio
       end
@@ -166,7 +197,10 @@ module PngConform
       end
 
       def metadata_count(result)
-        result.chunks.count { |c| METADATA_CHUNKS.include?(c.type) }
+        # Use only text and time chunks from metadata (excluding pHYs which is physical)
+        result.chunks.count do |c|
+          @config.text_chunks.include?(c.type) || c.type == "tIME"
+        end
       end
 
       def format_size_change(diff, percent)

data/lib/png_conform/analyzers/metrics_analyzer.rb

@@ -1,17 +1,14 @@
 # frozen_string_literal: true
 
+require_relative "../configuration"
+
 module PngConform
   module Analyzers
     # Generates comprehensive metrics for CI/CD and automation
     class MetricsAnalyzer
-      # Text chunk types
-      TEXT_CHUNKS = %w[tEXt zTXt iTXt].freeze
-
-      # Metadata chunk types including time
-      METADATA_CHUNKS = %w[tEXt zTXt iTXt tIME].freeze
-
-      def initialize(result)
+      def initialize(result, config: Configuration.instance)
         @result = result
+        @config = config
         ihdr = result.ihdr_chunk
         @width = ihdr ? get_width(ihdr) : 0
         @height = ihdr ? get_height(ihdr) : 0
@@ -149,10 +146,10 @@ module PngConform
           has_iccp: @result.has_chunk?("iCCP"),
           has_transparency: @result.has_chunk?("tRNS"),
           has_metadata: @result.chunks.any? do |c|
-            TEXT_CHUNKS.include?(c.type)
+            @config.text_chunks.include?(c.type)
           end,
           metadata_chunks_count: @result.chunks.count do |c|
-            METADATA_CHUNKS.include?(c.type)
+            @config.metadata_chunks.include?(c.type)
           end,
           bytes_per_pixel: calculate_bytes_per_pixel,
         }