pmacs-activerecord-oracle_enhanced-adapter 1.4.2.rc1 → 1.5.5.1

data/spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb

@@ -6,7 +6,8 @@ describe "OracleEnhancedAdapter schema dump" do
   before(:all) do
     ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.connection
-    @oracle11g = !! @conn.select_value("SELECT * FROM v$version WHERE banner LIKE 'Oracle%11g%'")
+    @oracle11g_or_higher = !! @conn.select_value(
+      "select * from product_component_version where product like 'Oracle%' and to_number(substr(version,1,2)) >= 11")
   end
 
   def standard_dump(options = {})
@@ -17,7 +18,7 @@ describe "OracleEnhancedAdapter schema dump" do
   end
 
   def create_test_posts_table(options = {})
-    options.merge! :force => true
+    options.merge! force: true
     schema_define do
       create_table :test_posts, options do |t|
         t.string :title
@@ -42,12 +43,12 @@ describe "OracleEnhancedAdapter schema dump" do
 
     it "should not include ignored table names in schema dump" do
       create_test_posts_table
-      standard_dump(:ignore_tables => %w(test_posts)).should_not =~ /create_table "test_posts"/
+      standard_dump(ignore_tables: %w(test_posts)).should_not =~ /create_table "test_posts"/
     end
 
     it "should not include ignored table regexes in schema dump" do
       create_test_posts_table
-      standard_dump(:ignore_tables => [ /test_posts/i ]).should_not =~ /create_table "test_posts"/
+      standard_dump(ignore_tables: [ /test_posts/i ]).should_not =~ /create_table "test_posts"/
     end
 
   end
@@ -55,9 +56,9 @@ describe "OracleEnhancedAdapter schema dump" do
   describe "dumping default values" do
     before :each do
       schema_define do
-        create_table "test_defaults", :force => true do |t|
-          t.string "regular", :default => "c"
-          t.string "special_c", :default => "\n"
+        create_table "test_defaults", force: true do |t|
+          t.string "regular", default: "c"
+          t.string "special_c", default: "\n"
         end
       end
     end
@@ -69,7 +70,7 @@ describe "OracleEnhancedAdapter schema dump" do
     end
 
     it "should be able to dump default values using special characters" do
-      standard_dump.should =~ /t.string \"special_c\", :default => "\\n"/
+      standard_dump.should =~ /t.string \"special_c\", default: "\\n"/
     end
   end
   describe "table prefixes and suffixes" do
@@ -124,8 +125,8 @@ describe "OracleEnhancedAdapter schema dump" do
     end
 
     it "should include non-default primary key in schema dump" do
-      create_test_posts_table(:primary_key => 'post_id')
-      standard_dump.should =~ /create_table "test_posts", :primary_key => "post_id"/
+      create_test_posts_table(primary_key: 'post_id')
+      standard_dump.should =~ /create_table "test_posts", primary_key: "post_id"/
     end
 
   end
@@ -138,13 +139,13 @@ describe "OracleEnhancedAdapter schema dump" do
     end
 
     it "should include primary key trigger in schema dump" do
-      create_test_posts_table(:primary_key_trigger => true)
+      create_test_posts_table(primary_key_trigger: true)
       standard_dump.should =~ /create_table "test_posts".*add_primary_key_trigger "test_posts"/m
     end
 
     it "should include primary key trigger with non-default primary key in schema dump" do
-      create_test_posts_table(:primary_key_trigger => true, :primary_key => 'post_id')
-      standard_dump.should =~ /create_table "test_posts", :primary_key => "post_id".*add_primary_key_trigger "test_posts", :primary_key => "post_id"/m
+      create_test_posts_table(primary_key_trigger: true, primary_key: 'post_id')
+      standard_dump.should =~ /create_table "test_posts", primary_key: "post_id".*add_primary_key_trigger "test_posts", primary_key: "post_id"/m
     end
 
   end
@@ -152,11 +153,11 @@ describe "OracleEnhancedAdapter schema dump" do
   describe "foreign key constraints" do
     before(:all) do
       schema_define do
-        create_table :test_posts, :force => true do |t|
+        create_table :test_posts, force: true do |t|
           t.string :title
         end
-        create_table :test_comments, :force => true do |t|
-          t.string :body, :limit => 4000
+        create_table :test_comments, force: true do |t|
+          t.string :body, limit: 4000
           t.references :test_post
         end
       end
@@ -165,7 +166,7 @@ describe "OracleEnhancedAdapter schema dump" do
     after(:each) do
       schema_define do
         remove_foreign_key :test_comments, :test_posts rescue nil
-        remove_foreign_key :test_comments, :name => 'comments_posts_baz_fooz_fk' rescue nil
+        remove_foreign_key :test_comments, name: 'comments_posts_baz_fooz_fk' rescue nil
       end
     end
     after(:all) do
@@ -179,49 +180,49 @@ describe "OracleEnhancedAdapter schema dump" do
       schema_define do
         add_foreign_key :test_comments, :test_posts
       end
-      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :name => "test_comments_test_post_id_fk"/
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", name: "test_comments_test_post_id_fk"/
     end
 
     it "should include foreign key with delete dependency in schema dump" do
       schema_define do
-        add_foreign_key :test_comments, :test_posts, :dependent => :delete
+        add_foreign_key :test_comments, :test_posts, dependent: :delete
       end
-      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :name => "test_comments_test_post_id_fk", :dependent => :delete/
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", name: "test_comments_test_post_id_fk", dependent: :delete/
     end
 
     it "should include foreign key with nullify dependency in schema dump" do
       schema_define do
-        add_foreign_key :test_comments, :test_posts, :dependent => :nullify
+        add_foreign_key :test_comments, :test_posts, dependent: :nullify
       end
-      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :name => "test_comments_test_post_id_fk", :dependent => :nullify/
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", name: "test_comments_test_post_id_fk", dependent: :nullify/
     end
 
     it "should not include foreign keys on ignored table names in schema dump" do
       schema_define do
         add_foreign_key :test_comments, :test_posts
       end
-      standard_dump(:ignore_tables => %w(test_comments)).should_not =~ /add_foreign_key "test_comments"/
+      standard_dump(ignore_tables: %w(test_comments)).should_not =~ /add_foreign_key "test_comments"/
     end
 
     it "should not include foreign keys on ignored table regexes in schema dump" do
       schema_define do
         add_foreign_key :test_comments, :test_posts
       end
-      standard_dump(:ignore_tables => [ /test_comments/i ]).should_not =~ /add_foreign_key "test_comments"/
+      standard_dump(ignore_tables: [ /test_comments/i ]).should_not =~ /add_foreign_key "test_comments"/
     end
 
     it "should include foreign keys referencing ignored table names in schema dump" do
       schema_define do
         add_foreign_key :test_comments, :test_posts
       end
-      standard_dump(:ignore_tables => %w(test_posts)).should =~ /add_foreign_key "test_comments"/
+      standard_dump(ignore_tables: %w(test_posts)).should =~ /add_foreign_key "test_comments"/
     end
 
     it "should include foreign keys referencing ignored table regexes in schema dump" do
       schema_define do
         add_foreign_key :test_comments, :test_posts
       end
-      standard_dump(:ignore_tables => [ /test_posts/i ]).should =~ /add_foreign_key "test_comments"/
+      standard_dump(ignore_tables: [ /test_posts/i ]).should =~ /add_foreign_key "test_comments"/
     end
 
     it "should include composite foreign keys" do
@@ -237,9 +238,9 @@ describe "OracleEnhancedAdapter schema dump" do
         add_column :test_comments, :baz_id, :integer
         add_column :test_comments, :fooz_id, :integer
 
-        add_foreign_key :test_comments, :test_posts, :columns => ["baz_id", "fooz_id"], :name => 'comments_posts_baz_fooz_fk'
+        add_foreign_key :test_comments, :test_posts, columns: ["baz_id", "fooz_id"], name: 'comments_posts_baz_fooz_fk'
       end
-      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", :columns => \["baz_id", "fooz_id"\], :name => "comments_posts_baz_fooz_fk"/
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", columns: \["baz_id", "fooz_id"\], name: "comments_posts_baz_fooz_fk"/
     end
     it "should include foreign keys following all tables" do
       # if foreign keys preceed declaration of all tables
@@ -250,6 +251,26 @@ describe "OracleEnhancedAdapter schema dump" do
       dump = standard_dump
       dump.rindex("create_table").should < dump.index("add_foreign_key")
     end
+ 
+    it "should include primary_key when reference column name is not 'id'" do
+      schema_define do
+        create_table :test_posts, force: true, :primary_key => 'baz_id' do |t|
+          t.string :title
+        end
+        create_table :test_comments, force: true do |t|
+          t.string :body, limit: 4000
+          t.integer :baz_id
+        end
+      end
+
+      @conn.execute <<-SQL
+        ALTER TABLE TEST_COMMENTS
+        ADD CONSTRAINT TEST_COMMENTS_BAZ_ID_FK FOREIGN KEY (baz_id) REFERENCES test_posts(baz_id)
+      SQL
+
+      standard_dump.should =~ /add_foreign_key "test_comments", "test_posts", column: "baz_id", primary_key: "baz_id", name: "test_comments_baz_id_fk"/
+    end
+    
   end
 
   describe "synonyms" do
@@ -261,37 +282,37 @@ describe "OracleEnhancedAdapter schema dump" do
 
     it "should include synonym to other schema table in schema dump" do
       schema_define do
-        add_synonym :test_synonym, "schema_name.table_name", :force => true
+        add_synonym :test_synonym, "schema_name.table_name", force: true
       end
-      standard_dump.should =~ /add_synonym "test_synonym", "schema_name.table_name", :force => true/
+      standard_dump.should =~ /add_synonym "test_synonym", "schema_name.table_name", force: true/
     end
 
     it "should include synonym to other database table in schema dump" do
       schema_define do
-        add_synonym :test_synonym, "table_name@link_name", :force => true
+        add_synonym :test_synonym, "table_name@link_name", force: true
       end
-      standard_dump.should =~ /add_synonym "test_synonym", "table_name@link_name(\.[-A-Za-z0-9_]+)*", :force => true/
+      standard_dump.should =~ /add_synonym "test_synonym", "table_name@link_name(\.[-A-Za-z0-9_]+)*", force: true/
     end
 
     it "should not include ignored table names in schema dump" do
       schema_define do
-        add_synonym :test_synonym, "schema_name.table_name", :force => true
+        add_synonym :test_synonym, "schema_name.table_name", force: true
       end
-      standard_dump(:ignore_tables => %w(test_synonym)).should_not =~ /add_synonym "test_synonym"/
+      standard_dump(ignore_tables: %w(test_synonym)).should_not =~ /add_synonym "test_synonym"/
     end
 
     it "should not include ignored table regexes in schema dump" do
       schema_define do
-        add_synonym :test_synonym, "schema_name.table_name", :force => true
+        add_synonym :test_synonym, "schema_name.table_name", force: true
       end
-      standard_dump(:ignore_tables => [ /test_synonym/i ]).should_not =~ /add_synonym "test_synonym"/
+      standard_dump(ignore_tables: [ /test_synonym/i ]).should_not =~ /add_synonym "test_synonym"/
     end
 
     it "should include synonyms to ignored table regexes in schema dump" do
       schema_define do
-        add_synonym :test_synonym, "schema_name.table_name", :force => true
+        add_synonym :test_synonym, "schema_name.table_name", force: true
       end
-      standard_dump(:ignore_tables => [ /table_name/i ]).should =~ /add_synonym "test_synonym"/
+      standard_dump(ignore_tables: [ /table_name/i ]).should =~ /add_synonym "test_synonym"/
     end
 
   end
@@ -302,8 +323,8 @@ describe "OracleEnhancedAdapter schema dump" do
     end
 
     it "should include temporary options" do
-      create_test_posts_table(:temporary => true)
-      standard_dump.should =~ /create_table "test_posts", :temporary => true/
+      create_test_posts_table(temporary: true)
+      standard_dump.should =~ /create_table "test_posts", temporary: true/
     end
   end
 
@@ -314,20 +335,20 @@ describe "OracleEnhancedAdapter schema dump" do
 
     it "should not specify default tablespace in add index" do
       create_test_posts_table
-      standard_dump.should =~ /add_index "test_posts", \["title"\], :name => "index_test_posts_on_title"$/
+      standard_dump.should =~ /add_index "test_posts", \["title"\], name: "index_test_posts_on_title"$/
     end
 
     it "should specify non-default tablespace in add index" do
       tablespace_name = @conn.default_tablespace
       @conn.stub!(:default_tablespace).and_return('dummy')
       create_test_posts_table
-      standard_dump.should =~ /add_index "test_posts", \["title"\], :name => "index_test_posts_on_title", :tablespace => "#{tablespace_name}"$/
+      standard_dump.should =~ /add_index "test_posts", \["title"\], name: "index_test_posts_on_title", tablespace: "#{tablespace_name}"$/
     end
 
     it "should create and dump function-based indexes" do
       create_test_posts_table
-      @conn.add_index :test_posts, "NVL(created_at, updated_at)", :name => "index_test_posts_cr_upd_at"
-      standard_dump.should =~ /add_index "test_posts", \["NVL\(\\"CREATED_AT\\",\\"UPDATED_AT\\"\)"\], :name => "index_test_posts_cr_upd_at"$/
+      @conn.add_index :test_posts, "NVL(created_at, updated_at)", name: "index_test_posts_cr_upd_at"
+      standard_dump.should =~ /add_index "test_posts", \["NVL\(\\"CREATED_AT\\",\\"UPDATED_AT\\"\)"\], name: "index_test_posts_cr_upd_at"$/
     end
 
   end
@@ -347,7 +368,7 @@ describe "OracleEnhancedAdapter schema dump" do
 
   describe 'virtual columns' do
     before(:all) do
-      if @oracle11g
+      if @oracle11g_or_higher
         schema_define do
           create_table :test_names, :force => true do |t|
             t.string  :first_name
@@ -355,6 +376,7 @@ describe "OracleEnhancedAdapter schema dump" do
             t.virtual :full_name,        :as => "first_name || ', ' || last_name"
             t.virtual :short_name,       :as => "COALESCE(first_name, last_name)", :type => :string, :limit => 300
             t.virtual :abbrev_name,      :as => "SUBSTR(first_name,1,50) || ' ' || SUBSTR(last_name,1,1) || '.'", :type => "VARCHAR(100)"
+            t.virtual :name_ratio, :as=>'(LENGTH(first_name)/LENGTH(last_name))'
             t.column  :full_name_length, :virtual, :as => "length(first_name || ', ' || last_name)", :type => :integer
             t.virtual :field_with_leading_space, :as => "' ' || first_name || ' '", :limit => 300, :type => :string
           end
@@ -365,31 +387,45 @@ describe "OracleEnhancedAdapter schema dump" do
     end
 
     before(:each) do
-      if @oracle11g
+      if @oracle11g_or_higher
         class ::TestName < ActiveRecord::Base
-          if self.respond_to?(:table_name=)
-            self.table_name = "test_names"
-          else
-            set_table_name "test_names"
-          end
+          self.table_name = "test_names"
         end
       end
     end
 
     after(:all) do
-      if @oracle11g
+      if @oracle11g_or_higher
         schema_define do
           drop_table :test_names
         end
       end
     end
 
-    it 'should dump correctly' do
-      standard_dump.should =~ /t\.virtual "full_name",(\s*):limit => 512,(\s*):as => "\\"FIRST_NAME\\"\|\|', '\|\|\\"LAST_NAME\\"",(\s*):type => :string/
-      standard_dump.should =~ /t\.virtual "short_name",(\s*):limit => 300,(\s*):as =>(.*),(\s*):type => :string/
-      standard_dump.should =~ /t\.virtual "full_name_length",(\s*):precision => 38,(\s*):scale => 0,(\s*):as =>(.*),(\s*):type => :integer/
-      standard_dump.should =~ /t\.virtual "abbrev_name",(\s*):limit => 100,(\s*):as =>(.*),(\s*):type => :string/
-      standard_dump.should =~ /t\.virtual "field_with_leading_space",(\s*):limit => 300,(\s*):as => "' '\|\|\\"FIRST_NAME\\"\|\|' '",(\s*):type => :string/
+    context "when number_datatype_coercion is :float" do
+      before { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.stub(:number_datatype_coercion).and_return(:float) }
+
+      it 'should dump correctly' do
+        standard_dump.should =~ /t\.virtual "full_name",(\s*)limit: 512,(\s*)as: "\\"FIRST_NAME\\"\|\|', '\|\|\\"LAST_NAME\\"",(\s*)type: :string/
+        standard_dump.should =~ /t\.virtual "short_name",(\s*)limit: 300,(\s*)as:(.*),(\s*)type: :string/
+        standard_dump.should =~ /t\.virtual "full_name_length",(\s*)precision: 38,(\s*)scale: 0,(\s*)as:(.*),(\s*)type: :integer/
+        standard_dump.should =~ /t\.virtual "name_ratio",(\s*)as:(.*),(\s*)type: :float$/
+        standard_dump.should =~ /t\.virtual "abbrev_name",(\s*)limit: 100,(\s*)as:(.*),(\s*)type: :string/
+        standard_dump.should =~ /t\.virtual "field_with_leading_space",(\s*)limit: 300,(\s*)as: "' '\|\|\\"FIRST_NAME\\"\|\|' '",(\s*)type: :string/
+      end
+    end
+
+    context "when number_datatype_coercion is :decimal" do
+      before { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.stub(:number_datatype_coercion).and_return(:decimal) }
+
+      it 'should dump correctly' do
+        standard_dump.should =~ /t\.virtual "full_name",(\s*)limit: 512,(\s*)as: "\\"FIRST_NAME\\"\|\|', '\|\|\\"LAST_NAME\\"",(\s*)type: :string/
+        standard_dump.should =~ /t\.virtual "short_name",(\s*)limit: 300,(\s*)as:(.*),(\s*)type: :string/
+        standard_dump.should =~ /t\.virtual "full_name_length",(\s*)precision: 38,(\s*)scale: 0,(\s*)as:(.*),(\s*)type: :integer/
+        standard_dump.should =~ /t\.virtual "name_ratio",(\s*)as:(.*)\"$/
+        standard_dump.should =~ /t\.virtual "abbrev_name",(\s*)limit: 100,(\s*)as:(.*),(\s*)type: :string/
+        standard_dump.should =~ /t\.virtual "field_with_leading_space",(\s*)limit: 300,(\s*)as: "' '\|\|\\"FIRST_NAME\\"\|\|' '",(\s*)type: :string/
+      end
     end
 
     context 'with column cache' do
@@ -415,14 +451,14 @@ describe "OracleEnhancedAdapter schema dump" do
 
     context "with index on virtual column" do
       before(:all) do
-        if @oracle11g
+        if @oracle11g_or_higher
           schema_define do 
             add_index 'test_names', 'field_with_leading_space', :name => "index_on_virtual_col"
           end
         end
       end
       after(:all) do
-        if @oracle11g
+        if @oracle11g_or_higher
           schema_define do
             remove_index 'test_names', :name => 'index_on_virtual_col'
           end
@@ -435,4 +471,160 @@ describe "OracleEnhancedAdapter schema dump" do
     end
   end
 
+  describe "NUMBER columns" do
+    after(:each) do
+      schema_define do
+        drop_table "test_numbers"
+      end
+    end
+
+    let(:value_within_max_precision)    { (10 ** @conn.class::NUMBER_MAX_PRECISION) - 1 }
+    let(:value_exceeding_max_precision) { (10 ** @conn.class::NUMBER_MAX_PRECISION) + 1 }
+
+    context "when using ActiveRecord::Schema.define and ActiveRecord::ConnectionAdapters::TableDefinition#float" do
+      before :each do
+        schema_define do
+          create_table :test_numbers, :force => true do |t|
+            t.float :value
+          end
+        end
+      end
+
+      context "when number_datatype_coercion is :float" do
+        before { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.stub(:number_datatype_coercion).and_return(:float) }
+
+        it "should dump correctly" do
+          standard_dump.should =~ /t\.float "value"$/
+        end
+      end
+
+      context "when number_datatype_coercion is :decimal" do
+        before { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.stub(:number_datatype_coercion).and_return(:decimal) }
+
+        it "should dump correctly" do
+          standard_dump.should =~ /t\.decimal "value"$/
+        end
+      end
+    end
+
+    context "when using handwritten 'CREATE_TABLE' SQL" do
+      before :each do
+        ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+        @conn = ActiveRecord::Base.connection
+        @conn.execute <<-SQL
+          CREATE TABLE test_numbers (
+            id     NUMBER(#{@conn.class::NUMBER_MAX_PRECISION},0) PRIMARY KEY,
+            value  NUMBER
+          )
+        SQL
+        @conn.execute <<-SQL
+          CREATE SEQUENCE test_numbers_seq  MINVALUE 1
+            INCREMENT BY 1 START WITH 1 CACHE 20 NOORDER NOCYCLE
+        SQL
+      end
+
+      context "when number_datatype_coercion is :float" do
+        before { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.stub(:number_datatype_coercion).and_return(:float) }
+
+        it "should dump correctly" do
+          standard_dump.should =~ /t\.float "value"$/
+        end
+
+        describe "ActiveRecord saving" do
+          before :each do
+            class ::TestNumber < ActiveRecord::Base
+              self.table_name = "test_numbers"
+            end
+          end
+
+          it "should allow saving of values within NUMBER_MAX_PRECISION" do
+            number = TestNumber.new(value: value_within_max_precision)
+            number.save!
+            number.reload
+            number.value.should eq(value_within_max_precision)
+          end
+
+          it "should allow saving of values larger than NUMBER_MAX_PRECISION" do
+            number = TestNumber.new(value: value_exceeding_max_precision)
+            number.save!
+            number.reload
+            number.value.should eq(value_exceeding_max_precision)
+          end
+
+          it "should be recreatable from dump and have same properties" do
+            # Simulating db:schema:dump & db:test:load
+            2.times do
+              create_table_dump = standard_dump[/(create_table.+?end)/m]
+
+              schema_define do
+                drop_table "test_numbers"
+              end
+
+              schema_define(&eval("-> * { #{create_table_dump} }"))
+            end
+
+            number = TestNumber.new(value: value_within_max_precision)
+            number.save!
+
+            number2 = TestNumber.new(value: value_exceeding_max_precision)
+            number2.save!
+          end
+        end
+      end
+
+      context "when number_datatype_coercion is :decimal" do
+        before { ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.stub(:number_datatype_coercion).and_return(:decimal) }
+
+        it "should dump correctly" do
+          standard_dump.should =~ /t\.decimal "value"$/
+        end
+
+        describe "ActiveRecord saving" do
+          before :each do
+            class ::TestNumber < ActiveRecord::Base
+              self.table_name = "test_numbers"
+            end
+          end
+
+          it "should allow saving of values within NUMBER_MAX_PRECISION" do
+            number = TestNumber.new(value: value_within_max_precision)
+            number.save!
+            number.reload
+            number.value.should eq(value_within_max_precision)
+          end
+
+          it "should allow saving of values larger than NUMBER_MAX_PRECISION" do
+            number = TestNumber.new(value: value_exceeding_max_precision)
+            number.save!
+            number.reload
+            number.value.should eq(value_exceeding_max_precision)
+          end
+
+          it "should be recreatable from dump and have same properties" do
+            # Simulating db:schema:dump & db:test:load
+            2.times do |i|
+              create_table_dump = standard_dump[/(create_table.+?end)/m]
+
+              schema_define do
+                drop_table "test_numbers"
+              end
+
+              schema_define(&eval("-> * { #{create_table_dump} }"))
+            end
+
+            number = TestNumber.new(value: value_within_max_precision)
+            number.save!
+
+            # Raises 'ORA-01438' as :value column type isn't FLOAT'ish
+            number2 = TestNumber.new(value: value_exceeding_max_precision)
+            lambda do
+              number2.save!
+            end.should raise_error() { |e| e.message.should =~ /ORA-01438/ }
+          end
+        end
+      end # context (:decimal)
+
+    end # context (handwritten)
+  end # describe (NUMBER columns)
+
 end