plutonium 0.10.3 → 0.11.0

data/lib/generators/pu/res/conn/conn_generator.rb

@@ -17,7 +17,7 @@ module Pu
         source_feature = select_feature
         source_module = (source_feature == "main_app") ? "ResourceRecord" : "#{source_feature.classify}::ResourceRecord"
 
-        Rails.application.eager_load!
+        Plutonium.eager_load_rails!
         available_resources = source_module.constantize.descendants.map(&:to_s)
         selected_resources = prompt.multi_select("Select resources", available_resources)
 
@@ -27,9 +27,9 @@ module Pu
           @resource_class = resource
 
           template "app/controllers/resource_controller.rb", "packages/#{package_namespace}/app/controllers/#{package_namespace}/#{resource.pluralize.underscore}_controller.rb"
-          template "app/policies/resource_policy.rb", "packages/#{package_namespace}/app/policies/#{package_namespace}/#{resource.underscore}_policy.rb"
-          template "app/presenters/resource_presenter.rb", "packages/#{package_namespace}/app/presenters/#{package_namespace}/#{resource.underscore}_presenter.rb"
-          template "app/query_objects/resource_query_object.rb", "packages/#{package_namespace}/app/query_objects/#{package_namespace}/#{resource.underscore}_query_object.rb"
+          # template "app/policies/resource_policy.rb", "packages/#{package_namespace}/app/policies/#{package_namespace}/#{resource.underscore}_policy.rb"
+          # template "app/presenters/resource_presenter.rb", "packages/#{package_namespace}/app/presenters/#{package_namespace}/#{resource.underscore}_presenter.rb"
+          # template "app/query_objects/resource_query_object.rb", "packages/#{package_namespace}/app/query_objects/#{package_namespace}/#{resource.underscore}_query_object.rb"
 
           insert_into_file "packages/#{package_namespace}/lib/engine.rb",
             indent("register_resource ::#{resource}\n", 6),

data/lib/generators/pu/res/conn/templates/app/controllers/resource_controller.rb.tt

@@ -1,3 +1,3 @@
 class <%= app_namespace %>::<%= resource_class.pluralize %>Controller < ::<%= resource_class.pluralize %>Controller
-  include <%= app_namespace %>::<%= app_namespace %>Controller
+  include <%= app_namespace %>::Concerns::Controller
 end

data/lib/generators/pu/res/model/model_generator.rb

@@ -14,9 +14,9 @@ module Pu
       def run_create_model
         model_class = class_name.safe_constantize
         if model_class.present? && !model_class.include?(Plutonium::Resource::Record)
-          insert_into_file File.join("app/models", class_path, "#{file_name}.rb"),
-            indent("include Plutonium::Resource::Record\n", 2),
-            after: /.*class .*\n/
+          gsub_file File.join("app/models", class_path, "#{file_name}.rb"),
+            "< ApplicationRecord",
+            "< ResourceRecord"
         end
 
         create_model_file if create_files?

data/lib/generators/pu/res/scaffold/templates/policy.rb.tt

@@ -19,5 +19,11 @@ class <%= class_name %>Policy < <%= [feature_package_name, "ResourcePolicy"].joi
   def permitted_attributes_for_read
     <%= attributes.select{ |a| !a.rich_text? && !a.password_digest? && !a.token? }.map(&:name).map(&:to_sym).inspect %>
   end
+
+  # Associations
+
+  def permitted_associations
+    %i[]
+  end
 end
 <% end -%>

data/lib/generators/pu/service/sidekiq/sidekiq_generator.rb

@@ -13,14 +13,9 @@ module Pu
 
       def start
         bundle "sidekiq"
-        bundle "sidekiq-failures"
         directory "app"
         directory "config"
 
-        in_root do
-          insert_into_file "app/jobs/application_job.rb", "\n  sidekiq_options failures: :exhausted\n", before: /^end/
-        end
-
         add_compose_env :REDIS_QUEUE_URL, "redis://redis-queue/0"
         add_required_env_vars :REDIS_QUEUE_URL
         add_compose_dependency redis_service

data/lib/generators/pu/service/sidekiq/templates/app/sidekiq/sidekiq_job.rb

@@ -1,5 +1,3 @@
 class SidekiqJob
   include Sidekiq::Job
-
-  sidekiq_options failures: :exhausted
 end

data/lib/plutonium/config.rb

@@ -3,19 +3,7 @@ require "active_model"
 
 module Plutonium
   module Config
-    mattr_accessor :stylesheet_tag
-    @@stylesheet_tag = ->(view_context) {
-      "<link rel=\"stylesheet\" href=\"#{Plutonium.stylesheet_link}\" data-turbo-track=\"reload\" />".html_safe
-    }
-
-    mattr_accessor :script_tag
-    @@script_tag = ->(view_context) {
-      "<script src=\"#{Plutonium.script_link}\" data-turbo-track=\"reload\"></script>".html_safe
-    }
-
-    mattr_accessor :favicon_tag
-    @@favicon_tag = ->(view_context) {
-      "<link rel=\"icon\" type=\"image/x-icon\" href=\"#{Plutonium.favicon_link}\">".html_safe
-    }
+    mattr_accessor :logo
+    @@logo = "plutonium-logo.png"
   end
 end

data/lib/plutonium/core/associations/renderers/basic_renderer.rb

@@ -0,0 +1,28 @@
+module Plutonium
+  module Core
+    module Associations
+      module Renderers
+        class BasicRenderer
+          attr_reader :name, :label, :reflection, :user_options
+
+          def initialize(name, label:, reflection:, **user_options)
+            @name = name
+            @label = label
+            @reflection = reflection
+            @user_options = user_options
+          end
+
+          def render(view_context, record)
+            raise NotImplementedError
+          end
+
+          def options = @options ||= renderer_options.deep_merge(@user_options)
+
+          private
+
+          def renderer_options = {}
+        end
+      end
+    end
+  end
+end

data/lib/plutonium/core/associations/renderers/factory.rb

@@ -0,0 +1,36 @@
+require "simple_form/map_type"
+
+module Plutonium
+  module Core
+    module Associations
+      module Renderers
+        class Factory
+          extend ::SimpleForm::MapType
+
+          map_type :has_many, to: Plutonium::Core::Associations::Renderers::HasManyRenderer
+
+          def self.build(name, type:, **)
+            mapping = mappings[type]
+            raise ArgumentError, "Unknown association renderer type #{type}" unless mapping.present?
+
+            mapping.new(name, **)
+          end
+
+          def self.for_resource_association(resource_class, attr_name, **options)
+            options[:label] ||= resource_class.human_attribute_name(attr_name)
+
+            association = resource_class.try(:reflect_on_association, attr_name)
+            raise ArgumentError, "#{attr_name} is not a valid association of #{resource_class}" unless association.present?
+            raise ArgumentError, "#{association.klass} does is not a resource record" unless association.klass.include?(Plutonium::Resource::Record)
+
+            type = association.macro
+            raise NotImplementedError, "#{macro} associations are currently not supported." unless type == :has_many
+
+            options[:reflection] = association
+            build(attr_name, type:, **options)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/plutonium/core/associations/renderers/has_many_renderer.rb

@@ -0,0 +1,16 @@
+module Plutonium
+  module Core
+    module Associations
+      module Renderers
+        class HasManyRenderer < BasicRenderer
+          def render(view_context, record)
+            view_context.render_component :has_many_panel,
+              title: label,
+              src: view_context.resource_url_for(reflection.klass, parent: record),
+              **options
+          end
+        end
+      end
+    end
+  end
+end

data/lib/plutonium/core/autodiscovery/association_renderer_discoverer.rb

@@ -0,0 +1,31 @@
+module Plutonium
+  module Core
+    module Autodiscovery
+      module AssociationRendererDiscoverer
+        extend ActiveSupport::Concern
+        include Discoverer
+
+        class_methods do
+          def autodiscovery_association_renderer_cache = @autodiscovery_association_renderer_cache ||= {}
+        end
+
+        private
+
+        # If cache_discovery is enabled, use the class level cache that persists
+        # between requests, otherwise use the instance one.
+        def autodiscovery_association_renderer_cache
+          if Rails.application.config.plutonium.cache_discovery
+            self.class.autodiscovery_association_renderer_cache
+          else
+            @autodiscovery_association_renderer_cache ||= {}
+          end
+        end
+
+        def autodiscover_association_renderer(name)
+          autodiscovery_association_renderer_cache[name] ||=
+            Plutonium::Core::Associations::Renderers::Factory.for_resource_association(resource_class, name)
+        end
+      end
+    end
+  end
+end

data/lib/plutonium/core/controllers/authorizable.rb

@@ -5,22 +5,17 @@ module Plutonium
     module Controllers
       module Authorizable
         extend ActiveSupport::Concern
-        include Pundit::Authorization
+        include ::Pundit::Authorization
 
         included do
           after_action :verify_authorized
           after_action :verify_policy_scoped, except: %i[new create]
 
-          helper_method :permitted_attributes
-          helper_method :current_policy
+          helper_method :current_policy, :permitted_attributes
         end
 
         private
 
-        def policy_namespace(scope)
-          [current_package.to_s.underscore.to_sym, scope]
-        end
-
         def policy_context
           raise NotImplementedError, "policy_context"
         end
@@ -29,22 +24,23 @@ module Plutonium
           policy_context
         end
 
-        def policy(scope)
-          super(policy_namespace(scope))
-        end
-
-        def policy_scope(scope)
-          super(policy_namespace(scope))
-        end
-
-        def authorize(record, query = nil)
-          super(policy_namespace(record), query)
+        # @return [Plutonium::Pundit::Context] a new instance of {Plutonium::Pundit::Context} with the current user and package
+        def pundit
+          @pundit ||= Plutonium::Pundit::Context.new(
+            package: current_package.to_s.underscore.to_sym,
+            user: pundit_user,
+            policy_cache: ::Pundit::CacheStore::LegacyStore.new(policies)
+          )
         end
 
         def permitted_attributes
           @permitted_attributes ||= current_policy.send_with_report :"permitted_attributes_for_#{action_name}"
         end
 
+        def permitted_associations
+          @permitted_associations ||= current_policy.permitted_associations
+        end
+
         def current_policy
           @current_policy ||= begin
             policy_subject = resource_record || resource_class

data/lib/plutonium/core/controllers/base.rb

@@ -18,7 +18,7 @@ module Plutonium
           end
 
           helper Plutonium::Helpers
-          helper_method :page_title, :resource_url_for, :resource_url_args_for, :root_path, :application_name
+          helper_method :make_page_title, :resource_url_for, :resource_url_args_for, :root_path
 
           append_view_path File.expand_path("app/views", Plutonium.root)
           layout -> { turbo_frame_request? ? false : "resource" }
@@ -30,12 +30,8 @@ module Plutonium
           @page_title = nil
         end
 
-        def page_title(title)
-          [title.presence, application_name].compact.join(" | ")
-        end
-
-        def application_name
-          Plutonium.application_name
+        def make_page_title(title)
+          [title.presence, helpers.application_name].compact.join(" | ")
         end
 
         #

data/lib/plutonium/core/controllers/presentable.rb

@@ -5,7 +5,7 @@ module Plutonium
         extend ActiveSupport::Concern
 
         included do
-          helper_method :presentable_attributes
+          helper_method :presentable_attributes, :present_associations?
         end
 
         private
@@ -44,6 +44,7 @@ module Plutonium
             resource_class:,
             record: resource_record,
             fields: current_presenter.defined_renderers_for(*presentable_attributes),
+            associations: current_presenter.defined_association_renderers_for(*permitted_associations),
             actions: current_presenter.actions
           )
         end
@@ -54,6 +55,10 @@ module Plutonium
             inputs: current_presenter.defined_inputs_for(*presentable_attributes)
           )
         end
+
+        def present_associations?
+          current_parent.nil?
+        end
       end
     end
   end

data/lib/plutonium/core/definers/association_renderer_definer.rb

@@ -0,0 +1,33 @@
+module Plutonium
+  module Core
+    module Definers
+      module AssociationRendererDefiner
+        extend ActiveSupport::Concern
+        include Plutonium::Core::Autodiscovery::AssociationRendererDiscoverer
+
+        def defined_association_renderers_for(*names)
+          (names - association_renderer_definitions.keys).each do |name|
+            define_association_renderer(name, renderer: autodiscover_association_renderer(name))
+          end
+          association_renderer_definitions.slice(*names)
+        end
+
+        private
+
+        def association_renderer_definitions = @association_renderer_definitions ||= {}
+
+        def define_association_renderer(name, renderer: nil, **options)
+          association_renderer_definitions[name] = if renderer.present?
+            renderer
+          else
+            autodiscover_association_renderer(name)
+          end
+        end
+
+        def association_renderer_defined?(name)
+          association_renderer_definitions.key? name
+        end
+      end
+    end
+  end
+end

data/lib/plutonium/core/fields/inputs/checkbox_input.rb

@@ -0,0 +1,13 @@
+module Plutonium
+  module Core
+    module Fields
+      module Inputs
+        class CheckboxInput < SimpleFormInput
+          private
+
+          def input_options = {wrapper: :resource_checkbox}
+        end
+      end
+    end
+  end
+end

data/lib/plutonium/core/fields/inputs/factory.rb

@@ -14,6 +14,7 @@ module Plutonium
           map_type :attachment, to: Plutonium::Core::Fields::Inputs::AttachmentInput
           map_type :datetime, :date, :time, to: Plutonium::Core::Fields::Inputs::DateTimeInput
           map_type :phone, to: Plutonium::Core::Fields::Inputs::PhoneInput
+          map_type :boolean, to: Plutonium::Core::Fields::Inputs::CheckboxInput
           # map_type :text, :string, to: Plutonium::Core::Fields::Inputs::SimpleFormInput
 
           def self.build(name, type:, **options)

data/lib/plutonium/core/fields/inputs/polymorphic_belongs_to_association_input.rb

@@ -27,7 +27,7 @@ module Plutonium
           end
 
           def associated_classes
-            Rails.application.eager_load! unless Rails.application.config.eager_load
+            Plutonium.eager_load_rails!
 
             associated_classes = []
             ActiveRecord::Base.descendants.each do |model|

data/lib/plutonium/core/ui/detail.rb

@@ -7,6 +7,7 @@ module Plutonium
         option :resource_class
         option :record, optional: true
         option :fields, default: proc { {} }
+        option :associations, default: proc { {} }
         option :actions, default: proc { Plutonium::Core::Actions::Collection.new }
       end
     end

data/lib/plutonium/helpers/application_helper.rb

@@ -1,17 +1,16 @@
 module Plutonium
   module Helpers
     module ApplicationHelper
-      # def tooltip(text)
-      #   text = sanitize text
-      #   "title=\"#{text}\" data-controller=\"tooltip\" data-bs-title=\"#{text}\"".html_safe
-      # end
-
-      def resource_name(resource_class, count = 1)
-        resource_class.model_name.human.pluralize(count)
+      def application_name
+        Plutonium.application_name
       end
 
-      def resource_name_plural(resource_class)
-        resource_name resource_class, 2
+      # Renders an icon using the Plutonium Icons library.
+      #
+      # @param icon [Symbol, String] The name or identifier of the icon to render.
+      # @return [String] The HTML-safe string for the rendered icon.
+      def render_icon(icon, **)
+        Plutonium::Icons.render(icon, **)
       end
     end
   end

data/lib/plutonium/helpers/assets_helper.rb

@@ -0,0 +1,33 @@
+module Plutonium
+  module Helpers
+    module AssetsHelper
+      def plutonium_stylesheet_tag
+        url = if Plutonium.development?
+          file = JSON.parse(File.read(Plutonium.root.join("src", "build", "css.manifest")))["plutonium.css"]
+          "/build/#{file}"
+        else
+          "plutonium.css"
+        end
+        stylesheet_link_tag url, "data-turbo-track": "reload"
+      end
+
+      def plutonium_script_tag
+        url = if Plutonium.development?
+          file = JSON.parse(File.read(Plutonium.root.join("src", "build", "js.manifest")))["plutonium.js"]
+          "/build/#{file}"
+        else
+          "plutonium.min.js"
+        end
+        javascript_include_tag url, "data-turbo-track": "reload", type: "module"
+      end
+
+      def logo_tag(classname:)
+        image_tag logo, class: classname
+      end
+
+      def logo
+        Plutonium::Config.logo || "plutonium-logo.png"
+      end
+    end
+  end
+end

data/lib/plutonium/helpers/display_helper.rb

@@ -1,6 +1,19 @@
 module Plutonium
   module Helpers
     module DisplayHelper
+      # def tooltip(text)
+      #   text = sanitize text
+      #   "title=\"#{text}\" data-controller=\"tooltip\" data-bs-title=\"#{text}\"".html_safe
+      # end
+
+      def resource_name(resource_class, count = 1)
+        resource_class.model_name.human.pluralize(count)
+      end
+
+      def resource_name_plural(resource_class)
+        resource_name resource_class, 2
+      end
+
       def display_field(value:, helper: nil, **options)
         return "-" unless value.present?
 

data/lib/plutonium/helpers/form_helper.rb

@@ -6,7 +6,7 @@ module Plutonium
       include ActionView::Helpers::FormHelper
 
       def resource_form_for(record, options = {}, &block)
-        options[:builder] ||= Plutonium::Ui::FormBuilder
+        options[:builder] ||= PlutoniumUi::FormBuilder
         options[:wrapper] ||= :default_resource_form
         options[:html] ||= {}
         unless options[:html].key?(:novalidate)

data/lib/plutonium/helpers.rb

@@ -12,6 +12,7 @@ module Plutonium
         include Plutonium::Helpers::TableHelper
         include Plutonium::Helpers::TurboHelper
         include Plutonium::Helpers::TurboStreamActionsHelper
+        include Plutonium::Helpers::AssetsHelper
       end
     end
   end

data/lib/plutonium/icons.rb

@@ -4,20 +4,27 @@ module Plutonium
     ICON_SIZES = {
       sm: "w-3 h-3",
       md: "w-4 h-4",
-      lg: "w-6 h-6"
+      lg: "w-6 h-6",
+      xl: "w-8 h-8"
     }
 
     class << self
-      def render(name, size: :md)
+      def render(name, size: :md, classname: nil)
+        size = ICON_SIZES.key?(size) ? size : :sm
+        classname = (Array(classname) + [ICON_SIZES[size]]).join(" ")
+
+        resolve(name).sub("<svg ", "<svg class=\"#{classname}\" ").html_safe
+      end
+
+      def resolve(name)
         # This is not threadsafe, but should not cause any issues
         # I believe adding a mutex would be overall more expensive than a few potential
         # concurrent disk accesses for a brief while after boot.
-        size = ICON_SIZES.key?(size) ? size : :sm
-        ICON_CACHE["#{name}:#{size}"] ||= begin
+        ICON_CACHE[name] ||= begin
           path = Plutonium.root.join "app/assets/icons/#{name}.svg"
           raise "Invalid icon: #{name}" unless File.exist?(path)
 
-          File.read(path).sub("<svg ", "<svg class=\"#{ICON_SIZES[size]}\" ").html_safe
+          File.read(path)
         end
       end
     end

data/lib/plutonium/pkg/app.rb

@@ -1,3 +1,5 @@
+require "active_support/notifications"
+
 module Plutonium
   module Pkg
     module App
@@ -49,6 +51,14 @@ module Plutonium
         end
 
         def draw_resource_routes
+          ActiveSupport::Notifications.instrument("plutonium.app.draw_resource_routes", app: self.class.module_parent.to_s) do
+            draw_resource_routes_internal
+          end
+        end
+
+        private
+
+        def draw_resource_routes_internal
           custom_routes_block = @custom_routes_block
           registered_resources = resource_register
           scoped_entity_param_key = self.scoped_entity_param_key if scoped_entity_strategy == :path

data/lib/plutonium/pundit/context.rb

@@ -0,0 +1,18 @@
+require "pundit"
+
+module Plutonium
+  module Pundit
+    class Context < ::Pundit::Context
+      def initialize(*, package:, **)
+        super(*, **)
+        @package = package
+      end
+
+      private
+
+      def policy_finder(record)
+        PolicyFinder.new(record, package: @package)
+      end
+    end
+  end
+end

data/lib/plutonium/pundit/policy_finder.rb

@@ -0,0 +1,25 @@
+require "pundit"
+
+module Plutonium
+  module Pundit
+    class PolicyFinder < ::Pundit::PolicyFinder
+      def initialize(*, package:)
+        super(*)
+        @package = package
+      end
+
+      attr_reader :package
+
+      def policy
+        policy_internal([package, object]) || policy_internal(object)
+      end
+
+      private
+
+      def policy_internal(object)
+        klass = find(object)
+        klass.is_a?(String) ? klass.safe_constantize : klass
+      end
+    end
+  end
+end

data/lib/plutonium/railtie.rb

@@ -6,27 +6,39 @@ module Plutonium
     config.plutonium.cache_discovery = defined?(Rails.env) && !Rails.env.development?
     config.plutonium.enable_hotreload = defined?(Rails.env) && Rails.env.development?
 
-    initializer "plutonium.append_assets_path" do |app|
-      config.to_prepare do
-        Rails.application.config.assets.paths << Plutonium.root.join("app/assets/build").to_s
-      end
+    # If you don't want to precompile Plutonium's assets (eg. because you're using webpack),
+    # you can do this in an intiailzer:
+    #
+    # config.after_initialize do
+    #   config.assets.precompile -= Plutonium::Railtie::PRECOMPILE_ASSETS
+    # end
+    PRECOMPILE_ASSETS = %w[plutonium.js plutonium.js.map plutonium.min.js plutonium.min.js.map plutonium.css]
+
+    initializer "plutonium.assets" do
+      next unless Rails.application.config.respond_to?(:assets)
+
+      Rails.application.config.assets.precompile += PRECOMPILE_ASSETS
+      Rails.application.config.assets.paths << Plutonium.root.join("app/assets").to_s
     end
 
-    initializer "plutonium.load_view_components" do
+    initializer "plutonium.load_components" do
       load Plutonium.root.join("app", "views", "components", "base.rb")
     end
 
-    initializer "plutonium.load_initializers" do
+    initializer "plutonium.initializers" do
       Dir.glob(Plutonium.root.join("config", "initializers", "**", "*.rb")) { |file| load file }
     end
 
     initializer "plutonium.asset_server" do
+      next unless Plutonium.development?
+
+      puts "=> [plutonium] starting assets server"
       # setup a middleware to serve our assets
       config.app_middleware.insert_before(
         ActionDispatch::Static,
         Rack::Static,
-        urls: ["/plutonium-assets"],
-        root: Plutonium.root.join("public"),
+        urls: ["/build"],
+        root: Plutonium.root.join("src").to_s,
         cascade: true,
         header_rules: [
           # Cache all static files in public caches (e.g. Rack::Cache) as well as in the browser