pluck_to_hash 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bfdbe8405632df3de1d9a02798734f4d240385b1
-  data.tar.gz: 62f0dec2dcbde43840140536dc347d6e8453b4f0
+  metadata.gz: d65f5c05dd598640b480fff78b2bbcbd50715877
+  data.tar.gz: 18d5c56bf46b8d7b93c7ad86c5af48b196ba2fae
 SHA512:
-  metadata.gz: ff28d40d114f7e0b17588bca904f22b812a4464fbf62b14827945eb8b9282fa7d05903f80dee43b8e11212f8b29f134aff24598c63aabbb6f90acf39a37b24ec
-  data.tar.gz: f41526670657c194b1d5937535d5d8c9aa6fecff0754f9b9eb80fb83482c20df6bf77bc49af25b0fddfa3514219cbb6e4fa81e960dfb32d98cb17b83420117bb
+  metadata.gz: a20b889c5bfcf85c7ff8be47bc0620c647481ae27a95b5eb81933a87a6d412f884a10c8378b7248c3645436b2961f0f74b79276363dbc6e7475c8bdab74e2514
+  data.tar.gz: 360ac11e42810918c61308223250ca01194f46be5ed721cf7762252f963e94828b69a8599ac17ca78680002e402391026c24401624e4a5081fa2c5a67960ed08

data/README.md

@@ -45,6 +45,23 @@ Post.limit(2).pluck_h(:id)
 #
 ```
 
+## Why not `ActiveRecord.select` or `ActiveRecord.as_json`?
+
+Here are results of "benchmark" tests performed on MacBook Air. Each method did 10 runs, rejected the 2 highest and 2 lowest times and average the remaining 6. Ran these tests on about 40,000 records. We notice that `pluck_to_hash` is almost 4x faster than `select` and about 8x faster than `as_json`. As with all the "benchmarks", you should take these results with a pinch of salt!
+
+```ruby
+# Node.pluck_h(:id, :title)
+# Node.select(:id, :title).to_a
+# Node.select(:id, :title).as_json
+
+                    user     system      total        real
+pluck_to_hash   0.145000   0.005000   0.150000 (  0.164836)
+select          0.566667   0.010000   0.576667 (  0.590911)
+as_json         1.196667   0.010000   1.206667 (  1.222286)
+```
+
+You might be interested in reading the [reason for this](http://gavinmiller.io/2013/active-records-dirty-little-secret/).
+
 ## Contributing
 
 1. Fork it ( https://github.com/girishso/pluck_to_hash/fork )

data/lib/pluck_to_hash.rb

@@ -5,7 +5,11 @@ module PluckToHash
 
   module ClassMethods
     def pluck_to_hash(*keys)
-      pluck(*keys).map{|row| Hash[keys.zip(Array(row))]}
+
+      pluck(*keys).map do |row|
+        row = [row] if keys.size == 1
+        Hash[keys.zip(row)]
+      end
     end
 
     alias_method :pluck_h, :pluck_to_hash

data/lib/pluck_to_hash/version.rb

@@ -1,3 +1,3 @@
 module PluckToHash
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/pluck_to_hash_spec.rb

@@ -1,6 +1,8 @@
 require_relative './spec_helper'
 
 describe 'PluckToHash' do
+  before { TestModel.delete_all }
+
   describe '.pluck_to_hash' do
     before do
       3.times.each do
@@ -43,6 +45,34 @@ describe 'PluckToHash' do
     end
   end
 
+  context 'when serialize attributes used' do
+    describe '.pluck_to_hash' do
+      before do
+        TestModel.create!(serialized_attribute: [])
+        TestModel.create!(serialized_attribute: ['Zygohistomorpic', 'Prepromorphism'])
+        TestModel.create!(serialized_attribute: ['Comonad'])
+      end
+      
+      it 'plucks the hash correctly' do
+        result = TestModel.pluck_to_hash(:serialized_attribute)
+        expect(result).to eq [
+          { serialized_attribute: [] },
+          { serialized_attribute: ['Zygohistomorpic', 'Prepromorphism'] },
+          { serialized_attribute: ['Comonad'] }
+        ]
+      end
+
+      it 'plucks a hash with multiple attributes' do
+        result = TestModel.pluck_to_hash(:test_attribute, :serialized_attribute)
+        expect(result).to eq [
+          { test_attribute: nil, serialized_attribute: [] },
+          { test_attribute: nil, serialized_attribute: ['Zygohistomorpic', 'Prepromorphism'] },
+          { test_attribute: nil, serialized_attribute: ['Comonad'] }
+        ]
+      end
+    end
+  end
+
   context 'making sure alias is fine' do
     describe '.pluck_h' do
       before do

data/spec/spec_helper.rb

@@ -11,8 +11,10 @@ ActiveRecord::Migration.verbose = false
 ActiveRecord::Schema.define do
   create_table :test_models do |t|
     t.string :test_attribute
+    t.string :serialized_attribute
   end
 end
 
 class TestModel < ActiveRecord::Base
-end
+  serialize :serialized_attribute, Array
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pluck_to_hash
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Girish S
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-09 00:00:00.000000000 Z
+date: 2015-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler