pluck_each 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 590090a4b024b581987c5189c8d33f7705fe9deb
-  data.tar.gz: b7902f329e25ff1a5590fdd5dcd8f757a441113f
+  metadata.gz: 12ea18fa9a2707621fb6430795c4c6047b337fec
+  data.tar.gz: 7091ef9abf6df62714e4f0f828303b482c82a765
 SHA512:
-  metadata.gz: 1686ceb57958906c293d0330f248bea630d921cc913bc7eeb2a3d508386b5421f27e52ebaee8f7524d73a944fa8d2cf952ac41b628ef4340966e33744843fd3c
-  data.tar.gz: f55c93814f73276331c515794f6863bc2634dee3558fc43b73f8e5191f6adb85d0a3a451b2dd31b3d434d216ceabb9a99f1c763da8d9f9bdf2128ab2a743fc23
+  metadata.gz: e11526748776eeb71864eb443c1cc16526b4c5e233d9488a9a207839270f8b4985a36de51942ed33cf5c6cec72ff5a236de8a28ff1eb46be6471b28032cb1514
+  data.tar.gz: 349cb861579f0c721068dc77f18113c71468f961c91dc3c887d49fc1e190874212c2879b26531a8836b18c6058caf9f0ae97e76a45660eb5982ccdc3a78c7cfd

data/lib/pluck_each.rb

@@ -53,12 +53,9 @@ module ActiveRecord
 
         break if batch.size < batch_size
 
-        # some relations don't have arel_attribute, need to figure that out
-        if respond_to?(:arel_attribute)
-          batch_relation = relation.where(arel_attribute(primary_key).gt(primary_key_offset))
-        else
-          batch_relation = relation.where("#{primary_key} > ?", primary_key_offset)
-        end
+        # Rails 5 introduced "arel_attribute" but keeps support for "table" so using
+        # "table" as the basis for this for now
+        batch_relation = relation.where(table[primary_key].gt(primary_key_offset))
       end
     end
   end

data/lib/pluck_each/version.rb

@@ -1,3 +1,3 @@
 module PluckEach
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/pluck_each_spec.rb

@@ -23,11 +23,27 @@ describe PluckEach do
   describe 'pluck_each' do
     before do
       User.delete_all
+      Product.delete_all
+
       User.create(:first_name => '1', :last_name => '1')
       User.create(:first_name => '2', :last_name => '2')
       User.create(:first_name => '3', :last_name => '3')
       User.create(:first_name => '4', :last_name => '4')
       User.create(:first_name => '5', :last_name => '5')
+      Product.create(:name => "1", :value => 1, :user_id => User.first.id)
+      Product.create(:name => "2", :value => 2, :user_id => User.first.id)
+      Product.create(:name => "3", :value => 3, :user_id => User.first.id)
+    end
+
+    it 'plucks :id from scope on association' do
+      values = []
+      user = User.first
+      user.products.pluck_each(:name) do |name|
+        values << name
+      end
+
+      values.sort!
+      values.must_equal ["1", "2", "3"]
     end
 
     it 'plucks :id when only field requested' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pluck_each
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Brandon Dewitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-03 00:00:00.000000000 Z
+date: 2016-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -146,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: pluck_each and plucK_in_batches ... should behave like find_each and find_in_batches