pliny 1.3.0 → 2.0.0

data/spec/commands/generator_spec.rb

@@ -1,7 +1,9 @@
-require 'pliny/commands/creator'
-require 'pliny/commands/generator'
-require 'pliny/commands/generator/base'
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "pliny/commands/creator"
+require "pliny/commands/generator"
+require "pliny/commands/generator/base"
+require "spec_helper"
 
 describe Pliny::Commands::Generator do
   subject { Pliny::Commands::Generator.new }
@@ -25,139 +27,139 @@ describe Pliny::Commands::Generator do
     Timecop.return
   end
 
-  describe '#endpoint' do
+  describe "#endpoint" do
     before do
-      subject.endpoint('artists')
+      subject.endpoint("artists")
     end
 
-    it 'creates a new endpoint module' do
-      assert File.exist?('lib/endpoints/artists.rb')
+    it "creates a new endpoint module" do
+      assert File.exist?("lib/endpoints/artists.rb")
     end
 
-    it 'creates an endpoint test' do
-      assert File.exist?('spec/endpoints/artists_spec.rb')
+    it "creates an endpoint test" do
+      assert File.exist?("spec/endpoints/artists_spec.rb")
     end
 
-    it 'creates an endpoint acceptance test' do
-      assert File.exist?('spec/acceptance/artists_spec.rb')
+    it "creates an endpoint acceptance test" do
+      assert File.exist?("spec/acceptance/artists_spec.rb")
     end
   end
 
-  describe '#mediator' do
+  describe "#mediator" do
     before do
-      subject.mediator('artists/creator')
+      subject.mediator("artists/creator")
     end
 
-    it 'creates a new mediator module' do
-      assert File.exist?('lib/mediators/artists/creator.rb')
+    it "creates a new mediator module" do
+      assert File.exist?("lib/mediators/artists/creator.rb")
     end
 
-    it 'creates a test' do
-      assert File.exist?('spec/mediators/artists/creator_spec.rb')
+    it "creates a test" do
+      assert File.exist?("spec/mediators/artists/creator_spec.rb")
     end
   end
 
-  describe '#model' do
-    describe 'simple model' do
+  describe "#model" do
+    describe "simple model" do
       before do
-        subject.model('artist')
+        subject.model("artist")
       end
 
-      it 'creates a migration' do
+      it "creates a migration" do
         assert File.exist?("db/migrate/#{@t.to_i}_create_artists.rb")
       end
 
-      it 'creates the actual model' do
-        assert File.exist?('lib/models/artist.rb')
+      it "creates the actual model" do
+        assert File.exist?("lib/models/artist.rb")
       end
 
-      it 'creates a test' do
-        assert File.exist?('spec/models/artist_spec.rb')
+      it "creates a test" do
+        assert File.exist?("spec/models/artist_spec.rb")
       end
     end
 
-    describe 'model in nested class' do
+    describe "model in nested class" do
       before do
-        subject.model('administration/user')
+        subject.model("administration/user")
       end
 
-      it 'creates a migration' do
+      it "creates a migration" do
         assert File.exist?("db/migrate/#{@t.to_i}_create_administration_users.rb")
       end
 
-      it 'creates the actual model' do
-        assert File.exist?('lib/models/administration/user.rb')
+      it "creates the actual model" do
+        assert File.exist?("lib/models/administration/user.rb")
       end
 
-      it 'creates a test' do
-        assert File.exist?('spec/models/administration/user_spec.rb')
+      it "creates a test" do
+        assert File.exist?("spec/models/administration/user_spec.rb")
       end
     end
   end
 
-  describe '#scaffold' do
+  describe "#scaffold" do
     before do
-      subject.scaffold('artist')
+      subject.scaffold("artist")
     end
 
-    it 'creates a new endpoint module' do
-      assert File.exist?('lib/endpoints/artists.rb')
+    it "creates a new endpoint module" do
+      assert File.exist?("lib/endpoints/artists.rb")
     end
 
-    it 'creates an endpoint test' do
-      assert File.exist?('spec/endpoints/artists_spec.rb')
+    it "creates an endpoint test" do
+      assert File.exist?("spec/endpoints/artists_spec.rb")
     end
 
-    it 'creates an endpoint acceptance test' do
-      assert File.exist?('spec/acceptance/artists_spec.rb')
+    it "creates an endpoint acceptance test" do
+      assert File.exist?("spec/acceptance/artists_spec.rb")
     end
 
-    it 'creates a migration' do
+    it "creates a migration" do
       assert File.exist?("db/migrate/#{@t.to_i}_create_artists.rb")
     end
 
-    it 'creates the actual model' do
-      assert File.exist?('lib/models/artist.rb')
+    it "creates the actual model" do
+      assert File.exist?("lib/models/artist.rb")
     end
 
-    it 'creates a test' do
-      assert File.exist?('spec/models/artist_spec.rb')
+    it "creates a test" do
+      assert File.exist?("spec/models/artist_spec.rb")
     end
 
-    it 'creates a schema' do
-      assert File.exist?('schema/schemata/artist.yaml')
+    it "creates a schema" do
+      assert File.exist?("schema/schemata/artist.yaml")
     end
 
-    it 'creates a new serializer module' do
-      assert File.exist?('lib/serializers/artist.rb')
+    it "creates a new serializer module" do
+      assert File.exist?("lib/serializers/artist.rb")
     end
 
-    it 'creates a test' do
-      assert File.exist?('spec/serializers/artist_spec.rb')
+    it "creates a test" do
+      assert File.exist?("spec/serializers/artist_spec.rb")
     end
   end
 
-  describe '#schema' do
+  describe "#schema" do
     before do
-      subject.schema('artist')
+      subject.schema("artist")
     end
 
-    it 'creates a schema' do
-      assert File.exist?('schema/schemata/artist.yaml')
+    it "creates a schema" do
+      assert File.exist?("schema/schemata/artist.yaml")
     end
   end
 
-  describe '#serializer' do
+  describe "#serializer" do
     before do
-      subject.serializer('artist')
+      subject.serializer("artist")
     end
 
-    it 'creates a new serializer module' do
-      assert File.exist?('lib/serializers/artist.rb')
+    it "creates a new serializer module" do
+      assert File.exist?("lib/serializers/artist.rb")
     end
 
-    it 'creates a test' do
-      assert File.exist?('spec/serializers/artist_spec.rb')
+    it "creates a test" do
+      assert File.exist?("spec/serializers/artist_spec.rb")
     end
   end
 end

data/spec/commands/updater_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "pliny/commands/updater"
 require "spec_helper"
 

data/spec/config_helpers_spec.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require "pliny/config_helpers"
 
 describe Pliny::CastingConfigHelpers do
-
   describe "#rack_env" do
     it "is development if app_env is development" do
       config = Class.new do
         extend Pliny::CastingConfigHelpers
-        override :app_env, 'development', string
+        override :app_env, "development", string
       end
 
       assert_equal "development", config.rack_env
@@ -16,7 +17,7 @@ describe Pliny::CastingConfigHelpers do
     it "is development if app_env is test" do
       config = Class.new do
         extend Pliny::CastingConfigHelpers
-        override :app_env, 'test', string
+        override :app_env, "test", string
       end
 
       assert_equal "development", config.rack_env
@@ -25,7 +26,7 @@ describe Pliny::CastingConfigHelpers do
     it "is deployment if app_env is production" do
       config = Class.new do
         extend Pliny::CastingConfigHelpers
-        override :app_env, 'production', string
+        override :app_env, "production", string
       end
 
       assert_equal "deployment", config.rack_env
@@ -34,7 +35,7 @@ describe Pliny::CastingConfigHelpers do
     it "is deployment if app_env is nil" do
       config = Class.new do
         extend Pliny::CastingConfigHelpers
-        override :app_env, '', string
+        override :app_env, "", string
       end
 
       assert_equal "deployment", config.rack_env
@@ -43,89 +44,10 @@ describe Pliny::CastingConfigHelpers do
     it "is deployment if app_env is another value" do
       config = Class.new do
         extend Pliny::CastingConfigHelpers
-        override :app_env, 'staging', string
+        override :app_env, "staging", string
       end
 
       assert_equal "deployment", config.rack_env
     end
-
-    context "when legacy PLINY_ENV is still defined" do
-      before do
-        ENV['ORIGINAL_PLINY_ENV'] = ENV['PLINY_ENV']
-        ENV['PLINY_ENV'] = 'staging'
-      end
-
-      after do
-        ENV['PLINY_ENV'] = ENV.delete('ORIGINAL_PLINY_ENV')
-      end
-
-      it "uses PLINY_ENV value instead of APP_ENV" do
-        config = Class.new do
-          extend Pliny::CastingConfigHelpers
-          override :app_env, 'development', string
-        end
-
-        assert_equal "deployment", config.rack_env
-      end
-
-      it "displays deprecation warning" do
-        config = Class.new do
-          extend Pliny::CastingConfigHelpers
-          override :app_env, 'development', string
-        end
-
-        io = StringIO.new
-        $stderr = io
-        config.rack_env
-        $stderr = STDERR
-
-        assert_includes io.string, "PLINY_ENV is deprecated"
-      end
-    end
-  end
-
-  describe "#pliny_env" do
-    it "displays deprecation warning if pliny_env is used" do
-      config = Class.new do
-        extend Pliny::CastingConfigHelpers
-        override :app_env, 'development', string
-      end
-
-      io = StringIO.new
-      $stderr = io
-      config.pliny_env
-      $stderr = STDERR
-
-      assert_includes io.string, "Config.pliny_env is deprecated"
-    end
-
-    it "returns app_env value" do
-      config = Class.new do
-        extend Pliny::CastingConfigHelpers
-        override :app_env, 'foo', string
-      end
-
-      assert_equal "foo", config.pliny_env
-    end
-
-    context "when legacy PLINY_ENV is still defined" do
-      before do
-        ENV['ORIGINAL_PLINY_ENV'] = ENV['PLINY_ENV']
-        ENV['PLINY_ENV'] = 'staging'
-      end
-
-      after do
-        ENV['PLINY_ENV'] = ENV.delete('ORIGINAL_PLINY_ENV')
-      end
-
-      it "returns PLINY_ENV value" do
-        config = Class.new do
-          extend Pliny::CastingConfigHelpers
-          override :app_env, 'development', string
-        end
-
-        assert_equal "staging", config.pliny_env
-      end
-    end
   end
 end

data/spec/db_support_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require "pliny/db_support"
 
@@ -176,8 +178,8 @@ describe Pliny::DbSupport do
     end
   end
 
-  describe 'MigrationStatusPresenter' do
-    let(:filename) { '1630551344_latest_change.rb' }
+  describe "MigrationStatusPresenter" do
+    let(:filename) { "1630551344_latest_change.rb" }
     let(:up_migration) { described_class::MigrationStatus.new(filename: "00#{filename}") }
     let(:down_migration) { described_class::MigrationStatus.new(filename: "0#{filename}") }
     let(:file_missing_migration) { described_class::MigrationStatus.new(filename: "000#{filename}") }
@@ -193,79 +195,79 @@ describe Pliny::DbSupport do
       file_missing_migration.present_on_disk = false
     end
 
-    describe '#barrier_row' do
-      it 'pads to the longest_migration name' do
-        expectation = '+--------------+--------------------------------+'
+    describe "#barrier_row" do
+      it "pads to the longest_migration name" do
+        expectation = "+--------------+--------------------------------+"
         assert_equal expectation, presenter.barrier_row
       end
     end
 
-    describe '#header_row' do
-      it 'pads to the longest migration name' do
-        expectation = '|    STATUS    |           MIGRATION            |'
+    describe "#header_row" do
+      it "pads to the longest migration name" do
+        expectation = "|    STATUS    |           MIGRATION            |"
         assert_equal expectation, presenter.header_row
       end
     end
 
-    describe '#header' do
-      let(:barrier) { '+--------------+--------------------------------+' }
-      let(:header)  { '|    STATUS    |           MIGRATION            |' }
+    describe "#header" do
+      let(:barrier) { "+--------------+--------------------------------+" }
+      let(:header) { "|    STATUS    |           MIGRATION            |" }
 
-      it 'wraps the title in barriers' do
+      it "wraps the title in barriers" do
         assert_equal [barrier, header, barrier], presenter.header
       end
     end
 
-    describe '#footer' do
-      let(:barrier) { '+--------------+--------------------------------+' }
+    describe "#footer" do
+      let(:barrier) { "+--------------+--------------------------------+" }
 
-      it 'just a barrier' do
+      it "just a barrier" do
         assert_equal [barrier], presenter.footer
       end
     end
 
-    describe '#status_row' do
-      context 'an up migration' do
-        it 'shows the correct details' do
-          expectation = '|      UP      | 001630551344_latest_change.rb  |'
+    describe "#status_row" do
+      context "an up migration" do
+        it "shows the correct details" do
+          expectation = "|      UP      | 001630551344_latest_change.rb  |"
           assert_equal expectation, presenter.status_row(up_migration)
         end
       end
 
-      context 'a down migration' do
-        it 'shows the correct details' do
-          expectation = '|     DOWN     | 01630551344_latest_change.rb   |'
+      context "a down migration" do
+        it "shows the correct details" do
+          expectation = "|     DOWN     | 01630551344_latest_change.rb   |"
           assert_equal expectation, presenter.status_row(down_migration)
         end
       end
 
-      context 'a file missing migration' do
-        it 'shows the correct details' do
-          expectation = '| FILE MISSING | 0001630551344_latest_change.rb |'
+      context "a file missing migration" do
+        it "shows the correct details" do
+          expectation = "| FILE MISSING | 0001630551344_latest_change.rb |"
           assert_equal expectation, presenter.status_row(file_missing_migration)
         end
       end
     end
 
-    describe '#statuses' do
-      let(:up_expectation)           { '|      UP      | 001630551344_latest_change.rb  |' }
-      let(:down_expectation)         { '|     DOWN     | 01630551344_latest_change.rb   |' }
-      let(:file_missing_expectation) { '| FILE MISSING | 0001630551344_latest_change.rb |' }
+    describe "#statuses" do
+      let(:up_expectation) { "|      UP      | 001630551344_latest_change.rb  |" }
+      let(:down_expectation) { "|     DOWN     | 01630551344_latest_change.rb   |" }
+      let(:file_missing_expectation) { "| FILE MISSING | 0001630551344_latest_change.rb |" }
 
-      it 'returns strings' do
+      it "returns strings" do
         assert_equal [up_expectation, down_expectation, file_missing_expectation], presenter.statuses
       end
     end
 
-    describe '#rows' do
-      let(:barrier)                  { '+--------------+--------------------------------+' }
-      let(:header)                   { '|    STATUS    |           MIGRATION            |' }
-      let(:up_expectation)           { '|      UP      | 001630551344_latest_change.rb  |' }
-      let(:down_expectation)         { '|     DOWN     | 01630551344_latest_change.rb   |' }
-      let(:file_missing_expectation) { '| FILE MISSING | 0001630551344_latest_change.rb |' }
-      let(:footer)                   { '+--------------+--------------------------------+' }
+    describe "#rows" do
+      let(:barrier) { "+--------------+--------------------------------+" }
+      let(:header) { "|    STATUS    |           MIGRATION            |" }
+      let(:up_expectation) { "|      UP      | 001630551344_latest_change.rb  |" }
+      let(:down_expectation) { "|     DOWN     | 01630551344_latest_change.rb   |" }
+      let(:file_missing_expectation) { "| FILE MISSING | 0001630551344_latest_change.rb |" }
+      let(:footer) { "+--------------+--------------------------------+" }
 
-      it 'is the table as an array' do
+      it "is the table as an array" do
         expectation = [
           barrier,
           header,
@@ -273,15 +275,15 @@ describe Pliny::DbSupport do
           up_expectation,
           down_expectation,
           file_missing_expectation,
-          footer
+          footer,
         ]
 
         assert_equal expectation, presenter.rows
       end
     end
 
-    describe '#to_s' do
-      it 'is the table as a string' do
+    describe "#to_s" do
+      it "is the table as a string" do
         expectation = <<~OUTPUT.chomp
           +--------------+--------------------------------+
           |    STATUS    |           MIGRATION            |
@@ -297,8 +299,8 @@ describe Pliny::DbSupport do
     end
   end
 
-  describe '#status' do
-    let(:filename) { '1630551344_latest_change.rb' }
+  describe "#status" do
+    let(:filename) { "1630551344_latest_change.rb" }
     let(:up_migration) { "00#{filename}" }
     let(:down_migration) { "0#{filename}" }
     let(:file_missing_migration) { "000#{filename}" }
@@ -339,7 +341,7 @@ describe Pliny::DbSupport do
       end
     end
 
-    it 'returns a table string' do
+    it "returns a table string" do
       expectation = <<~OUTPUT.chomp
         +--------------+--------------------------------+
         |    STATUS    |           MIGRATION            |

data/spec/error_reporters/rollbar_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require "rollbar"
 require "pliny/error_reporters/rollbar"
@@ -7,8 +9,8 @@ describe Pliny::ErrorReporters::Rollbar do
 
   describe "#notify" do
     let(:exception) { StandardError.new("Something went wrong") }
-    let(:context)   { { step: :foo } }
-    let(:rack_env)  { { "rack.input" => StringIO.new } }
+    let(:context) { { step: :foo } }
+    let(:rack_env) { { "rack.input" => StringIO.new } }
 
     subject(:notify) do
       reporter.notify(exception, context: context, rack_env: rack_env)
@@ -29,7 +31,7 @@ describe Pliny::ErrorReporters::Rollbar do
       notify
       expect(::Rollbar).to have_received(:scoped).once.with(hash_including(
         request: instance_of(Proc),
-        custom: { step: :foo }
+        custom: { step: :foo },
       ))
     end
 
@@ -38,8 +40,8 @@ describe Pliny::ErrorReporters::Rollbar do
         { "rollbar.person_data" => {
           id: SecureRandom.uuid,
           email: "foo@bar.com",
-          username: "foo"
-        }}
+          username: "foo",
+        } }
       end
 
       it "adds person to the rollbar notification" do
@@ -66,7 +68,7 @@ describe Pliny::ErrorReporters::Rollbar do
 
       it "reports to Rollbar without request data in the scope" do
         notify
-        expect(Rollbar).to have_received(:scoped).once.with({ custom: {step: :foo} })
+        expect(Rollbar).to have_received(:scoped).once.with({ custom: { step: :foo } })
       end
 
       it "delegates to #report_exception_to_rollbar" do

data/spec/error_reporters_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Pliny::ErrorReporters do
@@ -7,8 +9,8 @@ describe Pliny::ErrorReporters do
 
   describe ".notify" do
     let(:exception) { RuntimeError.new }
-    let(:context)   { { context: "foo" } }
-    let(:rack_env)  { { rack_env: "bar" } }
+    let(:context) { { context: "foo" } }
+    let(:rack_env) { { rack_env: "bar" } }
 
     subject(:notify_reporter) do
       reporter.notify(exception, context: context, rack_env: rack_env)

data/spec/errors_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Pliny::Errors do
@@ -9,7 +11,8 @@ describe Pliny::Errors do
 
   it "includes an HTTP error that will take generic parameters" do
     e = Pliny::Errors::HTTPStatusError.new(
-      "Custom HTTP error.", :custom_http_error, 499)
+      "Custom HTTP error.", :custom_http_error, 499,
+    )
     assert_equal "Custom HTTP error.", e.message
     assert_equal :custom_http_error, e.id
     assert_equal 499, e.status

data/spec/helpers/encode_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Pliny::Helpers::Encode do

data/spec/helpers/params_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Pliny::Helpers::Params do
@@ -11,35 +13,35 @@ describe Pliny::Helpers::Params do
   end
 
   it "loads json params" do
-    post "/", {hello: "world"}.to_json, {"CONTENT_TYPE" => "application/json"}
+    post "/", { hello: "world" }.to_json, { "CONTENT_TYPE" => "application/json" }
     assert_equal "{\"hello\":\"world\"}", last_response.body
   end
 
   it "loads json array of params" do
-    post "/", [{hello: "world"}, {goodbye: "moon"}].to_json, {"CONTENT_TYPE" => "application/json"}
+    post "/", [{ hello: "world" }, { goodbye: "moon" }].to_json, { "CONTENT_TYPE" => "application/json" }
     assert_equal "[{\"hello\":\"world\"},{\"goodbye\":\"moon\"}]", last_response.body
   end
 
   it "loads json array of arrays of params" do
-    post "/", [[{hello: "world"}], [{goodbye: "moon"}]].to_json, {"CONTENT_TYPE" => "application/json"}
+    post "/", [[{ hello: "world" }], [{ goodbye: "moon" }]].to_json, { "CONTENT_TYPE" => "application/json" }
     assert_equal "[[{\"hello\":\"world\"}],[{\"goodbye\":\"moon\"}]]", last_response.body
   end
 
   it "loads form data params" do
-    post "/", {hello: "world"}
+    post "/", { hello: "world" }
     assert_equal "{\"hello\":\"world\"}", last_response.body
   end
 
   it "loads from an unknown content type" do
-    post "/", "<hello>world</hello>", {"CONTENT_TYPE" => "application/xml"}
+    post "/", "<hello>world</hello>", { "CONTENT_TYPE" => "application/xml" }
     assert_equal "{}", last_response.body
   end
 
   it "should throw bad request when receiving invalid json via post" do
     err = assert_raises(Pliny::Errors::BadRequest) do
-      post "/", "{\"foo\"}", {"CONTENT_TYPE" => "application/json"}
+      post "/", "{\"foo\"}", { "CONTENT_TYPE" => "application/json" }
     end
 
-    assert_match /unexpected token/, err.message
+    assert_match(/expected ':' after object key at line 1 column 7/, err.message)
   end
 end