pleaserun 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9ed4accac8b94375fd217a37c253a3e2b71dc9d6
-  data.tar.gz: 1ded3b7e8379b7c58cf3c26e237122c7e6b8853e
+  metadata.gz: d316c9bf03f4fe179bbdbab74c1f1a85c55df584
+  data.tar.gz: 6cf4c7bd5e7e48c6618ddfffe576125ffd9c393c
 SHA512:
-  metadata.gz: ecab9e1a4f3b9c1822c51fb22ec65c23bd829094d92db453fb12fa9c578a96a25952a1d483a1ec101566e0d4013de7a0a9687cff521e1857750d03bafee2bc5d
-  data.tar.gz: 7937ec96541fb798bf3f887ce543df6f2d99b0f06ea395a3b84566644a668706f9ceaf70d5cd04eadc16c2d6ab7e310d083fd362435a69f77f6bb2f80044a710
+  metadata.gz: a20035fe0b854e1c87720d7392acf9c50267a29cccec027da48486f1ae549e8267bef074a27e4d2fb803b51bb7135e3ce4b44bde00c58399d8f2836a84b93d9f
+  data.tar.gz: cb819dc5499a68a6469201beb3b75a2a9f50a0f7eaa58bcb2aa3d7bbf9f29e96e3a8b6f22a1ed42c4b7f0a0cdcb738b3b6ad5f66dd9cf56c473fd979a1b5b744

data/README.md

@@ -21,9 +21,7 @@ Want more? It's easy to add things. [File an issue](issues/) and ask away!
 
 ## Installation
 
-```
-gem install pleaserun
-```
+    gem install pleaserun
 
 ## Your First Process
 
@@ -36,20 +34,16 @@ simulate the same workflow you would normally go through in production: acquire
 software, deploy it, run it. Pleaserun helps you with the 'run it' part, but
 first let's get redis and build it.
 
-```
-wget http://download.redis.io/releases/redis-2.8.6.tar.gz
-tar -zxf redis-2.8.6.tar.gz
-cd redis-2.8.6
-make -j4
-make install PREFIX=/tmp/redis
-```
+    wget http://download.redis.io/releases/redis-2.8.6.tar.gz
+    tar -zxf redis-2.8.6.tar.gz
+    cd redis-2.8.6
+    make -j4
+    make install PREFIX=/tmp/redis
 
 Assuming the above succeeds (it did for me!), we now have redis installed to `/tmp/redis`:
 
-```
-% ls /tmp/redis/bin
-redis-benchmark  redis-check-aof  redis-check-dump  redis-cli  redis-server
-```
+  % ls /tmp/redis/bin
+  redis-benchmark  redis-check-aof  redis-check-dump  redis-cli  redis-server
 
 You might be thinking - why /tmp? This is just a demo! That's why! :)
 
@@ -60,15 +54,13 @@ can never remember.
 
 Luckily, pleaserun remembers.
 
-```
-# Run as root so pleaserun has permissions to write to
-# any files required to install this as a service!
-% sudo pleaserun --install /tmp/redis/bin/redis-server
-No platform selected. Autodetecting... {:platform=>"upstart", :version=>"1.5", :level=>:warn}
-No name given, setting reasonable default {:name=>"redis-server", :level=>:warn}
-Writing file {:destination=>"/etc/init/redis-server.conf"}
-Writing file {:destination=>"/etc/init.d/redis-server"}
-```
+    # Run as root so pleaserun has permissions to write to
+    # any files required to install this as a service!
+    % sudo pleaserun --install /tmp/redis/bin/redis-server
+    No platform selected. Autodetecting... {:platform=>"upstart", :version=>"1.5", :level=>:warn}
+    No name given, setting reasonable default {:name=>"redis-server", :level=>:warn}
+    Writing file {:destination=>"/etc/init/redis-server.conf"}
+    Writing file {:destination=>"/etc/init.d/redis-server"}
 
 Note: The `--install` flag above tells pleaserun to install it on this current system. The
 default behavior without this flag is to install it in a temp directory so you can copy
@@ -77,28 +69,26 @@ it elsewhere if desired.
 Now what? You can see above it automatically detected that "Upstart 1.5" was
 the right process runner to target. Let's try using it!
 
-```
-% status redis-server
-redis-server stop/waiting
+    % status redis-server
+    redis-server stop/waiting
 
-% sudo start redis-server
-redis-server start/running, process 395
+    % sudo start redis-server
+    redis-server start/running, process 395
 
-% status redis-server
-redis-server start/running, process 395
+    % status redis-server
+    redis-server start/running, process 395
 
-% ps -fwwp 395
-UID        PID  PPID  C STIME TTY          TIME CMD
-root       395     1  0 06:27 ?        00:00:00 /tmp/redis/bin/redis-server *:6379
+    % ps -fwwp 395
+    UID        PID  PPID  C STIME TTY          TIME CMD
+    root       395     1  0 06:27 ?        00:00:00 /tmp/redis/bin/redis-server *:6379
 
-# Is it running? Let's check with redis-cli
-% redis-cli
-127.0.0.1:6379> ping
-PONG
+    # Is it running? Let's check with redis-cli
+    % redis-cli
+    127.0.0.1:6379> ping
+    PONG
 
-% sudo stop redis-server
-redis-server stop/waiting
-```
+    % sudo stop redis-server
+    redis-server stop/waiting
 
 Bam. Pretty easy, right? Let's recap!
 
@@ -108,3 +98,45 @@ Bam. Pretty easy, right? Let's recap!
 * Pleaserun detected the platform as Upstart 1.5
 * You didn't have to write an init script.
 * You didn't have to know how to write an Upstart config.
+
+### Overview
+
+See `pleaserun --help` for a list of flags. Basics:
+
+* `-p` lets you set the platform to target. If not specified, this is
+  automatically detected based on your current system/environment.
+* `-v` lets you set the version of the platform to target. Useful in cases
+  where things like Upstart 0.6.5 differ wildly in configuration from Upstart
+  1.5
+* `--name` the name of the process. This shows up as
+  /etc/init.d/the-name-you-give for sysv, or the name you use to reference the
+  service with upstart, systemd, or launchd, etc!
+* `--prestart` lets you run a command *before* starting the main program. This
+  can be used to do config or validation checks before you start a program. If
+  the prestart exits nonzero, the start of the process will be aborted.
+
+A silly example:
+
+    # Generate a LSB 3.1-compliant SYSV-style init script
+    % pleaserun --install -p sysv -v lsb-3.1 --name sleeper /bin/sleep 60
+    Writing file {:destination=>"/etc/init.d/sleeper"}
+    Writing file {:destination=>"/etc/default/sleeper"}
+
+    # Try it!
+    % /etc/init.d/sleeper status          
+    sleeper is not running
+
+    % sudo /etc/init.d/sleeper start
+    sleeper started.
+
+    % ps -fwp $(cat /var/run/sleeper.pid)
+    UID        PID  PPID  C STIME TTY          TIME CMD
+    root     50473     1  0 22:36 pts/7    00:00:00 /bin/sleep 60
+
+# One last thing!
+
+Please enjoy running things! If you are not enjoying this program, then something is wrong, and we can fix it together :)
+
+If you are having a bad time, it is a bug!
+
+All contributions welcome (bug reports, feature requests, bug fixes, new features, etc!)

data/lib/pleaserun/cli.rb

@@ -5,20 +5,19 @@ require "cabin"
 require "stud/temporary"
 
 require "pleaserun/platform/base"
+require "pleaserun/installer"
+require "pleaserun/errors"
 
 # The CLI interface to pleaserun.
 #
 # This is invoked by `bin/pleaserun`.
 class PleaseRun::CLI < Clamp::Command # rubocop:disable ClassLength
-  class Error < StandardError; end
-  class ConfigurationError < Error; end
-  class PlatformLoadError < Error; end
-  class FileWritingFailure < Error; end
 
   option ["-p", "--platform"], "PLATFORM", "The name of the platform to target, such as sysv, upstart, etc"
   option ["-v", "--version"], "VERSION", "The version of the platform to target, such as 'lsb-3.1' for sysv or '1.5' for upstart",
          :default => "default", :attribute_name => :target_version
 
+  option "--overwrite", :flag, "Overwrite any files that already exist when installing."
   option "--log", "LOGFILE", "The path to use for writing pleaserun logs."
   option "--json", :flag, "Output a result in JSON. Intended to be consumed by other programs. This will emit the file contents and install actions as a JSON object."
 
@@ -104,18 +103,7 @@ are made. If it fails, nagios will not start. Yay!
 
   def execute
     setup_logger
-
-    # Provide any dynamic defaults if necessary
-    if platform.nil?
-      require "pleaserun/detector"
-      self.platform, self.target_version = PleaseRun::Detector.detect
-      @logger.warn("No platform selected. Autodetecting...", :platform => platform, :version => target_version)
-    end
-
-    if name.nil?
-      self.name = File.basename(program)
-      @logger.warn("No name given, setting reasonable default", :name => name)
-    end
+    setup_defaults
 
     # Load the platform implementation
     platform_klass = load_platform(platform)
@@ -139,11 +127,25 @@ are made. If it fails, nagios will not start. Yay!
       return run_human(runner)
     end
     return 0
-  rescue Error => e
+  rescue PleaseRun::Error => e
     @logger.error("An error occurred: #{e}")
     return 1
   end # def execute
 
+  def setup_defaults
+    # Provide any dynamic defaults if necessary
+    if platform.nil?
+      require "pleaserun/detector"
+      self.platform, self.target_version = PleaseRun::Detector.detect
+      @logger.warn("No platform selected. Autodetecting...", :platform => platform, :version => target_version)
+    end
+
+    if name.nil?
+      self.name = File.basename(program)
+      @logger.warn("No name given, setting reasonable default based on the executable", :name => name)
+    end
+  end # def setup_defaults
+
   def run_json(runner)
     require "json"
 
@@ -164,54 +166,20 @@ are made. If it fails, nagios will not start. Yay!
   end # def run_json
 
   def run_human(runner)
-    tmp = Stud::Temporary.directory
-    errors = []
-
-    runner.files.each do |path, content, perms|
-      # TODO(sissel): Force-set default file permissions if not provided?
-      # perms ||= (0666 ^ File.umask)
-      fullpath = install? ? path : File.join(tmp, path)
-      success = write(fullpath, content, perms)
-      errors << fullpath unless success
+    if install?
+      PleaseRun::Installer.install_files(runner, "/", overwrite?)
+      PleaseRun::Installer.install_actions(runner)
+    else
+      tmp = Stud::Temporary.directory
+      actions_script = File.join(tmp, "install_actions.sh")
+      PleaseRun::Installer.install_files(runner, tmp)
+      PleaseRun::Installer.write_actions(runner, actions_script)
     end
-
-    raise FileWritingFailure, "Errors occurred while writing files" if errors.any?
-
-    # TODO(sissel): Refactor this to be less lines of code or put into methods.
-    if runner.install_actions.any?
-      if install?
-        runner.install_actions.each do |action|
-          @logger.info("Running install action", :action => action)
-          system(action)
-          @logger.warn("Install action failed", :action => action, :code => $CHILD_STATUS.exitstatus) unless $CHILD_STATUS.success?
-        end # each install action
-      else
-        path = File.join(tmp, "install_actions.sh")
-        @logger.log("Writing install actions. You will want to run this script to properly activate your service on the target host", :path => path)
-        File.open(path, "w") do |fd|
-          runner.install_actions.each do |action|
-            fd.puts(action)
-          end
-        end
-      end
-    end # if runner.install_actions.any?
     return 0
   end # def run_human
 
-  def write(fullpath, content, perms)
-    @logger.log("Writing file", :destination => fullpath)
-    FileUtils.mkdir_p(File.dirname(fullpath))
-    File.write(fullpath, content)
-    @logger.debug("Setting permissions", :destination => fullpath, :perms => perms)
-    File.chmod(perms, fullpath) if perms
-    return true
-  rescue Errno::EACCES
-    @logger.error("Access denied in writing a file. Maybe we need to be root?", :path => fullpath)
-    return false
-  end
-
   def setup_logger
-    @logger = Cabin::Channel.new
+    @logger = Cabin::Channel.get
     if quiet?
       @logger.level = :error
     elsif verbose?
@@ -223,7 +191,7 @@ are made. If it fails, nagios will not start. Yay!
     end
 
     if log
-      logfile = File.new(logfile, "a")
+      logfile = File.new(log, "a")
       @logger.subscribe(logfile)
       STDERR.puts "Sending all logs to #{log}" if STDERR.tty?
     else

data/lib/pleaserun/detector.rb

@@ -8,19 +8,26 @@ class PleaseRun::Detector
 
   # A mapping of of [os, version] => [runner, version]
   MAPPING = {
-    ["ubuntu", "12.04"] => ["upstart", "1.5"],
-    ["ubuntu", "12.10"] => ["upstart", "1.5"],
-    ["ubuntu", "13.04"] => ["upstart", "1.5"],
-    ["ubuntu", "13.10"] => ["upstart", "1.5"],
-    ["debian", "7"] => ["sysv", "lsb-3.1"],
+    ["arch", "rolling"] => ["systemd", "default"],
+    ["centos", "5"] => ["sysv", "lsb-3.1"],
+    ["centos", "6"] => ["upstart", "0.6.5"],
+    ["centos", "7"] => ["systemd", "default"],
     ["debian", "6"] => ["sysv", "lsb-3.1"],
+    ["debian", "7"] => ["sysv", "lsb-3.1"],
     ["fedora", "18"] => ["systemd", "default"],
     ["fedora", "19"] => ["systemd", "default"],
     ["fedora", "20"] => ["systemd", "default"],
-    ["mac_os_x", "10.9"] => [ "launchd", "10.9"]
+    ["mac_os_x", "10.9"] => ["launchd", "10.9"],
+    ["mac_os_x", "10.9"] => ["launchd", "10.9"],
+    ["ubuntu", "12.04"] => ["upstart", "1.5"],
+    ["ubuntu", "12.10"] => ["upstart", "1.5"],
+    ["ubuntu", "13.04"] => ["upstart", "1.5"],
+    ["ubuntu", "13.10"] => ["upstart", "1.5"]
   }
 
   def self.detect
+    return @system unless @system.nil?
+
     @logger ||= Cabin::Channel.get
     begin
       platform, version = detect_ohai
@@ -33,9 +40,9 @@ class PleaseRun::Detector
       end
     end
 
-    system = lookup([platform, version])
-    raise UnknownSystem if system.nil?
-    return system
+    @system = lookup([platform, version])
+    raise UnknownSystem if @system.nil?
+    return @system
   end # def self.detect
 
   def self.lookup(platform_and_version)
@@ -55,14 +62,24 @@ class PleaseRun::Detector
     return platform, normalize_version(platform, version)
   end # def detect_ohai
 
+  def self.detect_facter
+    require "facter"
+
+    platform = Facter.fact["operatingsystem"]
+    version = Facter.fact["operatingsystemrelease"]
+    return platform, normalize_version(platform, version)
+  end # def detect_facter
+
   def self.normalize_version(platform, version)
     case platform
       # Take '6.0.8' and make it just '6' since debian never makes major
       # changes in a minor release
-      when "debian" 
-        return version[/^[0-9]+/]
+      when "debian", "centos"
+        return version[/^[0-9]+/] # First digit is the 'major' version
       when "mac_os_x"
-        return version[/^[0-9]+\.[0-9]+/]
+        return version[/^[0-9]+\.[0-9]+/] # 10.x
+      when "arch"
+        return "rolling"
       # TODO(sissel): Any other edge cases?
     end
     return version

data/lib/pleaserun/errors.rb

@@ -0,0 +1,7 @@
+
+module PleaseRun
+  class Error < StandardError; end
+  class ConfigurationError < Error; end
+  class PlatformLoadError < Error; end
+  class FileWritingFailure < Error; end
+end

data/lib/pleaserun/installer.rb

@@ -0,0 +1,64 @@
+require "pleaserun/namespace"
+require "pleaserun/errors"
+
+# Some helpful methods for installing a runner.
+module PleaseRun::Installer
+  module_function
+
+  def install(runner)
+    install_files(runner)
+    install_actions(runner)
+  end
+
+  # Install files provided by a runner.
+  #
+  # If overwrite is false and any file already exists, then this method will fail.
+  def install_files(runner, root = "/", overwrite = false)
+    errors = 0
+    runner.files.each do |path, content, perms|
+      # TODO(sissel): Force-set default file permissions if not provided?
+      # perms ||= (0666 ^ File.umask)
+      fullpath = File.join(root, path)
+      raise PleaseRun::FileWritingFailure, "File already exists: #{fullpath}" if !overwrite && File.file?(fullpath)
+      success = write(fullpath, content, perms)
+      errors += 1 unless success
+    end
+    raise PleaseRun::FileWritingFailure, "Errors occurred while writing files" if errors > 0
+  end
+
+  def write(fullpath, content, perms)
+    logger.log("Writing file", :destination => fullpath)
+    FileUtils.mkdir_p(File.dirname(fullpath))
+    File.write(fullpath, content)
+    logger.debug("Setting permissions", :destination => fullpath, :perms => perms)
+    File.chmod(perms, fullpath) if perms
+    return true
+  rescue Errno::EACCES
+    logger.error("Access denied in writing a file. Maybe we need to be root?", :path => fullpath)
+    return false
+  end
+
+  def install_actions(runner)
+    return if runner.install_actions.empty?
+    # TODO(sissel): Refactor this to be less lines of code or put into methods.
+    runner.install_actions.each do |action|
+      logger.info("Running install action", :action => action)
+      system(action)
+      logger.warn("Install action failed", :action => action, :code => $CHILD_STATUS.exitstatus) unless $CHILD_STATUS.success?
+    end # each install action
+  end
+
+  def write_actions(runner, path)
+    return if runner.install_actions.empty?
+    logger.log("Writing install actions. You will want to run this script to properly activate your service on the target host", :path => path)
+    File.open(path, "w") do |fd|
+      runner.install_actions.each do |action|
+        fd.puts(action)
+      end
+    end
+  end
+
+  def logger
+    return @logger ||= Cabin::Channel.get
+  end
+end # module PleaseRun::Installer

data/lib/pleaserun/platform/base.rb

@@ -79,7 +79,7 @@ class PleaseRun::Platform::Base
     end
   end
 
-  attribute :chdir, "The directory to chdir to before running" do
+  attribute :chdir, "The directory to chdir to before running", :default => "/" do
     validate do |chdir|
       insist { chdir }.is_a?(String)
     end

data/lib/pleaserun/platform/sysv.rb

@@ -7,7 +7,7 @@ require "pleaserun/namespace"
 class PleaseRun::Platform::SYSV < PleaseRun::Platform::Base
   def files
     return Enumerator::Generator.new do |out|
-      out.yield(safe_filename("/etc/init.d/{{ name }}"), render_template("init.d"), 0755)
+      out.yield(safe_filename("/etc/init.d/{{ name }}"), render_template("init.sh"), 0755)
       out.yield(safe_filename("/etc/default/{{ name }}"), render_template("default"))
     end
   end

data/pleaserun.gemspec

@@ -2,7 +2,7 @@ Gem::Specification.new do |spec|
   files = %x{git ls-files}.split("\n")
 
   spec.name = "pleaserun"
-  spec.version = "0.0.4"
+  spec.version = "0.0.5"
   spec.summary = "pleaserun"
   spec.description = "pleaserun"
   spec.license = "Apache 2.0"

data/spec/pleaserun/platform/base_spec.rb

@@ -4,6 +4,7 @@ require "pleaserun/platform/base"
 describe PleaseRun::Platform::Base do
   context "default" do
     subject { PleaseRun::Platform::Base.new("example") }
+
     it "#name should be nil" do
       insist { subject.name }.nil?
     end
@@ -25,3 +26,4 @@ describe PleaseRun::Platform::Base do
     end
   end
 end
+

data/spec/pleaserun/platform/launchd_spec.rb

@@ -1,10 +1,20 @@
 require "English" # for $CHILD_STATUS
 require "testenv"
 require "pleaserun/platform/launchd"
+require "pleaserun/detector"
 
 describe PleaseRun::Platform::Launchd do
-  it "inherits correctly" do
-    insist { PleaseRun::Platform::Launchd.ancestors }.include?(PleaseRun::Platform::Base)
+  let(:platform) { PleaseRun::Detector.detect[0] }
+  let(:version) { PleaseRun::Detector.detect[1] }
+
+  context "deployment", :launchd => true do
+    it_behaves_like PleaseRun::Platform do
+      let(:start) { "launchctl start #{subject.name}" }
+      let(:stop) { "launchctl stop #{subject.name}" }
+      let(:status) { "launchctl list | awk '$3 == \"#{subject.name}\" { exit($1 == \"-\") }'" }
+      let(:restart) { "launchctl restart #{subject.name}" }
+    end
+
   end
 
   context "#files" do
@@ -32,63 +42,4 @@ describe PleaseRun::Platform::Launchd do
       insist { subject.install_actions }.include?("launchctl load /Library/LaunchDaemons/fancypants.plist")
     end
   end
-
-  context "deployment" do
-    partytime = (superuser? && platform?("darwin"))
-    it "cannot be attempted", :if => !partytime do
-      pending("we are not the superuser") unless superuser?
-      pending("platform is not darwin") unless platform?("darwin")
-    end
-
-    context "as the super user", :if => partytime do
-      subject { PleaseRun::Platform::Launchd.new("10.9") }
-
-      before do
-        subject.name = "example"
-        subject.user = "root"
-        subject.program = "/bin/sh"
-        subject.args = ["-c", "echo hello world; sleep 5"]
-
-        subject.files.each do |path, content|
-          File.write(path, content)
-        end
-        subject.install_actions.each do |command|
-          system(command)
-          raise "Command failed: #{command}" unless $CHILD_STATUS.success?
-        end
-      end
-
-      after do
-        system_quiet("launchctl stop #{subject.name}")
-        system_quiet("launchctl unload /Library/LaunchDaemons/#{subject.name}.plist")
-        subject.files.each do |path, content|
-          File.unlink(path) if File.exist?(path)
-        end
-
-        # Remove the logs, too.
-        ["/var/log/#{subject.name}.out", "/var/log/#{subject.name}.err"].each do |log|
-          File.unlink(log) if File.exist?(log)
-        end
-      end
-
-      it "should install" do
-        system_quiet("launchctl list #{subject.name}")
-        insist { $CHILD_STATUS }.success?
-      end
-
-      it "should start" do
-        system_quiet("launchctl start #{subject.name}")
-        insist { $CHILD_STATUS }.success?
-        system_quiet("launchctl list #{subject.name}")
-        insist { $CHILD_STATUS }.success?
-      end
-
-      it "should stop" do
-        system_quiet("launchctl start #{subject.name}")
-        insist { $CHILD_STATUS }.success?
-        system_quiet("launchctl stop #{subject.name}")
-        insist { $CHILD_STATUS }.success?
-      end
-    end
-  end # real tests
 end

data/spec/pleaserun/platform/systemd_spec.rb

@@ -2,18 +2,21 @@ require "testenv"
 require "pleaserun/platform/systemd"
 
 describe PleaseRun::Platform::Systemd do
-  let(:start) { "systemctl start #{subject.name}.service" }
-  let(:stop) { "systemctl stop #{subject.name}.service" }
-  let(:status) { "systemctl show #{subject.name} | grep -q SubState=running" }
-  let(:restart) { "systemctl restart #{subject.name}.service" }
-
-  it "inherits correctly" do
-    insist { PleaseRun::Platform::Systemd.ancestors }.include?(PleaseRun::Platform::Base)
+  let(:platform) { PleaseRun::Detector.detect[0] }
+  let(:version) { PleaseRun::Detector.detect[1] }
+
+  context "deployment", :systemd => true do
+    it_behaves_like PleaseRun::Platform do
+      let(:start) { "systemctl start #{subject.name}.service" }
+      let(:stop) { "systemctl stop #{subject.name}.service" }
+      let(:status) { "systemctl show #{subject.name} | grep -q SubState=running" }
+      let(:restart) { "systemctl restart #{subject.name}.service" }
+    end
   end
 
   context "#files" do
     subject do
-      runner = PleaseRun::Platform::Systemd.new("default")
+      runner = described_class.new(version)
       runner.name = "fancypants"
       runner.program = "/bin/true"
       next runner
@@ -28,7 +31,7 @@ describe PleaseRun::Platform::Systemd do
 
   context "#install_actions" do
     subject do
-      runner = PleaseRun::Platform::Systemd.new("default")
+      runner = described_class.new(version)
       runner.name = "fancypants"
       next runner
     end
@@ -37,78 +40,4 @@ describe PleaseRun::Platform::Systemd do
       insist { subject.install_actions }.include?("systemctl --system daemon-reload")
     end
   end
-
-  context "deployment" do
-    partytime = (superuser? && platform?("linux") && program?("systemctl") && File.directory?("/lib/systemd"))
-    it "cannot be attempted", :if => !partytime do
-      pending("we are not the superuser") unless superuser?
-      pending("platform is not linux") unless platform?("linux")
-      pending("no 'systemctl' program found") unless program?("systemctl")
-      pending("missing /lib/systemd directory") unless File.directory?("/lib/systemd")
-    end
-
-    context "as the super user", :if => partytime do
-      subject { PleaseRun::Platform::Systemd.new("default") }
-
-      before do
-        subject.name = "hurray"
-        subject.user = "root"
-        subject.program = "/bin/sh"
-        subject.args = ["-c", "echo hello world; sleep 5"]
-        activate(subject)
-        
-        # monkeypatch StartLimitInterval=0 into the .service file to avoid
-        # being throttled by systemd during these tests.
-        # Fixes https://github.com/jordansissel/pleaserun/issues/11
-        path = "/lib/systemd/system/#{subject.name}.service"
-        File.write(path, File.read(path).sub(/^\[Service\]$/, "[Service]\nStartLimitInterval=0"))
-      end
-
-      after do
-        system_quiet("systemctl stop #{subject.name}")
-        subject.files.each do |path, content|
-          File.unlink(path) if File.exist?(path)
-        end
-      end
-
-      it "should start" do
-        starts
-        status_running
-      end
-
-      it "should stop" do
-        starts
-        stops
-      end
-
-      it "should start and stop" do
-        5.times do
-          starts
-          stops
-        end
-      end
-
-      context "with failing prestart" do
-        before do
-          subject.prestart = "#!/bin/sh\nfalse\n"
-          activate(subject)
-        end
-
-        it "should fail to start" do
-          insist { starts }.fails
-        end
-      end
-
-      context "with successful prestart" do
-        before do
-          subject.prestart = "true"
-          activate(subject)
-        end
-
-        it "should start" do
-          starts
-        end
-      end
-    end # as the super user
-  end # real tests
 end

data/spec/pleaserun/platform/sysv_spec.rb

@@ -1,14 +1,18 @@
 require "testenv"
 require "pleaserun/platform/sysv"
+require "pleaserun/detector"
 
 describe PleaseRun::Platform::SYSV do
-  let(:start) { "/etc/init.d/#{subject.name} start" }
-  let(:stop) { "/etc/init.d/#{subject.name} stop" }
-  let(:status) { "/etc/init.d/#{subject.name} status" }
-  let(:restart) { "/etc/init.d/#{subject.name} restart" }
-
-  it "inherits correctly" do
-    insist { PleaseRun::Platform::SYSV.ancestors }.include?(PleaseRun::Platform::Base)
+  let(:platform) { PleaseRun::Detector.detect[0] }
+  let(:version) { PleaseRun::Detector.detect[1] }
+
+  context "deployment", :sysv => true do
+    it_behaves_like PleaseRun::Platform do
+      let(:start) { "/etc/init.d/#{subject.name} start" }
+      let(:stop) { "/etc/init.d/#{subject.name} stop" }
+      let(:status) { "/etc/init.d/#{subject.name} status" }
+      let(:restart) { "/etc/init.d/#{subject.name} restart" }
+    end
   end
 
   context "#files" do
@@ -27,105 +31,4 @@ describe PleaseRun::Platform::SYSV do
       insist { files }.include?("/etc/default/fancypants")
     end
   end
-
-  context "deployment" do
-    partytime = superuser? && File.directory?("/etc/init.d")
-    it "cannot be attempted", :if => !partytime do
-      pending("we are not the superuser") unless superuser?
-      pending("no /etc/init.d/ directory found") unless File.directory?("/etc/init.d")
-    end
-
-    context "as the super user", :if => partytime do
-      subject { PleaseRun::Platform::SYSV.new("ubuntu-12.04") }
-
-      before do
-        subject.name = "example"
-        subject.user = "root"
-        subject.program = "/bin/ping"
-        subject.args = ["127.0.0.1"]
-
-        activate(subject)
-      end
-
-      after do
-        system_quiet("/etc/init.d/#{subject.name} stop")
-        subject.files.each do |path, content|
-          File.unlink(path) if File.exist?(path)
-        end
-
-        # TODO(sissel): Remove the logs, too.
-      end
-
-      it "should install" do
-        insist { File }.exist?("/etc/init.d/#{subject.name}")
-      end
-
-      it "should start" do
-        # Status should fail before starting
-        status_stopped
-        starts
-      end
-
-      it "should stop" do
-        status_stopped
-        starts
-        stops
-      end
-
-      context "with failing prestart" do
-        before do
-          subject.prestart = "false"
-          activate(subject)
-        end
-
-        it "should fail to start" do
-          insist { starts }.fails
-        end
-
-        context "with PRESTART=no" do
-          before { ENV["PRESTART"] = "no" }
-          after { ENV["PRESTART"] = nil }
-          it "should start" do
-            starts
-          end
-        end
-
-        it "should stop" do
-          # Force a start
-          ENV["PRESTART"] = "no"
-          starts
-          ENV["PRESTART"] = nil
-          stops
-        end
-
-        it "should fail to restart" do
-          ENV["PRESTART"] = "no"
-          starts
-          ENV["PRESTART"] = nil
-          insist { restarts }.fails
-        end
-      end
-
-      context "with a successful prestart" do
-        before do
-          subject.prestart = "echo hello world"
-          activate(subject)
-        end
-
-        it "should start" do
-          starts
-        end
-
-        it "should restart" do
-          # Force start
-          ENV["PRESTART"] = "no"
-          starts
-          ENV["PRESTART"] = nil
-
-          # Restart should succeed
-          restarts
-        end
-      end
-    end # as the super user
-  end # real tests
 end

data/spec/pleaserun/platform/upstart_spec.rb

@@ -1,19 +1,23 @@
 require "testenv"
 require "pleaserun/platform/upstart"
+require "pleaserun/detector"
 
 describe PleaseRun::Platform::Upstart do
-  let(:start) { "initctl start #{subject.name}" }
-  let(:stop) { "initctl stop #{subject.name}" }
-  let(:status) { "initctl status #{subject.name} | egrep -v '#{subject.name} stop/'" }
-  let(:restart) { "initctl restart #{subject.name}" }
-
-  it "inherits correctly" do
-    insist { PleaseRun::Platform::Upstart.ancestors }.include?(PleaseRun::Platform::Base)
+  let(:platform) { PleaseRun::Detector.detect[0] }
+  let(:version) { PleaseRun::Detector.detect[1] }
+
+  context "deployment", :upstart=> true do
+    it_behaves_like PleaseRun::Platform do
+      let(:start) { "initctl start #{subject.name}" }
+      let(:stop) { "initctl stop #{subject.name}" }
+      let(:status) { "initctl status #{subject.name} | egrep -v '#{subject.name} stop/'" }
+      let(:restart) { "initctl restart #{subject.name}" }
+    end
   end
 
   context "#files" do
     subject do
-      runner = PleaseRun::Platform::Upstart.new("1.10")
+      runner = PleaseRun::Platform::Upstart.new(version)
       runner.name = "fancypants"
       next runner
     end
@@ -31,7 +35,7 @@ describe PleaseRun::Platform::Upstart do
 
   context "#install_actions" do
     subject do
-      runner = PleaseRun::Platform::Upstart.new("1.10")
+      runner = PleaseRun::Platform::Upstart.new(version)
       runner.name = "fancypants"
       next runner
     end
@@ -40,73 +44,4 @@ describe PleaseRun::Platform::Upstart do
       insist { subject.install_actions }.empty?
     end
   end
-
-  context "deployment" do
-    partytime = (superuser? && platform?("linux") && program?("initctl") && File.directory?("/etc/init"))
-    it "cannot be attempted", :if => !partytime do
-      pending("we are not the superuser") unless superuser?
-      pending("platform is not linux") unless platform?("linux")
-      pending("no 'initctl' program found") unless program?("initctl")
-      pending("missing /etc/init/ directory") unless File.directory?("/etc/init")
-    end
-
-    context "as the super user", :if => partytime do
-      subject { PleaseRun::Platform::Upstart.new("1.10") }
-
-      before do
-        subject.name = "example"
-        subject.user = "root"
-        subject.program = "/bin/sh"
-        subject.args = ["-c", "echo hello world; sleep 5"]
-        activate(subject)
-      end
-
-      after do
-        system_quiet("initctl stop #{subject.name}")
-        subject.files.each do |path, content|
-          File.unlink(path) if File.exist?(path)
-        end
-
-        # Remove the logs, too.
-        log = "/var/log/upstart/example.log"
-        File.unlink(log) if File.exist?(log)
-      end
-
-      it "should start" do
-        starts
-
-        # Starting an already-started job will fail
-        insist { starts }.fails
-
-        status_running
-      end
-
-      it "should stop" do
-        starts
-        stops
-      end
-
-      context "with failing prestart" do
-        before do
-          subject.prestart = "false"
-          activate(subject)
-        end
-
-        it "should fail to start" do
-          insist { starts }.fails
-        end
-      end
-
-      context "with successful prestart" do
-        before do
-          subject.prestart = "true"
-          activate(subject)
-        end
-
-        it "should start" do
-          starts
-        end
-      end
-    end # as the super user
-  end # real tests
 end

data/spec/shared_examples.rb

@@ -0,0 +1,87 @@
+require "pleaserun/platform/base"
+require "insist"
+
+shared_examples_for PleaseRun::Platform do
+  it "inherits correctly" do
+    insist { described_class.ancestors }.include?(PleaseRun::Platform::Base)
+  end
+
+  context "activation" do
+    subject { described_class.new(version) }
+
+    before do
+      subject.name = "hurray-#{rand(1000)}"
+      subject.user = "root"
+      subject.program = "/bin/sh"
+      subject.args = ["-c", "echo hello world; sleep 5"]
+      activate(subject)
+      
+      # Hack...
+      case described_class.name
+        when "PleaseRun::Platform::Systemd"
+          # monkeypatch StartLimitInterval=0 into the .service file to avoid
+          # being throttled by systemd during these tests.
+          # Fixes https://github.com/jordansissel/pleaserun/issues/11
+          path = "/lib/systemd/system/#{subject.name}.service"
+          File.write(path, File.read(path).sub(/^\[Service\]$/, "[Service]\nStartLimitInterval=0"))
+        when "PleaseRun::Platform::Launchd"
+          # Avoid being throttled during our tests.
+          path = subject.daemons_path
+          File.write(path, File.read(path).sub(/^<plist>$/, "<plist><key>ThrottleInterval</key><integer>0</integer>"))
+      end
+    end
+
+    after do
+      system_quiet(stop)
+      case described_class.name
+        when "PleaseRun::Platform::Launchd"
+          system_quiet("launchctl unload #{subject.daemons_path}")
+          system_quiet("launchctl remove #{subject.name}")
+      end
+      subject.files.each do |path, content|
+        File.unlink(path) if File.exist?(path)
+      end
+    end
+
+    it "should start" do
+      starts
+      status_running
+    end
+
+    it "should stop" do
+      starts
+      stops
+    end
+
+    it "should start and stop", :flapper => true do
+      5.times do
+        starts
+        stops
+      end
+    end
+
+    context "with prestart", :prestart => true do
+      context "that is failing" do
+        before do
+          subject.prestart = "#!/bin/sh\nfalse\n"
+          activate(subject)
+        end
+
+        it "should fail to start" do
+          insist { starts }.fails
+        end
+      end
+
+      context "that succeeds" do
+        before do
+          subject.prestart = "true"
+          activate(subject)
+        end
+
+        it "should start" do
+          starts
+        end
+      end
+    end
+  end # as the super user
+end

data/spec/testenv.rb

@@ -1,6 +1,7 @@
 require "English" # for $CHILD_STATUS
 require "pleaserun/namespace"
 require "insist"
+require "shared_examples"
 
 def superuser?
   return Process::UID.eid == 0
@@ -70,6 +71,20 @@ module Helpers
   end
 end
 
-RSpec.configure do |c|
-  c.include Helpers
+RSpec.configure do |config|
+  config.include Helpers
+
+  config.filter_run_excluding(
+    :systemd => !(superuser? && platform?("linux") && program?("systemctl") && File.directory?("/lib/systemd")),
+    :upstart => !(superuser? && platform?("linux") && program?("initctl") && File.directory?("/etc/init")),
+    :launchd => !(superuser? && platform?("darwin"))
+  )
+
+  if !config.exclusion_filter[:launchd]
+    # Skip prestart tests because launchd doesn't have such a feature.
+    config.filter_run_excluding(:prestart => true)
+    # Skip flapper tests because launchd's minimum restart-throttle is 5 seconds.
+    # I'm not waiting for that crap.
+    config.filter_run_excluding(:flapper => true)
+  end
 end

data/templates/upstart/0.6.5/init.conf

@@ -0,0 +1,39 @@
+description     "{{{ description }}}"
+start on filesystem or runlevel [2345]
+stop on runlevel [!2345]
+
+respawn
+umask {{{umask}}}
+#nice {{{nice}}}
+#chroot {{{chroot}}}
+#chdir {{{chdir}}}
+#limit core <softlimit> <hardlimit>
+#limit cpu <softlimit> <hardlimit>
+#limit data <softlimit> <hardlimit>
+#limit fsize <softlimit> <hardlimit>
+#limit memlock <softlimit> <hardlimit>
+#limit msgqueue <softlimit> <hardlimit>
+#limit nice <softlimit> <hardlimit>
+#limit nofile <softlimit> <hardlimit>
+#limit nproc <softlimit> <hardlimit>
+#limit rss <softlimit> <hardlimit>
+#limit rtprio <softlimit> <hardlimit>
+#limit sigpending <softlimit> <hardlimit>
+#limit stack <softlimit> <hardlimit>
+
+{{#prestart}}
+pre-start script
+  {{{ prestart }}}
+
+  status=$?
+  if [ "$status" -gt 0 ] ; then
+    echo "Prestart command failed with code $status."
+
+    # Per init(5) docs, simply calling 'stop' will abort this start.
+    stop
+  fi
+end script
+{{/prestart}}
+
+{{! TODO(sissel): Support logging }}
+exec chroot --userspec {{{user}}}:{{{group}}} {{{chroot}}} {{{program}}} {{{shell_args}}}

data/templates/upstart/1.5/init.conf

@@ -6,7 +6,7 @@ respawn
 umask {{{umask}}}
 #nice {{{nice}}}
 #chroot {{{chroot}}}
-#chdir {{{chdir}}}
+chdir {{{chdir}}}
 #limit core <softlimit> <hardlimit>
 #limit cpu <softlimit> <hardlimit>
 #limit data <softlimit> <hardlimit>

data/test/helpers.rb

@@ -9,7 +9,11 @@ def test_in_container(tag, commands, outfile, errfile)
   insist { $? }.success?
 
   commands.each do |command|
-    IO.popen("cd #{chdir}; vagrant ssh #{tag} -- sudo bash -l >> #{outfile} 2>> #{errfile}", "w") do |io|
+    cmd = "cd #{chdir}; vagrant ssh #{tag} -- bash -l >> #{outfile} 2>> #{errfile}"
+    IO.popen(cmd, "w") do |io|
+      io.puts(". /etc/profile")
+      io.puts(". ./.bashrc")
+      io.puts(". ./.bash_profile")
       io.puts(command)
       io.puts("exit $?")
       io.close_write

data/test/test.rb

@@ -22,8 +22,12 @@ ARGV.each do |tag|
     err = Stud::Temporary.pathname
     begin
       status = test_in_container(tag, [
-        ". /etc/profile; cd /pleaserun; rvm use 1.9.3; bundle install --quiet",
-        ". /etc/profile; cd /pleaserun; rvm use 1.9.3; rspec --format json"
+        # TODO(sissel): Test other ruby versions
+        "cd /pleaserun; rvm use 1.9.3; bundle install",
+
+        # Run rspec as root to make pleaserun's real deployment tests run.
+        "cd /pleaserun; rvm use 1.9.3; sudo -E `which ruby` `which rspec` --format json",
+        #"cd /pleaserun; rvm use 1.9.3; rspec --format json",
       ], out, err)
     rescue Insist::Failure
       status = false
@@ -36,11 +40,9 @@ results = ARGV.collect { tag, success, out, err = queue.pop }
 successes = results.count { |tag, success, out, err| success }
 failures = results.count { |tag, success, out, err| !success }
 tests = results.collect { |tag, success, out, err| 
-  #require "pry"
-  #binding.pry
   begin
     JSON.parse(File.read(out).split("\n").last[/{.*$/])["examples"].each { |r| r["tag"] = tag }
-  rescue TypeError
+  rescue TypeError, NoMethodError
     puts "Failed to parse json"
     puts :out => File.read(out)
     puts :err => File.read(err)

data/test/vagrant/Vagrantfile

@@ -36,5 +36,26 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
     c.vm.box_url = "http://puppet-vagrant-boxes.puppetlabs.com/fedora-18-x64-vbox4210-nocm.box"
     c.vm.provider "virtualbox"
     c.vm.provision "shell", :path => "fedora-18/provision.sh"
+    c.vm.network :forwarded_port, guest: 22, host: 2223
+    c.vm.provider :virtualbox do |vb|
+      vb.customize ["modifyvm", :id, "--cpus", "4"]
+    end
+  end
+
+  # Centos
+  # I would use docker, but I can't figure out how to get centos 6 w/ upstart working and there
+  # are plenty of quality CentOS vagrant boxes around :)
+  config.vm.define "centos-6.5" do |c|
+    c.vm.box = "centos-6.5"
+    c.vm.box_url = "http://puppet-vagrant-boxes.puppetlabs.com/centos-65-x64-virtualbox-puppet.box"
+    c.vm.provider "virtualbox"
+    c.vm.provision "shell", :path => "fedora-18/provision.sh"
+  end
+
+  # Solaris/Illumos/OmniOS
+  config.vm.define "omnios" do |c|
+    c.vm.box = "omnios"
+    c.vm.box_url = "http://omnios.omniti.com/media/omnios-latest.box"
+    c.vm.provider "virtualbox"
   end
 end

data/test/vagrant/fedora-18/provision.sh

@@ -1,10 +1,20 @@
 #!/bin/bash
 
-[ `whoami` != "vagrant" ] && chroot --userspec=vagrant / bash -l "$@"
+# Make sure we install rvm as the vagrant user because I generally want
+# to test things as non-root. I'll escalate with sudo if I need privileges.
+[ `whoami` != "vagrant" ] && exec chroot --userspec=vagrant / bash -l "$0" "$@"
 
 export USER=`whoami`
 export HOME=/home/vagrant
 
-[ ! -f "$HOME/.rvm/scripts/rvm" ] && curl -sSL https://get.rvm.io | bash -s stable
-. "$HOME/.rvm/scripts/rvm"
+case $USER in
+  root)
+    [ ! -f "/etc/profile.d/rvm.sh" ] && curl -sSL https://get.rvm.io | bash -s stable
+    . ". /etc/profile.d/rvm.sh"
+    ;;
+  *)
+    [ ! -f "$HOME/.rvm/scripts/rvm" ] && curl -sSL https://get.rvm.io | bash -s stable
+    . "$HOME/.rvm/scripts/rvm"
+    ;;
+esac
 rvm list | grep -q 'No rvm rubies' && rvm install 1.9.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pleaserun
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Jordan Sissel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-05 00:00:00.000000000 Z
+date: 2014-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cabin
@@ -130,6 +130,8 @@ files:
 - lib/pleaserun/cli.rb
 - lib/pleaserun/configurable.rb
 - lib/pleaserun/detector.rb
+- lib/pleaserun/errors.rb
+- lib/pleaserun/installer.rb
 - lib/pleaserun/mustache_methods.rb
 - lib/pleaserun/namespace.rb
 - lib/pleaserun/platform/base.rb
@@ -146,14 +148,16 @@ files:
 - spec/pleaserun/platform/systemd_spec.rb
 - spec/pleaserun/platform/sysv_spec.rb
 - spec/pleaserun/platform/upstart_spec.rb
+- spec/shared_examples.rb
 - spec/testenv.rb
-- templates/launchd/10.9/program.plist
+- templates/launchd/default/program.plist
 - templates/runit/log
 - templates/runit/run
 - templates/systemd/default/prestart.sh
 - templates/systemd/default/program.service
 - templates/sysv/lsb-3.1/default
-- templates/sysv/lsb-3.1/init.d
+- templates/sysv/lsb-3.1/init.sh
+- templates/upstart/0.6.5/init.conf
 - templates/upstart/1.5/init.conf
 - templates/upstart/1.5/init.d.sh
 - test.rb