playwright-ruby-client 0.5.7 → 0.6.1

data/lib/playwright/channel_owners/js_handle.rb

@@ -14,19 +14,11 @@ module Playwright
     end
 
     def evaluate(pageFunction, arg: nil)
-      if JavaScript.function?(pageFunction)
-        JavaScript::Function.new(pageFunction, arg).evaluate(@channel)
-      else
-        JavaScript::Expression.new(pageFunction).evaluate(@channel)
-      end
+      JavaScript::Expression.new(pageFunction, arg).evaluate(@channel)
     end
 
     def evaluate_handle(pageFunction, arg: nil)
-      if JavaScript.function?(pageFunction)
-        JavaScript::Function.new(pageFunction, arg).evaluate_handle(@channel)
-      else
-        JavaScript::Expression.new(pageFunction).evaluate_handle(@channel)
-      end
+      JavaScript::Expression.new(pageFunction, arg).evaluate_handle(@channel)
     end
 
     def get_properties

data/lib/playwright/channel_owners/page.rb

@@ -30,6 +30,7 @@ module Playwright
       @frames << @main_frame
       @opener = ChannelOwners::Page.from_nullable(@initializer['opener'])
 
+      @channel.on('bindingCall', ->(params) { on_binding(ChannelOwners::BindingCall.from(params['binding'])) })
       @channel.once('close', ->(_) { on_close })
       @channel.on('console', ->(params) {
         console_message = ChannelOwners::ConsoleMessage.from(params['message'])
@@ -56,25 +57,6 @@ module Playwright
       @channel.on('pageError', ->(params) {
         emit(Events::Page::PageError, Error.parse(params['error']['error']))
       })
-      @channel.on('request', ->(params) {
-        emit(Events::Page::Request, ChannelOwners::Request.from(params['request']))
-      })
-      @channel.on('requestFailed', ->(params) {
-        on_request_failed(
-          ChannelOwners::Request.from(params['request']),
-          params['responseEndTiming'],
-          params['failureText'],
-        )
-      })
-      @channel.on('requestFinished', ->(params) {
-        on_request_finished(
-          ChannelOwners::Request.from(params['request']),
-          params['responseEndTiming'],
-        )
-      })
-      @channel.on('response', ->(params) {
-        emit(Events::Page::Response, ChannelOwners::Response.from(params['response']))
-      })
       @channel.on('route', ->(params) {
         on_route(ChannelOwners::Route.from(params['route']), ChannelOwners::Request.from(params['request']))
       })
@@ -95,17 +77,6 @@ module Playwright
       :viewport_size,
       :main_frame
 
-    private def on_request_failed(request, response_end_timing, failure_text)
-      request.send(:update_failure_text, failure_text)
-      request.send(:update_response_end_timing, response_end_timing)
-      emit(Events::Page::RequestFailed, request)
-    end
-
-    private def on_request_finished(request, response_end_timing)
-      request.send(:update_response_end_timing, response_end_timing)
-      emit(Events::Page::RequestFinished, request)
-    end
-
     private def on_frame_attached(frame)
       frame.send(:update_page_from_page, self)
       @frames << frame
@@ -130,6 +101,14 @@ module Playwright
       end
     end
 
+    private def on_binding(binding_call)
+      func = @bindings[binding_call.name]
+      if func
+        binding_call.call_async(func)
+      end
+      @browser_context.send(:on_binding, binding_call)
+    end
+
     private def on_close
       @closed = true
       @browser_context.send(:remove_page, self)
@@ -145,6 +124,7 @@ module Playwright
 
     private def on_download(params)
       download = Download.new(
+        page: self,
         url: params['url'],
         suggested_filename: params['suggestedFilename'],
         artifact: ChannelOwners::Artifact.from(params['artifact']),
@@ -335,7 +315,7 @@ module Playwright
         timeout: timeout,
         waitUntil: waitUntil,
       }.compact
-      resp = @channel.send_message_to_server('reoad', params)
+      resp = @channel.send_message_to_server('reload', params)
       ChannelOwners::Response.from_nullable(resp)
     end
 
@@ -464,7 +444,8 @@ module Playwright
           modifiers: nil,
           noWaitAfter: nil,
           position: nil,
-          timeout: nil)
+          timeout: nil,
+          trial: nil)
 
       @main_frame.click(
         selector,
@@ -476,6 +457,7 @@ module Playwright
         noWaitAfter: noWaitAfter,
         position: position,
         timeout: timeout,
+        trial: trial,
       )
     end
 
@@ -487,7 +469,8 @@ module Playwright
           modifiers: nil,
           noWaitAfter: nil,
           position: nil,
-          timeout: nil)
+          timeout: nil,
+          trial: nil)
       @main_frame.dblclick(
         selector,
         button: button,
@@ -497,6 +480,7 @@ module Playwright
         noWaitAfter: noWaitAfter,
         position: position,
         timeout: timeout,
+        trial: trial,
       )
     end
 
@@ -506,7 +490,8 @@ module Playwright
           modifiers: nil,
           noWaitAfter: nil,
           position: nil,
-          timeout: nil)
+          timeout: nil,
+          trial: nil)
       @main_frame.tap_point(
         selector,
         force: force,
@@ -514,6 +499,7 @@ module Playwright
         noWaitAfter: noWaitAfter,
         position: position,
         timeout: timeout,
+        trial: trial,
       )
     end
 
@@ -546,13 +532,15 @@ module Playwright
           force: nil,
           modifiers: nil,
           position: nil,
-          timeout: nil)
+          timeout: nil,
+          trial: nil)
       @main_frame.hover(
         selector,
         force: force,
         modifiers: modifiers,
         position: position,
         timeout: timeout,
+        trial: trial,
       )
     end
 
@@ -604,9 +592,10 @@ module Playwright
       force: nil,
       noWaitAfter: nil,
       position: nil,
-      timeout: nil)
+      timeout: nil,
+      trial: nil)
 
-      @main_frame.check(selector, force: force, noWaitAfter: noWaitAfter, position: position, timeout: timeout)
+      @main_frame.check(selector, force: force, noWaitAfter: noWaitAfter, position: position, timeout: timeout, trial: trial)
     end
 
     def uncheck(
@@ -614,9 +603,10 @@ module Playwright
       force: nil,
       noWaitAfter: nil,
       position: nil,
-      timeout: nil)
+      timeout: nil,
+      trial: nil)
 
-      @main_frame.uncheck(selector, force: force, noWaitAfter: noWaitAfter, position: position, timeout: timeout)
+      @main_frame.uncheck(selector, force: force, noWaitAfter: noWaitAfter, position: position, timeout: timeout, trial: trial)
     end
 
     def wait_for_function(pageFunction, arg: nil, polling: nil, timeout: nil)
@@ -783,12 +773,6 @@ module Playwright
       expect_event(Events::Page::Response, predicate: predicate, timeout: timeout)
     end
 
-    # called from BrowserContext#on_page with send(:update_browser_context, page), so keep private.
-    private def update_browser_context(context)
-      @browser_context = context
-      @timeout_settings = TimeoutSettings.new(context.send(:_timeout_settings))
-    end
-
     # called from Frame with send(:timeout_settings)
     private def timeout_settings
       @timeout_settings

data/lib/playwright/download.rb

@@ -1,12 +1,13 @@
 module Playwright
   class Download
-    def initialize(url:, suggested_filename:, artifact:)
+    def initialize(page:, url:, suggested_filename:, artifact:)
+      @page = page
       @url = url
       @suggested_filename = suggested_filename
       @artifact = artifact
     end
 
-    attr_reader :url, :suggested_filename
+    attr_reader :page, :url, :suggested_filename
 
     def delete
       @artifact.delete

data/lib/playwright/events.rb

@@ -28,6 +28,10 @@ end
     Close: 'close',
     Page: 'page',
     ServiceWorker: 'serviceworker',
+    Request: 'request',
+    Response: 'response',
+    RequestFailed: 'requestfailed',
+    RequestFinished: 'requestfinished',
   },
 
   BrowserServer: {

data/lib/playwright/input_files.rb

@@ -1,5 +1,4 @@
 require 'base64'
-require 'mime/types'
 
 module Playwright
   class InputFiles
@@ -19,13 +18,11 @@ module Playwright
         when String
           {
             name: File.basename(file),
-            mimeType: mime_type_for(file),
             buffer: Base64.strict_encode64(File.read(file)),
           }
         when File
           {
             name: File.basename(file.path),
-            mimeType: mime_type_for(file.path),
             buffer: Base64.strict_encode64(file.read),
           }
         else
@@ -33,10 +30,5 @@ module Playwright
         end
       end
     end
-
-    private def mime_type_for(filepath)
-      mime_types = MIME::Types.type_for(filepath)
-      mime_types.first.to_s || 'application/octet-stream'
-    end
   end
 end

data/lib/playwright/javascript.rb

@@ -1,13 +1,3 @@
 require_relative './javascript/expression'
-require_relative './javascript/function'
 require_relative './javascript/value_parser'
 require_relative './javascript/value_serializer'
-
-module Playwright
-  module JavaScript
-    # Detect if str is likely to be a function
-    module_function def function?(str)
-      ['async', 'function'].any? { |key| str.strip.start_with?(key) } || str.include?('=>')
-    end
-  end
-end

data/lib/playwright/javascript/expression.rb

@@ -1,16 +1,15 @@
 module Playwright
   module JavaScript
     class Expression
-      def initialize(expression)
+      def initialize(expression, arg)
         @expression = expression
-        @serialized_arg = ValueSerializer.new(nil).serialize
+        @serialized_arg = ValueSerializer.new(arg).serialize
       end
 
       def evaluate(channel)
         value = channel.send_message_to_server(
           'evaluateExpression',
           expression: @expression,
-          isFunction: false,
           arg: @serialized_arg,
         )
         ValueParser.new(value).parse
@@ -20,7 +19,6 @@ module Playwright
         resp = channel.send_message_to_server(
           'evaluateExpressionHandle',
           expression: @expression,
-          isFunction: false,
           arg: @serialized_arg,
         )
         ::Playwright::ChannelOwner.from(resp)
@@ -31,7 +29,6 @@ module Playwright
           'evalOnSelector',
           selector: selector,
           expression: @expression,
-          isFunction: false,
           arg: @serialized_arg,
         )
         ValueParser.new(value).parse
@@ -42,7 +39,6 @@ module Playwright
           'evalOnSelectorAll',
           selector: selector,
           expression: @expression,
-          isFunction: false,
           arg: @serialized_arg,
         )
         ValueParser.new(value).parse
@@ -51,7 +47,6 @@ module Playwright
       def wait_for_function(channel, polling:, timeout:)
         params = {
           expression: @expression,
-          isFunction: false,
           arg: @serialized_arg,
           polling: polling,
           timeout: timeout,

data/lib/playwright/playwright_api.rb

@@ -31,7 +31,7 @@ module Playwright
       def wrap
         api_class = detect_class_for(@impl.class)
         if api_class
-          api_class.new(@impl)
+          @impl._api ||= api_class.new(@impl)
         else
           raise NotImplementedError.new("Playwright::#{expected_class_name_for(@impl.class)} is not implemented")
         end
@@ -101,10 +101,6 @@ module Playwright
       @impl = impl
     end
 
-    def ==(other)
-      @impl.to_s == other.instance_variable_get(:'@impl').to_s
-    end
-
     # @param block [Proc]
     private def wrap_block_call(block)
       return nil unless block.is_a?(Proc)

data/lib/playwright/tracing_impl.rb

@@ -0,0 +1,31 @@
+module Playwright
+  define_api_implementation :TracingImpl do
+    def initialize(channel, context)
+      @channel = channel
+      @context = context
+    end
+
+    def start(name: nil, screenshots: nil, snapshots: nil)
+      params = {
+        name: name,
+        screenshots: screenshots,
+        snapshots: snapshots,
+      }.compact
+      @channel.send_message_to_server('tracingStart', params)
+    end
+
+    # Stop tracing.
+    def stop
+      @channel.send_message_to_server('tracingStop')
+    end
+
+    def export(path)
+      resp = @channel.send_message_to_server('tracingExport')
+      artifact = ChannelOwners::Artifact.from(resp)
+      # if self._context._browser:
+      #   artifact._is_remote = self._context._browser._is_remote
+      artifact.save_as(path)
+      artifact.delete
+    end
+  end
+end

data/lib/playwright/version.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
 module Playwright
-  VERSION = '0.5.7'
+  VERSION = '0.6.1'
+  COMPATIBLE_PLAYWRIGHT_VERSION = '1.12.0'
 end

data/lib/playwright_api/accessibility.rb

@@ -2,13 +2,13 @@ module Playwright
   # The Accessibility class provides methods for inspecting Chromium's accessibility tree. The accessibility tree is used by
   # assistive technology such as [screen readers](https://en.wikipedia.org/wiki/Screen_reader) or
   # [switches](https://en.wikipedia.org/wiki/Switch_access).
-  # 
+  #
   # Accessibility is a very platform-specific thing. On different platforms, there are different screen readers that might
   # have wildly different output.
-  # 
+  #
   # Rendering engines of Chromium, Firefox and WebKit have a concept of "accessibility tree", which is then translated into
   # different platform-specific APIs. Accessibility namespace gives access to this Accessibility Tree.
-  # 
+  #
   # Most of the accessibility tree gets filtered out when converting from internal browser AX Tree to Platform-specific
   # AX-Tree or by assistive technologies themselves. By default, Playwright tries to approximate this filtering, exposing
   # only the "interesting" nodes of the tree.
@@ -16,100 +16,19 @@ module Playwright
 
     # Captures the current state of the accessibility tree. The returned object represents the root accessible node of the
     # page.
-    # 
+    #
     # > NOTE: The Chromium accessibility tree contains nodes that go unused on most platforms and by most screen readers.
     # Playwright will discard them as well for an easier to process tree, unless `interestingOnly` is set to `false`.
-    # 
+    #
     # An example of dumping the entire accessibility tree:
-    # 
     #
-    # ```js
-    # const snapshot = await page.accessibility.snapshot();
-    # console.log(snapshot);
-    # ```
-    # 
-    # ```java
-    # String snapshot = page.accessibility().snapshot();
-    # System.out.println(snapshot);
-    # ```
-    # 
-    # ```python async
-    # snapshot = await page.accessibility.snapshot()
-    # print(snapshot)
-    # ```
-    # 
     # ```python sync
     # snapshot = page.accessibility.snapshot()
     # print(snapshot)
     # ```
-    # 
-    # ```csharp
-    # var accessibilitySnapshot = await Page.Accessibility.SnapshotAsync();
-    # Console.WriteLine(accessibilitySnapshot);
-    # ```
-    # 
+    #
     # An example of logging the focused node's name:
-    # 
     #
-    # ```js
-    # const snapshot = await page.accessibility.snapshot();
-    # const node = findFocusedNode(snapshot);
-    # console.log(node && node.name);
-    # 
-    # function findFocusedNode(node) {
-    #   if (node.focused)
-    #     return node;
-    #   for (const child of node.children || []) {
-    #     const foundNode = findFocusedNode(child);
-    #     return foundNode;
-    #   }
-    #   return null;
-    # }
-    # ```
-    # 
-    # ```csharp
-    # Func<AccessibilitySnapshotResult, AccessibilitySnapshotResult> findFocusedNode = root =>
-    # {
-    #     var nodes = new Stack<AccessibilitySnapshotResult>(new[] { root });
-    #     while (nodes.Count > 0)
-    #     {
-    #         var node = nodes.Pop();
-    #         if (node.Focused) return node;
-    #         foreach (var innerNode in node.Children)
-    #         {
-    #             nodes.Push(innerNode);
-    #         }
-    #     }
-    # 
-    #     return null;
-    # };
-    # 
-    # var accessibilitySnapshot = await Page.Accessibility.SnapshotAsync();
-    # var focusedNode = findFocusedNode(accessibilitySnapshot);
-    # if(focusedNode != null)
-    #   Console.WriteLine(focusedNode.Name);
-    # ```
-    # 
-    # ```java
-    # // FIXME
-    # String snapshot = page.accessibility().snapshot();
-    # ```
-    # 
-    # ```python async
-    # def find_focused_node(node):
-    #     if (node.get("focused"))
-    #         return node
-    #     for child in (node.get("children") or []):
-    #         found_node = find_focused_node(child)
-    #         return found_node
-    #     return None
-    # 
-    # snapshot = await page.accessibility.snapshot()
-    # node = find_focused_node(snapshot)
-    # if node:
-    #     print(node["name"])
-    # ```
-    # 
     # ```python sync
     # def find_focused_node(node):
     #     if (node.get("focused"))
@@ -118,7 +37,7 @@ module Playwright
     #         found_node = find_focused_node(child)
     #         return found_node
     #     return None
-    # 
+    #
     # snapshot = page.accessibility.snapshot()
     # node = find_focused_node(snapshot)
     # if node: