playwright-ruby-client 0.5.3 → 0.5.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81be247e4fe8a3bf351cf8ead156c490657547f89a1ae5f8a1536ad72a1c30e4
-  data.tar.gz: '0398932fd2d3eae453668624bad5271990bc426168caa56e71be773e87e9504a'
+  metadata.gz: 6edb69becb86be4d50f959a89b068bca80135f98b7db737a8de23301abd92310
+  data.tar.gz: 61b8b4aed269864caadb03b780787ebb627269bdcf416ce1513b77a530c87dbe
 SHA512:
-  metadata.gz: b77d93002b1395839dc4f9cf2c62bb40e9abaca0008aaf2a52c83498b811018782144686c7a83acdc8ae2b9bc3287b21e2808fcb996d6b270deb7fdf04c2dddb
-  data.tar.gz: 72c787d2dc63a2b78e09ae5660d1774a390e65ceb322529807965a0da95f27ca5f6ffd23dbcf1b81fb8ac4bb44f17ac58e508075c5cae959b1d1e233ed7c09e1
+  metadata.gz: 8826473bfaf34affa5898551a68cc421403c0cea9cccd436fa3181706f84b3ef49cac4629a9749259096b41c90dcaa1cd844b88e0e4b6bf8a9761d6270ed07a2
+  data.tar.gz: 7d554a71a19a3473108b2e4a8e213a3dcac1adbdfa74c007fd95bc868f9d882b9c319660be65700e09791e1111526544875575150e81c0dea0437f818f29b4dc

data/lib/playwright/channel_owner.rb

@@ -10,6 +10,9 @@ module Playwright
       channel&.object
     end
 
+    # hidden field for caching API instance.
+    attr_accessor :_api
+
     # @param parent [Playwright::ChannelOwner|Playwright::Connection]
     # @param type [String]
     # @param guid [String]

data/lib/playwright/channel_owners/element_handle.rb

@@ -82,7 +82,7 @@ module Playwright
           modifiers: modifiers,
           position: position,
           timeout: timeout,
-        }
+        }.compact
         @channel.send_message_to_server('hover', params)
 
         nil
@@ -149,10 +149,8 @@ module Playwright
           value: value,
           label: label,
         ).as_params
-        params = base_params + { noWaitAfter: noWaitAfter, timeout: timeout }.compact
+        params = base_params.merge({ noWaitAfter: noWaitAfter, timeout: timeout }.compact)
         @channel.send_message_to_server('selectOption', params)
-
-        nil
       end
 
       def tap_point(

data/lib/playwright/channel_owners/frame.rb

@@ -421,10 +421,8 @@ module Playwright
         value: value,
         label: label,
       ).as_params
-      params = base_params + { selector: selector, noWaitAfter: noWaitAfter, timeout: timeout }.compact
+      params = base_params.merge({ selector: selector, noWaitAfter: noWaitAfter, timeout: timeout }.compact)
       @channel.send_message_to_server('selectOption', params)
-
-      nil
     end
 
     def set_input_files(selector, files, noWaitAfter: nil, timeout: nil)

data/lib/playwright/channel_owners/page.rb

@@ -798,5 +798,11 @@ module Playwright
     private def has_bindings?(name)
       @bindings.key?(name)
     end
+
+    # Expose guid for library developers.
+    # Not intended to be used by users.
+    def guid
+      @guid
+    end
   end
 end

data/lib/playwright/playwright_api.rb

@@ -14,7 +14,7 @@ module Playwright
       when ApiImplementation
         ApiImplementationWrapper.new(channel_owner_or_api_implementation).wrap
       else
-        nil
+        channel_owner_or_api_implementation
       end
     end
 
@@ -31,7 +31,7 @@ module Playwright
       def wrap
         api_class = detect_class_for(@impl.class)
         if api_class
-          api_class.new(@impl)
+          @impl._api ||= api_class.new(@impl)
         else
           raise NotImplementedError.new("Playwright::#{expected_class_name_for(@impl.class)} is not implemented")
         end
@@ -101,10 +101,6 @@ module Playwright
       @impl = impl
     end
 
-    def ==(other)
-      @impl.to_s == other.instance_variable_get(:'@impl').to_s
-    end
-
     # @param block [Proc]
     private def wrap_block_call(block)
       return nil unless block.is_a?(Proc)
@@ -119,7 +115,7 @@ module Playwright
       if object.is_a?(Array)
         object.map { |obj| wrap_impl(obj) }
       else
-        ::Playwright::PlaywrightApi.wrap(object) || object
+        ::Playwright::PlaywrightApi.wrap(object)
       end
     end
 

data/lib/playwright/select_option_values.rb

@@ -1,18 +1,30 @@
 module Playwright
   class SelectOptionValues
     def initialize(element: nil, index: nil, value: nil, label: nil)
-      @params =
-        if element
-          convert(elmeent)
-        elsif index
-          convert(index)
-        elsif value
-          convert(value)
-        elsif label
-          convert(label)
-        else
-          {}
-        end
+      params = {}
+
+      options = []
+      if value
+        options.concat(convert(:value, value))
+      end
+
+      if index
+        options.concat(convert(:index, index))
+      end
+
+      if label
+        options.concat(convert(:label, label))
+      end
+
+      unless options.empty?
+        params[:options] = options
+      end
+
+      if element
+        params[:elements] = convert(:element, element)
+      end
+
+      @params = params
     end
 
     # @return [Hash]
@@ -20,22 +32,19 @@ module Playwright
       @params
     end
 
-    private def convert(values)
-      return convert([values]) unless values.is_a?(Enumerable)
-      return {} if values.empty?
+    private def convert(key, values)
+      return convert(key, [values]) unless values.is_a?(Enumerable)
+      return [] if values.empty?
       values.each_with_index do |value, index|
-        unless values
+        unless value
           raise ArgumentError.new("options[#{index}]: expected object, got null")
         end
       end
 
-      case values.first
-      when ElementHandle
-        { elements: values.map(&:channel) }
-      when String
-        { options: values.map { |value| { value: value } } }
+      if key == :element
+        values.map(&:channel)
       else
-        { options: values }
+        values.map { |value| { key => value } }
       end
     end
   end

data/lib/playwright/transport.rb

@@ -30,8 +30,8 @@ module Playwright
       debug_send_message(message) if @debug
       msg = JSON.dump(message)
       @mutex.synchronize {
-        @stdin.write([msg.size].pack('V')) # unsigned 32bit, little endian
-        @stdin.write(msg)
+        @stdin.write([msg.bytes.length].pack('V')) # unsigned 32bit, little endian, real byte size instead of chars
+        @stdin.write(msg) # write UTF-8 in binary mode as byte stream
       }
     rescue Errno::EPIPE, IOError
       raise AlreadyDisconnectedError.new('send_message failed')
@@ -48,6 +48,7 @@ module Playwright
     # @note This method blocks until playwright-cli exited. Consider using Thread or Future.
     def async_run
       @stdin, @stdout, @stderr, @thread = Open3.popen3("#{@driver_executable_path} run-driver")
+      @stdin.binmode  # Ensure Strings are written 1:1 without encoding conversion, necessary for integer values
 
       Thread.new { handle_stdout }
       Thread.new { handle_stderr }

data/lib/playwright/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Playwright
-  VERSION = '0.5.3'
+  VERSION = '0.5.8'
 end

data/lib/playwright_api/browser_context.rb

@@ -730,13 +730,13 @@ module Playwright
     end
 
     # @nodoc
-    def options=(req)
-      wrap_impl(@impl.options=(unwrap_impl(req)))
+    def browser=(req)
+      wrap_impl(@impl.browser=(unwrap_impl(req)))
     end
 
     # @nodoc
-    def browser=(req)
-      wrap_impl(@impl.browser=(unwrap_impl(req)))
+    def owner_page=(req)
+      wrap_impl(@impl.owner_page=(unwrap_impl(req)))
     end
 
     # @nodoc
@@ -745,8 +745,8 @@ module Playwright
     end
 
     # @nodoc
-    def owner_page=(req)
-      wrap_impl(@impl.owner_page=(unwrap_impl(req)))
+    def options=(req)
+      wrap_impl(@impl.options=(unwrap_impl(req)))
     end
 
     # -- inherited from EventEmitter --

data/lib/playwright_api/page.rb

@@ -2268,6 +2268,11 @@ module Playwright
       raise NotImplementedError.new('wait_for_event is not implemented yet.')
     end
 
+    # @nodoc
+    def owned_context=(req)
+      wrap_impl(@impl.owned_context=(unwrap_impl(req)))
+    end
+
     # @nodoc
     def start_js_coverage(resetOnNavigation: nil, reportAnonymousScripts: nil)
       wrap_impl(@impl.start_js_coverage(resetOnNavigation: unwrap_impl(resetOnNavigation), reportAnonymousScripts: unwrap_impl(reportAnonymousScripts)))
@@ -2289,8 +2294,8 @@ module Playwright
     end
 
     # @nodoc
-    def owned_context=(req)
-      wrap_impl(@impl.owned_context=(unwrap_impl(req)))
+    def guid
+      wrap_impl(@impl.guid)
     end
 
     # -- inherited from EventEmitter --

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: playwright-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.8
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-05-02 00:00:00.000000000 Z
+date: 2021-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby