playwright-ruby-client 0.5.2 → 0.5.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8979977d78ed7f62007ac6049ccf50a4c865093ac0d4c8828a8f8b8fdd69beef
-  data.tar.gz: 20346e5f5a373b49441c81a1fc77cc15ed0afb3bd47479e7cb6e545935fb7dfa
+  metadata.gz: 66cf08a96bb2b41f99fdfcaa8880785ba08afb7287c9d98199d9312812d93362
+  data.tar.gz: b7ee7d9db9f28a6752f20e935825412a7bf088e2c138f3ea5b985f114bf6e66d
 SHA512:
-  metadata.gz: f74fc9b91dccf461603ef6be94c7dbb6aae4899f7246fb4db1456018cc16c9e4fc63d6bf8c9912623b69d20d2901fcd5aab6e128638afc799fa20caac989ddaf
-  data.tar.gz: f25f60d3d258fc5fa3592201a45e46e6b111a8508b4493c4308a206d4b33f7909925a1b8760e433a2b7139223e7670b4c9fa0474eccfc3ec2bf2c46061af04b4
+  metadata.gz: c50508317e8468f6cea658190b6b199f889777b8fcf6e0e7c208fb4e6574e122c0337562c4a8fec03a779750569ba54fa502ca85b71e8491a335cd7ae21e37b7
+  data.tar.gz: 035fff2a09a49a95b28ebfed67b13842c4baf54021613af9a3efc5b0da99198c28bed559d8e6724dd15ede4dd99dd19509ef44f05640e8c090acba9539b5be31

data/lib/playwright/channel_owners/element_handle.rb

@@ -82,7 +82,7 @@ module Playwright
           modifiers: modifiers,
           position: position,
           timeout: timeout,
-        }
+        }.compact
         @channel.send_message_to_server('hover', params)
 
         nil
@@ -149,10 +149,8 @@ module Playwright
           value: value,
           label: label,
         ).as_params
-        params = base_params + { noWaitAfter: noWaitAfter, timeout: timeout }.compact
+        params = base_params.merge({ noWaitAfter: noWaitAfter, timeout: timeout }.compact)
         @channel.send_message_to_server('selectOption', params)
-
-        nil
       end
 
       def tap_point(
@@ -230,10 +228,11 @@ module Playwright
         nil
       end
 
-      def check(force: nil, noWaitAfter: nil, timeout: nil)
+      def check(force: nil, noWaitAfter: nil, position: nil, timeout: nil)
         params = {
           force: force,
           noWaitAfter:  noWaitAfter,
+          position: position,
           timeout: timeout,
         }.compact
         @channel.send_message_to_server('check', params)
@@ -241,10 +240,11 @@ module Playwright
         nil
       end
 
-      def uncheck(force: nil, noWaitAfter: nil, timeout: nil)
+      def uncheck(force: nil, noWaitAfter: nil, position: nil, timeout: nil)
         params = {
           force: force,
           noWaitAfter:  noWaitAfter,
+          position: position,
           timeout: timeout,
         }.compact
         @channel.send_message_to_server('uncheck', params)

data/lib/playwright/channel_owners/frame.rb

@@ -421,10 +421,8 @@ module Playwright
         value: value,
         label: label,
       ).as_params
-      params = base_params + { selector: selector, noWaitAfter: noWaitAfter, timeout: timeout }.compact
+      params = base_params.merge({ selector: selector, noWaitAfter: noWaitAfter, timeout: timeout }.compact)
       @channel.send_message_to_server('selectOption', params)
-
-      nil
     end
 
     def set_input_files(selector, files, noWaitAfter: nil, timeout: nil)

data/lib/playwright/channel_owners/page.rb

@@ -798,5 +798,11 @@ module Playwright
     private def has_bindings?(name)
       @bindings.key?(name)
     end
+
+    # Expose guid for library developers.
+    # Not intended to be used by users.
+    def guid
+      @guid
+    end
   end
 end

data/lib/playwright/playwright_api.rb

@@ -14,7 +14,7 @@ module Playwright
       when ApiImplementation
         ApiImplementationWrapper.new(channel_owner_or_api_implementation).wrap
       else
-        nil
+        channel_owner_or_api_implementation
       end
     end
 
@@ -119,12 +119,14 @@ module Playwright
       if object.is_a?(Array)
         object.map { |obj| wrap_impl(obj) }
       else
-        ::Playwright::PlaywrightApi.wrap(object) || object
+        ::Playwright::PlaywrightApi.wrap(object)
       end
     end
 
     private def unwrap_impl(object)
-      if object.is_a?(PlaywrightApi)
+      if object.is_a?(Array)
+        object.map { |obj| unwrap_impl(obj) }
+      elsif object.is_a?(PlaywrightApi)
         object.instance_variable_get(:@impl)
       else
         object

data/lib/playwright/select_option_values.rb

@@ -1,18 +1,30 @@
 module Playwright
   class SelectOptionValues
     def initialize(element: nil, index: nil, value: nil, label: nil)
-      @params =
-        if element
-          convert(elmeent)
-        elsif index
-          convert(index)
-        elsif value
-          convert(value)
-        elsif label
-          convert(label)
-        else
-          {}
-        end
+      params = {}
+
+      options = []
+      if value
+        options.concat(convert(:value, value))
+      end
+
+      if index
+        options.concat(convert(:index, index))
+      end
+
+      if label
+        options.concat(convert(:label, label))
+      end
+
+      unless options.empty?
+        params[:options] = options
+      end
+
+      if element
+        params[:elements] = convert(:element, element)
+      end
+
+      @params = params
     end
 
     # @return [Hash]
@@ -20,22 +32,19 @@ module Playwright
       @params
     end
 
-    private def convert(values)
-      return convert([values]) unless values.is_a?(Enumerable)
-      return {} if values.empty?
+    private def convert(key, values)
+      return convert(key, [values]) unless values.is_a?(Enumerable)
+      return [] if values.empty?
       values.each_with_index do |value, index|
-        unless values
+        unless value
           raise ArgumentError.new("options[#{index}]: expected object, got null")
         end
       end
 
-      case values.first
-      when ElementHandle
-        { elements: values.map(&:channel) }
-      when String
-        { options: values.map { |value| { value: value } } }
+      if key == :element
+        values.map(&:channel)
       else
-        { options: values }
+        values.map { |value| { key => value } }
       end
     end
   end

data/lib/playwright/transport.rb

@@ -30,10 +30,10 @@ module Playwright
       debug_send_message(message) if @debug
       msg = JSON.dump(message)
       @mutex.synchronize {
-        @stdin.write([msg.size].pack('V')) # unsigned 32bit, little endian
-        @stdin.write(msg)
+        @stdin.write([msg.bytes.length].pack('V')) # unsigned 32bit, little endian, real byte size instead of chars
+        @stdin.write(msg) # write UTF-8 in binary mode as byte stream
       }
-    rescue Errno::EPIPE
+    rescue Errno::EPIPE, IOError
       raise AlreadyDisconnectedError.new('send_message failed')
     end
 
@@ -48,6 +48,7 @@ module Playwright
     # @note This method blocks until playwright-cli exited. Consider using Thread or Future.
     def async_run
       @stdin, @stdout, @stderr, @thread = Open3.popen3("#{@driver_executable_path} run-driver")
+      @stdin.binmode  # Ensure Strings are written 1:1 without encoding conversion, necessary for integer values
 
       Thread.new { handle_stdout }
       Thread.new { handle_stderr }

data/lib/playwright/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Playwright
-  VERSION = '0.5.2'
+  VERSION = '0.5.7'
 end

data/lib/playwright_api/browser_context.rb

@@ -730,23 +730,23 @@ module Playwright
     end
 
     # @nodoc
-    def options=(req)
-      wrap_impl(@impl.options=(unwrap_impl(req)))
+    def browser=(req)
+      wrap_impl(@impl.browser=(unwrap_impl(req)))
     end
 
     # @nodoc
-    def browser=(req)
-      wrap_impl(@impl.browser=(unwrap_impl(req)))
+    def owner_page=(req)
+      wrap_impl(@impl.owner_page=(unwrap_impl(req)))
     end
 
     # @nodoc
-    def pause
-      wrap_impl(@impl.pause)
+    def options=(req)
+      wrap_impl(@impl.options=(unwrap_impl(req)))
     end
 
     # @nodoc
-    def owner_page=(req)
-      wrap_impl(@impl.owner_page=(unwrap_impl(req)))
+    def pause
+      wrap_impl(@impl.pause)
     end
 
     # -- inherited from EventEmitter --

data/lib/playwright_api/page.rb

@@ -2268,6 +2268,11 @@ module Playwright
       raise NotImplementedError.new('wait_for_event is not implemented yet.')
     end
 
+    # @nodoc
+    def owned_context=(req)
+      wrap_impl(@impl.owned_context=(unwrap_impl(req)))
+    end
+
     # @nodoc
     def start_js_coverage(resetOnNavigation: nil, reportAnonymousScripts: nil)
       wrap_impl(@impl.start_js_coverage(resetOnNavigation: unwrap_impl(resetOnNavigation), reportAnonymousScripts: unwrap_impl(reportAnonymousScripts)))
@@ -2289,8 +2294,8 @@ module Playwright
     end
 
     # @nodoc
-    def owned_context=(req)
-      wrap_impl(@impl.owned_context=(unwrap_impl(req)))
+    def guid
+      wrap_impl(@impl.guid)
     end
 
     # -- inherited from EventEmitter --

data/lib/playwright_api/response.rb

@@ -60,13 +60,13 @@ module Playwright
     end
 
     # @nodoc
-    def after_initialize
-      wrap_impl(@impl.after_initialize)
+    def ok?
+      wrap_impl(@impl.ok?)
     end
 
     # @nodoc
-    def ok?
-      wrap_impl(@impl.ok?)
+    def after_initialize
+      wrap_impl(@impl.after_initialize)
     end
 
     # -- inherited from EventEmitter --

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: playwright-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.7
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-04-28 00:00:00.000000000 Z
+date: 2021-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby