playbook_ui 15.6.0.pre.alpha.play263913015 → 15.6.0.pre.alpha.play265012865

data/app/pb_kits/playbook/pb_draggable/context/index.tsx

@@ -1,4 +1,4 @@
-import React, { createContext, useReducer, useContext, useEffect, useMemo, useRef } from "react";
+import React, { createContext, useReducer, useContext, useEffect, useMemo } from "react";
 import { InitialStateType, ActionType, DraggableProviderType } from "./types";
 
 const initialState: InitialStateType = {
@@ -92,35 +92,6 @@ const reducer = (state: InitialStateType, action: ActionType) => {
       return { ...state, items: newItems };
     }
 
-    // Reset item back to its original container and position (e.g., when drag ends without valid drop)
-    case "RESET_DRAG_CONTAINER": {
-      const { itemId, originalContainer, originalIndex } = action.payload;
-      const newItems = [...state.items];
-      const draggedItem = newItems.find(item => item && item.id === itemId);
-      
-      if (!draggedItem) return state;
-      
-      const currentIndex = newItems.indexOf(draggedItem);
-      
-      // Remove from current position
-      newItems.splice(currentIndex, 1);
-      
-      // Restore container property and insert at original index
-      const restoredItem = { ...draggedItem, container: originalContainer };
-      
-      // Insert at original index, or at end if index is invalid
-      if (originalIndex !== undefined && originalIndex >= 0) {
-        newItems.splice(originalIndex, 0, restoredItem);
-      } else {
-        newItems.push(restoredItem);
-      }
-      
-      return {
-        ...state,
-        items: newItems
-      };
-    }
-
     default:
       return state;
   }
@@ -148,29 +119,6 @@ export const DraggableProvider = ({
   enableCrossContainerPreview = false,
 }: DraggableProviderType) => {
   const [state, dispatch] = useReducer(reducer, initialState);
-  
-  // Track drag state for global listener
-  const dragStateRef = useRef<{
-    isDragging: boolean;
-    draggedItemId: string;
-    originalContainer: string;
-    originalIndex: number;
-    currentContainer: string;
-    dropOccurred: boolean;
-  }>({
-    isDragging: false,
-    draggedItemId: '',
-    originalContainer: '',
-    originalIndex: -1,
-    currentContainer: '',
-    dropOccurred: false,
-  });
-
-  // Track current state for use in gated event listeners (avoid stale closures)
-  const stateRef = useRef(state);
-  useEffect(() => {
-    stateRef.current = state;
-  }, [state]);
 
   // Parse dropZone prop - handle both string format (backward compatibility) and object format
   let dropZoneType = 'ghost';
@@ -200,209 +148,7 @@ export const DraggableProvider = ({
     onReorder(state.items);
   }, [state.items]);
 
-  // Monitor for failed drops by detecting mouse/pointer release during drag (this is needed for cross container preview)
-  useEffect(() => {
-    if (!enableCrossContainerPreview) return;
-
-    // Allow drops anywhere on the document by preventing default dragover
-    const handleGlobalDragOver = (e: DragEvent) => {
-      if (dragStateRef.current.isDragging) {
-        e.preventDefault();
-      }
-    };
-
-    // Handle drops anywhere on the document (including non-container areas)
-    const handleGlobalDrop = (e: DragEvent) => {
-      if (!dragStateRef.current.isDragging) return;
-      
-      // If a container already handled the drop, don't process again
-      if (dragStateRef.current.dropOccurred) return;
-      
-      e.preventDefault();
-      
-      // If we reach here, it means the drop was NOT on a valid container
-      // (otherwise the container's handleDrop would have set dropOccurred = true)
-      // So we should ALWAYS reset to original container for invalid drops
-      const originalContainer = dragStateRef.current.originalContainer;
-      
-      dispatch({
-        type: 'RESET_DRAG_CONTAINER',
-        payload: {
-          itemId: dragStateRef.current.draggedItemId,
-          originalContainer: originalContainer,
-          originalIndex: dragStateRef.current.originalIndex,
-        },
-      });
-      
-      dispatch({ type: 'SET_IS_DRAGGING', payload: "" });
-      dispatch({ type: 'SET_ACTIVE_CONTAINER', payload: "" });
-      dispatch({ type: 'SET_DRAG_DATA', payload: { id: "", initialGroup: "", originId: "" } });
-      
-      // Clear drag state
-      dragStateRef.current = {
-        isDragging: false,
-        draggedItemId: '',
-        originalContainer: '',
-        originalIndex: -1,
-        currentContainer: '',
-        dropOccurred: false,
-      };
-    };
-
-    const handleGlobalMouseUp = () => {
-      // If we're dragging and mouse is released, wait a bit to see if drop occurs
-      if (dragStateRef.current.isDragging) {
-        setTimeout(() => {
-          const currentContainer = dragStateRef.current.currentContainer;
-          
-          // If drop still hasn't occurred, check if item is in a different container
-          if (dragStateRef.current.isDragging && !dragStateRef.current.dropOccurred) {
-            // If item is in a different container than original, treat it as a successful drop
-            if (currentContainer && currentContainer !== dragStateRef.current.originalContainer) {
-              // Trigger onDrop callback with the current container
-              if (onDrop) {
-                const draggedItem = stateRef.current.items.find(item => item && item.id === dragStateRef.current.draggedItemId);
-                const updatedItem = draggedItem ? { ...draggedItem, container: currentContainer } : null;
-                const itemsInContainer = stateRef.current.items.filter(item => item && item.container === currentContainer);
-                const indexInContainer = itemsInContainer.findIndex(item => item && item.id === dragStateRef.current.draggedItemId);
-                const itemAbove = indexInContainer > 0 ? itemsInContainer[indexInContainer - 1] : null;
-                const itemBelow = indexInContainer < itemsInContainer.length - 1 ? itemsInContainer[indexInContainer + 1] : null;
-                
-                onDrop(
-                  dragStateRef.current.draggedItemId,
-                  currentContainer,
-                  dragStateRef.current.originalContainer,
-                  updatedItem,
-                  itemAbove,
-                  itemBelow
-                );
-              }
-            } else {
-              dispatch({
-                type: 'RESET_DRAG_CONTAINER',
-                payload: {
-                  itemId: dragStateRef.current.draggedItemId,
-                  originalContainer: dragStateRef.current.originalContainer,
-                  originalIndex: dragStateRef.current.originalIndex,
-                },
-              });
-            }
-            dispatch({ type: 'SET_IS_DRAGGING', payload: "" });
-            dispatch({ type: 'SET_ACTIVE_CONTAINER', payload: "" });
-            dispatch({ type: 'SET_DRAG_DATA', payload: { id: "", initialGroup: "", originId: "" } });
-            
-            // Clear drag state
-            dragStateRef.current = {
-              isDragging: false,
-              draggedItemId: '',
-              originalContainer: '',
-              originalIndex: -1,
-              currentContainer: '',
-              dropOccurred: false,
-            };
-          }
-        }, 50); // Small delay to let drop event fire if it's going to
-      }
-    };
-
-    // Detect when drag leaves document boundaries
-    const handleDragLeave = (e: DragEvent) => {
-      // Check if we're leaving the document (relatedTarget will be null)
-      if (!e.relatedTarget && dragStateRef.current.isDragging && !dragStateRef.current.dropOccurred) {
-        // Drag left the document: reset to original container immediately
-        dispatch({
-          type: 'RESET_DRAG_CONTAINER',
-          payload: {
-            itemId: dragStateRef.current.draggedItemId,
-            originalContainer: dragStateRef.current.originalContainer,
-            originalIndex: dragStateRef.current.originalIndex,
-          },
-        });
-        dispatch({ type: 'SET_IS_DRAGGING', payload: "" });
-        dispatch({ type: 'SET_ACTIVE_CONTAINER', payload: "" });
-        dispatch({ type: 'SET_DRAG_DATA', payload: { id: "", initialGroup: "", originId: "" } });
-        
-        // Clear drag state
-        dragStateRef.current = {
-          isDragging: false,
-          draggedItemId: '',
-          originalContainer: '',
-          originalIndex: -1,
-          currentContainer: '',
-          dropOccurred: false,
-        };
-      }
-    };
-
-    document.addEventListener('dragover', handleGlobalDragOver);
-    document.addEventListener('drop', handleGlobalDrop);
-    document.addEventListener('dragleave', handleDragLeave);
-    document.addEventListener('mouseup', handleGlobalMouseUp);
-    document.addEventListener('pointerup', handleGlobalMouseUp);
-    
-    return () => {
-      document.removeEventListener('dragover', handleGlobalDragOver);
-      document.removeEventListener('drop', handleGlobalDrop);
-      document.removeEventListener('dragleave', handleDragLeave);
-      document.removeEventListener('mouseup', handleGlobalMouseUp);
-      document.removeEventListener('pointerup', handleGlobalMouseUp);
-    };
-  }, [enableCrossContainerPreview]);
-
-  // Detect when dragging stops (isDragging goes from truthy to empty)
-  const prevIsDraggingRef = useRef(state.isDragging);
-  
-  useEffect(() => {
-    if (!enableCrossContainerPreview) return;
-
-    const wasDragging = prevIsDraggingRef.current;
-    const isNowDragging = state.isDragging;
-
-    // Drag just ended (was dragging, now not)
-    if (wasDragging && !isNowDragging) {
-      
-      // If drop didn't occur, reset to original container
-      if (!dragStateRef.current.dropOccurred && dragStateRef.current.draggedItemId) {
-        dispatch({
-          type: 'RESET_DRAG_CONTAINER',
-          payload: {
-            itemId: dragStateRef.current.draggedItemId,
-            originalContainer: dragStateRef.current.originalContainer,
-            originalIndex: dragStateRef.current.originalIndex,
-          },
-        });
-      }
-      
-      // Clear drag state
-      dragStateRef.current = {
-        isDragging: false,
-        draggedItemId: '',
-        originalContainer: '',
-        originalIndex: -1,
-        currentContainer: '',
-        dropOccurred: false,
-      };
-    }
-    
-    prevIsDraggingRef.current = isNowDragging;
-  }, [state.isDragging, enableCrossContainerPreview]);
-
   const handleDragStart = (id: string, container: string) => {
-    // Track drag in ref for global listener
-    if (enableCrossContainerPreview) {
-      // Find the original index of the item
-      const originalIndex = state.items.findIndex(item => item && item.id === id);
-      
-      dragStateRef.current = {
-        isDragging: true,
-        draggedItemId: id,
-        originalContainer: container,
-        originalIndex: originalIndex,
-        currentContainer: container,
-        dropOccurred: false,
-      };
-    }
-    
     dispatch({ type: 'SET_DRAG_DATA', payload: { id: id, initialGroup: container, originId: providerId } });
     dispatch({ type: 'SET_IS_DRAGGING', payload: id });
     if (onDragStart) onDragStart(id, container);
@@ -435,10 +181,6 @@ export const DraggableProvider = ({
               newContainer: container,
             },
           });
-          // Update current container in ref
-          if (enableCrossContainerPreview) {
-            dragStateRef.current.currentContainer = container;
-          }
         } else {
           // Same container: keep original behavior
           dispatch({
@@ -451,10 +193,7 @@ export const DraggableProvider = ({
         dispatch({type: "REORDER_ITEMS", payload: { dragId: state.dragData.id, targetId: id }});
       }
 
-      // When enableCrossContainerPreview is true, preserve the original initialGroup
-      // Otherwise, update it to track the current container
-      const newInitialGroup = enableCrossContainerPreview ? state.dragData.initialGroup : container;
-      dispatch({type: "SET_DRAG_DATA",payload: {id: state.dragData.id, initialGroup: newInitialGroup, originId: providerId}});
+      dispatch({type: "SET_DRAG_DATA",payload: {id: state.dragData.id, initialGroup: container, originId: providerId}});
     }
     if (onDragEnter) onDragEnter(id, container);
   };
@@ -463,29 +202,17 @@ export const DraggableProvider = ({
     const draggedItemId = state.dragData.id;
     const originalContainer = state.dragData.initialGroup;
     
-    // If enableCrossContainerPreview is true and no drop occurred, reset item to original container
-    if (enableCrossContainerPreview && !dragStateRef.current.dropOccurred && draggedItemId && originalContainer) {
-      dispatch({ type: 'RESET_DRAG_CONTAINER', payload: { itemId: draggedItemId, originalContainer, originalIndex: dragStateRef.current.originalIndex } });
-    }
-    
     dispatch({ type: 'SET_IS_DRAGGING', payload: "" });
     dispatch({ type: 'SET_ACTIVE_CONTAINER', payload: "" });
     dispatch({ type: 'SET_DRAG_DATA', payload: { id: "", initialGroup: "", originId: "" } });
-    
-    // Only call onDragEnd if drop didn't already occur (for enableCrossContainerPreview)
-    // If drop occurred, handleDrop or global drop handler already called onDragEnd
-    if (enableCrossContainerPreview && dragStateRef.current.dropOccurred) {
-      return;
-    }
-    
     if (onDragEnd) {
       if (!enableCrossContainerPreview) {
         onDragEnd();
       } else {
-        const draggedItem = stateRef.current.items.find(item => item && item.id === draggedItemId);
+        const draggedItem = state.items.find(item => item && item.id === draggedItemId);
         const finalContainer = draggedItem ? draggedItem.container : originalContainer;
         
-        const itemsInContainer = stateRef.current.items.filter(item => item && item.container === finalContainer);
+        const itemsInContainer = state.items.filter(item => item && item.container === finalContainer);
         const indexInContainer = itemsInContainer.findIndex(item => item && item.id === draggedItemId);
         const itemAbove = indexInContainer > 0 ? itemsInContainer[indexInContainer - 1] : null;
         const itemBelow = indexInContainer < itemsInContainer.length - 1 ? itemsInContainer[indexInContainer + 1] : null;
@@ -510,58 +237,32 @@ export const DraggableProvider = ({
 
     const draggedItemId = state.dragData.id;
     const originalContainer = state.dragData.initialGroup;
-    
-    // Mark drop as successful in ref for global listener
-    if (enableCrossContainerPreview) {
-      dragStateRef.current.dropOccurred = true;
-    }
-
-    // Gather data for callbacks BEFORE clearing state
-    const isCrossContainer = container !== originalContainer;
-    let callbackData = null;
-    
-    if (enableCrossContainerPreview) {
-      const draggedItem = stateRef.current.items.find(item => item && item.id === draggedItemId);
-      const updatedItem = draggedItem ? { ...draggedItem, container } : null;
-      const itemsInContainer = stateRef.current.items.filter(item => item && item.container === container);
-      const indexInContainer = itemsInContainer.findIndex(item => item && item.id === draggedItemId);
-      const itemAbove = indexInContainer > 0 ? itemsInContainer[indexInContainer - 1] : null;
-      const itemBelow = indexInContainer < itemsInContainer.length - 1 ? itemsInContainer[indexInContainer + 1] : null;
-      
-      callbackData = { updatedItem, itemAbove, itemBelow };
-    }
 
     dispatch({ type: 'SET_IS_DRAGGING', payload: "" });
     dispatch({ type: 'SET_ACTIVE_CONTAINER', payload: "" });
-    dispatch({ type: 'SET_DRAG_DATA', payload: { id: "", initialGroup: "", originId: "" } });
     changeCategory(state.dragData.id, container);
-    
     if (onDrop) {
       if (!enableCrossContainerPreview) {
         onDrop(container);
       } else {
+        const draggedItem = state.items.find(item => item && item.id === draggedItemId);
+        const updatedItem = draggedItem ? { ...draggedItem, container } : null;
+        
+        const itemsInContainer = state.items.filter(item => item && item.container === container);
+        const indexInContainer = itemsInContainer.findIndex(item => item && item.id === draggedItemId);
+        const itemAbove = indexInContainer > 0 ? itemsInContainer[indexInContainer - 1] : null;
+        const itemBelow = indexInContainer < itemsInContainer.length - 1 ? itemsInContainer[indexInContainer + 1] : null;
+        
         onDrop(
           draggedItemId,
           container,
           originalContainer,
-          callbackData.updatedItem,
-          callbackData.itemAbove,
-          callbackData.itemBelow
+          updatedItem,
+          itemAbove,
+          itemBelow
         );
       }
     }
-    
-    // Trigger onDragEnd ONLY for cross-container drops (dragend doesn't fire reliably in that case)
-    // For same-container drops, handleDragEnd will be called normally
-    if (enableCrossContainerPreview && isCrossContainer && onDragEnd && callbackData) {
-      onDragEnd(
-        draggedItemId,
-        container,
-        originalContainer,
-        callbackData.itemAbove,
-        callbackData.itemBelow
-      );
-    }
   };
 
   const handleDragOver = (e: Event, container: string) => {
@@ -580,8 +281,6 @@ export const DraggableProvider = ({
           type: "MOVE_TO_CONTAINER_END",
           payload: { dragId: state.dragData.id, newContainer: container },
         });
-        // Update current container in ref
-        dragStateRef.current.currentContainer = container;
       }
     }
 

data/app/pb_kits/playbook/pb_draggable/context/types.ts

@@ -23,7 +23,7 @@ export type ActionType =
   | { type: 'REORDER_ITEMS'; payload: { dragId: string; targetId: string } }
   | { type: 'REORDER_ITEMS_CROSS_CONTAINER'; payload: { dragId: string; targetId: string; newContainer: string } }
   | { type: 'MOVE_TO_CONTAINER_END'; payload: { dragId: string; newContainer: string } }
-  | { type: 'RESET_DRAG_CONTAINER'; payload: { itemId: string; originalContainer: string, originalIndex: number } };
+  | { type: 'RESET_DRAG_CONTAINER'; payload: { itemId: string; originalContainer: string } };
 
   export interface DropZoneConfig {
     type?: 'ghost' | 'outline' | 'shadow' | 'line';

data/app/pb_kits/playbook/pb_filter/Filter/FilterBackground.tsx

@@ -6,10 +6,10 @@ import { GlobalProps, globalProps } from '../../utilities/globalProps'
 import Card from '../../pb_card/_card'
 
 export type FilterBackgroundProps = {
-  background?: boolean,
-  className?: string,
+  background: boolean,
+  className: string,
   children?: React.ReactChild[] | React.ReactChild,
-  dark?: boolean,
+  dark: boolean,
 } & GlobalProps
 
 const FilterBackground = (props: FilterBackgroundProps): React.ReactElement => {

data/app/pb_kits/playbook/pb_legend/_legend.tsx

@@ -1,8 +1,9 @@
-import React from 'react'
+import React, { useEffect } from 'react'
 import classnames from 'classnames'
 
 import { buildAriaProps, buildCss, buildDataProps, buildHtmlProps } from '../utilities/props'
 import { globalProps } from '../utilities/globalProps'
+import { deprecatedKitWarning } from '../utilities/deprecated'
 
 import Body from '../pb_body/_body'
 import Title from '../pb_title/_title'
@@ -32,6 +33,11 @@ const Legend = (props: LegendProps) => {
     text,
   } = props
 
+  useEffect(() => {
+    console.log('TESTING ------------------------')
+    deprecatedKitWarning('Legend')
+  }, [])
+
   const ariaProps = buildAriaProps(aria)
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)

data/app/pb_kits/playbook/pb_radio/docs/_radio_error.md

@@ -1 +1 @@
-Error shows that the radio option must be selected or is invalid (i.e. when used in a form it signals a user to fix an error).
+Error shows that the radio option must be selected or is invalid (ie when used in a form it signals a user to fix an error).

data/app/pb_kits/playbook/pb_select/_select.tsx

@@ -29,7 +29,6 @@ type SelectProps = {
   id?: string,
   includeBlank?: string,
   inline?: boolean,
-  inputOptions?: {[key: string]: string | number | boolean | (() => void)},
   label?: string,
   margin: string,
   marginBottom: string,
@@ -64,7 +63,6 @@ const Select = ({
   label,
   htmlOptions = {},
   inline = false,
-  inputOptions = {},
   multiple = false,
   name,
   onChange = () => undefined,
@@ -96,17 +94,14 @@ const Select = ({
   const angleDown = getAllIcons()["angleDown"].icon as unknown as { [key: string]: SVGElement }
 
   const selectWrapperClass = classnames(buildCss('pb_select_kit_wrapper'), { error }, className)
-  const selectId = (inputOptions?.id as string) || name
-
   const selectBody =(() =>{
     if (children) return children
     return (
       <select
           {...htmlOptions}
           {...domSafeProps(props)}
-          {...inputOptions}
           disabled={disabled}
-          id={selectId}
+          id={name}
           multiple={multiple}
           name={name}
           onChange={onChange}
@@ -130,7 +125,7 @@ const Select = ({
       {label &&
         <label
             className="pb_select_kit_label"
-            htmlFor={selectId}
+            htmlFor={name}
         >
           <Caption 
               dark={props.dark}
@@ -140,7 +135,7 @@ const Select = ({
       }
       <label
           className={selectWrapperClass}
-          htmlFor={selectId}
+          htmlFor={name}
       >
         {selectBody}
         { multiple !== true ?

data/app/pb_kits/playbook/pb_select/docs/_select_error.md

@@ -1 +1 @@
-Select w/ Error shows that an option must be selected or is invalid (i.e. when used in a form it signals a user to fix an error).
+Select w/ Error shows that the radio option must be selected or is invalid (ie when used in a form it signals a user to fix an error).

data/app/pb_kits/playbook/pb_select/docs/example.yml

@@ -15,7 +15,6 @@ examples:
   - select_inline_compact: Select Inline Compact
   - select_attributes: Select W/ Attributes
   - select_multiple: Select Multiple
-  - select_input_options: Input Options
 
 
 
@@ -34,7 +33,6 @@ examples:
   - select_inline_compact: Select Inline Compact
   - select_multiple: Select Multiple
   - select_react_hook: React Hook
-  - select_input_options: Input Options
 
   swift:
   - select_default_swift: Default

data/app/pb_kits/playbook/pb_select/docs/index.js

@@ -12,4 +12,3 @@ export { default as SelectInlineCompact } from './_select_inline_compact.jsx'
 export { default as SelectMultiple } from './_select_multiple.jsx'
 export { default as SelectReactHook } from './_select_react_hook.jsx'
 export { default as SelectCustomSelectSubheaders } from './_select_custom_select_subheaders.jsx'
-export { default as SelectInputOptions } from './_select_input_options.jsx'

data/app/pb_kits/playbook/pb_select/select.html.erb

@@ -2,11 +2,11 @@
   id: nil,
   class: object.classnames ) do %>
   <% if object.label %>
-    <label class="pb_select_kit_label" for="<%= object.input_options[:id] || object.name %>">
+    <label class="pb_select_kit_label" for="<%= object.name %>">
       <%= pb_rails("caption", props: { text: object.label, dark: object.dark }) %>
     </label>
   <% end %>
-  <label class="<%= object.select_wrapper_class %>" for="<%= object.input_options[:id] || object.name %>">
+  <label class="<%= object.select_wrapper_class %>" for="<%= object.name %>">
     <% if content.present? %>
       <%= content %>
       <%= pb_rails("body", props: { status: "negative", text: object.error }) %>

data/app/pb_kits/playbook/pb_select/select.rb

@@ -14,8 +14,6 @@ module Playbook
       prop :error
       prop :include_blank
       prop :inline, type: Playbook::Props::Boolean, default: false
-      prop :input_options, type: Playbook::Props::HashProp,
-                           default: {}
       prop :label
       prop :multiple, type: Playbook::Props::Boolean, default: false
       prop :name
@@ -40,7 +38,7 @@ module Playbook
           multiple: multiple,
           onchange: onchange,
           include_blank: include_blank,
-        }.merge(attributes).merge(input_options)
+        }.merge(attributes)
       end
 
       def classname

data/app/pb_kits/playbook/pb_select/select.test.js

@@ -65,27 +65,4 @@ test('returns multiple variant', () => {
   const selectElement = kit.querySelector('select');
 
   expect(selectElement).toHaveAttribute('multiple', '');
-});
-
-test('inputOptions are passed to select element', () => {
-  render(
-    <Select
-        data={{ testid: testId }}
-        inputOptions={{
-          id: 'custom-select-id',
-          className: 'custom-select-class',
-          'aria-label': 'Custom aria label',
-        }}
-        label="Favorite Food"
-        name="food"
-        options={options}
-    />
-  )
-
-  const kit = screen.getByTestId(testId)
-  const selectElement = kit.querySelector('select')
-
-  expect(selectElement).toHaveAttribute('id', 'custom-select-id')
-  expect(selectElement).toHaveClass('custom-select-class')
-  expect(selectElement).toHaveAttribute('aria-label', 'Custom aria label')
 });