playbook_ui 15.4.0.pre.alpha.testing6712538 → 15.4.0.pre.alpha.testingseparation12395

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba3c087c2d2427377e05cc7552c2e72b2ed5f661d5e68fb41e4b476878cb299e
-  data.tar.gz: bda64fa599febb5aa7720b356a36c4a8eeb8932f35107261e200213c5e998355
+  metadata.gz: d624bbeb1e46932cd1e856f16b68be71e5dcfdfa453efd9fa039041de3cdf479
+  data.tar.gz: ba1d653a0fd61df21f526b94f5142f29a10696a0a09e6336e27192d54dd1e3c5
 SHA512:
-  metadata.gz: 6e5969dfec2524550306d50dff0d360efcb10a851b0016cbae743cea3554226a90721f79455c1088f58506e8009ac573a72ac9e731a47252d20d36fc7a7027d9
-  data.tar.gz: 5686d6ca3e4a7fead6dc35c9333e3b7d445a5d96315fdb3bb98057f1b4f1e46aa32a908aa6f1db17f19643d2a19cfdfd4b8c5c38d468eccafe08467bc7552c5c
+  metadata.gz: 2d970af9311875357c6aeb3f0ebcd32a76ba599cffbb76703c2a9384a521b68189d33a84c5d82cb4d3bee9c2add55d334cb56a53f15422330baf7c4b1ab5a430
+  data.tar.gz: 2dd2ab0a7f9c8835de257faca45e419462626ee9d8b46326dc9707d9fa762e1579f0cbd8110904f732c3fc30b3e86db149ea2048f82802f48159d019830e4d98

data/app/pb_kits/playbook/pb_bar_graph/BarGraphStyles.scss

@@ -0,0 +1,58 @@
+@import "../tokens/colors";
+@import "../tokens/typography";
+@import url("https://code.highcharts.com/css/highcharts.css");
+
+:root {
+    --highcharts-color-0: #{$data_1};
+    --highcharts-color-1: #{$data_2};
+    --highcharts-color-2: #{$data_3};
+    --highcharts-color-3: #{$data_4};
+    --highcharts-color-4: #{$data_5};
+    --highcharts-color-5: #{$data_6};
+    --highcharts-color-6: #{$data_7};
+    --highcharts-color-7: #{$data_8};
+}
+
+.highcharts-title {
+    font-family: $font_family_base;
+    font-weight: $bold;
+    font-size: $heading_3;
+    color: $text_lt_default;
+    fill: $text_lt_default;
+}
+
+.highcharts-subtitle {
+    font-family: $font_family_base;
+    color: $text_lt_light;
+    fill: $text_lt_light;
+    font-weight: $regular;
+    font-size: $text_base;
+}
+
+.highcharts-yaxis > .highcharts-axis-title {
+    color: $text_lt_lighter;
+    fill: $text_lt_lighter;
+    font-family: $font_family_base;
+    font-weight: $bold;
+    font-size: $text_smaller;
+}
+
+.highcharts-axis-labels {
+    font-family: $font_family_base;
+    color: $text_lt_lighter;
+    fill: $text_lt_lighter;
+    font-weight: $bold;
+    font-size: $text_smaller;
+}
+
+.highcharts-grid-line {
+    stroke: $border_light;
+}
+
+.highcharts-point {
+  border-radius: 3px;
+}
+
+.highcharts-axis-line {
+  stroke: $border_light;
+}

data/app/pb_kits/playbook/pb_copy_button/_copy_button.tsx

@@ -5,7 +5,6 @@ import { globalProps } from '../utilities/globalProps'
 
 import Button from '../pb_button/_button'
 import Tooltip from '../pb_tooltip/_tooltip'
-import CircleIconButton from '../pb_circle_icon_button/_circle_icon_button'
 
 import usePBCopy from './usePBCopy'
 
@@ -19,7 +18,6 @@ type CopyButtonProps = {
   tooltipPlacement?: 'top' | 'right' | 'bottom' | 'left'
   tooltipText?: string
   value?: string
-  variant?: 'button' | 'icon'
   timeout?: number
 }
 
@@ -30,12 +28,11 @@ const CopyButton = (props: CopyButtonProps) => {
     data = {},
     from = '',
     id,
-    text = 'Copy',
+    text= 'Copy',
     timeout = 1000,
-    tooltipPlacement = 'bottom',
+    tooltipPlacement= 'bottom',
     tooltipText = 'Copied!',
     value = '',
-    variant = 'icon',
   } = props
 
   const [copied, copy] = usePBCopy({ value, from, timeout })
@@ -45,8 +42,7 @@ const CopyButton = (props: CopyButtonProps) => {
   const classes = classnames(buildCss('pb_copy_button_kit'), globalProps(props), className)
 
   return (
-    <div 
-        {...ariaProps}
+    <div {...ariaProps}
         {...dataProps}
         className={classes}
         id={id}
@@ -57,20 +53,11 @@ const CopyButton = (props: CopyButtonProps) => {
           showTooltip={false}
           text={tooltipText}
       >
-        {variant === 'icon' ? (
-          <CircleIconButton 
-              icon="copy" 
-              onClick={copy} 
-              variant="link" 
-          />
-        ) : (
-          <Button 
-              icon="copy"
-              onClick={copy}
-          >
-            {text}
-          </Button>
-        )}
+        <Button icon="copy"
+            onClick={copy}
+        >
+          {text}
+        </Button>
       </Tooltip>
     </div>
   )

data/app/pb_kits/playbook/pb_copy_button/copy_button.html.erb

@@ -1,10 +1,6 @@
 <%= pb_content_tag do %>
-    <% if object.variant == "icon" %>
-      <%= pb_rails("circle_icon_button", props: { icon: "copy", variant: "link" }) %>
-    <% else %>
-      <%= pb_rails("button", props: { icon: "copy" }) do %>
-        <%= object.text %>
-      <% end %>
+    <%= pb_rails("button", props: { icon: "copy" }) do %>
+      <%= object.text %>
     <% end %>
   <% if object.id %> 
   <%= pb_rails("tooltip", props: {

data/app/pb_kits/playbook/pb_copy_button/copy_button.rb

@@ -12,9 +12,6 @@ module Playbook
                           default: "Copied!"
       prop :value
       prop :from
-      prop :variant, type: Playbook::Props::Enum,
-                     values: %w[button icon],
-                     default: "icon"
 
       def classname
         generate_classname("pb_copy_button_kit")

data/app/pb_kits/playbook/pb_copy_button/copy_button.test.jsx

@@ -37,29 +37,6 @@ it('copies the value to clipboard and pastes it into an input', async () => {
   expect(navigator.clipboard.writeText).toHaveBeenCalledWith("copy");
 })
 
-test('passes text and tooltip props to icon variant', () => {
-  render(
-      <CopyButton
-          data={{ testid: 'text-test' }}
-          tooltipPlacement="right"
-          tooltipText="Text copied!"
-          value="copy"
-      />
-  )
-
-  const kit = screen.getByTestId('text-test')
-  const button = kit.querySelector('.pb_button_kit.pb_button_link.pb_button_inline.pb_button_enabled')
-  expect(button).toBeInTheDocument()
-
-  fireEvent.click(button)
-  const tooltipContent = screen.getByText("Text copied!")
-  expect(tooltipContent).toHaveTextContent("Text copied!")
-
-  const tooltip = kit.querySelector('.pb_tooltip_kit')
-  expect(tooltip).toBeInTheDocument()
-})
-
-
 test('passes text and tooltip props to button', () => {
   render(
       <CopyButton
@@ -68,7 +45,6 @@ test('passes text and tooltip props to button', () => {
           tooltipPlacement="right"
           tooltipText="Text copied!"
           value="copy"
-          variant="button"
       />
   )
 

data/app/pb_kits/playbook/pb_copy_button/docs/_copy_button_default.html.erb

@@ -1,2 +1,2 @@
-<%= pb_rails("copy_button", props: { id: "default-copy-button", value: "Playbook makes it easy to support bleeding edge, or legacy systems. Use Playbook’s 200+ components and end-to-end design language to create simple, intuitive and beautiful experiences with ease." } ) %>
-<%= pb_rails("textarea", props: { margin_top: "xs", placeholder: "Click the icon above to copy and paste here" }) %>
+<%= pb_rails("copy_button", props: { id: "default-copy-button", text: "Copy Text", value: "Playbook makes it easy to support bleeding edge, or legacy systems. Use Playbook’s 200+ components and end-to-end design language to create simple, intuitive and beautiful experiences with ease." } ) %>
+<%= pb_rails("textarea", props: { margin_top: "xs", placeholder: "Copy and paste here" }) %>

data/app/pb_kits/playbook/pb_copy_button/docs/_copy_button_default.jsx

@@ -7,6 +7,7 @@ const CopyButtonDefault = (props) => (
   <div>
     <CopyButton
         {...props}
+        text="Copy Text"
         tooltipPlacement="right"
         tooltipText="Text copied!"
         value="Playbook makes it easy to support bleeding edge, or legacy systems. Use Playbook’s 200+ components and end-to-end design language to create simple, intuitive and beautiful experiences with ease."
@@ -14,7 +15,7 @@ const CopyButtonDefault = (props) => (
 
     <Textarea
         {...props}
-        placeholder="Click the icon above to copy and paste here"
+        placeholder="Copy and paste here"
     />
   </div>
 )

data/app/pb_kits/playbook/pb_copy_button/docs/_copy_button_from.html.erb

@@ -1,5 +1,5 @@
 <%= pb_rails("body", props: { id: "body", text: "Copy this body text!"}) %>
-<%= pb_rails("copy_button", props: { text: "Copy Body text", from: "body", id: "copy-body-button", variant: "button" }) %>
+<%= pb_rails("copy_button", props: { text: "Copy Body text", from: "body", id: "copy-body-button" }) %>
 <%= pb_rails("text_input", props: { margin_top: "xs", placeholder: "Copy and paste here" }) %>
-<%= pb_rails("copy_button", props: { text: "Copy Text Input", from: "copy-input", id: "copy-input-button", variant: "button" }) %>
+<%= pb_rails("copy_button", props: { text: "Copy Text Input", from: "copy-input", id: "copy-input-button" }) %>
 <%= pb_rails("text_input", props: { margin_top: "xs", id: "copy-input" , value: "Copy and paste here" }) %>

data/app/pb_kits/playbook/pb_copy_button/docs/_copy_button_from.jsx

@@ -21,7 +21,6 @@ const CopyButtonFrom = (props) => {
         text="Copy Body text"
         tooltipPlacement="right"
         tooltipText="Body text copied!"
-        variant="button"
     />
 
     <TextInput
@@ -37,7 +36,6 @@ const CopyButtonFrom = (props) => {
         text="Copy Text Input"
         tooltipPlacement="right"
         tooltipText="Text input copied!"
-        variant="button"
     />
 
     <Textarea

data/app/pb_kits/playbook/pb_copy_button/docs/example.yml

@@ -1,12 +1,10 @@
 examples:
   rails:
   - copy_button_default: Default
-  - copy_button_button_variant: Button Variant
   - copy_button_from: Copy From
   - copy_button_hook_rails: Copy Hook
   
   react:
   - copy_button_default: Default
-  - copy_button_button_variant: Button Variant
   - copy_button_from: Copy From
   - copy_button_hook: Copy Hook

data/app/pb_kits/playbook/pb_copy_button/docs/index.js

@@ -1,4 +1,3 @@
 export { default as CopyButtonDefault } from './_copy_button_default.jsx'
 export { default as CopyButtonFrom } from './_copy_button_from.jsx' 
 export { default as CopyButtonHook } from './_copy_button_hook.jsx'
-export { default as CopyButtonButtonVariant } from './_copy_button_button_variant.jsx'

data/app/pb_kits/playbook/pb_date_time/_date_time.tsx

@@ -17,7 +17,6 @@ type DateTimeProps = {
   htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
   id?: string,
   size?: "sm" | "md",
-  showCurrentYear?: boolean,
   showDayOfWeek: boolean,
   showIcon?: boolean,
   timeZone?: string
@@ -33,7 +32,6 @@ const DateTime = (props: DateTimeProps): React.ReactElement => {
     showDayOfWeek = false,
     datetime,
     id,
-    showCurrentYear = false,
     showIcon = false,
     size = 'md',
     timeZone = 'America/New_York',
@@ -61,7 +59,6 @@ const DateTime = (props: DateTimeProps): React.ReactElement => {
           vertical="baseline"
       >
         <FormattedDate
-            showCurrentYear={showCurrentYear}
             showDayOfWeek={showDayOfWeek}
             size={size}
             value={datetime}

data/app/pb_kits/playbook/pb_date_time/date_time.html.erb

@@ -9,7 +9,6 @@
         dark: object.dark,
         date: object.date,
         show_day_of_week: object.show_day_of_week,
-        show_current_year: object.show_current_year,
         size: object.size,
         timezone: object.timezone,
       }) %>

data/app/pb_kits/playbook/pb_date_time/date_time.rb

@@ -16,7 +16,6 @@ module Playbook
       prop :dark, type: Playbook::Props::Boolean, default: false
       prop :show_icon, type: Playbook::Props::Boolean, default: false
       prop :show_day_of_week, type: Playbook::Props::Boolean, default: false
-      prop :show_current_year, type: Playbook::Props::Boolean, default: false
 
       def classname
         generate_classname("pb_date_time_kit", align)

data/app/pb_kits/playbook/pb_date_time/docs/example.yml

@@ -1,16 +1,14 @@
 examples:
-
+  
   rails:
   - date_time_default: Default
   - date_time_align: Alignment
   - date_time_size: Size
-  - date_time_show_current_year: Show Current Year
 
   react:
   - date_time_default: Default
   - date_time_align: Alignment
   - date_time_size: Size
-  - date_time_show_current_year: Show Current Year
 
   swift:
   - date_time_default_swift: Default

data/app/pb_kits/playbook/pb_date_time/docs/index.js

@@ -1,4 +1,3 @@
 export { default as DateTimeDefault } from './_date_time_default.jsx'
 export { default as DateTimeAlign } from './_date_time_align.jsx'
 export { default as DateTimeSize } from './_date_time_size.jsx'
-export { default as DateTimeShowCurrentYear } from './_date_time_show_current_year.jsx'

data/app/pb_kits/playbook/pb_date_time_stacked/_date_time_stacked.tsx

@@ -17,7 +17,6 @@ type DateTimeStackedProps = {
   datetime: Date,
   dark: boolean,
   timeZone?: string,
-  showCurrentYear?: boolean,
 }
 
 const DateTimeStacked = (props: DateTimeStackedProps): React.ReactElement => {
@@ -29,7 +28,6 @@ const DateTimeStacked = (props: DateTimeStackedProps): React.ReactElement => {
     dark,
     htmlOptions = {},
     timeZone = 'America/New_York',
-    showCurrentYear = false,
   } = props
 
   const classes = buildCss('pb_date_time_stacked_kit', globalProps(props))
@@ -48,7 +46,6 @@ const DateTimeStacked = (props: DateTimeStackedProps): React.ReactElement => {
             bold
             dark={dark}
             date={date || datetime}
-            showCurrentYear={showCurrentYear}
         />
       </FlexItem>
 

data/app/pb_kits/playbook/pb_date_time_stacked/date_time_stacked.html.erb

@@ -1,8 +1,8 @@
-  <%= pb_content_tag do %>
+<%= pb_content_tag do %>
 
   <%= pb_rails("flex", props: {classname: "flex-container", vertical: "stretch"}) do %>
       <%= pb_rails("body", props: {classname: "flex-item"}) do %>
-        <%= pb_rails("date_stacked", props: { date: object.date_time_value, size: "sm", align: "right", bold: true, dark: object.dark, show_current_year: object.show_current_year }) %>
+        <%= pb_rails("date_stacked", props: { date: object.date_time_value, size: "sm", align: "right", bold: true, dark: object.dark }) %>
       <% end %>
       <%= pb_rails("section_separator", props: { orientation: "vertical", classname: "date-time-padding" }) %>
       <%= pb_rails("body", props: {classname: "flex-item"}) do %>

data/app/pb_kits/playbook/pb_date_time_stacked/date_time_stacked.rb

@@ -10,8 +10,6 @@ module Playbook
                   default: false
       prop :timezone, type: Playbook::Props::String,
                       default: "America/New_York"
-      prop :show_current_year, type: Playbook::Props::Boolean,
-                               default: false
 
       def date_time_value
         date || date_time

data/app/pb_kits/playbook/pb_date_time_stacked/date_time_stacked.test.js

@@ -41,36 +41,3 @@ test('renders time in timezone', () => {
   const kit = renderKit(DateTimeStacked, props)
   expect(kit).toHaveTextContent(`${monthDayYear}11:00aMDT`)
 })
-
-test('renders current year when showCurrentYear is true', () => {
-  const currentYearDate = new Date()
-  const currentYear = currentYearDate.getFullYear()
-  
-  const kit = renderKit(DateTimeStacked, {
-    data: { testid: 'datetimestacked-current-year' },
-    datetime: currentYearDate,
-    dark: false,
-    showCurrentYear: true,
-  })
-  expect(kit).toHaveTextContent(currentYear.toString())
-})
-
-test('hides current year by default', () => {
-  const currentYearDate = new Date()
-  const currentYear = currentYearDate.getFullYear()
-  
-  const kit = renderKit(DateTimeStacked, {
-    data: { testid: 'datetimestacked-hide-year' },
-    datetime: currentYearDate,
-    dark: false,
-  })
- 
-  const yearElement = kit.querySelector('.pb_caption_kit_xs')
-
-  if (yearElement) {
-    expect(yearElement.textContent).not.toBe(currentYear.toString())
-  } else {
-
-    expect(yearElement).toBeNull()
-  }
-})

data/app/pb_kits/playbook/pb_date_time_stacked/docs/example.yml

@@ -2,11 +2,9 @@ examples:
 
   rails:
   - date_time_stacked_default: Default
-  - date_time_stacked_show_current_year: Show Current Year
-
+  
   react:
   - date_time_stacked_default: Default
-  - date_time_stacked_show_current_year: Show Current Year
   
   swift:
   - date_time_stacked_default_swift: Default

data/app/pb_kits/playbook/pb_date_time_stacked/docs/index.js

@@ -1,2 +1 @@
 export { default as DateTimeStackedDefault } from './_date_time_stacked_default.jsx'
-export { default as DateTimeStackedShowCurrentYear } from './_date_time_stacked_show_current_year.jsx'

data/app/pb_kits/playbook/pb_dropdown/index.js

@@ -33,8 +33,6 @@ export default class PbDropdown extends PbEnhancedElement {
     this.formPillProps = this.element.dataset.formPillProps
       ? JSON.parse(this.element.dataset.formPillProps)
       : {};
-    const baseInput = this.element.querySelector(DROPDOWN_INPUT);
-    this.wasOriginallyRequired = baseInput && baseInput.hasAttribute("required");
     this.setDefaultValue();
     this.bindEventListeners();
     this.bindSearchInput();
@@ -358,6 +356,17 @@ export default class PbDropdown extends PbEnhancedElement {
   }
 
   clearFormValidation(input) {
+    if (input.checkValidity()) {
+      const dropdownWrapperElement = input.closest(".dropdown_wrapper");
+      dropdownWrapperElement.classList.remove("error");
+
+      const errorLabelElement = dropdownWrapperElement.querySelector(
+        ".pb_body_kit_negative"
+      );
+      if (errorLabelElement) {
+        errorLabelElement.remove();
+      }
+    }
     if (this.isMultiSelect) {
       if (this.selectedOptions.size > 0) {
         const dropdownWrapperElement = input.closest(".dropdown_wrapper");
@@ -368,19 +377,6 @@ export default class PbDropdown extends PbEnhancedElement {
         if (errorLabelElement) {
           errorLabelElement.remove();
         }
-        return;
-      }
-    }
-    
-    if (input.checkValidity()) {
-      const dropdownWrapperElement = input.closest(".dropdown_wrapper");
-      dropdownWrapperElement.classList.remove("error");
-
-      const errorLabelElement = dropdownWrapperElement.querySelector(
-        ".pb_body_kit_negative"
-      );
-      if (errorLabelElement) {
-        errorLabelElement.remove();
       }
     }
   }
@@ -589,9 +585,7 @@ export default class PbDropdown extends PbEnhancedElement {
     // for multi_select, for each selectedOption, create a hidden input
     const name = baseInput.getAttribute("name");
     this.selectedOptions.forEach((raw) => {
-      const optionData = JSON.parse(raw);
-      // Use id if available, otherwise fall back to value
-      const id = optionData.id || optionData.value;
+      const id = JSON.parse(raw).id;
       const inp = document.createElement("input");
       inp.type = "hidden";
       inp.name = name;
@@ -599,19 +593,7 @@ export default class PbDropdown extends PbEnhancedElement {
       inp.dataset.generated = "true";
       baseInput.insertAdjacentElement("afterend", inp);
     });
-    
-    // For multi-select, remove required from base input when there are selections
-    // The generated inputs handle the form submission with actual values
-    // Restore required attribute when there are no selections (if it was originally required)
-    if (this.selectedOptions.size > 0) {
-      baseInput.value = "";
-      baseInput.removeAttribute("required");
-    } else {
-      baseInput.value = "";
-      if (this.wasOriginallyRequired) {
-        baseInput.setAttribute("required", "");
-      }
-    }
+    baseInput.value = "";
   }
 
   handleBackspaceClear() {