playbook_ui 15.3.0.pre.alpha.play259311731 → 15.3.0.pre.alpha.play262912095

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (93) hide show
  1. checksums.yaml +4 -4
  2. data/app/pb_kits/playbook/pb_advanced_table/Components/RegularTableView.tsx +2 -1
  3. data/app/pb_kits/playbook/pb_advanced_table/Hooks/useTableState.ts +15 -0
  4. data/app/pb_kits/playbook/pb_advanced_table/Utilities/RowUtils.ts +1 -1
  5. data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.scss +4 -4
  6. data/app/pb_kits/playbook/pb_advanced_table/advanced_table.test.jsx +68 -5
  7. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_background_control_rails.html.erb +4 -0
  8. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_background_control_rails.md +1 -1
  9. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_border_color.md +1 -1
  10. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_border_color_rails.md +1 -1
  11. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_styling.jsx +3 -1
  12. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_styling.md +2 -0
  13. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_styling_column_headers.jsx +1 -1
  14. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_styling_rails.html.erb +1 -0
  15. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_column_styling_rails.md +2 -0
  16. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_padding_control.jsx +9 -1
  17. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_padding_control.md +1 -1
  18. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_pagination_with_props.jsx +4 -1
  19. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_pagination_with_props.md +3 -2
  20. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_sticky_columns_and_header.md +1 -1
  21. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_table_props_sticky_header_rails.md +1 -1
  22. data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_table_props_sticky_header_react.md +1 -1
  23. data/app/pb_kits/playbook/pb_advanced_table/flat_advanced_table.js +2 -2
  24. data/app/pb_kits/playbook/pb_advanced_table/index.js +7 -7
  25. data/app/pb_kits/playbook/pb_advanced_table/scss_partials/advanced_table_sticky_mixin.scss +2 -2
  26. data/app/pb_kits/playbook/pb_advanced_table/table_row.rb +32 -3
  27. data/app/pb_kits/playbook/pb_background/background.html.erb +10 -2
  28. data/app/pb_kits/playbook/pb_background/docs/_background_category.md +1 -1
  29. data/app/pb_kits/playbook/pb_card/docs/_card_background.md +1 -1
  30. data/app/pb_kits/playbook/pb_card/docs/_card_header.md +1 -1
  31. data/app/pb_kits/playbook/pb_card/docs/_card_highlight.md +1 -1
  32. data/app/pb_kits/playbook/pb_card/docs/_card_light.md +1 -1
  33. data/app/pb_kits/playbook/pb_currency/_currency.tsx +20 -7
  34. data/app/pb_kits/playbook/pb_currency/currency.rb +35 -8
  35. data/app/pb_kits/playbook/pb_currency/currency.test.js +47 -0
  36. data/app/pb_kits/playbook/pb_currency/docs/_currency_variants.html.erb +1 -1
  37. data/app/pb_kits/playbook/pb_currency/docs/_currency_variants.jsx +1 -1
  38. data/app/pb_kits/playbook/pb_currency/docs/_currency_variants.md +1 -0
  39. data/app/pb_kits/playbook/pb_date_picker/date_picker.rb +2 -0
  40. data/app/pb_kits/playbook/pb_distribution_bar/docs/_distribution_bar_custom_colors.md +1 -1
  41. data/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_with_custom_active_style_options_react.md +1 -1
  42. data/app/pb_kits/playbook/pb_filter/docs/_filter_max_width.md +1 -1
  43. data/app/pb_kits/playbook/pb_form_pill/docs/_form_pill_truncated_text_rails.md +1 -1
  44. data/app/pb_kits/playbook/pb_form_pill/docs/_form_pill_truncated_text_react.md +1 -1
  45. data/app/pb_kits/playbook/pb_icon/docs/_icon_color.md +1 -1
  46. data/app/pb_kits/playbook/pb_icon_circle/docs/_icon_circle_color.md +1 -1
  47. data/app/pb_kits/playbook/pb_icon_stat_value/docs/_icon_stat_value_color.html.erb +7 -14
  48. data/app/pb_kits/playbook/pb_icon_stat_value/docs/_icon_stat_value_color.jsx +6 -15
  49. data/app/pb_kits/playbook/pb_layout/docs/_layout_collection.md +1 -1
  50. data/app/pb_kits/playbook/pb_nav/docs/_collapsible_nav_item_spacing.md +1 -1
  51. data/app/pb_kits/playbook/pb_nav/docs/_nav_with_spacing_control.md +1 -1
  52. data/app/pb_kits/playbook/pb_overlay/docs/_overlay_layout.md +1 -1
  53. data/app/pb_kits/playbook/pb_pill/docs/_description.md +1 -1
  54. data/app/pb_kits/playbook/pb_popover/_popover.tsx +69 -34
  55. data/app/pb_kits/playbook/pb_popover/docs/_popover_append_to.jsx +68 -0
  56. data/app/pb_kits/playbook/pb_popover/docs/_popover_append_to_react.md +1 -0
  57. data/app/pb_kits/playbook/pb_popover/docs/example.yml +1 -0
  58. data/app/pb_kits/playbook/pb_popover/docs/index.js +1 -0
  59. data/app/pb_kits/playbook/pb_popover/popover.test.js +80 -0
  60. data/app/pb_kits/playbook/pb_rich_text_editor/docs/_description.md +1 -1
  61. data/app/pb_kits/playbook/pb_section_separator/docs/_description.md +1 -1
  62. data/app/pb_kits/playbook/pb_selectable_card/_selectable_card.scss +29 -0
  63. data/app/pb_kits/playbook/pb_skeleton_loading/docs/_skeleton_loading_border_radius_rails.md +1 -1
  64. data/app/pb_kits/playbook/pb_skeleton_loading/docs/_skeleton_loading_border_radius_react.md +1 -1
  65. data/app/pb_kits/playbook/pb_skeleton_loading/docs/_skeleton_loading_layout.md +1 -1
  66. data/app/pb_kits/playbook/pb_table/docs/_table_side_highlight.md +1 -1
  67. data/app/pb_kits/playbook/pb_table/docs/_table_sm.md +1 -1
  68. data/app/pb_kits/playbook/pb_table/docs/_table_with_dynamic_collapsible.html.erb +63 -0
  69. data/app/pb_kits/playbook/pb_table/docs/_table_with_dynamic_collapsible.jsx +89 -0
  70. data/app/pb_kits/playbook/pb_table/docs/_table_with_dynamic_collapsible_rails.md +4 -0
  71. data/app/pb_kits/playbook/pb_table/docs/_table_with_dynamic_collapsible_react.md +3 -0
  72. data/app/pb_kits/playbook/pb_table/docs/example.yml +2 -0
  73. data/app/pb_kits/playbook/pb_table/docs/index.js +1 -0
  74. data/app/pb_kits/playbook/pb_text_input/text_input.rb +2 -2
  75. data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_custom_options.html.erb +2 -2
  76. data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_custom_options.jsx +1 -1
  77. data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_custom_options.md +1 -1
  78. data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_default_options.html.erb +67 -1
  79. data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_default_value.jsx +68 -6
  80. data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_truncated_text.md +1 -1
  81. data/app/pb_kits/playbook/pb_typeahead/docs/example.yml +2 -2
  82. data/dist/chunks/{_line_graph-CUts2R88.js → _line_graph-CqE0-dq5.js} +1 -1
  83. data/dist/chunks/_typeahead-3ZAbZUqU.js +6 -0
  84. data/dist/chunks/{_weekday_stacked-GooEyiGT.js → _weekday_stacked-W1kKx2Gl.js} +2 -2
  85. data/dist/chunks/vendor.js +1 -1
  86. data/dist/playbook-doc.js +2 -2
  87. data/dist/playbook-rails-react-bindings.js +1 -1
  88. data/dist/playbook-rails.js +1 -1
  89. data/dist/playbook.css +1 -1
  90. data/lib/playbook/version.rb +1 -1
  91. metadata +13 -6
  92. data/dist/chunks/_typeahead--U_6fwUM.js +0 -6
  93. /data/app/pb_kits/playbook/pb_popover/docs/{_popover_append_to.md → _popover_append_to_rails.md} +0 -0
@@ -17,8 +17,7 @@ module Playbook
17
17
  prop :symbol, type: Playbook::Props::String,
18
18
  default: "$"
19
19
 
20
- prop :amount, type: Playbook::Props::String,
21
- required: true
20
+ prop :amount, required: true
22
21
 
23
22
  prop :unit, type: Playbook::Props::String,
24
23
  required: false
@@ -92,7 +91,7 @@ module Playbook
92
91
  end
93
92
 
94
93
  def negative_sign
95
- amount.starts_with?("-") && swap_negative ? "-" : ""
94
+ currency_amount.starts_with?("-") && swap_negative ? "-" : ""
96
95
  end
97
96
 
98
97
  def body_props
@@ -117,10 +116,32 @@ module Playbook
117
116
  end
118
117
  end
119
118
 
119
+ def currency_amount
120
+ @currency_amount ||= convert_amount(amount)
121
+ end
122
+
120
123
  private
121
124
 
125
+ # Convert numeric input to string format
126
+ def convert_amount(input)
127
+ if input.is_a?(Numeric)
128
+ if input.zero? && null_display.nil?
129
+ ""
130
+ else
131
+ format("%.2f", input)
132
+ end
133
+ # Handle string representations of zero
134
+ elsif input.to_s.strip.match?(/^-?0+(\.0+)?$/) && null_display.nil?
135
+ ""
136
+ else
137
+ input.to_s
138
+ end
139
+ end
140
+
122
141
  def whole_value
123
- value = amount.split(".").first
142
+ return "" if currency_amount.blank?
143
+
144
+ value = currency_amount.split(".").first
124
145
  if comma_separator
125
146
  number_with_delimiter(value.gsub(",", ""))
126
147
  else
@@ -129,7 +150,9 @@ module Playbook
129
150
  end
130
151
 
131
152
  def decimal_value
132
- amount.split(".")[1] || "00"
153
+ return "00" if currency_amount.blank?
154
+
155
+ currency_amount.split(".")[1] || "00"
133
156
  end
134
157
 
135
158
  def units_element
@@ -147,7 +170,9 @@ module Playbook
147
170
  end
148
171
 
149
172
  def abbreviated_value(index = 0..-2)
150
- value = amount.split(".").first.gsub(",", "").to_i
173
+ return "" if currency_amount.blank?
174
+
175
+ value = currency_amount.split(".").first.gsub(",", "").to_i
151
176
  abbreviated_num = number_to_human(value, units: { thousand: "K", million: "M", billion: "B", trillion: "T" }).gsub(/\s+/, "")
152
177
  abbreviated_num[index]
153
178
  end
@@ -174,9 +199,11 @@ module Playbook
174
199
 
175
200
  if decimals == "matching"
176
201
  if comma_separator
177
- number_with_delimiter(amount.gsub(",", ""))
202
+ return "" if currency_amount.blank?
203
+
204
+ number_with_delimiter(currency_amount.gsub(",", ""))
178
205
  else
179
- amount
206
+ currency_amount
180
207
  end
181
208
  else
182
209
  whole_value
@@ -133,3 +133,50 @@ test('handles negative amounts correctly', () => {
133
133
  expect(screen.getByTestId('test-negative-no-symbol')).toHaveTextContent('-400.50')
134
134
  expect(screen.getByTestId('test-negative-medium-size')).toHaveTextContent('$-500.55')
135
135
  })
136
+
137
+ test('handles numeric amounts correctly', () => {
138
+ render(
139
+ <>
140
+ <Currency
141
+ amount={320}
142
+ data={{ testid: 'test-numeric-default' }}
143
+ />
144
+ <Currency
145
+ abbreviate
146
+ amount={3200000}
147
+ data={{ testid: 'test-numeric-millions' }}
148
+ />
149
+ <Currency
150
+ amount={123456.78}
151
+ commaSeparator
152
+ data={{ testid: 'test-numeric-comma-decimals' }}
153
+ />
154
+ <Currency
155
+ amount={400.50}
156
+ data={{ testid: 'test-numeric-no-symbol' }}
157
+ symbol=""
158
+ />
159
+ <Currency
160
+ amount={500.55}
161
+ data={{ testid: 'test-numeric-medium-size' }}
162
+ size="md"
163
+ />
164
+ <Currency
165
+ amount={-600.70}
166
+ data={{ testid: 'test-numeric-negative' }}
167
+ />
168
+ <Currency
169
+ amount={0.00}
170
+ data={{ testid: 'test-numeric-null' }}
171
+ />
172
+ </>
173
+ )
174
+
175
+ expect(screen.getByTestId('test-numeric-default')).toHaveTextContent('$320')
176
+ expect(screen.getByTestId('test-numeric-millions')).toHaveTextContent('$3.2M')
177
+ expect(screen.getByTestId('test-numeric-comma-decimals')).toHaveTextContent('$123,456.78')
178
+ expect(screen.getByTestId('test-numeric-no-symbol')).toHaveTextContent('400.50')
179
+ expect(screen.getByTestId('test-numeric-medium-size')).toHaveTextContent('$500.55')
180
+ expect(screen.getByTestId('test-numeric-negative')).toHaveTextContent('-$600.70')
181
+ expect(screen.getByTestId('test-numeric-null')).toHaveTextContent('$.00')
182
+ })
@@ -7,7 +7,7 @@
7
7
  }) %>
8
8
 
9
9
  <%= pb_rails("currency", props: {
10
- amount: "342",
10
+ amount: 342,
11
11
  label: "Light",
12
12
  margin_bottom: "md",
13
13
  size: "sm",
@@ -14,7 +14,7 @@ const CurrencyVariants = (props) => {
14
14
  {...props}
15
15
  />
16
16
  <Currency
17
- amount="342"
17
+ amount={342}
18
18
  label="Light"
19
19
  marginBottom="md"
20
20
  size="sm"
@@ -0,0 +1 @@
1
+ **NOTE:** The value passed into the `amount` prop can be either a string or numeric value.
@@ -85,6 +85,8 @@ module Playbook
85
85
  default: ""
86
86
  prop :sync_end_with, type: Playbook::Props::String,
87
87
  default: ""
88
+ prop :cursor, type: Playbook::Props::String,
89
+ default: "pointer"
88
90
 
89
91
  def classname
90
92
  default_margin_bottom = margin_bottom.present? ? "" : " mb_sm"
@@ -1 +1 @@
1
- You can customize the order of the colors you would like to use by using the `colors` prop. Only the data and status colors will work for Playbook charts. See the [design page](/visual_guidelines) for reference.
1
+ You can customize the order of the colors you would like to use by using the `colors` prop. Only the data and status colors will work for Playbook charts. See the [design page](https://playbook.powerapp.cloud/token/colors) for reference.
@@ -1,4 +1,4 @@
1
1
  The `activeStyle` prop can be used to customize the appearance of the dropdown selection indicator. It accepts an object with the following keys: `backgroundColor` sets the background color of the selected item (and its hover state); `fontColor` sets the font color of the selected item.
2
2
 
3
3
  `backgroundColor` **Type**: String | **Values**: bg_light | white | **Default**: (no selection) is primary
4
- `fontColor` **Type**: String | **Values**: primary | all [Playbook Text Colors](https://playbook.powerapp.cloud/visual_guidelines/colors) | **Default**: (no selection) is white
4
+ `fontColor` **Type**: String | **Values**: primary | all [Playbook Text Colors](https://playbook.powerapp.cloud/global_props/colors) | **Default**: (no selection) is white
@@ -1 +1 @@
1
- Filter can leverage the max-width property. Learn more in our <a href="https://playbook.powerapp.cloud/visual_guidelines" target="_blank">visual guidelines.</a>
1
+ Filter can leverage the max-width property. Learn more in our <a href="https://playbook.powerapp.cloud/global_props/max_width" target="_blank">visual guidelines.</a>
@@ -1,3 +1,3 @@
1
- For Form Pills with longer text, the truncate global prop can be used to truncate the label within each Form Pill. See [here](https://playbook.powerapp.cloud/visual_guidelines/truncate) for more information on the truncate global prop.
1
+ For Form Pills with longer text, the truncate global prop can be used to truncate the label within each Form Pill. See [here](https://playbook.powerapp.cloud/global_props/truncate) for more information on the truncate global prop.
2
2
 
3
3
  __NOTE__: For Rails Form Pills (not ones embedded within a React-rendered Typeahead or MultiLevelSelect), a unique `id` is required to enable the Tooltip functionality displaying the text or tag section of the Form Pill.
@@ -1 +1 @@
1
- For Form Pills with longer text, the `truncate` global prop can be used to truncate the label within each Form Pill. Hover over the truncated Form Pill and a Tooltip containing the text or tag section of the Form Pill will appear. See [here](https://playbook.powerapp.cloud/visual_guidelines/truncate) for more information on the truncate global prop.
1
+ For Form Pills with longer text, the `truncate` global prop can be used to truncate the label within each Form Pill. Hover over the truncated Form Pill and a Tooltip containing the text or tag section of the Form Pill will appear. See [here](https://playbook.powerapp.cloud/global_props/truncate) for more information on the truncate global prop.
@@ -1 +1 @@
1
- Pass any text, status, data, product, or category Playbook <a href="https://playbook.powerapp.cloud/visual_guidelines/colors" target="_blank">color token</a> to the `color` prop to change any icon's color.
1
+ Pass any text, status, data, product, or category Playbook <a href="https://playbook.powerapp.cloud/tokens/colors" target="_blank">color token</a> to the `color` prop to change any icon's color.
@@ -1 +1 @@
1
- Customize your icon circle by passing one of our seven base colors to the `variant` prop: `royal` `blue` `orange` `purple` `teal` `red` `yellow` `green`
1
+ Customize your icon circle by passing one of our seven base colors to the `variant` prop: `royal` `orange` `purple` `teal` `red` `yellow` `green`
@@ -3,48 +3,41 @@
3
3
  text: "Mercury",
4
4
  unit: "AU",
5
5
  value: 0.39,
6
- variant:"blue"
6
+ variant:"royal"
7
7
  }) %>
8
8
  <br>
9
9
  <%= pb_rails("icon_stat_value", props: { icon: "planet-ringed",
10
10
  text: "Venus",
11
11
  unit: "AU",
12
12
  value: 0.723,
13
- variant:"royal"
13
+ variant:"purple"
14
14
  }) %>
15
15
  <br>
16
16
  <%= pb_rails("icon_stat_value", props: { icon: "planet-moon",
17
17
  text: "Earth",
18
18
  unit: "AU",
19
19
  value: 1.0,
20
- variant:"purple"
20
+ variant:"teal"
21
21
  }) %>
22
22
  <br>
23
23
  <%= pb_rails("icon_stat_value", props: { icon: "solar-system",
24
24
  text: "Mars",
25
25
  unit: "AU",
26
26
  value: 1.524,
27
- variant:"teal"
27
+ variant:"red"
28
28
  }) %>
29
29
  <br>
30
30
  <%= pb_rails("icon_stat_value", props: { icon: "globe-americas",
31
- text: "Jupitar",
31
+ text: "Jupiter",
32
32
  unit: "AU",
33
33
  value: 5.203,
34
- variant:"red"
34
+ variant:"yellow"
35
35
  }) %>
36
36
  <br>
37
37
  <%= pb_rails("icon_stat_value", props: { icon: "globe-africa",
38
38
  text: "Saturn",
39
39
  unit: "AU",
40
40
  value: 9.539,
41
- variant:"yellow"
42
- }) %>
43
- <br>
44
- <%= pb_rails("icon_stat_value", props: { icon: "globe",
45
- text: "Uranus",
46
- unit: "AU",
47
- value: 19.18,
48
41
  variant:"green"
49
42
  }) %>
50
43
  <br>
@@ -53,4 +46,4 @@
53
46
  unit: "AU",
54
47
  value: 19.18,
55
48
  variant:"orange"
56
- }) %>
49
+ }) %>
@@ -9,7 +9,7 @@ const IconStatValueColor = (props) => {
9
9
  text="Mercury"
10
10
  unit="AU"
11
11
  value={0.39}
12
- variant="blue"
12
+ variant="royal"
13
13
  {...props}
14
14
  />
15
15
  <br />
@@ -18,7 +18,7 @@ const IconStatValueColor = (props) => {
18
18
  text="Venus"
19
19
  unit="AU"
20
20
  value={0.723}
21
- variant="royal"
21
+ variant="purple"
22
22
  {...props}
23
23
  />
24
24
  <br />
@@ -27,7 +27,7 @@ const IconStatValueColor = (props) => {
27
27
  text="Earth"
28
28
  unit="AU"
29
29
  value={1.0}
30
- variant="purple"
30
+ variant="teal"
31
31
  {...props}
32
32
  />
33
33
  <br />
@@ -36,16 +36,16 @@ const IconStatValueColor = (props) => {
36
36
  text="Mars"
37
37
  unit="AU"
38
38
  value={1.524}
39
- variant="teal"
39
+ variant="red"
40
40
  {...props}
41
41
  />
42
42
  <br />
43
43
  <IconStatValue
44
44
  icon="globe-americas"
45
- text="Jupitar"
45
+ text="Jupiter"
46
46
  unit="AU"
47
47
  value={5.203}
48
- variant="red"
48
+ variant="yellow"
49
49
  {...props}
50
50
  />
51
51
  <br />
@@ -54,15 +54,6 @@ const IconStatValueColor = (props) => {
54
54
  text="Saturn"
55
55
  unit="AU"
56
56
  value={9.539}
57
- variant="yellow"
58
- {...props}
59
- />
60
- <br />
61
- <IconStatValue
62
- icon="globe"
63
- text="Uranus"
64
- unit="AU"
65
- value={19.18}
66
57
  variant="green"
67
58
  {...props}
68
59
  />
@@ -1 +1 @@
1
- Layout can leverage the max-width property. Learn more in our <a href="https://playbook.powerapp.cloud/visual_guidelines" target="_blank">visual guidelines.</a>
1
+ Layout can leverage the max-width property. Learn more in our <a href="https://playbook.powerapp.cloud/global_props/max_width" target="_blank">visual guidelines.</a>
@@ -1 +1 @@
1
- The `itemSpacing` prop can optionally be applied to the `Nav` parent element and accepts an object through which any of our [Spacing](https://playbook.powerapp.cloud/visual_guidelines/spacing) (padding, margin) global prop values can be passed as an object. All spacing values passed to `itemSpacing` will be applied to all navItems within the nav. Spacing (padding, margin) global props can still be used on nested navItems in conjunction with `itenSpacing` on the Nav for customized control. Any Spacing (padding,margin) global props applied directly to a navItem will override any competing `itemSpacing` value.
1
+ The `itemSpacing` prop can optionally be applied to the `Nav` parent element and accepts an object through which any of our Spacing ([padding](https://playbook.powerapp.cloud/global_props/padding), [margin](https://playbook.powerapp.cloud/global_props/margin)) global prop values can be passed as an object. All spacing values passed to `itemSpacing` will be applied to all navItems within the nav. Spacing (padding, margin) global props can still be used on nested navItems in conjunction with `itenSpacing` on the Nav for customized control. Any Spacing (padding,margin) global props applied directly to a navItem will override any competing `itemSpacing` value.
@@ -1 +1 @@
1
- All Nav variants' navItems accept our [global Spacing](https://playbook.powerapp.cloud/visual_guidelines/spacing) (padding, margin) props for custom spacing requirements. This example uses paddingY="xxs" and margin="none" on the bold variant to show this in action!
1
+ All Nav variants' navItems accept our global Spacing ([padding](https://playbook.powerapp.cloud/global_props/padding), [margin](https://playbook.powerapp.cloud/global_props/margin)) props for custom spacing requirements. This example uses paddingY="xxs" and margin="none" on the bold variant to show this in action!
@@ -2,4 +2,4 @@ The optional `layout` prop accepts the `position` and `size` of the overlay as a
2
2
 
3
3
  The `position` key accepts `bottom` (default), `top`, `y` (for both top and bottom) `right`, `left`, or `x` (for both left and right), which sets the side(s) where the `color` overlay starts. The direction of the overlay is always toward the opposite side of the position. For example, the default position of `bottom` starts the overlay on the bottom edge of your container and extends it toward the opposite side: the top.
4
4
 
5
- The `size` value is `full` (100%) by default, but accepts our [spacing tokens](https://playbook.powerapp.cloud/visual_guidelines/spacing) or a percentage value as a string, and literally translates to how much of the container is covered by the overlay(s).
5
+ The `size` value is `full` (100%) by default, but accepts our spacing tokens([padding](https://playbook.powerapp.cloud/global_props/padding), [margin](https://playbook.powerapp.cloud/global_props/margin)) or a percentage value as a string, and literally translates to how much of the container is covered by the overlay(s).
@@ -1 +1 @@
1
- A pill uses both a keyword and a specific color to categorize an item. Each pill directly corresponds to a data color <a href="https://playbook.powerapp.cloud/visual_guidelines/colors" target="_blank">here</a>.
1
+ A pill uses both a keyword and a specific color to categorize an item. Each pill directly corresponds to a data color <a href="https://playbook.powerapp.cloud/global_props/colors" target="_blank">here</a>.
@@ -1,5 +1,5 @@
1
1
  /* eslint-disable react/no-multi-comp */
2
- import React, { useEffect, useState } from "react";
2
+ import React, { useEffect, useRef, useState } from "react";
3
3
  import ReactDOM from "react-dom";
4
4
  import {
5
5
  Popper,
@@ -24,6 +24,7 @@ import { uniqueId } from '../utilities/object';
24
24
  type ModifiedGlobalProps = Omit<GlobalProps, 'minWidth' | 'maxHeight' | 'minHeight'>
25
25
 
26
26
  type PbPopoverProps = {
27
+ appendTo?: string;
27
28
  aria?: { [key: string]: string };
28
29
  className?: string;
29
30
  closeOnClick?: "outside" | "inside" | "any";
@@ -62,6 +63,25 @@ const popoverModifiers = ({
62
63
  return offset ? modifiers.concat([POPOVER_MODIFIERS.offset]) : modifiers;
63
64
  };
64
65
 
66
+ const getAppendTarget = (
67
+ appendTo: string | undefined,
68
+ targetId: string
69
+ ): HTMLElement => {
70
+ if (!appendTo || appendTo === "body") return document.body;
71
+
72
+ if (appendTo === "parent") {
73
+ const referenceWrapper = document.querySelector(`#reference-${targetId}`);
74
+ if (referenceWrapper?.parentElement) {
75
+ return referenceWrapper.parentElement;
76
+ }
77
+ }
78
+
79
+ const selectorMatch = document.querySelector(appendTo);
80
+ if (selectorMatch instanceof HTMLElement) return selectorMatch;
81
+
82
+ return document.body;
83
+ };
84
+
65
85
  const Popover = (props: PbPopoverProps) => {
66
86
  const {
67
87
  aria = {},
@@ -89,7 +109,7 @@ const Popover = (props: PbPopoverProps) => {
89
109
  const popoverSpacing =
90
110
  filteredGlobalProps.includes("dark") || !filteredGlobalProps
91
111
  ? "p_sm"
92
- : filteredGlobalProps
112
+ : filteredGlobalProps
93
113
  const overflowHandling = maxHeight || maxWidth ? "overflow_handling" : "";
94
114
  const zIndexStyle = zIndex ? { zIndex: zIndex } : {};
95
115
  const widthHeightStyles = () => {
@@ -113,7 +133,7 @@ const Popover = (props: PbPopoverProps) => {
113
133
 
114
134
  return (
115
135
  <Popper
116
- modifiers={popoverModifiers({ modifiers, offset })}
136
+ modifiers={popoverModifiers({ modifiers, offset: offset || false })}
117
137
  placement={placement}
118
138
  referenceElement={referenceElement}
119
139
  >
@@ -154,6 +174,7 @@ const Popover = (props: PbPopoverProps) => {
154
174
  const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
155
175
  const [targetId] = useState(uniqueId('id-'))
156
176
  const {
177
+ appendTo,
157
178
  className,
158
179
  children,
159
180
  modifiers = [],
@@ -170,42 +191,56 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
170
191
  minHeight,
171
192
  minWidth,
172
193
  width,
194
+ closeOnClick,
195
+ shouldClosePopover = noop,
173
196
  } = props;
174
197
 
198
+ // Store latest callback in a ref to avoid re-runs
199
+ const shouldClosePopoverRef = useRef(shouldClosePopover);
200
+
201
+ // Update ref on change
175
202
  useEffect(() => {
176
- const { closeOnClick, shouldClosePopover = noop } = props;
203
+ shouldClosePopoverRef.current = shouldClosePopover;
204
+ }, [shouldClosePopover]);
177
205
 
206
+ useEffect(() => {
178
207
  if (!closeOnClick) return;
179
208
 
180
- document.body.addEventListener(
181
- "click",
182
- (e: MouseEvent) => {
183
- const target = e.target as HTMLElement
209
+ // Function to handle popover event listener and targetId.
210
+ // Ensure that whenever the component is conditionally rendered
211
+ // that the old listener is removed and the new listener is
212
+ // updated with the targetId.
213
+ const handleClick = (e: MouseEvent) => {
214
+ const target = e.target as HTMLElement
184
215
 
185
- const targetIsPopover =
186
- target.closest("#" + targetId) !== null;
187
- const targetIsReference =
188
- target.closest("#reference-" + targetId) !== null;
216
+ const targetIsPopover =
217
+ target.closest("#" + targetId) !== null;
218
+ const targetIsReference =
219
+ target.closest("#reference-" + targetId) !== null;
189
220
 
190
- const shouldClose = () => {
191
- setTimeout(() => shouldClosePopover(true), 0);
192
- }
221
+ const shouldClose = () => {
222
+ setTimeout(() => shouldClosePopoverRef.current(true), 0);
223
+ }
193
224
 
194
- switch (closeOnClick) {
195
- case "outside":
196
- if (!targetIsPopover && !targetIsReference) shouldClose();
197
- break;
198
- case "inside":
199
- if (targetIsPopover) shouldClose();
200
- break;
201
- case "any":
202
- if (targetIsPopover || !targetIsPopover && !targetIsReference) shouldClose();
203
- break;
204
- }
205
- },
206
- { capture: true }
207
- );
208
- }, []);
225
+ switch (closeOnClick) {
226
+ case "outside":
227
+ if (!targetIsPopover && !targetIsReference) shouldClose();
228
+ break;
229
+ case "inside":
230
+ if (targetIsPopover) shouldClose();
231
+ break;
232
+ case "any":
233
+ if (targetIsPopover || !targetIsPopover && !targetIsReference) shouldClose();
234
+ break;
235
+ }
236
+ };
237
+
238
+ document.body.addEventListener("click", handleClick, { capture: true });
239
+
240
+ return () => {
241
+ document.body.removeEventListener("click", handleClick, { capture: true });
242
+ };
243
+ }, [targetId, closeOnClick]);
209
244
 
210
245
  const popoverComponent = (
211
246
  <Popover
@@ -246,10 +281,10 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
246
281
  {show &&
247
282
  (usePortal ? (
248
283
  <>
249
- {ReactDOM.createPortal(
250
- popoverComponent,
251
- document.querySelector(portal)
252
- )}
284
+ {ReactDOM.createPortal(
285
+ popoverComponent,
286
+ getAppendTarget(appendTo, targetId)
287
+ )}
253
288
  </>
254
289
  ) : (
255
290
  { popoverComponent }
@@ -0,0 +1,68 @@
1
+ import React, { useState } from "react";
2
+ import { PbReactPopover, CircleIconButton, Body, Flex } from "playbook-ui";
3
+
4
+ const PopoverAppendTo = (props) => {
5
+ const [showParentPopover, setShowParentPopover] = useState(false);
6
+ const [showSelectorPopover, setShowSelectorPopover] = useState(false);
7
+
8
+ const parentPopoverReference = (
9
+ <CircleIconButton
10
+ icon="info"
11
+ onClick={() => setShowParentPopover(!showParentPopover)}
12
+ variant="secondary"
13
+ />
14
+ );
15
+
16
+ const selectorPopoverReference = (
17
+ <CircleIconButton
18
+ icon="info"
19
+ onClick={() => setShowSelectorPopover(!showSelectorPopover)}
20
+ variant="secondary"
21
+ />
22
+ );
23
+
24
+ return (
25
+ <>
26
+ <Flex
27
+ marginBottom="md"
28
+ orientation="row"
29
+ vertical="center"
30
+ {...props}
31
+ >
32
+ <Body text="Click info for more details" />
33
+ &nbsp;
34
+ <PbReactPopover
35
+ appendTo="parent"
36
+ offset
37
+ placement="top"
38
+ reference={parentPopoverReference}
39
+ show={showParentPopover}
40
+ {...props}
41
+ >
42
+ {'I\'m a popover. I have been appended to my parent element.'}
43
+ </PbReactPopover>
44
+ </Flex>
45
+
46
+ <Flex
47
+ orientation="row"
48
+ vertical="center"
49
+ {...props}
50
+ >
51
+ <Body text="Click info for more details" />
52
+ &nbsp;
53
+ <PbReactPopover
54
+ appendTo=".kit-show-wrapper"
55
+ offset
56
+ placement="top"
57
+ reference={selectorPopoverReference}
58
+ show={showSelectorPopover}
59
+ {...props}
60
+ >
61
+ {'I\'m a popover. I have been appended to the .kit-show-wrapper.'}
62
+ </PbReactPopover>
63
+ </Flex>
64
+ </>
65
+ );
66
+ };
67
+
68
+ export default PopoverAppendTo;
@@ -0,0 +1 @@
1
+ By default, the popover tooltip attaches to the `<body>`. To attach it elsewhere, use the `appendTo` prop. Set it to `"parent"` to place the tooltip inside its parent element, or pass any CSS selector (`#id` or `.class`) to specify a custom container.
@@ -15,3 +15,4 @@ examples:
15
15
  - popover_z_index: Set Z-Index
16
16
  - popover_scroll_height: Scroll and Height Settings
17
17
  - popover_actionable_content: With Actionable Content
18
+ - popover_append_to: Append To
@@ -4,3 +4,4 @@ export { default as PopoverClose } from './_popover_close.jsx'
4
4
  export { default as PopoverZIndex } from './_popover_z_index.jsx'
5
5
  export { default as PopoverScrollHeight } from './_popover_scroll_height.jsx'
6
6
  export { default as PopoverActionableContent } from './_popover_actionable_content.jsx'
7
+ export { default as PopoverAppendTo } from './_popover_append_to.jsx'