playbook_ui 15.3.0.pre.alpha.PLAY2322popoverconditionalrender11766 → 15.3.0.pre.alpha.PLAY2565formkitsubmitfix11681

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f59d7e7c4376efeb5b93d1b598f303d41137dbf51803939bfc58fe39bf2111c
-  data.tar.gz: 7a6940c220be0ca9d18b3e2cd9a283539d66df7ee26245320d22e676b8244d93
+  metadata.gz: e57165e0f6855d1e877e88b67b0cfc62dffcca56c75494c4919a2774443a3f4e
+  data.tar.gz: c13a71137883d0c2277e488a8a0163f88768e01a22d75c9d0f1bcd157ca473b9
 SHA512:
-  metadata.gz: f0aff746453cdd793520c58b60da087f0ed804622f33c98b25869cfdb19bb6a601ba4488772991c9edadf3e5bfbcfa1a8be38a883280f229ef62d0c761e7a4c6
-  data.tar.gz: 807933083868d271c5d7ae0f2b3d0519ca4d35feb9ad1890cbcc3c0cd84c4e24690ee76151bafe2271eefc2683bf03f0ee396738951e77f1ec9307736135c583
+  metadata.gz: e40cbc1a718b7157b85199fbd02852055a6dfa954d351af3a3299a84311b3185b8bbc93de30b9000b2161d97ae1bdd79f8a519ce3524d9907e506b095ed3c9b7
+  data.tar.gz: e06abbce30f98797e15dc84498c72d3d370275df49cb93f490fa8a9cdda3cc5844efe471a2fdb37ad969db0801bc6f6fb6c0f476204eae726b50b30042f1f296

data/app/pb_kits/playbook/pb_advanced_table/Components/TableHeaderCell.tsx

@@ -30,7 +30,6 @@ type TableHeaderCellProps = {
   headerChildren?: React.ReactNode | React.ReactNode[]
   isPinnedLeft?: boolean
   loading?: boolean
-  persistToggleExpansionButton?: boolean
   sortIcon?: string | string[]
   table?: Table<GenericObject>
 } & GlobalProps
@@ -59,7 +58,6 @@ export const TableHeaderCell = ({
     selectableRows,
     hasAnySubRows,
     showActionsBar,
-    persistToggleExpansionButton,
     stickyLeftColumn,
     inlineRowLoading,
     isActionBarVisible,
@@ -222,7 +220,7 @@ const isToggleExpansionEnabled =
               />
             )
           }
-          {isToggleExpansionEnabled &&  ((hasAnySubRows) || (inlineRowLoading && persistToggleExpansionButton)) && !expandByDepth && (
+          {isToggleExpansionEnabled && hasAnySubRows && !expandByDepth && (
               <ToggleIconButton onClick={handleExpandOrCollapse} />
             )}
           {isToggleExpansionEnabled && hasAnySubRows && expandByDepth && (

data/app/pb_kits/playbook/pb_advanced_table/Hooks/useTableActions.ts

@@ -9,9 +9,6 @@ interface UseTableActionsProps {
   setExpanded: (expanded: GenericObject) => void;
   onToggleExpansionClick?: (arg: Row<GenericObject>) => void;
   onRowSelectionChange?: (rowSelection: any) => void;
-  inlineRowLoading?: boolean;
-  localPagination?: { pageIndex: number; pageSize: number };
-  setLocalPagination?: (pagination: { pageIndex: number; pageSize: number }) => void;
 }
 
 export function useTableActions({
@@ -19,10 +16,7 @@ export function useTableActions({
   expanded,
   setExpanded,
   onToggleExpansionClick,
-  onRowSelectionChange,
-  inlineRowLoading = false,
-  localPagination,
-  setLocalPagination
+  onRowSelectionChange
 }: UseTableActionsProps) {
 
   // State to achieve 1 second delay before fetching more rows
@@ -44,17 +38,8 @@ export function useTableActions({
 
   // Handle pagination
   const onPageChange = useCallback((page: number) => {
-    if (inlineRowLoading && setLocalPagination && localPagination) {
-      // Use manual pagination state for inlineRowLoading
-      setLocalPagination({
-        ...localPagination,
-        pageIndex: page - 1
-      });
-    } else {
-      // Use tanstack's built-in pagination
-      table.setPageIndex(page - 1);
-    }
-  }, [table, inlineRowLoading, setLocalPagination, localPagination]);
+    table.setPageIndex(page - 1);
+  }, [table]);
 
   // Handle scroll detection for infinite scroll/virtualization
   const fetchMoreOnBottomReached = useCallback((

data/app/pb_kits/playbook/pb_advanced_table/Hooks/useTableState.ts

@@ -35,7 +35,6 @@ interface UseTableStateProps {
   onRowSelectionChange?: (arg: RowSelectionState) => void;
   columnVisibilityControl?: GenericObject;
   rowStyling?: GenericObject;
-  inlineRowLoading?: boolean;
 }
 
 export function useTableState({
@@ -54,8 +53,7 @@ export function useTableState({
   tableOptions,
   columnVisibilityControl,
   pinnedRows,
-  rowStyling,
-  inlineRowLoading = false
+  rowStyling
 }: UseTableStateProps) {
 
   // Create a local state for expanded and setExpanded if expandedControl not used
@@ -66,12 +64,6 @@ export function useTableState({
   const [localRowPinning, setLocalRowPinning] = useState<RowPinningState>({
     top: [],
   });
-  // Manage local state to preserve current page index when inlineRowLoading is enabled so it does not boot table to page 1
-  // We can extend this for more usecases, but for now scoping it only for inlineRowLoading
-  const [localPagination, setLocalPagination] = useState({
-    pageIndex: paginationProps?.pageIndex ?? 0, 
-    pageSize: paginationProps?.pageSize ?? 20,
-  });
   // Determine whether to use the prop or the local state
   const expanded = expandedControl ? expandedControl.value : localExpanded;
   const setExpanded = expandedControl ? expandedControl.onChange : setLocalExpanded;
@@ -141,7 +133,6 @@ export function useTableState({
       ...(selectableRows  && { rowSelection }),
       ...(columnVisibility && { columnVisibility }),
       ...(pinnedRows && { rowPinning }),
-      ...(inlineRowLoading && { pagination: localPagination }),
     },
   }), [
     expanded,
@@ -151,36 +142,23 @@ export function useTableState({
     rowSelection,
     columnVisibility,
     rowPinning,
-    inlineRowLoading,
-    localPagination
   ]);
 
   // Pagination configuration
   const paginationInitializer = useMemo(() => {
     if (!pagination) return {};
 
-    if (inlineRowLoading) {
-      // Use manual pagination state when inlineRowLoading is enabled (see https://tanstack.com/table/latest/docs/guide/pagination#client-side-pagination)
-      return {
-        getPaginationRowModel: getPaginationRowModel(),
-        paginateExpandedRows: false,
-        onPaginationChange: setLocalPagination,
-        autoResetPageIndex: false, // This is what prevent auto-reset of page index
-      };
-    } else {
-      // Use normal pagination initialization for non- inlineRowLoading usecases
-      return {
-        getPaginationRowModel: getPaginationRowModel(),
-        paginateExpandedRows: false,
-        initialState: {
-          pagination: {
-            pageIndex: paginationProps?.pageIndex ?? 0,
-            pageSize: paginationProps?.pageSize ?? 20,
-          },
+    return {
+      getPaginationRowModel: getPaginationRowModel(),
+      paginateExpandedRows: false,
+      initialState: {
+        pagination: {
+          pageIndex: paginationProps?.pageIndex ?? 0,
+          pageSize: paginationProps?.pageSize ?? 20,
         },
-      };
-    }
-  }, [pagination, paginationProps, inlineRowLoading]);
+      },
+    };
+  }, [pagination, paginationProps]);
 
   // Initialize the table
   const table = useReactTable({
@@ -228,27 +206,9 @@ export function useTableState({
   // Set pagination state when pagination is enabled
   useEffect(() => {
     if (pagination && paginationProps?.pageSize) {
-      if (inlineRowLoading) {
-        // Update local pagination state for inlineRowLoading
-        setLocalPagination(prev => ({
-          ...prev,
-          pageSize: paginationProps.pageSize
-        }));
-      } else {
-        table.setPageSize(paginationProps.pageSize);
-      }
-    }
-  }, [pagination, paginationProps?.pageSize, table, inlineRowLoading]);
-
-  // Update local pagination when paginationProps change and inlineRowLoading is enabled
-  useEffect(() => {
-    if (pagination && inlineRowLoading && paginationProps) {
-      setLocalPagination({
-        pageIndex: paginationProps.pageIndex ?? localPagination.pageIndex,
-        pageSize: paginationProps.pageSize ?? localPagination.pageSize,
-      });
+      table.setPageSize(paginationProps.pageSize);
     }
-  }, [pagination, inlineRowLoading, paginationProps?.pageIndex, paginationProps?.pageSize]);
+  }, [pagination, paginationProps?.pageSize, table]);
 
   // Check if table has any sub-rows
   const hasAnySubRows = table.getRowModel().rows.some(row => row.subRows && row.subRows.length > 0);
@@ -287,8 +247,6 @@ export function useTableState({
     rowSelection,
     fullData,
     totalFetched,
-    isFetching,
-    localPagination,
-    setLocalPagination
+    isFetching
   };
 }

data/app/pb_kits/playbook/pb_advanced_table/SubKits/TableHeader.tsx

@@ -39,7 +39,6 @@ export const TableHeader = ({
     hasAnySubRows,
     showActionsBar,
     selectableRows,
-    persistToggleExpansionButton,
     responsive,
     headerRef,
     virtualizedRows,
@@ -93,7 +92,6 @@ export const TableHeader = ({
                   isPinnedLeft={isPinnedLeft}
                   key={`${header.id}-header`}
                   loading={loading}
-                  persistToggleExpansionButton={persistToggleExpansionButton}
                   sortIcon={sortIcon}
                   table={table}
               />
@@ -138,7 +136,6 @@ export const TableHeader = ({
                   isVirtualized
                   key={`${header.id}-header-virtualized`}
                   loading={loading}
-                  persistToggleExpansionButton={persistToggleExpansionButton}
                   sortIcon={sortIcon}
                   table={table}
               />

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.tsx

@@ -63,7 +63,6 @@ type AdvancedTableProps = {
   scrollBarNone?: boolean,
   selectableRows?: boolean,
   showActionsBar?: boolean,
-  persistToggleExpansionButton?: boolean,
   sortControl?: GenericObject
   tableData: GenericObject[]
   tableOptions?: GenericObject
@@ -110,7 +109,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     scrollBarNone= false,
     showActionsBar = true,
     selectableRows,
-    persistToggleExpansionButton = false,
     sortControl,
     stickyLeftColumn,
     tableData,
@@ -136,9 +134,7 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     updateLoadingStateRowCount,
     fullData,
     totalFetched,
-    isFetching,
-    localPagination,
-    setLocalPagination
+    isFetching
   } = useTableState({
     tableData,
     columnDefinitions,
@@ -156,8 +152,7 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     onRowSelectionChange,
     columnVisibilityControl,
     pinnedRows,
-    rowStyling,
-    inlineRowLoading
+    rowStyling
   });
 
   // Initialize table actions
@@ -170,10 +165,7 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     expanded,
     setExpanded,
     onToggleExpansionClick,
-    onRowSelectionChange,
-    inlineRowLoading,
-    localPagination,
-    setLocalPagination
+    onRowSelectionChange
   });
 
   // Set table row count for loading state
@@ -357,7 +349,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
             loading={loading}
             onCustomSortClick={onCustomSortClick}
             onExpandByDepthClick={onExpandByDepthClick}
-            persistToggleExpansionButton={persistToggleExpansionButton}
             pinnedRows={pinnedRows}
             responsive={responsive}
             rowStyling={rowStyling}

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.test.jsx

@@ -108,48 +108,6 @@ const MOCK_DATA_WITH_ID = [
   },
 ]
 
-const MOCK_DATA_NO_SUBROWS = [
-  {
-    year: "2021",
-    quarter: null,
-    month: null,
-    day: null,
-    newEnrollments: "20",
-    scheduledMeetings: "10",
-    attendanceRate: "51%",
-    completedClasses: "3",
-    classCompletionRate: "33%",
-    graduatedStudents: "19",
-    children: [],
-  },
-  {
-    year: "2022",
-    quarter: null,
-    month: null,
-    day: null,
-    newEnrollments: "25",
-    scheduledMeetings: "17",
-    attendanceRate: "75%",
-    completedClasses: "5",
-    classCompletionRate: "45%",
-    graduatedStudents: "32",
-    children: [],
-  },
-  {
-    year: "2023",
-    quarter: null,
-    month: null,
-    day: null,
-    newEnrollments: "30",
-    scheduledMeetings: "22",
-    attendanceRate: "80%",
-    completedClasses: "7",
-    classCompletionRate: "55%",
-    graduatedStudents: "45",
-    children: [],
-  },
-]
-
 const columnDefinitions = [
   {
     accessor: "year",
@@ -551,23 +509,6 @@ test("inlineRowLoading prop renders inline loading if true", () => {
   expect(inlineLoading).toBeInTheDocument()
 })
 
-test("persistToggleExpansionButton prop shows header toggle when inlineRowLoading is true", () => {
-  render(
-    <AdvancedTable
-        columnDefinitions={columnDefinitions}
-        data={{ testid: testId }}
-        enableToggleExpansion="all"
-        inlineRowLoading
-        persistToggleExpansionButton
-        tableData={MOCK_DATA_NO_SUBROWS}
-    />
-  )
-
-  const kit = screen.getByTestId(testId)
-  const headerToggleButton = kit.querySelector(".gray-icon.toggle-all-icon")
-  expect(headerToggleButton).toBeInTheDocument()
-})
-
 test("responsive prop functions as expected", () => {
   render(
     <AdvancedTable

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_inline_row_loading.jsx

@@ -1,8 +1,6 @@
 import React from "react"
 import AdvancedTable from '../../pb_advanced_table/_advanced_table'
-import Caption from '../../pb_caption/_caption'
 import { MOCK_DATA_INLINE_LOADING } from "./_mock_data_inline_loading"
-import { MOCK_DATA_INLINE_LOADING_EMPTY_CHILDREN } from "./_mock_data_inline_loading_empty_children"
 
 const AdvancedTableInlineRowLoading = (props) => {
   const columnDefinitions = [
@@ -43,42 +41,16 @@ const AdvancedTableInlineRowLoading = (props) => {
 
   return (
     <div>
-      <Caption text="Inline Row Loading - Demonstrated in Row 1 (Rows 2 and 3 have data)" />
       <AdvancedTable
           columnDefinitions={columnDefinitions}
           enableToggleExpansion="all"
           inlineRowLoading
-          marginBottom="md"
           tableData={MOCK_DATA_INLINE_LOADING}
           {...props}
       >
         <AdvancedTable.Header />
         <AdvancedTable.Body subRowHeaders={subRowHeaders}/>
       </AdvancedTable>
-      <Caption text="Inline Row Loading with No Subrow Data - All Rows Display Inline Row Loading and the Toggle All Button is not rendered" />
-      <AdvancedTable
-          columnDefinitions={columnDefinitions}
-          enableToggleExpansion="all"
-          inlineRowLoading
-          marginBottom="md"
-          tableData={MOCK_DATA_INLINE_LOADING_EMPTY_CHILDREN}
-          {...props}
-      >
-        <AdvancedTable.Header />
-        <AdvancedTable.Body subRowHeaders={subRowHeaders}/>
-      </AdvancedTable>
-      <Caption text="Inline Row Loading and Persist Toggle Expansion Button with No Subrow Data - All Rows Display Inline Row Loading and the Toggle All Button is rendered" />
-      <AdvancedTable
-          columnDefinitions={columnDefinitions}
-          enableToggleExpansion="all"
-          inlineRowLoading
-          persistToggleExpansionButton
-          tableData={MOCK_DATA_INLINE_LOADING_EMPTY_CHILDREN}
-          {...props}
-      >
-        <AdvancedTable.Header />
-        <AdvancedTable.Body subRowHeaders={subRowHeaders}/>
-      </AdvancedTable>
     </div>
   )
 }

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_inline_row_loading.md

@@ -1,14 +1,5 @@
-### inlineRowLoading
 As a default, the kit assumes that the initial dataset is complete, and it renders all expansion buttons/controls based on that data; if no children are present, no expansion controls are rendered. If, however, you want to change the initial dataset to omit some or all of its children (to improve load times of a complex dataset, perhaps), and you implement a querying logic that loads children only when its parent is expanded, then you must use the `inlineRowLoading` prop to ensure your expansion controls are rendered even though your child data is not yet loaded. You must also pass an empty `children` array to any node that will have children to ensure its parent maintains its ability to expand. If this prop is called AND your data contains empty `children` arrays, the kit will render expansion controls on any row with empty children, and then add an inline loading state within the expanded subrow until those child row(s) are returned to the page [by your query logic].
 
-In the first Advanced Table in this code example, 2021 has an empty children array. Toggle it open to see the inline loading state. Once the correct data loads, this state will be replaced with the correct data rows. 
+In this code example, 2021 has an empty children array. Toggle it open to see the inline loading state. Once the correct data loads, this state will be replaced with the correct data rows. 
 
-This prop is set to `false` by default. 
-
-
-### persistToggleExpansion
-The `persistToggleExpansionButton` is a boolean prop that renders the toggle-all icon in the top left header cell for complex datasets with empty `children` arrays and advanced querying logic explained in the preceeding doc example. Your logic may require an additional query helper file to update data specifically from requerying via toggle all buttons.
-
-In the second and third Advanced Tables in this code example, all 3 rows have empty children arrays. The second Advanced Table demonstrates that the toggle all button does not render (prior to an initial row expansion) without `persistToggleExpansionButton` in place. The third Advanced Table shows the toggle all button due to `persistToggleExpansionButton`. 
-
-This prop is set to false by default and should only be used in conjunction with `inlineRowLoading`.
+This prop is set to `false` by default. 

data/app/pb_kits/playbook/pb_date_picker/sass_partials/_quick_pick_styles.scss

@@ -9,20 +9,29 @@ $pb_card_border_radius: $border_rad_heavier;
 
 // used to display dropdown on the left of the calender
 .quick-pick-drop-down {
-  width: 100%;
+  width: auto;
+  display: grid;
 }
 
 .quick-pick-ul {
+  padding: $space_xs 0px;
   margin: 0;
   list-style: none;
 }
 
 .nav-item {
   list-style: none;
+  border-radius: 6px;
+  border-bottom: 0;
+  margin: $space_xs $space_sm;
 }
 
 .nav-item-link {
   text-decoration: none;
+  border-width: $pb_card_border_width;
+  border-style: solid;
+  border-color: $border_light;
+  border-radius: $pb_card_border_radius;
   padding: $space_xs 14px;
   transition-property: color, background-color;
   transition-duration: 0.15s;
@@ -31,21 +40,15 @@ $pb_card_border_radius: $border_rad_heavier;
   color: $charcoal;
   font-size: $font_default;
   font-weight: $regular;
-  text-align: left;
-  border-bottom: 1px solid $border_light;
   &.active {
-    color: $white;
-    background-color: $primary;
-    &:hover {
-      background-color: $product_1_background;
-      color: $white;
-    }
+    border-width: 2px;
+    border-color: $primary;
   }
   @media (hover:hover) {
     &:hover {
       cursor: pointer;
-      background-color: $bg_light;
-      color: $primary;
+      box-shadow: $shadow-deep;
+      border-color: $slate;
     }
   }
 }
@@ -54,3 +57,19 @@ $pb_card_border_radius: $border_rad_heavier;
 .quick-pick-drop-down > .flatpickr-months, .quick-pick-drop-down > .flatpickr-innerContainer {
   display: none;
 }
+
+@media only screen and (max-width: 767px) {
+  .quick-pick-ul {
+    padding: $space_xs $space_xs;
+    display: grid;
+    grid-template-columns: 1fr 1fr;
+  }
+
+  .nav-item {
+    margin: $space_xxs $space_xs;
+  }
+
+  .nav-item-link {
+    padding: $space_xs $space_xxs;
+  }
+}

data/app/pb_kits/playbook/pb_popover/_popover.scss

@@ -56,15 +56,3 @@
 .pb_popover_reference_wrapper {
   display: inline-block;
 }
-
-// Temporary code to replicate bug - DO NOT MERGE
-@media (max-width: 619px) {
-  :root {
-    --is-pwa: 1;
-  }
-}
-@media (min-width: 620px) {
-  :root {
-    --is-pwa: 0;
-  }
-}

data/app/pb_kits/playbook/pb_popover/_popover.tsx

@@ -1,5 +1,5 @@
 /* eslint-disable react/no-multi-comp */
-import React, { useEffect, useRef, useState } from "react";
+import React, { useEffect, useState } from "react";
 import ReactDOM from "react-dom";
 import {
   Popper,
@@ -89,7 +89,7 @@ const Popover = (props: PbPopoverProps) => {
   const popoverSpacing =
     filteredGlobalProps.includes("dark") || !filteredGlobalProps
       ? "p_sm"
-      : filteredGlobalProps
+      : filteredGlobalProps 
   const overflowHandling = maxHeight || maxWidth ? "overflow_handling" : "";
   const zIndexStyle = zIndex ? { zIndex: zIndex } : {};
   const widthHeightStyles = () => {
@@ -170,56 +170,42 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
     minHeight,
     minWidth,
     width,
-    closeOnClick,
-    shouldClosePopover = noop,
   } = props;
 
-  // Store latest callback in a ref to avoid re-runs
-  const shouldClosePopoverRef = useRef(shouldClosePopover);
-
-  // Update ref on change
   useEffect(() => {
-    shouldClosePopoverRef.current = shouldClosePopover;
-  }, [shouldClosePopover]);
+    const { closeOnClick, shouldClosePopover = noop } = props;
 
-  useEffect(() => {
     if (!closeOnClick) return;
 
-    // Function to handle popover event listener and targetId.
-    // Ensure that whenever the component is conditionally rendered
-    // that the old listener is removed and the new listener is
-    // updated with the targetId.
-    const handleClick = (e: MouseEvent) => {
-      const target = e.target as HTMLElement
-
-      const targetIsPopover =
-        target.closest("#" + targetId) !== null;
-      const targetIsReference =
-        target.closest("#reference-" + targetId) !== null;
+    document.body.addEventListener(
+      "click",
+      (e: MouseEvent) => {
+        const target = e.target as HTMLElement
 
-      const shouldClose = () => {
-        setTimeout(() => shouldClosePopoverRef.current(true), 0);
-      }
+        const targetIsPopover =
+          target.closest("#" + targetId) !== null;
+        const targetIsReference =
+          target.closest("#reference-" + targetId) !== null;
 
-      switch (closeOnClick) {
-        case "outside":
-          if (!targetIsPopover && !targetIsReference) shouldClose();
-          break;
-        case "inside":
-          if (targetIsPopover) shouldClose();
-          break;
-        case "any":
-          if (targetIsPopover || !targetIsPopover && !targetIsReference) shouldClose();
-          break;
-      }
-    };
+        const shouldClose = () => {
+          setTimeout(() => shouldClosePopover(true), 0);
+        }
 
-    document.body.addEventListener("click", handleClick, { capture: true });
-
-    return () => {
-      document.body.removeEventListener("click", handleClick, { capture: true });
-    };
-  }, [targetId, closeOnClick]);
+        switch (closeOnClick) {
+          case "outside":
+            if (!targetIsPopover && !targetIsReference) shouldClose();
+            break;
+          case "inside":
+            if (targetIsPopover) shouldClose();
+            break;
+          case "any":
+            if (targetIsPopover || !targetIsPopover && !targetIsReference) shouldClose();
+            break;
+        }
+      },
+      { capture: true }
+    );
+  }, []);
 
   const popoverComponent = (
     <Popover

data/app/pb_kits/playbook/pb_popover/docs/_popover_close.jsx

@@ -3,14 +3,11 @@ import React, { useState } from 'react'
 import Button from '../../pb_button/_button'
 import Flex from '../../pb_flex/_flex'
 import PbReactPopover from '../../pb_popover/_popover'
-// Temporary code to replicate bug - DO NOT MERGE (Revert example when done)
-import useSmallScreenIndicator from './hook/useSmallScreenIndicator'
 
 const PopoverClose = (props) => {
   const [showInsidePopover, setInsideShowPopover] = useState(false)
   const [showOutsidePopover, setOutsideShowPopover] = useState(false)
   const [showAnyPopover, setAnyShowPopover] = useState(false)
-  const isPwa = useSmallScreenIndicator()
 
   const handleInsideShouldClosePopover = (shouldClosePopover) => {
     setInsideShowPopover(!shouldClosePopover)
@@ -62,10 +59,6 @@ const PopoverClose = (props) => {
     />
   )
 
-  if (isPwa) {
-    return null
-  }
-
   return (
     <Flex spacing="between">
       <PbReactPopover