playbook_ui 14.9.0.pre.alpha.play1742globalheightfixes4766 → 14.9.0.pre.rc.0

data/app/pb_kits/playbook/pb_typeahead/typeahead.html.erb

@@ -17,14 +17,11 @@
       <%= pb_rails("text_input", props: {
         type: "search",
         input_options: object.input_options,
+        label: object.label,
         name: object.name,
         value: object.value,
         placeholder: object.placeholder,
         margin_bottom: "none",
-        required: object.required,
-        validation: object.validation,
-        label: object.label,
-        id: object.input_options[:id],
       }) %>
       <%= pb_rails("list", props: { ordered: false, borderless: false, xpadding: true, role: "status", aria: { live: "polite" }, data: { pb_typeahead_kit_results: true } }) do %>
       <% end %>
@@ -36,4 +33,4 @@
       <% end %>
     </template>
   <% end %>
-<% end %>
+<% end %>

data/app/pb_kits/playbook/pb_typeahead/typeahead.rb

@@ -40,10 +40,6 @@ module Playbook
       prop :pill_color, type: Playbook::Props::Enum,
                         values: %w[primary neutral success warning error info data_1 data_2 data_3 data_4 data_5 data_6 data_7 data_8 windows siding roofing doors gutters solar insulation accessories],
                         default: "primary"
-      prop :required, type: Playbook::Props::Boolean,
-                      default: false
-      prop :validation, type: Playbook::Props::HashProp,
-                        default: {}
 
       def classname
         default_margin_bottom = margin_bottom.present? ? "" : " mb_sm"

data/app/pb_kits/playbook/utilities/_max_width.scss

@@ -1,49 +1,29 @@
-@import "../tokens/container";
-
+.max_width_xs {
+  max-width: 360px;
+}
 .max_width_0 {
-  max-width: map-get($containers, 'none');
+  max-width: 0;
 }
-
 .max_width_none {
   max-width: none;
 }
 
-.max_width_0_percent {
-  max-width: $container_0;
-}
-
-.max_width_xxs {
-  max-width: $container_xxs;
-}
-
-.max_width_xs {
-  max-width: $container_xs;
-}
-
 .max_width_sm {
-  max-width: $container_sm;
+  max-width: 540px;
 }
 
 .max_width_md {
-  max-width: $container_md;
+  max-width: 720px;
 }
 
 .max_width_lg {
-  max-width: $container_lg;
+  max-width: 960px;
 }
 
 .max_width_xl {
-  max-width: $container_xl;
+  max-width: 1140px;
 }
 
 .max_width_xxl {
-  max-width: $container_xxl;
-}
-
-.max_width_100_percent {
-  max-width: $container_100;
-}
-
-.width-resize {
-  resize: horizontal;
+  max-width: 1320px;
 }

data/app/pb_kits/playbook/utilities/_min_width.scss

@@ -4,11 +4,7 @@
   min-width: map-get($containers, 'none');
 }
 
-.min_width_none {
-  min-width: none;
-}
-
-.min_width_0_percent {
+.min_with_0_percent {
   min-width: $container_0;
 }
 
@@ -44,6 +40,6 @@
   min-width: $container_100;
 }
 
-.width-resize {
+.minwidth-resize {
   resize: horizontal;
 }

data/app/pb_kits/playbook/utilities/globalPropNames.mjs

@@ -7,6 +7,7 @@ export default [
   "right",
   "top",
   "hover",
+  "groupHover",
   "zIndex",
   "verticalAlign",
   "truncate",
@@ -29,7 +30,6 @@ export default [
   "numberSpacing",
   "maxWidth",
   "minWidth",
-  "width",
   "marginRight",
   "marginLeft",
   "marginTop",

data/app/pb_kits/playbook/utilities/globalProps.ts

@@ -95,16 +95,12 @@ type Margin = {
   default?: string
 }
 
-type Width = {
-  width?: string
-}
-
 type MaxWidth = {
-  maxWidth?: string,
+  maxWidth?: Sizes,
 }
 
 type MinWidth = {
-  minWidth?: string,
+  minWidth?: Sizes,
 }
 
 type NumberSpacing = {
@@ -180,7 +176,7 @@ type ZIndex = {
 } | ZIndexResponsiveType
 
 type Height = {
-  height?: string
+  height?: string 
 }
 
 type MaxHeight = {
@@ -195,7 +191,7 @@ type MinHeight = {
 export type GlobalProps = AlignContent & AlignItems & AlignSelf &
   BorderRadius & Cursor & Dark & Display & DisplaySizes & Flex & FlexDirection &
   FlexGrow & FlexShrink & FlexWrap & JustifyContent & JustifySelf &
-  LineHeight & Margin & Width & MinWidth & MaxWidth & NumberSpacing & Order & Overflow & Padding &
+  LineHeight & Margin & MinWidth & MaxWidth & NumberSpacing & Order & Overflow & Padding &
   Position & Shadow & TextAlign & Truncate & VerticalAlign & ZIndex & { hover?: string } & Top & Right & Bottom & Left & Height & MaxHeight & MinHeight;
 
 const getResponsivePropClasses = (prop: {[key: string]: string}, classPrefix: string) => {
@@ -355,11 +351,6 @@ const PROP_CATEGORIES: {[key:string]: (props: {[key: string]: any}) => string} =
     css += numberSpacing ? `ns_${numberSpacing} ` : ''
     return css
   },
-  widthProps: ({ width }: Width) => {
-    let css = ''
-    css += width ? `width_${filterClassName(width)} ` : ''
-    return css.trimEnd()
-  },
   minWidthProps: ({ minWidth }: MinWidth) => {
     let css = ''
     css += minWidth ? `min_width_${filterClassName(minWidth)} ` : ''
@@ -370,30 +361,6 @@ const PROP_CATEGORIES: {[key:string]: (props: {[key: string]: any}) => string} =
     css += maxWidth ? `max_width_${filterClassName(maxWidth)} ` : ''
     return css.trimEnd()
   },
-  minHeightProps: ({ minHeight }: MinHeight) => {
-    const heightValues = ["auto", "xs", "sm", "md", "lg", "xl", "xxl", "xxxl"]
-    if (heightValues.includes(minHeight)) {
-      let css = ''
-      css += minHeight ? `min_height_${filterClassName(minHeight)} ` : ''
-      return css.trimEnd()
-    }
-  },
-  maxHeightProps: ({ maxHeight }: MaxHeight) => {
-    const heightValues = ["auto", "xs", "sm", "md", "lg", "xl", "xxl", "xxxl"]
-    if (heightValues.includes(maxHeight)) {
-      let css = ''
-      css += maxHeight ? `max_height_${filterClassName(maxHeight)} ` : ''
-      return css.trimEnd()
-    }
-  },
-  heightProps: ({ height }: Height) => {
-    const heightValues = ["auto", "xs", "sm", "md", "lg", "xl", "xxl", "xxxl"]
-    if (heightValues.includes(height)) {
-      let css = ''
-      css += height ? `height_${filterClassName(height)} ` : ''
-      return css.trimEnd()
-    }
-  },
   zIndexProps: (zIndex: ZIndex) => {
     let css = ''
     Object.entries(zIndex).forEach((zIndexEntry) => {