playbook_ui 14.6.0.pre.alpha.play1586datearea4218 → 14.6.0.pre.rc.0

data/app/pb_kits/playbook/pb_phone_number_input/types.d.ts

@@ -1,4 +1 @@
-declare module 'intl-tel-input/build/js/intlTelInputWithUtils.js' {
-    const intlTelInput: any;
-    export default intlTelInput;
-}
+declare module 'intl-tel-input'

data/app/pb_kits/playbook/pb_popover/_popover.tsx

@@ -21,7 +21,7 @@ import classnames from "classnames";
 import { globalProps, GlobalProps } from "../utilities/globalProps";
 import { uniqueId } from 'lodash';
 
-type ModifiedGlobalProps = Omit<GlobalProps, 'minWidth' | 'maxHeight' | 'minHeight'>
+type ModifiedGlobalProps = Omit<GlobalProps, 'minWidth'>
 
 type PbPopoverProps = {
   aria?: { [key: string]: string };
@@ -79,7 +79,6 @@ const Popover = (props: PbPopoverProps) => {
     maxWidth,
     minHeight,
     minWidth,
-    width,
     targetId,
   } = props;
 
@@ -98,8 +97,7 @@ const Popover = (props: PbPopoverProps) => {
       maxHeight ? { maxHeight: maxHeight } : {},
       maxWidth ? { maxWidth: maxWidth } : {},
       minHeight ? { minHeight: minHeight } : {},
-      minWidth ? { minWidth: minWidth } : {},
-      width ? { width: width } : {}
+      minWidth ? { minWidth: minWidth } : {}
     );
   };
   const ariaProps = buildAriaProps(aria);
@@ -169,7 +167,6 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
     maxWidth,
     minHeight,
     minWidth,
-    width,
   } = props;
 
   useEffect(() => {
@@ -219,7 +216,6 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
         placement={placement}
         referenceElement={referenceElement}
         targetId={targetId}
-        width={width}
         zIndex={zIndex}
         {...props}
     >

data/app/pb_kits/playbook/pb_popover/docs/_popover_default.html.erb

@@ -14,7 +14,7 @@
         trigger_element_id: "regular-popover-1",
         tooltip_id: "tooltip-1",
         offset: true,
-        position: "top",
+        position: "top"
     }) do %>
         I'm a popover. I can show content of any size.
     <% end %>

data/app/pb_kits/playbook/pb_popover/popover.rb

@@ -12,7 +12,6 @@ module Playbook
       prop :max_width
       prop :min_width
       prop :min_height
-      prop :width
       prop :z_index, type: Playbook::Props::String
       prop :offset, type: Playbook::Props::Boolean, default: false
       prop :close_on_click, type: Playbook::Props::Enum,
@@ -37,12 +36,11 @@ module Playbook
         out += "max-width: #{max_width}; " if max_width.present?
         out += "min-height: #{min_height}; " if min_height.present?
         out += "min-width: #{min_width};" if min_width.present?
-        out += "width: #{width};" if width.present?
         out
       end
 
       def width_height_class_helper
-        "overflow_handling" if max_height || max_width || width
+        "overflow_handling" if max_height || max_width
       end
 
       def data

data/app/pb_kits/playbook/pb_timeline/_item.tsx

@@ -1,15 +1,12 @@
 import React from 'react'
 import classnames from 'classnames'
+
 import { buildCss, buildHtmlProps } from '../utilities/props'
-import { globalProps, GlobalProps } from "../utilities/globalProps"
+import { globalProps, GlobalProps } from "../utilities/globalProps";
 
 import DateStacked from '../pb_date_stacked/_date_stacked'
 import IconCircle from '../pb_icon_circle/_icon_circle'
 
-import TimelineLabel from './subcomponents/Label'
-import TimelineStep from './subcomponents/Step'
-import TimelineDetail from './subcomponents/Detail'
-
 type ItemProps = {
   className?: string,
   children?: React.ReactNode[] | React.ReactNode,
@@ -20,13 +17,6 @@ type ItemProps = {
   lineStyle?: 'solid' | 'dotted',
 } & GlobalProps
 
-function isElementOfType<P>(
-  element: React.ReactNode,
-  component: React.ComponentType<P>
-): element is React.ReactElement<P> {
-  return React.isValidElement<P>(element) && element.type === component
-}
-
 const TimelineItem = ({
   className,
   children,
@@ -41,57 +31,31 @@ const TimelineItem = ({
 
   const htmlProps = buildHtmlProps(htmlOptions)
 
-  const childrenArray = React.Children.toArray(children)
-
-  const labelChild = childrenArray.find(
-    (child): child is React.ReactElement => isElementOfType(child, TimelineLabel)
-  )
-
-  const stepChild = childrenArray.find(
-    (child): child is React.ReactElement => isElementOfType(child, TimelineStep)
-  )
-
-  const detailChild = childrenArray.find(
-    (child): child is React.ReactElement => isElementOfType(child, TimelineDetail)
-  )
-
-  const otherChildren = childrenArray.filter(
-    (child) =>
-      !isElementOfType(child, TimelineLabel) &&
-      !isElementOfType(child, TimelineStep) &&
-      !isElementOfType(child, TimelineDetail)
-  )
-
   return (
-    <div
+    <div 
         {...htmlProps}
         className={classnames(timelineItemCss, globalProps(props), className)}
     >
-        {labelChild || (
-          <div className="pb_timeline_item_left_block">
-            {date && (
-              <DateStacked
-                  align="center"
-                  date={date}
-                  size="sm"
-              />
-            )}
-          </div>
-        )}
-        {stepChild || (
-          <div className="pb_timeline_item_step">
-            <IconCircle icon={icon}
-                size="xs"
-                variant={iconColor}
-            />
-            <div className="pb_timeline_item_connector" />
-          </div>
-        )}
-        {detailChild || (
-          <div className="pb_timeline_item_right_block">
-           { otherChildren }
-          </div>
-        )}
+      <div className="pb_timeline_item_left_block">
+        {date &&
+          <DateStacked
+              align="center"
+              date={date}
+              size="sm"
+          />
+        }
+      </div>
+      <div className="pb_timeline_item_step">
+        <IconCircle
+            icon={icon}
+            size="xs"
+            variant={iconColor}
+        />
+        <div className="pb_timeline_item_connector" />
+      </div>
+      <div className="pb_timeline_item_right_block">
+        {children}
+      </div>
     </div>
   )
 }

data/app/pb_kits/playbook/pb_timeline/_timeline.tsx

@@ -5,11 +5,6 @@ import { buildAriaProps, buildCss, buildDataProps, buildHtmlProps } from '../uti
 import { GlobalProps, globalProps } from '../utilities/globalProps'
 
 import TimelineItem from './_item'
-import {
-  TimelineStep,
-  TimelineLabel,
-  TimelineDetail,
-} from './subcomponents'
 
 type TimelineProps = {
   aria?: { [key: string]: string },
@@ -52,8 +47,5 @@ const Timeline = ({
 }
 
 Timeline.Item = TimelineItem
-Timeline.Step = TimelineStep
-Timeline.Label = TimelineLabel
-Timeline.Detail = TimelineDetail
 
 export default Timeline

data/app/pb_kits/playbook/pb_timeline/docs/example.yml

@@ -4,11 +4,10 @@ examples:
   - timeline_default: Default
   - timeline_vertical: Vertical
   - timeline_with_date: With Date
-  - timeline_with_children: With Children
   
   
   react:
   - timeline_default: Default
   - timeline_vertical: Vertical
   - timeline_with_date: With Date
-  - timeline_with_children: With Children
+  

data/app/pb_kits/playbook/pb_timeline/docs/index.js

@@ -1,4 +1,3 @@
 export { default as TimelineDefault } from './_timeline_default.jsx'
 export { default as TimelineVertical } from './_timeline_vertical.jsx'
 export { default as TimelineWithDate } from './_timeline_with_date.jsx'
-export { default as TimelineWithChildren } from './_timeline_with_children.jsx'

data/app/pb_kits/playbook/pb_timeline/item.html.erb

@@ -1,21 +1,25 @@
 <%= pb_content_tag do %>
-  <% if date_area %>
-    <%= date_area %>
-  <% else %>
-    <%= pb_rails("timeline/date_area", props: { date: date }) %>
-  <% end %>
 
-  <% if node_area %>
-    <%= node_area %>
-  <% else %>
-    <%= pb_rails("timeline/node_area", props: { icon: icon, icon_color: icon_color }) %>
-  <% end %>
-
-  <% if detail_area %>
-    <%= detail_area %>
-  <% else %>
-    <%= pb_rails("timeline/detail_area") do %>
-      <%= content %>
+  <div class="pb_timeline_item_left_block">
+    <% if object.date.present? %>
+      <%= pb_rails("date_stacked", props: {
+        date: object.date,
+        size: "sm",
+        align: "center"
+      }) %>
     <% end %>
-  <% end %>
+  </div>
+
+  <div class="pb_timeline_item_step">
+    <%= pb_rails("icon_circle", props: {
+      icon: object.icon,
+      variant: object.icon_color,
+      size: "xs"
+    }) %>
+    <div class="pb_timeline_item_connector"></div>
+  </div>
+
+  <div class="pb_timeline_item_right_block">
+    <%= content.presence %>
+  </div>
 <% end %>

data/app/pb_kits/playbook/pb_timeline/item.rb

@@ -13,10 +13,6 @@ module Playbook
                         values: %w[solid dotted],
                         default: "solid"
 
-      renders_one :date_area
-      renders_one :node_area
-      renders_one :detail_area
-
       def classname
         generate_classname("pb_timeline_item_kit", line_style)
       end

data/app/pb_kits/playbook/pb_timeline/timeline.test.js

@@ -2,10 +2,6 @@ import React from 'react'
 import { render, screen } from '../utilities/test-utils'
 
 import Timeline from './_timeline'
-import TimelineItem from './_item'
-import TimelineLabel from './subcomponents/Label'
-import TimelineStep from './subcoponents/Step'
-import TimelineDetail from './subcomponents/Detail'
 import TitleDetail from '../pb_title_detail/_title_detail'
 
 const testId = 'timeline'
@@ -47,91 +43,18 @@ const TimelineDefault = (props) => (
     </>
 )
 
-const TimelineWithChildren = (props) => (
-  <>
-    <Timeline
-        className={className}
-        data={{ testid: testId }}
-        orientation="horizontal"
-        showDate
-        {...props}
-    >
-      <TimelineItem lineStyle="solid"
-          {...props}
-      >
-        <TimelineLabel date={new Date()} />
-        <TimelineStep icon="user"
-            iconColor="royal"
-        />
-        <TimelineDetail>
-          <TitleDetail
-              detail="37-27 74th Street"
-              title="Jackson Heights"
-              {...props}
-          />
-        </TimelineDetail>
-      </TimelineItem>
-
-      <TimelineItem lineStyle="dotted"
-          {...props}
-      >
-        <TimelineStep icon="check"
-            iconColor="teal"
-        />
-        <TimelineDetail>
-          <TitleDetail
-              detail="81 Gate St Brooklyn"
-              title="Greenpoint"
-              {...props}
-          />
-        </TimelineDetail>
-      </TimelineItem>
-
-      <TimelineItem lineStyle="solid"
-          {...props}
-      >
-        <TimelineLabel
-            date={new Date(new Date().setDate(new Date().getDate() + 1))}
-        />
-        <TimelineStep icon="map-marker-alt"
-            iconColor="purple"
-        />
-        <TimelineDetail>
-          <TitleDetail
-              detail="72 E St Astoria"
-              title="Society Hill"
-              {...props}
-          />
-        </TimelineDetail>
-      </TimelineItem>
-    </Timeline>
-  </>
-)
-
 test('should pass data prop', () => {
     render(<TimelineDefault />)
     const kit = screen.getByTestId(testId)
     expect(kit).toBeInTheDocument()
 })
 
-test('should pass data prop using children', () => {
-    render(<TimelineWithChildren />)
-    const kit = screen.getByTestId(testId)
-    expect(kit).toBeInTheDocument()
-})
-
 test('should pass className prop', () => {
     render(<TimelineDefault />)
     const kit = screen.getByTestId(testId)
     expect(kit).toHaveClass(className)
 })
 
-test('should pass className prop with children', () => {
-    render(<TimelineWithChildren />)
-    const kit = screen.getByTestId(testId)
-    expect(kit).toHaveClass(className)
-})
-
 test('should pass aria prop', () => {
     render(<TimelineDefault />)
     const kit = screen.getByTestId(testId)
@@ -163,10 +86,3 @@ test('should pass showDate prop', () => {
     const kit = screen.getByTestId(testId)
     expect(kit).toHaveClass('pb_timeline_kit__horizontal__with_date')
 })
-
-test('should pass showDate prop with Children', () => {
-    const props = { showDate: true }
-    render(<TimelineWithChildren {...props} />)
-    const kit = screen.getByTestId(testId)
-    expect(kit).toHaveClass('pb_timeline_kit__horizontal__with_date')
-})

data/app/pb_kits/playbook/pb_typeahead/_typeahead.tsx

@@ -136,15 +136,12 @@ const Typeahead = ({
     }
   }
 
-  const filteredProps: TypeaheadProps = {...props}
-  delete filteredProps.truncate
-
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)
   const classes = classnames(
     'pb_typeahead_kit react-select',
     `mb_${marginBottom}`,
-    globalProps(filteredProps),
+    globalProps(props),
     className
   )
 

data/app/pb_kits/playbook/pb_typeahead/components/MultiValue.tsx

@@ -16,7 +16,7 @@ type Props = {
 const MultiValue = (props: Props) => {
   const { removeProps } = props
   const { imageUrl, label } = props.data
-  const { dark, multiKit, pillColor, truncate } = props.selectProps
+  const { dark, multiKit, pillColor } = props.selectProps
 
   const formPillProps = {
     marginRight: 'xs',
@@ -51,7 +51,6 @@ const MultiValue = (props: Props) => {
             name={label}
             size={multiKit === 'smallPill' ? 'small' : ''}
             text=''
-            truncate={truncate}
             {...props}
         />
       }
@@ -65,7 +64,6 @@ const MultiValue = (props: Props) => {
             name=''
             size={multiKit === 'smallPill' ? 'small' : ''}
             text={label}
-            truncate={truncate}
             {...props}
         />
       }

data/app/pb_kits/playbook/pb_typeahead/typeahead.rb

@@ -65,10 +65,10 @@ module Playbook
       def typeahead_react_options
         base_options = {
           className: classname,
+          pillColor: pill_color,
           dark: dark,
           defaultValue: default_options,
           error: error,
-          htmlOptions: html_options,
           id: id,
           inline: inline,
           isMulti: is_multi,
@@ -77,10 +77,8 @@ module Playbook
           multiKit: multi_kit,
           name: name,
           options: options,
-          pillColor: pill_color,
           placeholder: placeholder,
           plusIcon: plus_icon,
-          truncate: truncate,
         }
 
         base_options[:getOptionLabel] = get_option_label if get_option_label.present?

data/app/pb_kits/playbook/utilities/globalPropNames.mjs

@@ -1,7 +1,4 @@
 export default [
-  "minHeight",
-  "maxHeight",
-  "height",
   "left",
   "bottom",
   "right",

data/app/pb_kits/playbook/utilities/globalProps.ts

@@ -170,24 +170,12 @@ type ZIndex = {
   zIndex?: ZIndexType,
 } | ZIndexResponsiveType
 
-type Height = {
-  height?: string 
-}
-
-type MaxHeight = {
-  maxHeight?: string
-}
-
-type MinHeight = {
-  minHeight?: string
-}
-
 // keep this as the last type definition
 export type GlobalProps = AlignContent & AlignItems & AlignSelf &
   BorderRadius & Cursor & Dark & Display & DisplaySizes & Flex & FlexDirection &
   FlexGrow & FlexShrink & FlexWrap & JustifyContent & JustifySelf &
   LineHeight & Margin & MinWidth & MaxWidth & NumberSpacing & Order & Overflow & Padding &
-  Position & Shadow & TextAlign & Truncate & VerticalAlign & ZIndex & { hover?: string } & Top & Right & Bottom & Left & Height & MaxHeight & MinHeight;
+  Position & Shadow & TextAlign & Truncate & VerticalAlign & ZIndex & { hover?: string } & Top & Right & Bottom & Left;
 
 const getResponsivePropClasses = (prop: {[key: string]: string}, classPrefix: string) => {
   const keys: string[] = Object.keys(prop)
@@ -510,22 +498,7 @@ const PROP_CATEGORIES: {[key:string]: (props: {[key: string]: any}) => string} =
     } else {
       return verticalAlign ? `vertical_align_${verticalAlign} ` : ''
     }
-  },
-
-}
-
-const PROP_INLINE_CATEGORIES: {[key:string]: (props: {[key: string]: any}) => {[key: string]: any}} = {
-  heightProps: ({ height }: Height) => {
-    return height ? { height } : {}; 
-  },
-
-  maxHeightProps: ({ maxHeight }: MaxHeight) => {
-    return maxHeight ? { maxHeight } : {};
-  },
-
-  minHeightProps: ({ minHeight }: MinHeight) => {
-    return minHeight ? { minHeight } : {}; 
-  },
+  }
 }
 
 type DefaultProps = {[key: string]: string} | Record<string, unknown>
@@ -537,16 +510,6 @@ export const globalProps = (props: GlobalProps, defaultProps: DefaultProps = {})
   }).filter((value) => value?.length > 0).join(" ")
 }
 
-// New function for inline styles
-export const globalInlineProps = (props: GlobalProps): React.CSSProperties => {
-  const styles = Object.keys(PROP_INLINE_CATEGORIES).reduce((acc, key) => {
-    const result = PROP_INLINE_CATEGORIES[key](props);
-    return { ...acc, ...(typeof result === 'object' ? result : {}) }; // Ensure result is an object before spreading
-  }, {});
-
-  return styles; // Return the styles object directly
-}
-
 
 export const deprecatedProps = (): void => {
   // if (process.env.NODE_ENV === 'development') {