playbook_ui 14.5.0.pre.alpha.PBNTR595popoverwidthpropfilterpopoverprop4158 → 14.5.0.pre.alpha.PBNTR600reactfilterdisplayzeroresults4068

data/app/pb_kits/playbook/pb_multiple_users_stacked/docs/example.yml

@@ -3,13 +3,11 @@ examples:
   rails:
   - multiple_users_stacked_default: Default
   - multiple_users_stacked_bubble: Bubble
-  - multiple_users_stacked_size: Sizes
 
 
   react:
   - multiple_users_stacked_default: Default
   - multiple_users_stacked_bubble: Bubble
-  - multiple_users_stacked_size: Sizes
 
   swift: 
   - multiple_users_stacked_default_swift: Default

data/app/pb_kits/playbook/pb_multiple_users_stacked/docs/index.js

@@ -1,3 +1,2 @@
 export { default as MultipleUsersStackedDefault } from './_multiple_users_stacked_default.jsx'
 export { default as MultipleUsersStackedBubble } from './_multiple_users_stacked_bubble.jsx'
-export { default as MultipleUsersStackedSize } from './_multiple_users_stacked_size.jsx'

data/app/pb_kits/playbook/pb_multiple_users_stacked/multiple_users_stacked.html.erb

@@ -1,15 +1,5 @@
 <%= pb_content_tag do %>
-  <%= pb_rails(
-    "avatar",
-    props: object.users[0].merge({
-      classname: "pb_multiple_users_stacked_item first_item" +
-                 (object.double_bubble ? " double_bubble" : "") +
-                 (object.triple_bubble ? " triple_bubble" : "") +
-                 (object.quadruple_bubble ? " quadruple_bubble" : ""),
-      dark: object.dark,
-      size: 'xs'          
-    })
-  ) %>
+  <%= pb_rails("avatar", props: object.users[0].merge({size: object.bubble ? "sm" : "xs", classname: "pb_multiple_users_stacked_item first_item#{object.triple_bubble ? " triple_bubble" : ""}#{object.quadruple_bubble ? " quadruple_bubble" : ""}", dark: object.dark}) ) %>
 
   <% unless object.only_one %>
     <% if object.more_than_two && !object.bubble %>
@@ -18,26 +8,14 @@
         text: "+#{object.users.count - object.display_count}",
         variant: "primary",
         rounded: true,
-        classname: "pb_multiple_users_stacked_item second_item"
-      }) %>
+        classname: "pb_multiple_users_stacked_item second_item" }) %>
     <% elsif object.bubble %>
-      <% object.users.slice(1, 3).each_with_index do |item, idx| %>
-        <%= pb_rails(
-          "avatar",
-          props: item.merge({
-            classname: object.bubble_classname(idx),
-            dark: object.dark
-          })
-        ) %>
+      <% object.users.slice(1,3).each_with_index do |item, idx| %>
+        <%= pb_rails("avatar", props: item.merge({size: "xs", classname: "pb_multiple_users_stacked_item #{idx == 0 ? "second_item#{object.triple_bubble ? " triple_bubble" : ""}#{object.quadruple_bubble ? " quadruple_bubble" : ""}" : idx == 1 ? "third_item#{object.quadruple_bubble ? " quadruple_bubble" : ""}" : "fourth_item"}", dark: object.dark}) ) %>
       <% end %>
     <% else %>
-      <%= pb_rails(
-        "avatar",
-        props: object.users[1].merge({
-          classname: "pb_multiple_users_stacked_item second_item",
-          dark: object.dark
-        })
-      ) %>
+      <%= pb_rails("avatar", props: object.users[1].merge({size: "xs", classname: "pb_multiple_users_stacked_item second_item", dark: object.dark}) ) %>
     <% end %>
   <% end %>
+
 <% end %>

data/app/pb_kits/playbook/pb_multiple_users_stacked/multiple_users_stacked.rb

@@ -4,9 +4,6 @@ module Playbook
   module PbMultipleUsersStacked
     class MultipleUsersStacked < Playbook::KitBase
       prop :users, type: Playbook::Props::HashArray, required: true
-      prop :size, type: Playbook::Props::Enum,
-                  values: %w[sm md lg xl],
-                  default: "sm"
 
       prop :variant, type: Playbook::Props::Enum,
                      values: %w[default bubble],
@@ -28,10 +25,6 @@ module Playbook
         variant == "bubble"
       end
 
-      def double_bubble
-        bubble && users.count === 2
-      end
-
       def triple_bubble
         bubble && users.count === 3
       end
@@ -40,31 +33,8 @@ module Playbook
         bubble && users.count > 3
       end
 
-      def size_class
-        "size_#{size}" if bubble
-      end
-
       def classname
-        generate_classname("pb_multiple_users_stacked_kit", single_class, bubble_class, size_class)
-      end
-
-      def bubble_classname(index)
-        base_classname = "pb_multiple_users_stacked_item "
-
-        case index
-        when 0
-          base_classname += "second_item"
-          base_classname += " double_bubble" if double_bubble
-          base_classname += " triple_bubble" if triple_bubble
-          base_classname += " quadruple_bubble" if quadruple_bubble
-        when 1
-          base_classname += "third_item"
-          base_classname += " quadruple_bubble" if quadruple_bubble
-        else
-          base_classname += "fourth_item"
-        end
-
-        base_classname
+        generate_classname("pb_multiple_users_stacked_kit", single_class, bubble_class)
       end
 
     private

data/app/pb_kits/playbook/pb_popover/_popover.tsx

@@ -79,7 +79,6 @@ const Popover = (props: PbPopoverProps) => {
     maxWidth,
     minHeight,
     minWidth,
-    width,
     targetId,
   } = props;
 
@@ -98,8 +97,7 @@ const Popover = (props: PbPopoverProps) => {
       maxHeight ? { maxHeight: maxHeight } : {},
       maxWidth ? { maxWidth: maxWidth } : {},
       minHeight ? { minHeight: minHeight } : {},
-      minWidth ? { minWidth: minWidth } : {},
-      width ? { width: width } : {}
+      minWidth ? { minWidth: minWidth } : {}
     );
   };
   const ariaProps = buildAriaProps(aria);
@@ -169,7 +167,6 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
     maxWidth,
     minHeight,
     minWidth,
-    width,
   } = props;
 
   useEffect(() => {
@@ -219,7 +216,6 @@ const PbReactPopover = (props: PbPopoverProps): React.ReactElement => {
         placement={placement}
         referenceElement={referenceElement}
         targetId={targetId}
-        width={width}
         zIndex={zIndex}
         {...props}
     >

data/app/pb_kits/playbook/pb_popover/docs/_popover_default.html.erb

@@ -14,7 +14,7 @@
         trigger_element_id: "regular-popover-1",
         tooltip_id: "tooltip-1",
         offset: true,
-        position: "top",
+        position: "top"
     }) do %>
         I'm a popover. I can show content of any size.
     <% end %>

data/app/pb_kits/playbook/pb_popover/popover.rb

@@ -12,7 +12,6 @@ module Playbook
       prop :max_width
       prop :min_width
       prop :min_height
-      prop :width
       prop :z_index, type: Playbook::Props::String
       prop :offset, type: Playbook::Props::Boolean, default: false
       prop :close_on_click, type: Playbook::Props::Enum,
@@ -37,12 +36,11 @@ module Playbook
         out += "max-width: #{max_width}; " if max_width.present?
         out += "min-height: #{min_height}; " if min_height.present?
         out += "min-width: #{min_width};" if min_width.present?
-        out += "width: #{width};" if width.present?
         out
       end
 
       def width_height_class_helper
-        "overflow_handling" if max_height || max_width || width
+        "overflow_handling" if max_height || max_width
       end
 
       def data