playbook_ui 14.3.0 → 14.3.1.pre.alpha.PBNTR515typeaheadmarginbottomredux3746

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5eb649996c1fd3759b47ed9784e4189e1dba79f0a267936bb3843c2cff995d6c
-  data.tar.gz: cddd304f2aace5096dfa1035ac0e8dc304cfdb857b38d21606d7045d38d0ca97
+  metadata.gz: f422119e094bb65421697ac44567037f7dc9f7c1a6fa490b696245accea173d2
+  data.tar.gz: a9513ac152f0b28da77fcd545c9c288b1935d46c90f2c7e777b85a8edd57a2c5
 SHA512:
-  metadata.gz: 572786db824746207a14e7a5106b4da6af5d88d60aa0998aed2482a170431b477cfda472504d5b8bc9fc75c8b9fd2750148331d4a7273405a548f26bfc19b257
-  data.tar.gz: d3dd8bba1a7428ea356de7265d14cc3ef868e814e7a3f10043b5aaa3682896c998039226082a6ab063523dec461c184b1f7f0221c2224bf0c3305b6a33dd45fc
+  metadata.gz: c717f2203155c2e7acfee431ba79a78e6e6f392a3bc4fe57b50063067ad217fb95304818a563aa1009dc6369f95952dcbee28ca6746aeee8f5af1d891d85a873
+  data.tar.gz: a23cf73a0bbcd1cf5482469fc3786f1c857bceb090ab7f5e1fed709ff022ad95246b34be5be65d0696e55cb8c971ec4f145c9e17f94ed7855861f348c7cf05c2

data/app/pb_kits/playbook/pb_collapsible/_helper_functions.ts

@@ -6,6 +6,10 @@ export const showElement = (elem: HTMLElement) => {
   elem.style.overflow = "hidden"
   // Once the transition is complete, remove the inline max-height so the content can scale responsively
   window.setTimeout(() => {
+    // If a user toggles multiple times quickly in a row, 'is-visible' can be removed by hideElement's timeout
+    if (!elem.classList.contains('is-visible')) {
+      elem.classList.add('is-visible')
+    }
     elem.style.height = '';
     elem.style.overflow = "visible"
   }, 300);

data/app/pb_kits/playbook/pb_radio/docs/_radio_children.jsx

@@ -18,32 +18,29 @@ const RadioChildren = (props) => {
     <div>
       <Radio
           label="Select"
-          marginBottom="sm"
           name="Group1"
           tabIndex={0}
           value="Select"
           {...props}
       >
         <Select 
-            marginBottom="none"
             minWidth="xs"
             options={options}
         />
       </Radio>
       <Radio
           label="Typeahead"
-          marginBottom="sm"
           name="Group1"
           tabIndex={0}
           value="Typeahead"
           {...props}
       >
         <Typeahead 
-            marginBottom="none"
             minWidth="xs"
             options={options}
         />
       </Radio>
+      <br />
       <Radio
           defaultChecked={false}
           label="Typography"

data/app/pb_kits/playbook/pb_text_input/_text_input.scss

@@ -45,6 +45,7 @@
       }
     }
     .text_input_wrapper {
+      margin-bottom: 1rem;
       input::placeholder,
       .text_input .placeholder {
         @include pb_body_light_dark;

data/app/pb_kits/playbook/pb_typeahead/_typeahead.test.jsx

@@ -107,17 +107,4 @@ test('should pass className prop', () => {
 
   const kit = screen.getByTestId('typeahead-test')
   expect(kit).toHaveClass(className)
-})
-
-test('typeahead textinput has mb_sm class by default', () => {
-  render(
-    <Typeahead
-        data={{ testid: 'default-mb-test' }}
-        options={options} 
-    />
-  )
-
-  const kit = screen.getByTestId('default-mb-test')
-  const textInput = kit.querySelector(".pb_text_input_kit")
-  expect(textInput).toHaveClass("mb_sm")
 })

data/app/pb_kits/playbook/pb_typeahead/_typeahead.tsx

@@ -83,12 +83,7 @@ const Typeahead = ({
   const selectProps = {
     cacheOptions: true,
     components: {
-      Control: (controlProps: any) => (
-        <Control 
-            {...controlProps} 
-            marginBottom={marginBottom} 
-        />
-      ),
+      Control,
       ClearIndicator,
       IndicatorsContainer,
       IndicatorSeparator: null as null,
@@ -141,6 +136,7 @@ const Typeahead = ({
   const htmlProps = buildHtmlProps(htmlOptions)
   const classes = classnames(
     'pb_typeahead_kit react-select',
+    `mb_${marginBottom}`,
     globalProps(props),
     className
   )

data/app/pb_kits/playbook/pb_typeahead/components/Control.tsx

@@ -3,14 +3,15 @@ import { components } from 'react-select'
 
 import Flex from '../../pb_flex/_flex'
 import TextInput from '../../pb_text_input/_text_input'
+import { MarginBottomType } from '../_typeahead'
+
 
 type Props = {
   selectProps: any,
-  marginBottom?: string,
 }
 
 const TypeaheadControl = (props: Props) => {
-  const { selectProps, marginBottom } = props
+  const { selectProps } = props
   const { dark, error, label } = selectProps
 
   return (
@@ -19,7 +20,7 @@ const TypeaheadControl = (props: Props) => {
           dark={dark}
           error={error}
           label={label}
-          marginBottom={marginBottom}
+          marginBottom="none"
       >
         <Flex>
           <components.Control

data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_margin_bottom.jsx

@@ -57,4 +57,4 @@ const TypeaheadMarginBottom = (props) => {
   )
 }
 
-export default TypeaheadMarginBottom
+export default TypeaheadMarginBottom

data/app/pb_kits/playbook/pb_typeahead/docs/example.yml

@@ -9,7 +9,6 @@ examples:
     - typeahead_inline: Inline
     - typeahead_multi_kit: Multi Kit Options
     - typeahead_error_state: Error State
-    - typeahead_margin_bottom: Margin Bottom
 
   react:
     - typeahead_default: Default

data/app/pb_kits/playbook/pb_typeahead/typeahead.html.erb

@@ -20,8 +20,7 @@
         label: object.label,
         name: object.name,
         value: object.value,
-        placeholder: object.placeholder,
-        margin_bottom: "none",
+        placeholder: object.placeholder
       }) %>
       <%= pb_rails("list", props: { ordered: false, borderless: false, xpadding: true, role: "status", aria: { live: "polite" }, data: { pb_typeahead_kit_results: true } }) do %>
       <% end %>

data/app/pb_kits/playbook/pb_typeahead/typeahead.rb

@@ -14,9 +14,6 @@ module Playbook
                     default: false
       prop :label
       prop :load_options
-      prop :margin_bottom, type: Playbook::Props::Enum,
-                           values: %w[none xxs xs sm md lg xl],
-                           default: "sm"
       prop :multi_kit, type: Playbook::Props::String,
                        default: ""
       prop :name
@@ -39,8 +36,7 @@ module Playbook
       prop :value
 
       def classname
-        default_margin_bottom = margin_bottom.present? ? "" : " mb_sm"
-        generate_classname("pb_typeahead_kit") + default_margin_bottom
+        generate_classname("pb_typeahead_kit")
       end
 
       def inline_class
@@ -69,7 +65,6 @@ module Playbook
           inline: inline,
           isMulti: is_multi,
           label: label,
-          marginBottom: margin_bottom,
           multiKit: multi_kit,
           name: name,
           options: options,