playbook_ui 14.25.0.pre.alpha.PLAY2414removedialoghelper10118 → 14.25.0.pre.alpha.PLAY2419dialogaccessibility10271

data/app/pb_kits/playbook/pb_radio/docs/_radio_react_hook.jsx

@@ -19,7 +19,6 @@ const RadioReactHook = () => {
           paddingRight="lg"
         >
         <Radio
-            alignment="left"
             label="Small"
             marginBottom='sm'
             name="size"
@@ -28,7 +27,6 @@ const RadioReactHook = () => {
         />
         <br />
         <Radio
-            alignment="left"
             label="Medium"
             marginBottom='sm'
             name="size"
@@ -37,7 +35,6 @@ const RadioReactHook = () => {
         />
         <br />
         <Radio
-            alignment="left"
             label="Large"
             marginBottom='sm'
             name="size"

data/app/pb_kits/playbook/pb_rich_text_editor/_rich_text_editor.scss

@@ -10,7 +10,7 @@
 @import "./trix_styles";
 @import "./tiptap_styles";
 
-[class^=pb_rich_text_editor_kit] {
+.pb_rich_text_editor_kit {
   // Disables File Attatchment Button in Toolbar
   trix-toolbar [data-trix-button-group="file-tools"] {
     display: none;
@@ -126,7 +126,7 @@
   }
   // Trix doesn't provide customization to their icons.
   // https://github.com/basecamp/trix/issues/464#issuecomment-564683997
-  &[class*=dark] {
+  &.dark {
     // Dark SVG Icon Styles
     .trix-button--icon-bold::before {
       background-image: url("data:image/svg+xml,%3Csvg width='11px' height='14px' viewBox='0 0 11 14' version='1.1' xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink'%3E%3Cg id='Symbols' stroke='none' stroke-width='1' fill='none' fill-rule='evenodd' fill-opacity='0.6'%3E%3Cg id='Rich-Text/Dark/Field-Only/Empty' transform='translate(-19.000000, -17.000000)' fill='%23FFFFFF' fill-rule='nonzero'%3E%3Cg id='Styling1' transform='translate(7.000000, 7.000000)'%3E%3Cpath d='M20.6,16.79 C21.565,16.115 22.25,15.025 22.25,14 C22.25,11.745 20.505,10 18.25,10 L12,10 L12,24 L19.04,24 C21.135,24 22.75,22.3 22.75,20.21 C22.75,18.69 21.885,17.395 20.6,16.79 Z M15,12.5 L18,12.5 C18.83,12.5 19.5,13.17 19.5,14 C19.5,14.83 18.83,15.5 18,15.5 L15,15.5 L15,12.5 L15,12.5 Z M18.5,21.5 L15,21.5 L15,18.5 L18.5,18.5 C19.33,18.5 20,19.17 20,20 C20,20.83 19.33,21.5 18.5,21.5 Z' id='Shape'%3E%3C/path%3E%3C/g%3E%3C/g%3E%3C/g%3E%3C/svg%3E");
@@ -291,14 +291,14 @@
         background-color: $focus_input_light;
       }
     }
-    &[class*=dark]:hover {
+    &.dark:hover {
       .trix-button-row,
       trix-editor {
         background-color: rgba($white, 0.1);
         border-color: rgba($white, 0.15);
       }
     }
-    &[class*=dark]:focus-within {
+    &.dark:focus-within {
       .trix-button-row,
       trix-editor {
         background-color: rgba($white, 0.03);

data/app/pb_kits/playbook/pb_section_separator/_section_separator.scss

@@ -18,7 +18,7 @@ $section_colors_dark: (
   card:         tint($bg_dark,10),
 );
 
-[class^=pb_section_separator_kit] {
+.pb_section_separator_kit {
   display: flex;
   justify-content: center;
   align-items: center;
@@ -26,7 +26,7 @@ $section_colors_dark: (
   span {
     padding: 0;
     display: flex;
-    [class*="pb_caption_kit"] {
+    .pb_caption_kit_md {
       padding: 0 $space_xs;
     }
   }
@@ -42,96 +42,107 @@ $section_colors_dark: (
     flex: 1;
     @include section_separator_horizontal;
   }
-  @each $color_name, $color_value in $section_selector_colors {
-    &[class*="color_#{$color_name}"] {
-      &::before, &::after {
+}
+
+// Horizontal orientation (default)
+.pb_section_separator_horizontal {
+  justify-content: center;
+}
+
+// Vertical orientation
+.pb_section_separator_vertical {
+  margin-left: $space_xs;
+  margin-right: $space_xs;
+  &::before {
+    display: none;
+  }
+  &::after {
+    @include section_separator_vertical(false);
+  }
+}
+
+// Dashed line style
+.pb_section_separator_dashed {
+  &::before, &::after {
+    @include section_separator_dashed(false);
+  }
+}
+
+// Color variations
+@each $color_name, $color_value in $section_selector_colors {
+  .pb_section_separator_color_#{$color_name} {
+    &::before, &::after {
+      background: $color_value;
+    }
+
+    &.pb_section_separator_vertical {
+      &::after {
         background: $color_value;
       }
-
-      &[class*=_vertical] {
-        &::after {
-          background: $color_value;
-        }
+    }
+    
+    &.pb_section_separator_dashed {
+      &::before, &::after {
+        border: 1px dashed $color_value;
+        background: none;
       }
-      &[class*=_dashed] {
-        &::before, &::after {
+      &.pb_section_separator_vertical {
+        &::after {
           border: 1px dashed $color_value;
-        }
-        &[class*=_vertical] {
-          &::after {
-            border: 1px dashed $color_value;
-            background: none;
-          }
+          background: none;
         }
       }
     }
   }
+}
 
-  &[class*=_horizontal] {
-    justify-content: center;
+// Dark mode styles
+.pb_section_separator_kit.dark {
+  &::before {
+    @include section_separator_horizontal(true);
   }
-  &[class*=_vertical] {
-    margin-left: $space_xs;
-    margin-right: $space_xs;
-    &::before {
-      display: none;
-    }
+  &::after {
+    @include section_separator_horizontal(true);
+  }
+  
+  &.pb_section_separator_vertical {
     &::after {
-      @include section_separator_vertical(false);
+      @include section_separator_vertical(true);
     }
   }
-
-  &[class*=_dashed] {
+  
+  &.pb_section_separator_dashed {
     &::before, &::after {
-      @include section_separator_dashed(false);
+      @include section_separator_dashed(true);
     }
   }
+}
 
-  // Dark =========================
-
-  &.dark {
-    @each $color_name, $color_value in $section_selector_colors {
-      &[class*="color_#{$color_name}"] {
-        &::before, &::after {
-          background: $color_value;
-        }
-
-        &[class*=_vertical] {
-          &::after {
-            @include section_separator_vertical(false);
-            background: $color_value;
-          }
-        }
-
-        &[class*=_dashed] {
-          &::before, &::after {
-            border: 1px dashed $color_value;
-            background: none;
-          }
-          &[class*=_vertical] {
-            &::after {
-              border: 1px dashed $color_value;
-              background: none;
-            }
-          }
-        }
-      }
-    }
-    &::before {
-      @include section_separator_horizontal(true);
-    }
-    &::after {
-      @include section_separator_horizontal(true);
+// Dark mode color variations
+@each $color_name, $color_value in $section_selector_colors {
+  .pb_section_separator_kit.dark.pb_section_separator_color_#{$color_name} {
+    &::before, &::after {
+      background: $color_value;
     }
-    &[class*=_vertical] {
+
+    &.pb_section_separator_vertical {
       &::after {
-        @include section_separator_vertical(true);
+        @include section_separator_vertical(false);
+        background: $color_value;
       }
     }
-    &[class*=_dashed] {
+
+    &.pb_section_separator_dashed {
       &::before, &::after {
-        @include section_separator_dashed(true);
+        border: 1px dashed $color_value;
+        background: none;
+      }
+      &.pb_section_separator_vertical {
+        &::after {
+          border: 1px dashed $color_value;
+          background: none;
+        }
       }
     }
   }
-}
+}

data/app/pb_kits/playbook/pb_section_separator/_section_separator.tsx

@@ -39,7 +39,15 @@ const SectionSeparator = (props: SectionSeparatorProps): React.ReactElement => {
   const ariaProps = buildAriaProps(aria)
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)
-  const classes = classnames(buildCss('pb_section_separator_kit', variant, orientation, lineStyle === "dashed" ? lineStyle : "", color !== "default" ? `color_${color}` : ''), globalProps(props), className)
+  const classes = classnames(
+    'pb_section_separator_kit',
+    `pb_section_separator_${variant}`,
+    `pb_section_separator_${orientation}`,
+    lineStyle === "dashed" ? 'pb_section_separator_dashed' : 'pb_section_separator_solid',
+    color !== "default" ? `pb_section_separator_color_${color}` : 'pb_section_separator_color_default',
+    globalProps(props),
+    className
+  )
   const dynamicInlineProps = globalInlineProps(props)
 
   return (

data/app/pb_kits/playbook/pb_section_separator/_section_separator_mixin.scss

@@ -30,4 +30,4 @@
         border: 1px dashed $border_dark;
         background: none;
     }
-}
+}

data/app/pb_kits/playbook/pb_section_separator/docs/_section_separator_color.jsx

@@ -5,7 +5,9 @@ import Detail from '../../pb_detail/_detail'
 import Icon from '../../pb_icon/_icon'
 
 const children = (
-  <Flex padding="xs">
+  <Flex alignItems="center"
+      padding="xs"
+  >
     <Icon color="primary"
         icon="arrow-down"
     />

data/app/pb_kits/playbook/pb_section_separator/section_separator.rb

@@ -20,7 +20,13 @@ module Playbook
                         default: "solid"
 
       def classname
-        generate_classname("pb_section_separator_kit", variant, orientation, line_style == "dashed" ? "dashed" : nil, color != "default" ? "color_#{color}" : nil)
+        class_names = ["pb_section_separator_kit"]
+        class_names << "pb_section_separator_#{variant}"
+        class_names << "pb_section_separator_#{orientation}"
+        class_names << "pb_section_separator_#{line_style}"
+        class_names << "pb_section_separator_color_#{color}"
+
+        generate_classname(class_names.join(" "), separator: " ")
       end
 
     private

data/app/pb_kits/playbook/pb_select/_select.scss

@@ -4,7 +4,7 @@
 @import "../tokens/colors";
 @import "../tokens/spacing";
 
-[class^=pb_select] {
+.pb_select {
   select {
     @include pb_textarea_light;
     @include pb_body_light;
@@ -80,7 +80,7 @@
     position: relative;
     display: block;
     &.error {
-      [class*=pb_body_kit] {
+      > .pb_body_kit_negative {
         margin-top: $space_xs / 2;
       }
       > select:first-child {
@@ -157,7 +157,7 @@
   }
 }
 
-[class^=pb_select].dark {
+.pb_select.dark {
   select {
     @include pb_textarea_dark;
     @include pb_body_light_dark;
@@ -260,4 +260,4 @@
       }
     }
   }
-}
+}

data/app/pb_kits/playbook/pb_selectable_card/_selectable_card.scss

@@ -28,7 +28,11 @@ $pb_selectable_paddings: (
   py: ("padding-top", "padding-bottom")
 );
 
-[class^=pb_selectable_card_kit] {
+.pb_selectable_card_kit,
+.pb_selectable_card_kit_checked_disabled,
+.pb_selectable_card_kit_checked_enabled,
+.pb_selectable_card_kit_disabled,
+.pb_selectable_card_kit_enabled {
   display: block;
   margin-bottom: 0;
 
@@ -212,4 +216,4 @@ $pb_selectable_paddings: (
       background: $error;
     }
   }
-}
+}

data/app/pb_kits/playbook/pb_selectable_card_icon/_selectable_card_icon.scss

@@ -1,9 +1,13 @@
-[class^=pb_selectable_card_icon_kit] {
+.pb_selectable_card_icon_kit,
+.pb_selectable_card_icon_kit_checked_disabled,
+.pb_selectable_card_icon_kit_checked_enabled,
+.pb_selectable_card_icon_kit_disabled,
+.pb_selectable_card_icon_kit_enabled {
 
 	text-align: center;
 	user-select: none;
 
-  .buffer > [class*=pb_selectable_icon_kit]::before {
+  .buffer > .pb_selectable_icon_kit::before {
     content: '';
     position: absolute;
     width: 100%;
@@ -12,7 +16,7 @@
     left: 0;
   }
 
-  .buffer > [class*=pb_selectable_icon_kit] {
+  .buffer > .pb_selectable_icon_kit {
     @media (hover:hover) {
       &:hover * {
             transition: transform $transition_short ease;
@@ -42,7 +46,8 @@
       }
     }
 
-    &[class*=_disabled] {
+    &.pb_selectable_card_icon_kit_disabled,
+    &.pb_selectable_card_icon_kit_checked_disabled {
       opacity: $opacity_6;
       cursor: not-allowed;
 
@@ -79,15 +84,19 @@
     }
   }
 
-  [class^=pb_selectable_icon_kit] {
+  .pb_selectable_icon_kit {
     margin-bottom: 0px;
   }
 
-  [class^=pb_body_kit_light] {
+  .pb_body_kit_light {
     margin-top: $space_xs;
   }
 
-  [class^=pb_selectable_card_kit] {
+  .pb_selectable_card_kit,
+  .pb_selectable_card_kit_checked_disabled,
+  .pb_selectable_card_kit_checked_enabled,
+  .pb_selectable_card_kit_disabled,
+  .pb_selectable_card_kit_enabled {
     margin-bottom: 0px !important;
   }
-}
+}

data/app/pb_kits/playbook/pb_selectable_icon/_selectable_icon.scss

@@ -1,6 +1,11 @@
 @import "../tokens/transition";
 
-[class^=pb_selectable_icon] {
+.pb_selectable_icon_kit,
+.pb_selectable_icon_kit_checked,
+.pb_selectable_icon_kit_enabled,
+.pb_selectable_icon_kit_disabled,
+.pb_selectable_icon_kit_checked_enabled,
+.pb_selectable_icon_kit_checked_disabled {
 
 	text-align: center;
 	cursor: pointer;
@@ -27,14 +32,6 @@
 		transition: color $transition_short ease;
 	}
 
-	&[class*=_disabled] {
-		opacity: $opacity_6;
-		cursor: not-allowed;
-		* {
-			cursor: not-allowed;
-		}
-	}
-	
 	input[type="checkbox"],
 	input[type="radio"] {
 		-webkit-appearance: none;
@@ -54,33 +51,46 @@
 
 		}
 	}
+}
 
+.pb_selectable_icon_kit_disabled,
+.pb_selectable_icon_kit_checked_disabled {
+	opacity: $opacity_6;
+	cursor: not-allowed;
+	* {
+		cursor: not-allowed;
+	}
+}
 
-	&.dark {
-		input[type="checkbox"],
-		input[type="radio"] {
-			-webkit-appearance: none;
-			-moz-appearance: none;
-			display: none;
-			appearance: none;
+.pb_selectable_icon_kit.dark,
+.pb_selectable_icon_kit_checked.dark,
+.pb_selectable_icon_kit_enabled.dark,
+.pb_selectable_icon_kit_disabled.dark,
+.pb_selectable_icon_kit_checked_enabled.dark,
+.pb_selectable_icon_kit_checked_disabled.dark {
+	input[type="checkbox"],
+	input[type="radio"] {
+		-webkit-appearance: none;
+		-moz-appearance: none;
+		display: none;
+		appearance: none;
+		transition: color $transition_short ease;
+		
+		&:checked ~ label * {
 			transition: color $transition_short ease;
+			color: $active_dark !important;
+		}
 			
-			&:checked ~ label * {
-				transition: color $transition_short ease;
-				color: $active_dark !important;
-			}
-				
-			&:not(:checked) ~ label {
-				transition: color $transition_short ease;
-				color: $text_dk_lighter;
+		&:not(:checked) ~ label {
+			transition: color $transition_short ease;
+			color: $text_dk_lighter;
 
-				h4 {
-					transition: color $transition_short ease;
-					color: $text_dk_default;
-				}
+			h4 {
+				transition: color $transition_short ease;
+				color: $text_dk_default;
 			}
 		}
- 	}
+	}
 }
 
 

data/app/pb_kits/playbook/pb_selectable_list/_item.tsx

@@ -82,6 +82,7 @@ const SelectableListItem = ({
             <Checkbox
                 checked={checkedState}
                 id={id}
+                marginLeft="xs"
                 name={name}
                 onChange={handleChecked}
                 // eslint suppressor, text is needed to display on screen
@@ -98,6 +99,7 @@ const SelectableListItem = ({
         {variant == "radio" && (
           <>
             <Radio
+                className="ml_xs"
                 defaultChecked={defaultChecked}
                 id={id}
                 label={label}

data/app/pb_kits/playbook/pb_selectable_list/_selectable_list.scss

@@ -1,20 +1,17 @@
 @import "../tokens/colors";
 @import "../tokens/spacing";
 
-[class^=pb_selectable_list]{
+.pb_selectable_list_kit {
   margin-bottom: 0px;
-  [class^=pb_item_kit] {
+  
+  .pb_item_kit,
+  .pb_item_kit_checked_item {
     &:hover {
       background-color: $bg_light;
     }
-    &[class*=checked_item] {
-      background-color: $active_light;
-    }
-  }
-  [class^=pb_radio_kit] {
-    margin-left: $space_xs;
   }
-  [class^=pb_checkbox_kit] {
-    margin-left: $space_xs;
+
+  .checked_item {
+    background-color: $active_light;
   }
-}
+}

data/app/pb_kits/playbook/pb_selectable_list/selectable_list.test.js

@@ -35,7 +35,6 @@ const SelectableListRadio = () => {
             value="1"
         />
         <SelectableList.Item
-            defaultChecked
             label="Medium"
             name="radio"
             value="2"
@@ -62,7 +61,7 @@ test("renders variant checkbox", () => {
 test("renders variant radio", () => {
     render(<SelectableListRadio />)
     const kit = screen.getByTestId("selectable-list-test")
-    const checkbox = kit.querySelector(".pb_radio_kit")
-    expect(checkbox).toBeInTheDocument()
+    const radio = kit.querySelector("input[type='radio']")
+    expect(radio).toBeInTheDocument()
 
 })

data/app/pb_kits/playbook/pb_selectable_list/selectable_list_item.html.erb

@@ -12,12 +12,12 @@
     </span>
   <% end %>
   <% if object.variant == "radio"%>
-    <%= pb_rails("radio", props: { text: object.text, checked: object.checked, input_options: object.input_options } ) %>
+    <%= pb_rails("radio", props: { margin_left:"xs", text: object.text, checked: object.checked, input_options: object.input_options } ) %>
     <% if content.present? %>
       <%= content %>
     <% end %>
   <% else %>
-    <%= pb_rails("checkbox", props: { text: object.text, checked: object.checked, input_options: object.input_options } ) %>
+    <%= pb_rails("checkbox", props: { margin_left:"xs", text: object.text, checked: object.checked, input_options: object.input_options } ) %>
     <% if content.present? %>
       <%= content %>
     <% end %>

data/app/pb_kits/playbook/pb_source/_source.scss

@@ -1,29 +1,29 @@
 @import "../tokens/spacing";
 
-[class^=pb_source] {
-  [class^=pb__source_layout] {
+.pb_source_kit {
+  .pb__source_layout {
     display: flex;
     justify-content: flex-start;
     align-items: flex-start;
   }
 
-  [class^=pb_icon_circle],
-  [class^=pb_avatar] {
+  .pb_icon_circle_kit_size_sm_default,
+  .pb_avatar_kit_size_sm {
     margin-right: $space-sm;
   }
 
-  [class^=pb__source_content] {
+  .pb__source_content {
     display: block;
     flex-grow: 1;
 
-    [class^=pb__source_value] {
+    .pb__source_value {
       display: flex;
       justify-content: flex-start;
       align-items: baseline;
 
-      [class^=pb_body] {
+      .pb_body_kit {
         margin-right: $space-xs;
       }
     }
   }
-}
+}

data/app/pb_kits/playbook/pb_star_rating/_star_rating.scss

@@ -3,7 +3,7 @@
 @import "../tokens/spacing";
 
 
-[class*=pb_star_rating_kit] {
+.pb_star_rating_kit {
   display: flex;
   align-items: flex-end;
   justify-content: flex-start;

data/app/pb_kits/playbook/pb_star_rating/star_rating.test.js

@@ -65,7 +65,7 @@ describe("Star Rating Kit", () => {
     const stars = highlight.querySelectorAll(".pb_star_lg")
     const count = stars.length
 
-    expect(title.className).toBe("pb_title_kit_size_2_light_thin pr_sm pb_star_rating_number_lg")
+    expect(title.className).toBe("pb_title_kit pb_title_2 pb_title_light pb_title_thin pr_sm pb_star_rating_number_lg")
     expect(count).toBe(5)
   })
 })

data/app/pb_kits/playbook/pb_stat_value/_stat_value.scss

@@ -1,7 +1,7 @@
 @import "../pb_title/title";
 
-[class^=pb_stat_value_kit]{
-  [class^=pb_stat_value_wrapper] {
+.pb_stat_value_kit {
+  .pb_stat_value_wrapper {
     display: flex;
     justify-content: flex-start;
     align-items: baseline;