playbook_ui 14.24.0.pre.alpha.testingwithoutlazyload9529 → 14.24.0.pre.rc.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64a141d94e5ef234fb2ec95185ff176aad2ae02840bb184cc7840e7665256659
-  data.tar.gz: d8dffbb0f1a40ec480be47fb056a9b5f3ff1518cb8791252e5c56dcbb1c1bb73
+  metadata.gz: 0e6c42711223f44800761968ff6b12e3e01d675dbf792208ac3af880849420ba
+  data.tar.gz: 7ac59da841cc4a9040005e6de70ff3e1e87645917aa19714338d8031397d97e9
 SHA512:
-  metadata.gz: fb17faa5c45ee69cc85d0422d23eb52a112c3a8d3ce6c5e174960d751964a32b8993336dc86811769f361e78c0314465305cc1c97b5a2c06bbbf918691c2383b
-  data.tar.gz: 3e0d0be40dd0afd0f8b57629cdc54557392f4ef7d28b981d24b3cb95dc0004e285320607a092d873d6411b9eb30a0bf54c6a877ac63ff65f93dae80a4b80b5fd
+  metadata.gz: f0e3d0844fe67b12098f03a4eb1c4c31fd1307d6f4fec41c3c324fbe4645336a89af6abfb7f80a49ba292f6824677c88cd98c9624df441e61a5764605a62bb15
+  data.tar.gz: 51924ba09262e9be87069173a5b994f843f42e45c4da68def19965c66161842eeef85be41d968c68244b4ffff73337e0dd0afe9d5e141b481ba86460bc0732c5

data/app/pb_kits/playbook/_playbook.scss

@@ -107,6 +107,7 @@
 @import 'pb_typeahead/typeahead';
 @import 'pb_user/user';
 @import 'pb_user_badge/user_badge';
+@import 'pb_walkthrough/walkthrough';
 @import 'pb_weekday_stacked/weekday_stacked';
 @import 'pb_empty_state/empty_state';
 @import 'utilities/mixins';

data/app/pb_kits/playbook/pb_advanced_table/Components/CustomCell.tsx

@@ -20,7 +20,7 @@ interface CustomCellProps {
   customRenderer?: (row: Row<GenericObject>, value: string | undefined) => React.ReactNode
   selectableRows?: boolean
   customStyle?: GenericObject
-} 
+}
 
 export const CustomCell = ({
   getValue,
@@ -35,7 +35,7 @@ export const CustomCell = ({
 
   const handleOnExpand = (row: Row<GenericObject>) => {
     onRowToggleClick && onRowToggleClick(row);
-    
+
     if (!expandedControl) {
       setExpanded({ ...expanded, [row.id]: !row.getIsExpanded() });
     }
@@ -46,8 +46,8 @@ export const CustomCell = ({
 
   return (
     <div style={{ paddingLeft: `${row.depth * 1.25}em`}}>
-      <Flex 
-          alignItems="center" 
+      <Flex
+          alignItems="center"
           columnGap="xs"
           justify="start"
           orientation="row"
@@ -71,12 +71,11 @@ export const CustomCell = ({
           >
             {row.getIsExpanded() ? (
               <Icon cursor="pointer"
-                  icon="circle-play"
-                  rotation={90}
+                  icon="circle-play-down"
               />
             ) : (
               <Icon cursor="pointer"
-                  icon="circle-play"    
+                  icon="circle-play"
                />
             )}
           </button>

data/app/pb_kits/playbook/pb_advanced_table/Components/RegularTableView.tsx

@@ -58,9 +58,7 @@ const TableCellRenderer = ({
         // Find the “owning” colDefinition by accessor. Needed for multi column logic
         const colDef = findColumnDefByAccessor(columnDefinitions ?? [], column.id)
         const cellAlignment = colDef?.columnStyling?.cellAlignment ?? "right"
-        const paddingValue = colDef?.columnStyling?.cellPadding ?? customRowStyle?.cellPadding
-        const paddingClass = paddingValue ? `p_${paddingValue}` : undefined
-        
+
         return (
           <td
               align={cellAlignment}
@@ -70,7 +68,6 @@ const TableCellRenderer = ({
                 isPinnedLeft && 'pinned-left',
                 stickyLeftColumn && stickyLeftColumn.length > 0 && isPinnedLeft && 'sticky-left',
                 isLastCell && 'last-cell',
-                paddingClass
               )}
               key={`${cell.id}-data`}
               style={{

data/app/pb_kits/playbook/pb_advanced_table/Components/SortIconButton.tsx

@@ -4,48 +4,49 @@ import { Header } from "@tanstack/react-table"
 import { GenericObject } from "../../types"
 
 import Icon from "../../pb_icon/_icon"
+import { getAllIcons } from "../../utilities/icons/allicons"
 
 import { displayIcon } from "../Utilities/IconHelpers"
 
 type SortIconButtonProps = {
   header: Header<GenericObject, unknown>
   sortIcon?: string | string[]
-  enableSortingRemoval?: boolean
 }
 
-export const SortIconButton = ({ header, sortIcon, enableSortingRemoval }: SortIconButtonProps) => {
-  const firstIcon = displayIcon(sortIcon)[0]
-  const secondIcon = displayIcon(sortIcon)[1]
+export const SortIconButton = ({ header, sortIcon }: SortIconButtonProps) => {
+
+const firstIcon = displayIcon(sortIcon)[0] 
+const secondIcon = displayIcon(sortIcon)[1] 
+const upIcon = getAllIcons()["arrowUpShortWide"].icon as unknown as { [key: string]: SVGElement }
+const downIcon = getAllIcons()["arrowDownShortWide"].icon as unknown as { [key: string]: SVGElement }
 
   return (
     <>
-      {header.column.getIsSorted() === "desc" && (
-        <div
-            className="sort-button-icon"
+      {header.column.getIsSorted() === "desc" ? (
+        <div className="sort-button-icon" 
             key={firstIcon}
-            style={{ paddingLeft: `${header?.index === 0 ? "2px" : "4px"}` }}
         >
+        { firstIcon === "arrow-up-short-wide" ? (
+          <Icon 
+              className="svg-inline--fa"
+              customIcon={upIcon}
+          /> ) : (
           <Icon icon={firstIcon} />
+        )}
         </div>
-      )}
-      {header.column.getIsSorted() === "asc" && (
-        <div
-            className="sort-button-icon"
+      ) : (
+        <div className="sort-button-icon" 
             key={secondIcon}
-            style={{ paddingLeft: `${header?.index === 0 ? "2px" : "4px"}` }}
         >
+        { secondIcon === "arrow-down-short-wide" ? (
+          <Icon 
+              className="svg-inline--fa"
+              customIcon={downIcon}
+          /> ) : (
           <Icon icon={secondIcon} />
-        </div>
-      )}
-      {header.column.getIsSorted() === false && (
-        <div
-            className="sort-button-icon"
-            key={enableSortingRemoval ? "arrow-up-arrow-down" : secondIcon}
-            style={{ paddingLeft: `${header?.index === 0 ? "2px" : "4px"}` }}
-        >
-          <Icon icon={enableSortingRemoval ? "arrow-up-arrow-down" : secondIcon} />
+        )}
         </div>
       )}
     </>
-  );
-};
+  )
+}

data/app/pb_kits/playbook/pb_advanced_table/Components/TableActionBar.tsx

@@ -112,7 +112,7 @@ const TableActionBar: React.FC<TableActionBarProps> = ({
             paddingBottom="xs"
             text={node.label}
         />
-        <Flex flexDirection="column"
+        <Flex flexDirection="column" 
             paddingLeft="lg"
         >
           {node?.children?.map((child) =>
@@ -141,8 +141,8 @@ const TableActionBar: React.FC<TableActionBarProps> = ({
     setShowPopover(!shouldClose)
 
   const popoverReference = (
-    <Tooltip
-        placement="top"
+    <Tooltip 
+        placement="top" 
         text="Column Configuration"
     >
       <div onClick={togglePopover}>
@@ -170,8 +170,8 @@ const TableActionBar: React.FC<TableActionBarProps> = ({
       >
         {type === "row-selection" ? (
           <>
-            <Caption color="light"
-                paddingLeft="xs"
+            <Caption color="light" 
+                paddingLeft="xs" 
                 size="xs"
             >
               {selectedCount} Selected
@@ -188,15 +188,15 @@ const TableActionBar: React.FC<TableActionBarProps> = ({
               zIndex={3}
           >
             <>
-              <Caption
-                  paddingY="sm"
+              <Caption 
+                  paddingY="sm" 
                   text="Columns Config"
-                  textAlign="center"
+                  textAlign="center" 
               />
               <SectionSeparator paddingBottom="xs" />
               {tree.map((node: VisibilityNode) => (
-                <Flex cursor="pointer"
-                    flexDirection="column"
+                <Flex cursor="pointer" 
+                    flexDirection="column" 
                     key={node.id}
                     paddingX="xs"
                 >

data/app/pb_kits/playbook/pb_advanced_table/Components/TableHeaderCell.tsx

@@ -50,7 +50,6 @@ export const TableHeaderCell = ({
     expanded,
     setExpanded,
     expandByDepth,
-    enableSortingRemoval,
     onExpandByDepthClick,
     toggleExpansionIcon,
     sortControl,
@@ -65,7 +64,6 @@ export const TableHeaderCell = ({
 
   type justifyTypes = "none" | "center" | "start" | "end" | "between" | "around" | "evenly"
   
-  
   const toggleSortButton = (event: React.SyntheticEvent) => {
     if (sortControl) {
       const sortIsDesc = header?.column.getIsSorted() === "desc"
@@ -103,6 +101,7 @@ export const TableHeaderCell = ({
     if (!header) return false;
   
     if (header.colSpan > 1 && header.column.parent !== undefined) return true;
+  
     const parent = header.column.parent;
   
     if (!parent) {
@@ -112,7 +111,7 @@ export const TableHeaderCell = ({
     const visibleSiblings = parent.columns.filter(columnHasVisibleLeaf);
     return visibleSiblings.at(-1) === header.column;
   })();
-
+ 
 const cellClassName = classnames(
   "table-header-cells",
   `${showActionsBar && isActionBarVisible && "header-cells-with-actions"}`,
@@ -121,7 +120,7 @@ const cellClassName = classnames(
   { "pinned-left": responsive === "scroll" && isPinnedLeft },
    isLastHeaderCell ? "last-header-cell" : "",
   stickyLeftColumn && stickyLeftColumn.length > 0 && isPinnedLeft ? 'sticky-left' : "",
-  colDef?.columnStyling?.headerPadding && `p_${colDef?.columnStyling?.headerPadding}`
+
 ); 
 
 const cellId = `${loading ? 
@@ -258,9 +257,12 @@ const isToggleExpansionEnabled =
             )}
 
           <Flex
-              className={`${header?.index === 0 && enableSorting && "header-sort-button pb_th_link"} ${header?.index !== 0 && header?.column.getCanSort() && "header-sort-secondary-columns"}`}
-              cursor={((header?.index !== 0 && header?.column.getCanSort()) || (header?.index === 0 && enableSorting) ? "pointer" : "default")}
-              {...(((header?.index !== 0 && header?.column.getCanSort()) || (header?.index === 0 && enableSorting)) && {
+              className={`${header?.index === 0 &&
+                enableSorting &&
+                "header-sort-button pb_th_link"}`}
+              cursor={header?.index === 0 && enableSorting ? "pointer" : "default"}
+              {...(header?.index === 0 &&
+                enableSorting && {
                   htmlOptions: {
                     onClick: (event: React.MouseEvent) => toggleSortButton(event),
                     onKeyDown: (event: React.KeyboardEvent) => {
@@ -278,13 +280,13 @@ const isToggleExpansionEnabled =
               {flexRender(header?.column.columnDef.header, header?.getContext())}
             </div>
 
-            {((header?.index !== 0 && header?.column.getCanSort()) || (header?.index === 0 && enableSorting)) &&
+            {header?.index === 0 &&
+              header.column.getCanSort() &&
+              enableSorting &&
               (loading ? (
                 <div className="loading-toggle-icon" />
               ) : (
-                <SortIconButton 
-                    enableSortingRemoval={enableSortingRemoval}
-                    header={header} 
+                <SortIconButton header={header} 
                     sortIcon={sortIcon} 
                 />
               ))}

data/app/pb_kits/playbook/pb_advanced_table/Hooks/useTableState.ts

@@ -16,10 +16,8 @@ import { createCellFunction } from "../Utilities/CellRendererUtils";
 interface UseTableStateProps {
   tableData: GenericObject[];
   columnDefinitions: GenericObject[];
-  enableSortingRemoval?: boolean;
   expandedControl?: GenericObject;
   sortControl?: GenericObject;
-  firstColumnSort?: boolean;
   onRowToggleClick?: (arg: Row<GenericObject>) => void;
   selectableRows?: boolean;
   initialLoadingRowsCount?: number;
@@ -40,7 +38,6 @@ interface UseTableStateProps {
 export function useTableState({
   tableData,
   columnDefinitions,
-  enableSortingRemoval,
   expandedControl,
   sortControl,
   onRowToggleClick,
@@ -86,19 +83,19 @@ export function useTableState({
   const buildColumns = useCallback((columnDefinitions: GenericObject[], isRoot = true): any[] => {
     return columnDefinitions?.map((column, index) => {
       const isFirstColumn = isRoot && index === 0;
+
       // Handle grouped columns
       if (column.columns && column.columns.length > 0) {
         return {
-          header: column.header ?? column.label ?? "",
-          id: column.id ?? column.label ?? `group-${index}`,
+          header: column.header || column.label || "",
           columns: buildColumns(column.columns, false),
         };
       }
+
       // Define the base column structure
       const columnStructure = {
         ...columnHelper.accessor(column.accessor, {
           header: column.header ?? column.label ?? "",
-          enableSorting: isFirstColumn || column.enableSort === true,
         }),
       };
 
@@ -169,7 +166,7 @@ export function useTableState({
     getCoreRowModel: getCoreRowModel(),
     getExpandedRowModel: getExpandedRowModel(),
     getSortedRowModel: getSortedRowModel(),
-    enableSortingRemoval: enableSortingRemoval,
+    enableSortingRemoval: false,
     sortDescFirst: true,
     onRowSelectionChange: setRowSelection,
     onRowPinningChange,

data/app/pb_kits/playbook/pb_advanced_table/SubKits/TableHeader.tsx

@@ -28,7 +28,7 @@ export const TableHeader = ({
   dark = false,
   enableSorting = false,
   id,
-  sortIcon = ["arrow-up-wide-short", "arrow-down-short-wide"],
+  sortIcon = ["arrow-up-short-wide", "arrow-down-short-wide"],
   ...props
 }: TableHeaderProps) => {
   const {

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.scss

@@ -124,65 +124,13 @@
       -ms-overflow-style: none !important;
       scrollbar-width: none !important;
   }
-
-  // When action bar is hidden, ensure proper border radius for header corners
-  &.hidden-action-bar {
-    .pb_advanced_table_header {
-      > tr:first-child {
-        th:first-child {
-          border-top-left-radius: 4px !important;
-        }
-        th:last-child {
-          border-top-right-radius: 4px !important;
-        }
-      }
-    }
-
-    // Also handle the case when there are multiple header rows
-    .pb_advanced_table_header {
-      > tr:first-child {
-        th:first-child,
-        .table-header-cells:first-child,
-        .table-header-cells-custom:first-child {
-          border-top-left-radius: 4px !important;
-        }
-        th:last-child,
-        .table-header-cells:last-child,
-        .table-header-cells-custom:last-child {
-          border-top-right-radius: 4px !important;
-        }
-      }
-    }
-  }
-
-  // When action bar is shown, remove border radius from header
-  .row-selection-actions-card.is-visible ~ * .pb_advanced_table_header,
-  .row-selection-actions-card.show-action-card ~ * .pb_advanced_table_header {
-    > tr:first-child {
-      th:first-child,
-      th:last-child,
-      .table-header-cells:first-child,
-      .table-header-cells:last-child,
-      .table-header-cells-custom:first-child,
-      .table-header-cells-custom:last-child {
-        border-top-left-radius: 0 !important;
-        border-top-right-radius: 0 !important;
-      }
-    }
-  }
-
+  
 
   .row-selection-actions-card {
     border-bottom-right-radius: 0px !important;
     border-bottom-left-radius: 0px !important;
     border-bottom-color: transparent;
     transition: height 300ms ease;
-
-    &.is-visible,
-    &.show-action-card {
-      border-top-left-radius: 4px !important;
-      border-top-right-radius: 4px !important;
-    }
   }
   .table-header-cells:first-child {
     min-width: 180px;
@@ -422,15 +370,6 @@
     padding: 2px;
   }
 
-  .header-sort-secondary-columns {
-    color: $primary !important;
-
-    &:hover {
-      background-color: rgba($primary, 0.03);
-      border-radius: $border_radius_md;
-    }
-  }
-
   .toggle-all-icon {
     @extend .button-icon;
     @extend %primary-color-pseudo;
@@ -971,58 +910,9 @@
       }
     }
   }
-
-  // Firefox-specific fix for last-header-cell and last-cell vertical borders
-  @-moz-document url-prefix() {
-    .pb_advanced_table_header {
-      .last-header-cell {
-        border-right: none !important;
-        box-shadow: 1px 0 0 0 $border_light !important;
-      }
-    }
-
-    .pb_advanced_table_body {
-      .last-cell {
-        border-right: none !important;
-        box-shadow: 1px 0 0 0 $border_light !important;
-      }
-    }
-
-    // Dark mode Firefox fixes
-    &.dark {
-      .pb_advanced_table_header {
-        .last-header-cell {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_dark !important;
-        }
-      }
-
-      .pb_advanced_table_body {
-        .last-cell {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_dark !important;
-        }
-      }
-    }
-  }
 }
 
 // Outside of the pb_advanced_table class for popover
 .pb-advanced-table-popover-option:hover {
   background-color: $bg_light;
-}
-// Removes borders when Wrapped inside the Card Kit
-[class^=pb_card_kit] > .pb_advanced_table .pb_advanced_table_body .last-cell,
-[class^=pb_card_kit] > .pb_advanced_table .pb_advanced_table_header .last-header-cell,
-[class^=pb_card_kit] > .pb_advanced_table .pb_advanced_table_body tr td:last-child,
-[class^=pb_card_kit] > .pb_advanced_table .pb_advanced_table_header tr th:last-child {
-    border-right: none !important;
-}
-
-//  Removes borders when Wrapped inside the Card Kit
-[class^=pb_card_kit] > .pb_advanced_table tr:last-child, 
-[class^=pb_card_kit] > .pb_advanced_table .last-row-cell {
-  td {
-    border-bottom: none !important; 
-  }
-}
+}

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.tsx

@@ -40,7 +40,6 @@ type AdvancedTableProps = {
   dark?: boolean
   data?: { [key: string]: string }
   enableToggleExpansion?: "all" | "header" | "none"
-  enableSortingRemoval?: boolean
   expandedControl?: GenericObject
   expandByDepth?: { [key: string]: string | number }
   onExpandByDepthClick?: (arg: number, arg1: any) => void
@@ -88,7 +87,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     dark = false,
     data = {},
     enableToggleExpansion = "header",
-    enableSortingRemoval = false,
     expandedControl,
     expandByDepth,
     onExpandByDepthClick,
@@ -124,6 +122,7 @@ const AdvancedTable = (props: AdvancedTableProps) => {
   // Component refs
   const tableWrapperRef = useRef<HTMLDivElement>(null);
 
+  // Initialize table state
   const {
     table,
     expanded,
@@ -138,7 +137,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
   } = useTableState({
     tableData,
     columnDefinitions,
-    enableSortingRemoval,
     expandedControl,
     sortControl,
     onRowToggleClick,
@@ -220,10 +218,10 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     )
 
     return (
-      <Card
+      <Card 
           borderNone
           borderRadius="none"
-          className="advanced-table-fullscreen-header"
+          className="advanced-table-fullscreen-header" 
           {...props}
       >
           <Flex justify="end">
@@ -252,10 +250,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
   const ariaProps = buildAriaProps(aria);
   const dataProps = buildDataProps(data);
   const htmlProps = buildHtmlProps(htmlOptions);
-
-  // Visibility flag for action bar
-  const isActionBarVisible = (selectableRows && showActionsBar && selectedRowsLength > 0) || columnVisibilityControl;
-
   const classes = classnames(
     buildCss("pb_advanced_table"),
     `advanced-table-responsive-${responsive}`,
@@ -263,8 +257,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     {
       'advanced-table-fullscreen': isFullscreen,
       'advanced-table-allow-fullscreen': allowFullScreen,
-      // Add the hidden-action-bar class when action bar functionality exists but is not visible
-      'hidden-action-bar': (selectableRows || columnVisibilityControl) && !isActionBarVisible,
     },
     {'advanced-table-sticky-left-columns': stickyLeftColumn && stickyLeftColumn.length > 0},
     columnGroupBorderColor ? `column-group-border-${columnGroupBorderColor}` : '',
@@ -278,6 +270,9 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     ? getVirtualizedContainerStyles(maxHeight)
     : {};
 
+  // Visibility flag for action bar
+  const isActionBarVisible = (selectableRows && showActionsBar && selectedRowsLength > 0) || columnVisibilityControl;
+
   // The actual Main <Table /> element
   const tableElement = (
     <Table
@@ -293,7 +288,7 @@ const AdvancedTable = (props: AdvancedTableProps) => {
       ) : (
         <>
           <TableHeader />
-          <TableBody
+          <TableBody   
               isFetching={isFetching}
           />
         </>
@@ -335,7 +330,6 @@ const AdvancedTable = (props: AdvancedTableProps) => {
             columnGroupBorderColor={columnGroupBorderColor}
             columnVisibilityControl={columnVisibilityControl}
             customSort={customSort}
-            enableSortingRemoval={enableSortingRemoval}
             enableToggleExpansion={enableToggleExpansion}
             enableVirtualization={virtualizedRows}
             expandByDepth={expandByDepth}

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.html.erb

@@ -11,7 +11,7 @@
     <% if content.present? %>
       <% content.presence %>
     <% else %>
-      <%= pb_rails("advanced_table/table_header", props: { id: object.id, column_definitions: object.column_definitions, enable_toggle_expansion: object.enable_toggle_expansion, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, show_actions_bar: object.show_actions_bar }) %>
+      <%= pb_rails("advanced_table/table_header", props: { column_definitions: object.column_definitions, enable_toggle_expansion: object.enable_toggle_expansion, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, show_actions_bar: object.show_actions_bar }) %>
       <%= pb_rails("advanced_table/table_body", props: { id: object.id, table_data: object.table_data, column_definitions: object.column_definitions, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, enable_toggle_expansion: object.enable_toggle_expansion, row_styling: object.row_styling }) %>
     <% end %>
   <% end %>

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.rb

@@ -35,12 +35,7 @@ module Playbook
                          default: []
 
       def classname
-        additional_classes = [
-          responsive_classname,
-          max_height_classname,
-          hide_scroll_bar_class,
-          hidden_action_bar_class,
-        ]
+        additional_classes = [responsive_classname, max_height_classname, hide_scroll_bar_class]
         additional_classes << "column-group-border-#{column_group_border_color}" if column_group_border_color != "none"
         generate_classname("pb_advanced_table", *additional_classes, separator: " ")
       end
@@ -54,12 +49,7 @@ module Playbook
       end
 
       def hide_scroll_bar_class
-        scroll_bar_none ? "advanced-table-hide-scrollbar" : ""
-      end
-
-      def hidden_action_bar_class
-        # Add hidden-action-bar class when action bar functionality is enabled but not currently visible
-        selectable_rows && !is_action_bar_visible ? "hidden-action-bar" : ""
+        scroll_bar_none ? "advanced-table-hide-scrollbar " : ""
       end
 
       def selected_rows