playbook_ui 14.24.0.pre.alpha.PLAY2360circleiconbuttonvariantdatabug9438 → 14.24.0.pre.alpha.PLAY19989342

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d63f8caad922ad77209ac5c84981e8afa63785f9293cc729d85bab21f7a6b9e
-  data.tar.gz: 301b9c1eb70fefd1a9d7e43023db95bfd2eb6829d2594ff09f53ea79a9ab8e96
+  metadata.gz: 59c17882526a3b72d9fc83804b03d9b16990cb101e1862b0e52b86302f1d2910
+  data.tar.gz: 2a8bcde09ad5af23d054ddba72d05dd55d18a592e84748435269a933456942ed
 SHA512:
-  metadata.gz: 0e8f122547dcf95b2598b27081cb0e51b2c31d871871b357cae1e957e7af6740dfcb147d7ca4aac7f5c8ce96ee43dd7bacd6a397cffd73c44bda691142c1e0e7
-  data.tar.gz: d671ca594ccbbcf966350fa8e2e0f894da084a212d173d04b1f54f7ed003131d390c127eed7601c7fa24ea4728dcb2d9103f32f590d79c6f2723c7907f6ba0af
+  metadata.gz: f6e0c7da6c2b966bef964121f3f25a0c4d5f141be242d977d173e14f063dd7c3dd96cb81eedd14bf6cfa06838719ad76470b5e76d5c9b8818d5314b7a4234e13
+  data.tar.gz: 95e0c86be7672a3370c39a60ccdcb2cd5e31112c921b407cea885baf651560869bef742c89716510a5f714f1b768b30472895da6f8f04ac2ac101839ce41082b

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.scss

@@ -971,40 +971,6 @@
       }
     }
   }
-
-  // Firefox-specific fix for last-header-cell and last-cell vertical borders
-  @-moz-document url-prefix() {
-    .pb_advanced_table_header {
-      .last-header-cell {
-        border-right: none !important;
-        box-shadow: 1px 0 0 0 $border_light !important;
-      }
-    }
-
-    .pb_advanced_table_body {
-      .last-cell {
-        border-right: none !important;
-        box-shadow: 1px 0 0 0 $border_light !important;
-      }
-    }
-
-    // Dark mode Firefox fixes
-    &.dark {
-      .pb_advanced_table_header {
-        .last-header-cell {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_dark !important;
-        }
-      }
-
-      .pb_advanced_table_body {
-        .last-cell {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_dark !important;
-        }
-      }
-    }
-  }
 }
 
 // Outside of the pb_advanced_table class for popover

data/app/pb_kits/playbook/pb_advanced_table/docs/example.yml

@@ -13,7 +13,6 @@ examples:
   - advanced_table_with_custom_header_rails: Custom Header Cell
   - advanced_table_column_headers: Multi-Header Columns
   - advanced_table_column_headers_multiple: Multi-Header Columns (Multiple Levels)
-  - advanced_table_column_headers_vertical_border: Multi-Header Columns with Vertical Borders
   - advanced_table_no_subrows: Table with No Subrows or Expansion
   - advanced_table_selectable_rows_rails: Selectable Rows
   - advanced_table_selectable_rows_no_subrows_rails: Selectable Rows (No Subrows)
@@ -54,7 +53,6 @@ examples:
   - advanced_table_column_headers: Multi-Header Columns
   - advanced_table_column_headers_multiple: Multi-Header Columns (Multiple Levels)
   - advanced_table_column_headers_custom_cell: Multi-Header Columns with Custom Cells
-  - advanced_table_column_headers_vertical_border: Multi-Header Columns with Vertical Borders
   - advanced_table_no_subrows: Table with No Subrows or Expansion
   - advanced_table_pinned_rows: Pinned Rows
   - advanced_table_selectable_rows: Selectable Rows

data/app/pb_kits/playbook/pb_advanced_table/docs/index.js

@@ -21,7 +21,6 @@ export { default as AdvancedTableSelectableRowsHeader } from './_advanced_table_
 export { default as AdvancedTableSelectableRowsActions } from './_advanced_table_selectable_rows_actions.jsx'
 export { default as AdvancedTableTablePropsStickyHeader } from './_advanced_table_table_props_sticky_header.jsx'
 export { default as AdvancedTableColumnHeadersCustomCell } from './_advanced_table_column_headers_custom_cell.jsx'
-export { default as AdvancedTableColumnHeadersVerticalBorder } from './_advanced_table_column_headers_vertical_border.jsx'
 export { default as AdvancedTableInlineEditing } from './_advanced_table_inline_editing.jsx'
 export { default as AdvancedTableFullscreen } from './_advanced_table_fullscreen.jsx'
 export { default as AdvancedTableStickyColumns } from './_advanced_table_sticky_columns.jsx'

data/app/pb_kits/playbook/pb_advanced_table/table_row.rb

@@ -43,7 +43,7 @@ module Playbook
       end
 
       def td_classname(column, index)
-        classes = %w[id-cell]
+        classes = %w[id-cell chrome-styles]
         classes << "last-cell" if column[:is_last_in_group]
         classes << "pinned-left" if index.zero? && is_pinned_left && responsive == "scroll"
         classes.join(" ")

data/app/pb_kits/playbook/pb_advanced_table/table_subrow_header.rb

@@ -29,7 +29,7 @@ module Playbook
       end
 
       def td_classname(index)
-        classes = %w[id-cell]
+        classes = %w[id-cell chrome-styles]
         classes << "pinned-left" if index.zero? && responsive == "scroll"
         classes.join(" ")
       end

data/app/pb_kits/playbook/pb_circle_icon_button/circle_icon_button.html.erb

@@ -1,14 +1,5 @@
 <%= pb_content_tag do %>
-  <%= pb_rails("button", props: {
-    type: object.type, 
-    loading: object.loading, 
-    link: object.link, 
-    new_window: object.new_window, 
-    variant: object.variant, 
-    target: object.target, 
-    disabled: object.disabled, 
-    dark: object.dark
-  }.merge(object.input_options)) do %>
+  <%= pb_rails("button", props: {type: object.type, loading: object.loading, link: object.link, new_window:object.new_window, variant: object.variant, target: object.target, disabled: object.disabled, dark: object.dark}) do %>
     <%= pb_rails("icon", props: {icon: object.icon, fixed_width: true, dark: object.dark}) %>
   <% end %>
 <% end %>

data/app/pb_kits/playbook/pb_circle_icon_button/circle_icon_button.rb

@@ -21,8 +21,6 @@ module Playbook
       prop :size, type: Playbook::Props::Enum,
                   values: %w[default sm],
                   default: "default"
-      prop :input_options, type: Playbook::Props::HashProp,
-                           default: {}
 
       def classname
         generate_classname("pb_circle_icon_button_kit") + size_class

data/app/pb_kits/playbook/pb_circle_icon_button/docs/example.yml

@@ -5,7 +5,6 @@ examples:
   - circle_icon_button_link: Link
   - circle_icon_button_loading: Loading
   - circle_icon_button_size: Size
-  - circle_icon_button_input_options: Input Options
   
   react:
   - circle_icon_button_default: Default

data/app/pb_kits/playbook/pb_table/styles/_vertical_border.scss

@@ -7,7 +7,7 @@
     thead tr:not(:first-child) th {
       border-right: 1px solid $border_light !important;
     }
-
+    
     @media screen and (min-width: $screen-xs-min) {
       tr:hover, .pb_table_tr:hover {
         td:last-child, .pb_table_td:last-child {
@@ -15,53 +15,5 @@
         }
       }
     }
-
-    // Firefox-specific fix for sticky elements
-    @-moz-document url-prefix() {
-      // Target sticky headers
-      &.sticky-header {
-        th:not(:last-child) {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_light !important;
-        }
-
-        .pb_advanced_table_body {
-          .pinned-row {
-            td:not(:first-child):not(:last-child) {
-              border-right: none !important;
-              box-shadow: 1px 0 0 0 $border_light !important;
-            }
-          }
-        }
-      }
-
-      // Target sticky left columns
-      &.sticky-left-column {
-        td[style="left"], th[style="left"] {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_light !important;
-        }
-      }
-
-      // Target sticky right columns
-      &.sticky-right-column {
-        td[style="right"], th[style="right"] {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_light !important;
-        }
-      }
-
-      // Handle hover states in Firefox
-      @media screen and (min-width: $screen-xs-min) {
-        tr:hover, .pb_table_tr:hover {
-          td:last-child, .pb_table_td:last-child {
-            &[style="left"], &[style="right"] {
-              border-right: none !important;
-              box-shadow: 1px 0 0 0 darken($border_light, 10%) !important;
-            }
-          }
-        }
-      }
-    }
   }
 }

data/dist/menu.yml

@@ -57,7 +57,7 @@ kits:
     enhanced_element_used: true
   - name: column_configuration
     parent: advanced_table
-    kit_section: ["Column Visibility Control", "Column Visibility Control With State", "Column Visibility Control with Custom Dropdown", "Column Visibility Control with Multi-Header Columns", "Multi-Header Columns", "Multi-Header Columns (Multiple Levels)", "Multi-Header Columns with Custom Cells", "Multi-Header Columns with Vertical Borders"]
+    kit_section: ["Column Visibility Control", "Column Visibility Control With State", "Column Visibility Control with Custom Dropdown", "Column Visibility Control with Multi-Header Columns", "Multi-Header Columns", "Multi-Header Columns (Multiple Levels)", "Multi-Header Columns with Custom Cells"]
     platforms: *1
     status: stable
     icons_used: true