playbook_ui 14.22.0.pre.alpha.PLAY2292advancedtablepinnedrowsloading8632 → 14.22.0.pre.alpha.PLAY2292advancedtablepinnedrowsloading8633

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a87d5a3b0f1ba4c0e20a6d286acb82d538fb5bd2cb68700d81df41cf44f1449
-  data.tar.gz: 507e84e412dc50c8020a636f6c46e1fa326605de6ba7ffbd60499790770d6c54
+  metadata.gz: 50940c977e833de1ec35e25c6269e332057fc06778dd67d44d2e59ab4ddd799e
+  data.tar.gz: def4a38171d0f1a0a97bcf80ddb277491d34b5661bcdb2d83b5f7c53c7bc9497
 SHA512:
-  metadata.gz: 90f4a2e682d5d0575ea805a1adc4a0bde6aaf65bb592093c4c98a8122eab250960f90547c9c64ac17724331933ba040a5fb4d60b7bab8b800cc87d01af6cbbf5
-  data.tar.gz: 2a44d15f9f3d820cd44c807cdaab752bd116b2e0ba30dac1dcfdee66f5e1e47828b9c507008948d2baef396cf5ccb780ae4b0c328bf650081ad2f3c5feaa8c78
+  metadata.gz: 492530c127fd34e4edaf65b5afea93df1c41ebe96fd62aaffc2d398ba788cd88d6703175c406c62c6e9bd024f0bdf45f7a2b5ade54e44691a86c63c01556562f
+  data.tar.gz: dba59d34834a6c95d44fa1253641a2d29eccc7762abe866903f30948a04260fce9bf4393e5c4f013cf4ac58252210ac40606c436be76208d2eef2db4e119573c

data/app/pb_kits/playbook/pb_advanced_table/Hooks/useTableState.ts

@@ -188,16 +188,28 @@ export function useTableState({
   }, [tableData, dataChunk, virtualizedRows, loading]);
   
   const [prevDataHash, setPrevDataHash] = useState(dataHash);
-  
-  // Clear pins when data actually changes (by ID composition)
-  useEffect(() => {
-    if (loading) return;
+
+  // Synchronously clear pins when data changes to prevent table errors
+  if (!loading && dataHash !== prevDataHash) {
+    setPrevDataHash(dataHash);
     
-    if (dataHash !== prevDataHash) {
-      setPrevDataHash(dataHash);
-      onRowPinningChange({ top: [] });
+    const currentPins = pinnedRows?.value?.top ?? [];
+    if (currentPins.length > 0) {
+      try {
+        const currentData = virtualizedRows ? dataChunk : tableData;
+        const validPins = currentPins.filter(id => 
+          currentData.some(row => row.id === id)
+        );
+        
+        if (validPins.length !== currentPins.length) {
+          onRowPinningChange({ top: validPins });
+        }
+      } catch (error) {
+        console.warn('Error validating pins on data change, clearing pins:', error);
+        onRowPinningChange({ top: [] });
+      }
     }
-  }, [dataHash, prevDataHash, loading, onRowPinningChange]);
+  }
 
   // Handle row pinning changes
   useEffect(() => {
@@ -208,17 +220,48 @@ export function useTableState({
       onRowPinningChange({ top: [] });
       return;
     }
-    const rows = table.getRowModel().rows;
-    const collectAllDescendantIds = (subs: Row<GenericObject>[]): string[] =>
-      subs.flatMap(r => [r.id, ...collectAllDescendantIds(r.subRows)]);
-    const allPinned: string[] = [];
-    topPins.forEach(id => {
-      const parent = rows.find(r => r.id === id && r.depth === 0);
-      if (parent) {
-        allPinned.push(parent.id, ...collectAllDescendantIds(parent.subRows));
+
+    try {
+      const rows = table.getRowModel().rows;
+      
+      const validPinnedIds = topPins.filter(id => {
+        try {
+          return rows.some(row => row.id === id && row.depth === 0);
+        } catch (error) {
+          console.warn(`Pinned row with id ${id} not found in current dataset`);
+          return false;
+        }
+      });
+  
+      if (validPinnedIds.length === 0) {
+        onRowPinningChange({ top: [] });
+        return;
       }
-    });
-    onRowPinningChange({ top: allPinned });
+
+      const collectAllDescendantIds = (subs: Row<GenericObject>[]): string[] =>
+        subs.flatMap(r => [r.id, ...collectAllDescendantIds(r.subRows)]);
+
+      const allPinned: string[] = [];
+
+      validPinnedIds.forEach(id => {
+        const parent = rows.find(r => r.id === id && r.depth === 0);
+        if (parent) {
+          allPinned.push(parent.id, ...collectAllDescendantIds(parent.subRows));
+        }
+      });
+
+      const currentPins = pinnedRows?.value?.top ?? [];
+      const pinsChanged = allPinned.length !== currentPins.length || 
+                        !allPinned.every(id => currentPins.includes(id));
+ 
+      if (pinsChanged) {
+        onRowPinningChange({ top: allPinned });
+      }
+
+    } catch (error) {
+      console.error('Error in pinned rows logic:', error);
+      onRowPinningChange({ top: [] });
+    }
   }, [table, pinnedRows?.value?.top?.join(','), loading]);
 
   // Check if table has any sub-rows