playbook_ui 14.22.0.pre.alpha.PLAY2292advancedtablepinnedrowsloading8631 → 14.22.0.pre.alpha.PLAY2292advancedtablepinnedrowsloading8633

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc8c480032767b70d345545bb050a1a402e25edc0533e7f241d07e8c448eba1b
-  data.tar.gz: 0b791da24dd14a9e71467272645c86449fde0d2433e72774c8a77db84cf378fb
+  metadata.gz: 50940c977e833de1ec35e25c6269e332057fc06778dd67d44d2e59ab4ddd799e
+  data.tar.gz: def4a38171d0f1a0a97bcf80ddb277491d34b5661bcdb2d83b5f7c53c7bc9497
 SHA512:
-  metadata.gz: 7b01d8af55ae4645022e7121aaf51b11f89e0afdd149ab498a18d90fae59942e0da55f049bf6a06d9757c2108a8e1c45baf11cc1d521d4c84db1591374a33580
-  data.tar.gz: 2c87fbf4597479a6590baa63eb3a06f8789d6f28be225db1347213f381ccfb744d05735c81e6727d548e997f76af5c08782dbc08951bde4225b69a79099a2cec
+  metadata.gz: 492530c127fd34e4edaf65b5afea93df1c41ebe96fd62aaffc2d398ba788cd88d6703175c406c62c6e9bd024f0bdf45f7a2b5ade54e44691a86c63c01556562f
+  data.tar.gz: dba59d34834a6c95d44fa1253641a2d29eccc7762abe866903f30948a04260fce9bf4393e5c4f013cf4ac58252210ac40606c436be76208d2eef2db4e119573c

data/app/pb_kits/playbook/pb_advanced_table/Hooks/useTableState.ts

@@ -1,4 +1,4 @@
-import { useState, useCallback, useMemo, useEffect, useRef } from 'react';
+import { useState, useCallback, useMemo, useEffect } from 'react';
 import {
   useReactTable,
   getCoreRowModel,
@@ -180,19 +180,36 @@ export function useTableState({
     ...tableOptions,
   });
 
-  // Store a reference to the current data to detect changes
-  const dataRef = useRef(tableData);
+  // Create a stable hash of the data to detect changes
+  const dataHash = useMemo(() => {
+    if (loading) return '';
+    const currentData = virtualizedRows ? dataChunk : tableData;
+    return currentData.map(row => row.id).join(',');
+  }, [tableData, dataChunk, virtualizedRows, loading]);
   
-  // Clear pins when data changes (detected by reference change)
-  useEffect(() => {
-    if (loading) return;
+  const [prevDataHash, setPrevDataHash] = useState(dataHash);
+
+  // Synchronously clear pins when data changes to prevent table errors
+  if (!loading && dataHash !== prevDataHash) {
+    setPrevDataHash(dataHash);
     
-    // If the data reference changed, clear pins
-    if (dataRef.current !== tableData) {
-      dataRef.current = tableData;
-      onRowPinningChange({ top: [] });
+    const currentPins = pinnedRows?.value?.top ?? [];
+    if (currentPins.length > 0) {
+      try {
+        const currentData = virtualizedRows ? dataChunk : tableData;
+        const validPins = currentPins.filter(id => 
+          currentData.some(row => row.id === id)
+        );
+        
+        if (validPins.length !== currentPins.length) {
+          onRowPinningChange({ top: validPins });
+        }
+      } catch (error) {
+        console.warn('Error validating pins on data change, clearing pins:', error);
+        onRowPinningChange({ top: [] });
+      }
     }
-  }, [tableData, loading, onRowPinningChange]);
+  }
 
   // Handle row pinning changes
   useEffect(() => {
@@ -203,17 +220,48 @@ export function useTableState({
       onRowPinningChange({ top: [] });
       return;
     }
-    const rows = table.getRowModel().rows;
-    const collectAllDescendantIds = (subs: Row<GenericObject>[]): string[] =>
-      subs.flatMap(r => [r.id, ...collectAllDescendantIds(r.subRows)]);
-    const allPinned: string[] = [];
-    topPins.forEach(id => {
-      const parent = rows.find(r => r.id === id && r.depth === 0);
-      if (parent) {
-        allPinned.push(parent.id, ...collectAllDescendantIds(parent.subRows));
+
+    try {
+      const rows = table.getRowModel().rows;
+      
+      const validPinnedIds = topPins.filter(id => {
+        try {
+          return rows.some(row => row.id === id && row.depth === 0);
+        } catch (error) {
+          console.warn(`Pinned row with id ${id} not found in current dataset`);
+          return false;
+        }
+      });
+  
+      if (validPinnedIds.length === 0) {
+        onRowPinningChange({ top: [] });
+        return;
       }
-    });
-    onRowPinningChange({ top: allPinned });
+
+      const collectAllDescendantIds = (subs: Row<GenericObject>[]): string[] =>
+        subs.flatMap(r => [r.id, ...collectAllDescendantIds(r.subRows)]);
+
+      const allPinned: string[] = [];
+
+      validPinnedIds.forEach(id => {
+        const parent = rows.find(r => r.id === id && r.depth === 0);
+        if (parent) {
+          allPinned.push(parent.id, ...collectAllDescendantIds(parent.subRows));
+        }
+      });
+
+      const currentPins = pinnedRows?.value?.top ?? [];
+      const pinsChanged = allPinned.length !== currentPins.length || 
+                        !allPinned.every(id => currentPins.includes(id));
+ 
+      if (pinsChanged) {
+        onRowPinningChange({ top: allPinned });
+      }
+
+    } catch (error) {
+      console.error('Error in pinned rows logic:', error);
+      onRowPinningChange({ top: [] });
+    }
   }, [table, pinnedRows?.value?.top?.join(','), loading]);
 
   // Check if table has any sub-rows