playbook_ui 14.19.0.pre.alpha.borderfixadvancedtable7816 → 14.19.0.pre.alpha.play1997dropdownenablepillsinselection7702

data/app/pb_kits/playbook/pb_multi_level_select/docs/_multi_level_select_single_children_only.jsx

@@ -4,80 +4,80 @@ import MultiLevelSelect from "../_multi_level_select";
 const treeData = [
   {
     label: "HQ",
-    value: "hQ",
+    value: "HQ",
     id: "hq1",
   },
   {
     label: "Philadelphia",
-    value: "philadelphia",
+    value: "Philadelphia",
     id: "phl1",
     hideRadio: true,
     children: [
       {
         label: "Marketing & Sales PHL",
-        value: "marketingAndSalesPhl",
+        value: "Marketing & Sales PHL",
         id: "marketingPHL1",
       },
       {
         label: "Installation Office PHL",
-        value: "installationOfficePhl",
+        value: "Installation Office PHL",
         id: "installationPHL1",
       },
       {
         label: "Warehouse PHL",
-        value: "warehousePhl",
+        value: "Warehouse PHL",
         id: "warehousePHL1",
       },
     ]
   },
   {
     label: "New Jersey",
-    value: "newJersey",
+    value: "New Jersey",
     id: "nj2",
     hideRadio: true,
     children: [
       {
         label: "New Jersey",
-        value: "newJersey",
+        value: "New Jersey",
         id: "nj3",
         hideRadio: true,
         children: [
           {
             label: "Marketing & Sales NJ",
-            value: "marketingAndSalesNj",
+            value: "Marketing & Sales NJ",
             id: "marketingNJ1",
           },
           {
             label: "Installation Office NJ",
-            value: "installationOfficeNj",
+            value: "Installation Office NJ",
             id: "installationNJ1",
           },
           {
             label: "Warehouse NJ",
-            value: "warehouseNj",
+            value: "Warehouse NJ",
             id: "warehouseNJ1",
           },
         ],
       },
       {
         label: "Princeton",
-        value: "princeton",
+        value: "Princeton",
         id: "princeton1",
         hideRadio: true,
         children: [
           {
             label: "Marketing & Sales Princeton",
-            value: "marketingAndSalesPrinceton",
+            value: "Marketing & Sales Princeton",
             id: "marketingPR1",
           },
           {
             label: "Installation Office Princeton",
-            value: "installationOfficePrinceton",
+            value: "Installation Office Princeton",
             id: "installationPR1",
           },
           {
             label: "Warehouse Princeton",
-            value: "warehousePrinceton",
+            value: "Warehouse Princeton",
             id: "warehousePR1",
           },
         ]
@@ -86,46 +86,46 @@ const treeData = [
   },
   {
     label: "Maryland",
-    value: "maryland",
+    value: "Maryland",
     id: "MD1",
     hideRadio: true,
     children: [
       {
         label: "Marketing & Sales MD",
-        value: "marketingAndSalesMd",
+        value: "Marketing & Sales MD",
         id: "marketingMD1",
       },
       {
         label: "Installation Office MD",
-        value: "installationOfficeMd",
+        value: "Installation Office MD",
         id: "installationMD1",
       },
       {
         label: "Warehouse MD",
-        value: "warehouseMd",
+        value: "Warehouse MD",
         id: "warehouseMD1",
       },
     ]
   },
   {
     label: "Connecticut",
-    value: "connecticut",
+    value: "Connecticut",
     id: "CT1",
     hideRadio: true,
     children: [
       {
         label: "Marketing & Sales CT",
-        value: "marketingAndSalesCt",
+        value: "Marketing & Sales CT",
         id: "marketingCT1",
       },
       {
         label: "Installation Office CT",
-        value: "installationOfficeCt",
+        value: "Installation Office CT",
         id: "installationCT1",
       },
       {
         label: "Warehouse CT",
-        value: "warehouseCt",
+        value: "Warehouse CT",
         id: "warehouseCT1",
       },
     ]

data/app/pb_kits/playbook/pb_multi_level_select/docs/_multi_level_select_with_children.jsx

@@ -5,25 +5,25 @@ import Badge from "../../pb_badge/_badge";
 const treeData = [
   {
     label: "Power Home Remodeling",
-    value: "powerHomeRemodeling",
+    value: "Power Home Remodeling",
     id: "powerhome1",
     expanded: true,
     children: [
       {
         label: "People",
-        value: "people",
+        value: "People",
         id: "people1",
         expanded: true,
         status: "active",
         children: [
           {
             label: "Talent Acquisition",
-            value: "talentAcquisition",
+            value: "Talent Acquisition",
             id: "talent1",
           },
           {
             label: "Business Affairs",
-            value: "businessAffairs",
+            value: "Business Affairs",
             id: "business1",
             status: "active",
             variant: "primary",
@@ -31,12 +31,12 @@ const treeData = [
             children: [
               {
                 label: "Initiatives",
-                value: "initiatives",
+                value: "Initiatives",
                 id: "initiative1",
               },
               {
                 label: "Learning & Development",
-                value: "learningAndDevelopment",
+                value: "Learning & Development",
                 id: "development1",
                 status: "Inactive",
               },
@@ -44,31 +44,31 @@ const treeData = [
           },
           {
             label: "People Experience",
-            value: "peopleExperience",
+            value: "People Experience",
             id: "experience1",
           },
         ],
       },
       {
         label: "Contact Center",
-        value: "contactCenter",
+        value: "Contact Center",
         id: "contact1",
         status: "Inactive",
         variant: "error",
         children: [
           {
             label: "Appointment Management",
-            value: "appointmentManagement",
+            value: "Appointment Management",
             id: "appointment1",
           },
           {
             label: "Customer Service",
-            value: "customerService",
+            value: "Customer Service",
             id: "customer1",
           },
           {
             label: "Energy",
-            value: "energy",
+            value: "Energy",
             id: "energy1",
           },
         ],

data/app/pb_kits/playbook/pb_multi_level_select/docs/_multi_level_select_with_children_with_radios.jsx

@@ -5,25 +5,25 @@ import Badge from "../../pb_badge/_badge";
 const treeData = [
   {
     label: "Power Home Remodeling",
-    value: "powerHomeRemodeling",
+    value: "Power Home Remodeling",
     id: "powerhome1",
     expanded: true,
     children: [
       {
         label: "People",
-        value: "people",
+        value: "People",
         id: "people1",
         expanded: true,
         status: "active",
         children: [
           {
             label: "Talent Acquisition",
-            value: "talentAcquisition",
+            value: "Talent Acquisition",
             id: "talent1",
           },
           {
             label: "Business Affairs",
-            value: "businessAffairs",
+            value: "Business Affairs",
             id: "business1",
             status: "active",
             variant: "primary",
@@ -31,12 +31,12 @@ const treeData = [
             children: [
               {
                 label: "Initiatives",
-                value: "initiatives",
+                value: "Initiatives",
                 id: "initiative1",
               },
               {
                 label: "Learning & Development",
-                value: "learningAndDevelopment",
+                value: "Learning & Development",
                 id: "development1",
                 status: "Inactive",
               },
@@ -44,31 +44,31 @@ const treeData = [
           },
           {
             label: "People Experience",
-            value: "peopleExperience",
+            value: "People Experience",
             id: "experience1",
           },
         ],
       },
       {
         label: "Contact Center",
-        value: "contactCenter",
+        value: "Contact Center",
         id: "contact1",
         status: "Inactive",
         variant: "error",
         children: [
           {
             label: "Appointment Management",
-            value: "appointmentManagement",
+            value: "Appointment Management",
             id: "appointment1",
           },
           {
             label: "Customer Service",
-            value: "customerService",
+            value: "Customer Service",
             id: "customer1",
           },
           {
             label: "Energy",
-            value: "energy",
+            value: "Energy",
             id: "energy1",
           },
         ],

data/app/pb_kits/playbook/pb_multi_level_select/docs/_multi_level_select_with_form.html.erb

@@ -2,62 +2,62 @@
 
   <% treeData = [{
   label: "Power Home Remodeling",
-  value: "powerHomeRemodeling",
+  value: "Power Home Remodeling",
   id: "powerhome1",
   expanded: true,
   children: [
     {
       label: "People",
-      value: "people",
+      value: "People",
       id: "people1",
       children: [
         {
           label: "Talent Acquisition",
-          value: "talentAcquisition",
+          value: "Talent Acquisition",
           id: "talent1",
         },
         {
           label: "Business Affairs",
-          value: "businessAffairs",
+          value: "Business Affairs",
           id: "business1",
           children: [
             {
               label: "Initiatives",
-              value: "initiatives",
+              value: "Initiatives",
               id: "initiative1",
             },
             {
               label: "Learning & Development",
-              value: "learningAndDevelopment",
+              value: "Learning & Development",
               id: "development1",
             },
           ],
         },
         {
           label: "People Experience",
-          value: "peopleExperience",
+          value: "People Experience",
           id: "experience1",
         },
       ],
     },
     {
       label: "Contact Center",
-      value: "contactCenter",
+      value: "Contact Center",
       id: "contact1",
       children: [
         {
           label: "Appointment Management",
-          value: "appointmentManagement",
+          value: "Appointment Management",
           id: "appointment1",
         },
         {
           label: "Customer Service",
-          value: "customerService",
+          value: "Customer Service",
           id: "customer1",
         },
         {
           label: "Energy",
-          value: "energy",
+          value: "Energy",
           id: "energy1",
         },
       ],

data/app/pb_kits/playbook/pb_person/_person.tsx

@@ -41,16 +41,6 @@ const Person = (props: PersonProps): React.ReactElement => {
     className
   )
 
-  const hasAllEmptyProps = [firstName, lastName].every(field => field === undefined || field === null || field === '')
-
-  if (hasAllEmptyProps) {
-    return (
-      <>
-        —
-      </>
-    )
-  }
-
   return (
     <div
         {...ariaProps}
@@ -63,13 +53,13 @@ const Person = (props: PersonProps): React.ReactElement => {
           className="pb_person_first"
           tag="span"
       >
-        {firstName ?? ''}
+        {firstName}
       </Body>
       {lastName && 
         <Title
             className="pb_person_first"
             size={4}
-            text={lastName ? ` ${lastName}` : ''}
+            text={` ${lastName}`}
         />
       }
     </div>

data/app/pb_kits/playbook/pb_phone_number_input/_phone_number_input.scss

@@ -42,7 +42,7 @@ $flag-min-resolution: 192dpi;
   .iti__country-list {
     min-width: $dropdown-min-width;
   }
-  // iti-spacer-horizontal's default is 8px, or $space_xs
+  // iti-spacer-horizontal's default is 8px, or $space_xs 
   .iti__country-list .iti__flag, .iti__country-name {
     margin-right: $space_xs;
   }
@@ -60,7 +60,7 @@ $flag-min-resolution: 192dpi;
     color: $focus_input_light;
   }
 
-  .dropdown_open:not(.error) {
+  .dropdown_open {
     .text_input {
       border-color: $primary !important;
     }
@@ -76,7 +76,7 @@ $flag-min-resolution: 192dpi;
   }
 
   .iti__divider {
-    border-bottom: 1px solid $border_light !important;
+    border-bottom: 1px solid $border_light !important;  
   }
 
   .iti__selected-country-primary {
@@ -96,7 +96,7 @@ $flag-min-resolution: 192dpi;
     justify-content: center;
     align-items: center;
     border-width: 0;
-    border-radius: $space_xxs;
+    border-radius: $space_xxs; 
 
     &[aria-expanded="true"] {
       color: $primary_action;
@@ -199,7 +199,7 @@ $flag-min-resolution: 192dpi;
   }
 
   .iti__dropdown-content {
-    border-radius: $space_xs;
+    border-radius: $space_xs; 
     border: 1px solid $border_light !important;
     position: absolute;
     top: 100%;
@@ -228,13 +228,13 @@ $flag-min-resolution: 192dpi;
     }
 
     .iti__dropdown-content {
-      border-radius: $space_xs;
+      border-radius: $space_xs; 
       border: 1px solid $border_dark !important;
       .iti__search-input {
         background-color: $bg_dark_card;
         &:hover {
           background-color: $bg_dark_card;
-        }
+        }      
         &:active,
         &:focus {
           background-color: $card_dark;
@@ -243,7 +243,7 @@ $flag-min-resolution: 192dpi;
     }
 
     .iti__divider {
-      border-bottom: 1px solid $border_dark !important;
+      border-bottom: 1px solid $border_dark !important;  
     }
 
     .iti__country-list {
@@ -278,7 +278,7 @@ $flag-min-resolution: 192dpi;
       color: $white;
     }
   }
-
+  
   @media (-webkit-min-device-pixel-ratio: 2), (min-resolution: $flag-min-resolution) {
     .iti__flag {
       background-image: url("https://unpkg.com/intl-tel-input@24.6.0/build/img/flags@2x.png");

data/app/pb_kits/playbook/pb_section_separator/_section_separator.tsx

@@ -2,7 +2,7 @@ import React from 'react'
 import classnames from 'classnames'
 
 import { buildAriaProps, buildCss, buildDataProps, buildHtmlProps } from '../utilities/props'
-import { globalProps, globalInlineProps, GlobalProps } from '../utilities/globalProps'
+import { globalProps, globalInlineProps } from '../utilities/globalProps'
 
 import Caption from '../pb_caption/_caption'
 
@@ -19,7 +19,7 @@ type SectionSeparatorProps = {
   orientation?: "horizontal" | "vertical",
   text?: string,
   variant?: "card" | "background",
-} & GlobalProps
+}
 
 const SectionSeparator = (props: SectionSeparatorProps): React.ReactElement => {
   const {

data/app/pb_kits/playbook/pb_text_input/_text_input.scss

@@ -71,8 +71,7 @@
     }
     &.error {
       .text_input_wrapper {
-        // The `:not` here prevents error styling from affecting the country search input in the Phone Number Input Kit.
-        input:not(.iti__search-input),
+        input,
         .text_input {
           border-color: $error_dark;
         }
@@ -103,8 +102,7 @@
       [class*="pb_body_kit"] {
         margin-top: $space_xs / 2;
       }
-      // The `:not` here prevents error styling from affecting the country search input in the Phone Number Input Kit.
-      input:not(.iti__search-input),
+      input,
       .text_input {
         border-color: $error;
       }