RubyGems - playbook_ui - Versions diffs - 14.18.0.pre.alpha.PLAY20397473 → 14.18.0.pre.alpha.PLAY20787400 - Mend

playbook_ui 14.18.0.pre.alpha.PLAY20397473 → 14.18.0.pre.alpha.PLAY20787400

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (64) hide show

data/app/pb_kits/playbook/pb_popover/index.ts CHANGED Viewed

@@ -13,15 +13,7 @@ export default class PbPopover extends PbEnhancedElement {
   }
   moveTooltip() {
-    let container: HTMLElement | null;
-    if (this.appendTo === "parent") {
-      container = this.element.parentElement;
-    } else if (this.appendTo) {
-      container = document.querySelector(this.appendTo);
-    }
-    (container || document.body).appendChild(this.tooltip);
+    document.querySelector('body').appendChild(this.tooltip)
   }
   connect() {
@@ -116,8 +108,4 @@ export default class PbPopover extends PbEnhancedElement {
   get closeOnClick() {
     return this.element.dataset.pbPopoverCloseOnClick
   }
-  get appendTo() {
-    return this.element.dataset.pbPopoverAppendTo;
-  }
 }

data/app/pb_kits/playbook/pb_popover/popover.rb CHANGED Viewed

@@ -3,7 +3,6 @@
 module Playbook
   module PbPopover
     class Popover < Playbook::KitBase
-      prop :append_to, type: Playbook::Props::String, default: "body"
       prop :position, type: Playbook::Props::Enum,
                       values: %w[top bottom left right top-start top-end bottom-start bottom-end right-start right-end left-start left-end],
                       default: "left"
@@ -48,7 +47,6 @@ module Playbook
       def data
         Hash(values[:data]).merge(
-          pb_popover_append_to: append_to,
           pb_popover_kit: true,
           pb_popover_position: position,
           pb_popover_trigger_element_id: trigger_element_id,

data/app/pb_kits/playbook/pb_select/docs/_select_error.jsx CHANGED Viewed

@@ -1,7 +1,6 @@
 import React from 'react'
 import Body from '../../pb_body/_body'
 import Select from '../../pb_select/_select'
-import Icon from '../../pb_icon/_icon'
 const SelectError = (props) => {
   const options = [
@@ -19,14 +18,10 @@ const SelectError = (props) => {
     },
   ]
-  const error = (<>
-    <Icon icon="warning" /> Please make a valid selection
-  </>)
   return (
     <div>
       <Select
-          error={error}
+          error="Please make a valid selection"
           label="Favorite Food"
           name="food"
           options={options}
@@ -34,7 +29,7 @@ const SelectError = (props) => {
           {...props}
       />
       <Body
-          error={error}
+          error="Please make a valid selection"
           status="negative"
           {...props}
       />

data/app/pb_kits/playbook/pb_text_input/docs/_text_input_error.jsx CHANGED Viewed

@@ -1,7 +1,6 @@
 import React, { useState } from 'react'
 import TextInput from '../_text_input'
-import Icon from '../../pb_icon/_icon'
 const TextInputError = (props) => {
   const [email, setEmail] = useState('')
@@ -9,18 +8,11 @@ const TextInputError = (props) => {
   const handleUpdateEmail = ({ target }) => {
     setEmail(target.value)
   }
-  const error = (
-    <>
-      <Icon icon="warning" /> Please enter a valid email address
-    </>
-  )
   return (
     <div>
       <TextInput
           addOn={{ icon: 'user', alignment: 'left', border: true }}
-          error={error}
+          error="Please enter a valid email address"
           label="Email Address"
           onChange={handleUpdateEmail}
           placeholder="Enter email address"

data/app/pb_kits/playbook/pb_textarea/docs/_textarea_error.jsx CHANGED Viewed

@@ -1,21 +1,15 @@
 import React, {useState} from 'react'
 import Textarea from '../../pb_textarea/_textarea'
-import Icon from '../../pb_icon/_icon'
 const TextareaError = (props) => {
   const [value, setValue] = useState('default value text')
   const handleChange = (event) => {
     setValue(event.target.value)
   }
-  const error = (
-    <>
-        <Icon icon="warning" /> This field has an error!
-    </>
-  )
   return (
     <div>
       <Textarea
-          error={error}
+          error="This field has an error!"
           label="Label"
           name="comment"
           onChange={(e)=> handleChange(e)}

data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_error_state.jsx CHANGED Viewed

@@ -1,7 +1,6 @@
 import React, { useState, useEffect } from 'react'
 import Typeahead from '../_typeahead'
-import Icon from '../../pb_icon/_icon'
 const options = [
   { label: 'Orange', value: '#FFA500' },
@@ -11,10 +10,7 @@ const options = [
 ]
 const TypeaheadErrorState = (props) => {
-  const error = (<>
-    <Icon icon="warning" /> Please make a valid selection
-  </>)
-  const [errorState, setErrorState] = useState(error);
+  const [errorState, setErrorState] = useState("Please make a valid selection");
   const [searchValue, setSearchValue] = useState(null);
   const handleOnChange = (value) => setSearchValue(value)
@@ -23,7 +19,7 @@ const TypeaheadErrorState = (props) => {
       if(searchValue) {
         setErrorState("")
       } else {
-        setErrorState(error)
+        setErrorState("Please make a valid selection")
       }
     }, [searchValue])