playbook_ui 14.1.0.pre.alpha.PBNTR462starratingdefaultvalue3582 → 14.1.0.pre.alpha.pbntr373enablekitsforradio3593

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86c5c7a19a77669f0f9596f882885bf9755b7133dfda2003ffd1c992c2bae189
-  data.tar.gz: 51834aabec9d4f6f0be017af72d03ef45f1a0f7bdd4990a74f0cc6f1170d6dea
+  metadata.gz: 3196a7c6aa5e0024e25c8581fe5f40df03e4e21cc9c56c49d0a1ca632526705a
+  data.tar.gz: f7c8bb1d07368d634a75ba43c233bfb38a56806f41b5233736cece0f9a7f94e4
 SHA512:
-  metadata.gz: 3346c978f64fd9869968ddde829ce952c95d88f79e4f5402077c6852267a32327a230a50832859df450d9329c9c8250120e7c7785b23248a20d9bf0276924bfb
-  data.tar.gz: 89c68496e6d686d31845b51181fcb2e55dc3643a9962a6778175bc4c2eb7be0aa058f3b62f17513e8da3853d2246f938d47b536c2e761f2eade0bff7674d33c9
+  metadata.gz: 88b1dc8797609b61c77cac834ce35550d8a42ab675575b683b266d0b543c763d1f04effee8183793c331e6e4a7d96c53eb7b9b103e1a14d96cd0c4f337767f1b
+  data.tar.gz: 1ea4a1fdd91607e9c6c7af6029f637a48f8b770366ce33e87eb83be9f9672898c09fcac287c1c3478f226efd7c1c3a951c03c8769ee15da4b6560cd5af70e8ed

data/app/pb_kits/playbook/pb_radio/_radio.scss

@@ -8,17 +8,17 @@
   display: inline-flex;
   cursor: pointer;
 
-  .pb_radio_button {
-    width: 22px;
-    min-width: 22px;
-    height: 22px;
-    box-sizing: border-box;
-    border-radius: 1000px;
-    border: 2px solid $border_light;
-    margin-right: $space_xs;
-    transition: background $transition_default ease, box-shadow $transition_default ease, border-color $transition_default ease;
-  }
-
+    .pb_radio_button{
+      width: 22px;
+      min-width: 22px;
+      height: 22px;
+      box-sizing: border-box;
+      border-radius: 1000px;
+      border: 2px solid $border_light;
+      margin-right: $space_xs;
+      transition: background $transition_default ease, box-shadow $transition_default ease, border-color $transition_default ease;
+    }
+  
   @media (hover:hover) {
     &:hover .pb_radio_button {
       background-color: $bg_light;

data/app/pb_kits/playbook/pb_radio/_radio.tsx

@@ -1,28 +1,27 @@
-/*eslint-disable react/no-multi-comp, flowtype/space-before-type-colon */
-
-import React, { forwardRef } from 'react'
+import React, { forwardRef, isValidElement, useRef } from 'react'
 import Body from '../pb_body/_body'
+import Flex from '../pb_flex/_flex'
 import classnames from 'classnames'
 import { buildAriaProps, buildCss, buildDataProps, buildHtmlProps } from '../utilities/props'
 import { globalProps, GlobalProps } from '../utilities/globalProps'
 
 type RadioProps = {
-  aria?: {[key: string]: string},
+  aria?: { [key: string]: string },
   alignment?: string,
   checked?: boolean,
   children?: React.ReactChild[] | React.ReactChild,
   className?: string,
   dark?: boolean,
-  data?: {[key: string]: string},
+  data?: { [key: string]: string },
   disabled?: boolean,
   error?: boolean,
-  htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
+  htmlOptions?: { [key: string]: string | number | boolean | (() => void) },
   id?: string,
   label: string,
   name?: string,
   value?: string,
   text?: string,
-  onChange: (event: React.FormEvent<HTMLInputElement> | null)=>void,
+  onChange: (event: React.FormEvent<HTMLInputElement> | null) => void,
 } & GlobalProps
 
 const Radio = ({
@@ -31,9 +30,9 @@ const Radio = ({
   children,
   className,
   dark = false,
-  data = {},
   disabled = false,
   error = false,
+  data = {},
   htmlOptions = {},
   id,
   label,
@@ -42,52 +41,103 @@ const Radio = ({
   value = 'radio_text',
   onChange = () => { void 0 },
   ...props
-}: RadioProps, ref: any) => {
-  const ariaProps = buildAriaProps(aria)
-  const dataProps = buildDataProps(data)
-  const htmlProps = buildHtmlProps(htmlOptions)
+}: RadioProps ) => {
+  const radioRef = useRef(null);
+
+  const ariaProps = buildAriaProps(aria);
+  const dataProps = buildDataProps(data);
+  const htmlProps = buildHtmlProps(htmlOptions);
   const classes = classnames(
-    buildCss('pb_radio_kit', alignment ),
-    dark ? 'dark': null, error ? 'error': null,
+    buildCss('pb_radio_kit', alignment),
+    dark ? 'dark' : null,
+    error ? 'error' : null,
     globalProps(props),
-    className)
+    className
+  );
+
+  const classesCustom = classnames(
+    dark ? 'dark' : null,
+    error ? 'error' : null,
+    globalProps(props),
+    className
+  );
+
+  const isCustomChild = children && isValidElement(children) && children.type !== 'input';
 
   const displayRadio = (props: RadioProps & any) => {
-    if (children)
-      return (children)
-    else
-    return (
-    <input
-        disabled={disabled}
-        id={id}
-        name={name}
-        onChange={onChange}
-        ref={ref}
-        text={text}
-        type="radio"
-        value={value}
-        {...props}
-    />
-  )}
+    if (isValidElement(children) && children.type === 'input') {
+      return React.cloneElement(children, { ...props, ref: radioRef });
+    } else if (isCustomChild || !children) {
+      return (
+        <input
+            disabled={disabled}
+            id={id}
+            name={name}
+            onChange={onChange}
+            ref={radioRef}
+            text={text}
+            type="radio"
+            value={value}
+            {...props}
+        />
+      );
+    }
+  };
+
+  const handleContainerClick = (event: React.MouseEvent<HTMLDivElement, MouseEvent> | undefined) => {
+    if (event) {
+      const target = event.target as HTMLElement;
+      if (
+        target.id === 'children-wrapper' ||
+        target.closest('#children-wrapper')
+      ) {
+        radioRef.current?.click();
+      }
+    }
+  };
 
   return (
-    <label
-        {...ariaProps}
-        {...dataProps}
-        {...htmlProps}
-        className={classes}
-        htmlFor={id}
-    >
-    <>{displayRadio(props)}</>
-    <span className="pb_radio_button" />
-    <Body
-        dark={dark}
-        status={error ? 'negative' : null}
-        text={label}
-        variant={null}
-    />
-    </label>
-  )
-}
+    isCustomChild ? (
+      <Flex 
+          {...ariaProps}
+          {...dataProps}
+          {...htmlProps}
+          align='center'
+          className={classesCustom}
+          cursor='pointer'
+          htmlFor={id}
+          htmlOptions={{
+            onClick: ((event: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
+              handleContainerClick(event);
+            }) as unknown as () => void
+          }}
+          id="radio-container"
+      >
+        <label className={buildCss('pb_radio_kit', alignment)}>
+          <>{displayRadio(props)}</>
+          <span className="pb_radio_button" />
+        </label>
+        <div id="children-wrapper"> {children} </div>
+      </Flex>
+    ) : (
+      <label
+          {...ariaProps}
+          {...dataProps}
+          {...htmlProps}
+          className={classes}
+          htmlFor={id}
+      >
+        <>{displayRadio(props)}</>
+        <span className="pb_radio_button" />
+        <Body
+            dark={dark}
+            status={error ? 'negative' : null}
+            text={label}
+            variant={null}
+        />
+      </label>
+    )
+  );
+};
 
-export default forwardRef(Radio)
+export default forwardRef(Radio);

data/app/pb_kits/playbook/pb_radio/docs/_radio_children.jsx

@@ -0,0 +1,51 @@
+import React from 'react'
+import Radio from '../_radio'
+import Typeahead from '../../pb_typeahead/_typeahead'
+import Dropdown from '../../pb_dropdown/_dropdown'
+import Title from '../../pb_title/_title'
+
+const RadioChildren = (props) => {
+
+
+  const options = [
+    { label: 'Orange', value: '#FFA500' },
+    { label: 'Red', value: '#FF0000' },
+    { label: 'Green', value: '#00FF00' },
+    { label: 'Blue', value: '#0000FF' },
+  ]
+
+  return (
+    <div>
+      <Radio
+          label="Power"
+          name="Group2"
+          tabIndex={0}
+          value="Power"
+          {...props}
+      >
+        <Dropdown options={options}/>
+      </Radio>
+      <br />
+      <Radio
+          defaultChecked={false}
+          label="Nitro"
+          name="Group2"
+          value="Nitro"
+          {...props}
+      >
+        <Typeahead options={options} />
+      </Radio>
+      <br />
+      <Radio
+          defaultChecked={false}
+          label="Google"
+          name="Group2"
+          value="Google"
+          {...props}
+      >
+        <Title text="Custom Typography" />
+        </Radio>
+    </div>
+  )
+}
+export default RadioChildren

data/app/pb_kits/playbook/pb_radio/docs/_radio_default.jsx

@@ -34,4 +34,4 @@ const RadioDefault = (props) => {
     </div>
   )
 }
-export default RadioDefault
+export default RadioDefault

data/app/pb_kits/playbook/pb_radio/docs/example.yml

@@ -14,6 +14,7 @@ examples:
   - radio_error: With Error
   - radio_alignment: Alignment
   - radio_disabled: Disabled
+  - radio_children: Children
 
   swift:
   - radio_default_swift: Default

data/app/pb_kits/playbook/pb_radio/docs/index.js

@@ -3,3 +3,4 @@ export { default as RadioCustom } from './_radio_custom.jsx'
 export { default as RadioError } from './_radio_error.jsx'
 export { default as RadioAlignment } from './_radio_alignment.jsx'
 export { default as RadioDisabled } from './_radio_disabled.jsx'
+export { default as RadioChildren } from './_radio_children.jsx'

data/app/pb_kits/playbook/pb_star_rating/index.js

@@ -12,7 +12,6 @@ export default class PbStarRating extends PbEnhancedElement {
   connect() {
     this.addEventListeners()
     this.handleFormReset()
-    this.setDefaultValue()
   }
 
   addEventListeners() {
@@ -154,13 +153,4 @@ export default class PbStarRating extends PbEnhancedElement {
       }
     }
   }
-
-  setDefaultValue() {
-    const hiddenInput = this.element.querySelector(STAR_RATING_INPUT_DATA_SELECTOR)
-    const defaultValue = hiddenInput.value
-
-    if (defaultValue) {
-      this.updateStarColors(defaultValue)
-    }
-  }
 }

data/app/pb_kits/playbook/pb_star_rating/star_rating.rb

@@ -34,7 +34,6 @@ module Playbook
                       default: false
       prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
-      prop :default_value
 
       def one_decimal_rating
         rating.to_f.round(1)
@@ -121,8 +120,7 @@ module Playbook
           data: { "pb-star-rating-input": true },
           name: name,
           required: required,
-          style: "display: none",
-          value: default_value || ""
+          style: "display: none"
         )
       end
     end