playbook_ui 14.0.0.pre.alpha.PLAY14113475 → 14.0.0.pre.alpha.PLAY14733479

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 256935cc0094e0047461f73eb8aa9a359414951eade45a2a3c82507ba9430d19
-  data.tar.gz: 7d173634a0c2134da2756f3c16435c48662570980fa226a0bbe8bb256950620e
+  metadata.gz: 0f1032bd8dc627bac427d2d177e18570a070b7de63f26357f5742cf5a159b499
+  data.tar.gz: dc85f6f9604c30a0d256fef9a849911b4c286642082d09ca976b39a2ae8c3019
 SHA512:
-  metadata.gz: 6861772c1549b55563f7d3c79026f56cb930297ef756e02a5b9adc7df3300b31dc8286df6188b800023c23870eb90a62e4b7fc14f0fcfecdc1aa3769deb77a2f
-  data.tar.gz: 5b80990b1a26b4aa82392837d1c1a8c54304f3371e527beb8e7786ce54bb1620dab12804798855b9d43e4958f7586c10fd5e338d8f2b2adbccb26fe1d691c376
+  metadata.gz: 60531d9ddbc954b2d8d32171aa706f7728a28ce40ddda950bbb786a33eeafb1b6e5ce5f5adb96e81c78b76a0478184cb3fc1f09a6c68450355b6b4f3c5330de0
+  data.tar.gz: 14295b3f6b91c5db621da347a6d0178f6fe451634ffab76982d9d6a137e6a4990123ebe3574a4278694c3c5c3efe0d837b2ad5bb0515721a3b15e0394cf791c7

data/app/pb_kits/playbook/pb_badge/_badge.scss

@@ -42,12 +42,6 @@
     color: $white;
   }
 
-
-  &[class*=_notification_error] {
-    background: $error;
-    color: $white;
-  }
-
   &.dark {
     border-width: 0;
 

data/app/pb_kits/playbook/pb_badge/_badge.tsx

@@ -25,7 +25,7 @@ type BadgeProps = {
   removeOnClick?: React.MouseEventHandler<HTMLSpanElement>,
   rounded?: boolean,
   text?: string,
-  variant?: "error" | "info" | "neutral" | "notification" | "notificationError" | "primary" | "success" | "warning",
+  variant?: "error" | "info" | "neutral" | "notification" | "primary" | "success" | "warning",
 } & GlobalProps
 const Badge = (props: BadgeProps): React.ReactElement => {
   const {
@@ -45,9 +45,7 @@ const Badge = (props: BadgeProps): React.ReactElement => {
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)
   const css = classnames(
-    buildCss('pb_badge_kit',
-      variant === "success" ? "success_sm" : variant === "notificationError" ? "notification_error" : variant,
-      rounded ? 'rounded' : ''),
+    buildCss('pb_badge_kit', variant === "success" ? "success_sm" : variant, rounded ? 'rounded' : null),
     globalProps(props),
     className
   )

data/app/pb_kits/playbook/pb_badge/badge.rb

@@ -6,7 +6,7 @@ module Playbook
       prop :rounded, type: Playbook::Props::Boolean, default: false
       prop :text
       prop :variant, type: Playbook::Props::Enum,
-                     values: %w[success warning error info neutral notification notification_error primary],
+                     values: %w[success warning error info neutral notification primary],
                      default: "neutral"
 
       def classname

data/app/pb_kits/playbook/pb_badge/badge.test.js

@@ -94,21 +94,15 @@ test('displays success variant', () => {
 
 })
 
-test('displays notification variants', () => {
-  [
-    "notification",
-    "notificationError"
-  ].forEach((colorVariant) => {
-    render(
-      <Badge
-          data={{ testid: testId }}
-          text={colorVariant}
-          variant={colorVariant}
-      />
-    )
-    const kit = screen.getByTestId(testId)
-    expect(kit).toHaveClass(`pb_badge_kit_${colorVariant === "notificationError" ? "notification_error" : "notification"}`)
-
-    cleanup()
-  })
+test('displays notification variant', () => {
+  render(
+    <Badge
+        data={{ testid: testId }}
+        text="1"
+        variant="notification"
+    />
+  )
+  const kit = screen.getByTestId(testId)
+  expect(kit).toHaveClass(`pb_badge_kit_notification`)
+  cleanup()
 })

data/app/pb_kits/playbook/pb_badge/docs/_badge_notification.html.erb

@@ -10,16 +10,3 @@
     variant: "notification"
   }) %>
 </div>
-
-<div>
-  <%= pb_rails("badge", props: {
-    text: "1",
-    variant: "notification_error",
-    rounded: true
-  }) %>
-
-  <%= pb_rails("badge", props: {
-    text: "4",
-    variant: "notification_error"
-  }) %>
-</div>

data/app/pb_kits/playbook/pb_badge/docs/_badge_notification.jsx

@@ -4,39 +4,20 @@ import Badge from '../_badge'
 const BadgeNotification = (props) => {
   return (
     <>
-      <div>
-        <Badge
-            rounded
-            text="1"
-            variant="notification"
-            {...props}
-        />
+      <Badge
+          rounded
+          text="1"
+          variant="notification"
+          {...props}
+      />
 
-        &nbsp;
+      &nbsp;
 
-        <Badge
-            text="4"
-            variant="notification"
-            {...props}
-        />
-      </div>
-
-      <div>
-        <Badge
-            rounded
-            text="1"
-            variant="notificationError"
-            {...props}
-        />
-
-        &nbsp;
-
-        <Badge
-            text="4"
-            variant="notificationError"
-            {...props}
-        />
-      </div>
+      <Badge
+          text="4"
+          variant="notification"
+          {...props}
+      />
     </>
   )
 }