playbook_ui 13.5.0 → 13.6.0.pre.alpha.tiptapreacthookformbug1210

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3fbde0c47559510e98e402f39e88e8eee92d920fe6316a10cf69edd6433c593d
-  data.tar.gz: 528eb97cc4627c05a97fdc42c44e2b306481fe8467f9abf38dd135e95916c5a1
+  metadata.gz: d8771c78a1ecc2d78dcac4e22ab2ada7e04f99d1e4426d5c824cefb854532cb0
+  data.tar.gz: ae5e324a57a9340ea86ada259e94943a975c16d0c721100b3551a4e30af63e55
 SHA512:
-  metadata.gz: 476c5d3b3afc10856fad58a4a417b9124a45bce23ac7af0987fb94e7e5987785786472c35b35a8fe8c1acb8db6c5c040c423f29886c26a0dd8ec7c7ea2baf072
-  data.tar.gz: ae782bd74d7a7cf8ee5f88a804079742e28044fc0f7228b1243292711c1d40bf6c8f54c2ed004bc8994321183d35efe7e975c867a99e5baba781f939d8eb76e9
+  metadata.gz: b031c275c0b45eac2065985bc48358cb2c9a05337d9cb198698c1af364486bcdbb42c3c8c4e65d5fb4aeef6998481b61d37ea8d17ec0caca1459cbc4c94eb571
+  data.tar.gz: e5e2848b9c33616179dac4582f8a3c5c0fecb04a1fa5c8dbddbaa2e2553fc75248bd1f6730c7ef76d2e66a6b27490753e3035f184464370e273a86173d4f8d0c

data/app/pb_kits/playbook/_playbook.scss

@@ -113,5 +113,6 @@
 @import './utilities/border_radius';
 @import './utilities/hover';
 @import './utilities/text_align';
+@import './utilities/overflow';
 
 @import 'pb_multi_level_select/multi_level_select';

data/app/pb_kits/playbook/pb_body/_body.tsx

@@ -24,7 +24,7 @@ type BodyProps = {
 } & GlobalProps
 
 const Body = (props: BodyProps): React.ReactElement => {
-  if (props.variant) deprecatedProps("Body", ["status"]) //status prop is deprecated, use color instead please
+  if (props.variant) deprecatedProps() //status prop is deprecated, use color instead please
   const {
     aria = {},
     children,

data/app/pb_kits/playbook/pb_caption/_caption.tsx

@@ -17,7 +17,7 @@ type CaptionProps = {
 } & GlobalProps;
 
 const Caption = (props: CaptionProps): React.ReactElement => {
-  if (props.variant) deprecatedProps('Title', ['variant']) //variant prop is deprecated, use color instead
+  if (props.variant) deprecatedProps() //variant prop is deprecated, use color instead
   const {
     aria = {},
     children,

data/app/pb_kits/playbook/pb_card/card.rb

@@ -4,7 +4,7 @@ module Playbook
   module PbCard
     class Card < Playbook::KitBase
       prop :selected, type: Playbook::Props::Boolean, default: false
-      prop :highlight, type: Playbook::Props::Hash,
+      prop :highlight, type: Playbook::Props::HashProp,
                        default: {}
       prop :tag, type: Playbook::Props::Enum,
                  values: %w[div section footer header article aside main nav],

data/app/pb_kits/playbook/pb_checkbox/checkbox.rb

@@ -10,7 +10,7 @@ module Playbook
       prop :value
       prop :name
 
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
       prop :required, type: Playbook::Props::Boolean,
                       default: false

data/app/pb_kits/playbook/pb_dashboard_value/dashboard_value.rb

@@ -6,10 +6,10 @@ module Playbook
       prop :align, type: Playbook::Props::Enum,
                    values: %w[left center right],
                    default: "left"
-      prop :stat_change, type: Playbook::Props::Hash,
+      prop :stat_change, type: Playbook::Props::HashProp,
                          default: {}
       prop :stat_label
-      prop :stat_value, type: Playbook::Props::Hash,
+      prop :stat_value, type: Playbook::Props::HashProp,
                         default: {}
 
       def formatted_stat_value

data/app/pb_kits/playbook/pb_date_picker/_date_picker.tsx

@@ -49,7 +49,7 @@ type DatePickerProps = {
 } & GlobalProps
 
 const DatePicker = (props: DatePickerProps): React.ReactElement => {
-  if (props.plugins) deprecatedProps('Date Picker', ['plugins'])
+  if (props.plugins) deprecatedProps()
 
   const {
     allowInput = false,

data/app/pb_kits/playbook/pb_date_picker/date_picker.rb

@@ -34,9 +34,9 @@ module Playbook
                     default: false
       prop :label, type: Playbook::Props::String,
                    default: "Date Picker"
-      prop :input_aria, type: Playbook::Props::Hash,
+      prop :input_aria, type: Playbook::Props::HashProp,
                         default: {}
-      prop :input_data, type: Playbook::Props::Hash,
+      prop :input_data, type: Playbook::Props::HashProp,
                         default: {}
       prop :max_date, type: Playbook::Props::String
       prop :min_date, type: Playbook::Props::String

data/app/pb_kits/playbook/pb_date_time_stacked/_date_time_stacked.tsx

@@ -19,7 +19,7 @@ type DateTimeStackedProps = {
 }
 
 const DateTimeStacked = (props: DateTimeStackedProps): React.ReactElement => {
-  if (props.date) deprecatedProps('Date Time Stacked', ['date'])
+  if (props.date) deprecatedProps()
 
   const {
     date,

data/app/pb_kits/playbook/pb_file_upload/file_upload.rb

@@ -18,7 +18,7 @@ module Playbook
       prop :full_width, type: Playbook::Props::Boolean,
                         default: false
 
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
 
       def classname

data/app/pb_kits/playbook/pb_flex/_flex_item.scss

@@ -44,14 +44,6 @@
     order: -1;
   }
 
-  $overflow_values: auto, hidden, inherit, initial, scroll, visible;
-
-  @each $value in $overflow_values {
-    &.overflow_#{$value} {
-      overflow: #{$value}
-    }
-  }
-
   @for $i from 0 through 12 {
     &[class*=_flex_#{$i}]{
       flex: $i;

data/app/pb_kits/playbook/pb_flex/_flex_item.tsx

@@ -8,7 +8,6 @@ type FlexItemPropTypes = {
   grow?: boolean,
   shrink?: boolean,
   className?: string,
-  overflow?: "auto" | "hidden" | "initial" | "inherit" | "scroll" | "visible",
   order?: 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 'first' | 'none',
   alignSelf?: "start" | "end" | "center" | "stretch" | null,
   displayFlex?: boolean
@@ -20,7 +19,6 @@ const FlexItem = (props: FlexItemPropTypes): React.ReactElement => {
     className,
     fixedSize,
     grow,
-    overflow = null,
     shrink,
     flex = 'none',
     order = 'none',
@@ -30,7 +28,6 @@ const FlexItem = (props: FlexItemPropTypes): React.ReactElement => {
   const growClass = grow === true ? 'grow' : ''
   const displayFlexClass = displayFlex === true ? `display_flex_${displayFlex}` : ''
   const flexClass = flex !== 'none' ? `flex_${flex}` : ''
-  const overflowClass = overflow ? `overflow_${overflow}` : ''
   const shrinkClass = shrink === true ? 'shrink' : ''
   const alignSelfClass = alignSelf ? `align_self_${alignSelf}` : ''
   const fixedStyle =
@@ -39,7 +36,7 @@ const FlexItem = (props: FlexItemPropTypes): React.ReactElement => {
 
   return (
     <div
-        className={classnames(buildCss('pb_flex_item_kit', growClass, shrinkClass, flexClass, displayFlexClass), overflowClass, orderClass, alignSelfClass, globalProps(props), className)}
+        className={classnames(buildCss('pb_flex_item_kit', growClass, shrinkClass, flexClass, displayFlexClass), orderClass, alignSelfClass, globalProps(props), className)}
         style={fixedStyle}
     >
       {children}

data/app/pb_kits/playbook/pb_flex/flex_item.rb

@@ -9,10 +9,6 @@ module Playbook
       prop :shrink, type: Playbook::Props::Boolean,
                     default: false
 
-      prop :overflow, type: Playbook::Props::Enum,
-                      values: %w[auto hidden inherit initial scroll visible] + [nil],
-                      default: nil
-
       prop :align_self, type: Playbook::Props::Enum,
                         values: %w[start center end stretch] + [nil],
                         default: nil
@@ -21,7 +17,7 @@ module Playbook
                           default: false
 
       def classname
-        generate_classname("pb_flex_item_kit", fixed_size_class, grow_class, shrink_class, display_flex_class) + overflow_class + align_self_class
+        generate_classname("pb_flex_item_kit", fixed_size_class, grow_class, shrink_class, display_flex_class) + align_self_class
       end
 
       def style_value
@@ -46,10 +42,6 @@ module Playbook
         grow ? "grow" : nil
       end
 
-      def overflow_class
-        overflow ? " overflow_#{overflow}" : ""
-      end
-
       def shrink_class
         shrink ? "shrink" : nil
       end

data/app/pb_kits/playbook/pb_nav/_collapsible_nav.scss

@@ -33,7 +33,7 @@
         margin: 0;
       }
       &[class*="_active"] {
-        .pb_collapsible_main_kit {
+        >.pb_collapsible_main_kit {
           background-color: $active_light;
         }
       }
@@ -46,7 +46,7 @@
           }
         }
         &[class*="_active"] {
-          .pb_collapsible_main_kit {
+          >.pb_collapsible_main_kit {
             background-color: mix($white, $card_dark, 20%);
             .pb_nav_list_item_text_collapsible,
             svg {
@@ -63,7 +63,7 @@
     .pb_collapsible_kit {
       &[class*="_active"] {
         background-color: unset;
-        .pb_collapsible_main_kit {
+        >.pb_collapsible_main_kit {
           background-color: $primary;
           border-radius: $border_rad_heavier;
           .pb_nav_list_item_text_collapsible,
@@ -94,7 +94,7 @@
     &.dark {
       .pb_collapsible_kit {
         &[class*="_active"] {
-          .pb_collapsible_main_kit {
+          >.pb_collapsible_main_kit {
             background-color: $primary;
           }
           .pb_nav_list_item_link {
@@ -112,7 +112,7 @@
     .pb_collapsible_kit {
       &[class*="_active"] {
         background-color: unset;
-        .pb_collapsible_main_kit {
+        >.pb_collapsible_main_kit {
           background-color: $active_light;
           border-radius: $border_rad_heavier;
           .pb_nav_list_item_text_collapsible,
@@ -128,7 +128,7 @@
     &.dark {
       .pb_collapsible_kit {
         &[class*="_active"] {
-          .pb_collapsible_main_kit {
+          >.pb_collapsible_main_kit {
             background-color: mix($white, $card_dark, 20%) !important;
             .pb_nav_list_item_text_collapsible,
             svg {

data/app/pb_kits/playbook/pb_passphrase/passphrase.rb

@@ -4,7 +4,7 @@ module Playbook
   module PbPassphrase
     class Passphrase < Playbook::KitBase
       prop :confirmation, type: Playbook::Props::Boolean, default: false
-      prop :input_props, type: Playbook::Props::Hash, default: {}
+      prop :input_props, type: Playbook::Props::HashProp, default: {}
       prop :label
       prop :show_tips_below, type: Playbook::Props::Enum,
                              values: %w[always xs sm md lg xl],

data/app/pb_kits/playbook/pb_radio/radio.rb

@@ -11,7 +11,7 @@ module Playbook
                      default: false
       prop :error, type: Playbook::Props::Boolean,
                    default: false
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
       prop :name, type: Playbook::Props::String,
                   default: "radio_name"

data/app/pb_kits/playbook/pb_rich_text_editor/TipTap/EditorButton.tsx

@@ -31,8 +31,10 @@ const EditorButton = ({
     >
       <button
         className={classname}
-        onClick={onclick}
         disabled={disable}
+        onClick={onclick}
+        role="button"
+        type="button"
       >
         <Flex 
           align="center"

data/app/pb_kits/playbook/pb_rich_text_editor/TipTap/MoreExtensionsDropdown.tsx

@@ -22,6 +22,8 @@ const popoverReference = (
     <button
       className="toolbar_button"
       onClick={handleTogglePopover}
+      role="button"
+      type="button"
     >
     <Flex 
       align="center"

data/app/pb_kits/playbook/pb_select/select.rb

@@ -6,7 +6,7 @@ require "action_view"
 module Playbook
   module PbSelect
     class Select < Playbook::KitBase
-      prop :attributes, type: Playbook::Props::Hash,
+      prop :attributes, type: Playbook::Props::HashProp,
                         default: {}
       prop :blank_selection
       prop :compact, type: Playbook::Props::Boolean, default: false

data/app/pb_kits/playbook/pb_selectable_card/selectable_card.rb

@@ -15,7 +15,7 @@ module Playbook
                    default: true
       prop :input_id, type: Playbook::Props::String
 
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
       prop :name
       prop :text

data/app/pb_kits/playbook/pb_selectable_card_icon/selectable_card_icon.rb

@@ -23,7 +23,7 @@ module Playbook
                        default: false
       prop :value
 
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
 
       def classname

data/app/pb_kits/playbook/pb_selectable_icon/selectable_icon.rb

@@ -21,7 +21,7 @@ module Playbook
                       default: false
       prop :value
 
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
 
       # Conditional rendering for input field

data/app/pb_kits/playbook/pb_selectable_list/selectable_list_item.rb

@@ -12,7 +12,7 @@ module Playbook
       prop :variant, type: Playbook::Props::Enum,
                      values: %w[radio checkbox],
                      default: "radio"
-      prop :input_options, type: Playbook::Props::Hash,
+      prop :input_options, type: Playbook::Props::HashProp,
                            default: {}
 
       def classname

data/app/pb_kits/playbook/pb_source/source.rb

@@ -10,7 +10,7 @@ module Playbook
       prop :type, type: Playbook::Props::Enum,
                   values: %w[user retail inbound outbound prospecting events referral],
                   default: "inbound"
-      prop :user, type: Playbook::Props::Hash, default: {}
+      prop :user, type: Playbook::Props::HashProp, default: {}
 
       def type_text
         if type == "user" || (type == "referral" && user.present?)

data/app/pb_kits/playbook/pb_table/docs/_table_header.html.erb

@@ -2,27 +2,31 @@
   <thead>
     <tr>
       <%= pb_rails("table/table_header", props: {
-        id: "name",
-        colspan: 2,
+        text: "Territory",
+        id: "territory",
         sort_menu: [
-          { item: "Name", link: "?q[sorts]=name+desc", active: false, direction: "desc" },
-          { item: "Name", link: "?q[sorts]=name+asc", active: true, direction: "asc" },
+          { item: "Territory", link: "?sort=territory_desc", active: params["sort"] == "territory_desc", direction: "desc" },
+          { item: "Territory", link: "?sort=territory_asc", active: params["sort"] == "territory_asc", direction: "asc" }
         ],
       }) %>
       <%= pb_rails("table/table_header", props: {
-        text: "Age",
-        id: "age",
+        id: "name",
+        text: "Full Name",
+        colspan: 2,
         sort_menu: [
-          { item: "Age", link: "?q[sorts]=age+desc", active: false, direction: "desc" },
-          { item: "Age", link: "?q[sorts]=age+asc", active: false, direction: "asc" },
+          { item: "First Name Descending", link: "?sort=firstname_desc", active: params["sort"] == "firstname_desc", direction: "desc" },
+          { item: "First Name Ascending", link: "?sort=firstname_asc", active: params["sort"] == "firstname_asc", direction: "asc" },
+          { item: "Last Name Descending", link: "?sort=lastname_desc", active: params["sort"] == "lastname_desc", direction: "desc" },
+          { item: "Last Name Ascending", link: "?sort=lastname_asc", active: params["sort"] == "lastname_asc", direction: "asc" }
         ],
       }) %>
       <%= pb_rails("table/table_header", props: {
-        text: "Territory",
-        id: "territory",
+        text: "Age",
+        id: "age",
+        sort_dropdown: true,
         sort_menu: [
-          { item: "Territory", link: "?q[sorts]=territory+desc", active: false, direction: "desc" },
-          { item: "Territory", link: "?q[sorts]=territory+asc", active: false, direction: "asc" },
+          { item: "Age Descending", link: "?sort=age_desc", active: params["sort"] == "age_desc", direction: "desc" },
+          { item: "Age Ascending", link: "?sort=age_asc", active: params["sort"] == "age_asc", direction: "asc" }
         ],
       }) %>
       <%= pb_rails("table/table_header", props: { text: "Job Title" }) %>
@@ -30,25 +34,25 @@
   </thead>
   <tbody>
     <tr>
-      <td>Name 1</td>
-      <td>Name 2</td>
-      <td>Value 3</td>
-      <td>Value 4</td>
-      <td>Value 5</td>
+      <td>Ter 1</td>
+      <td>First Name 1</td>
+      <td>Last Name 1</td>
+      <td>Age 1</td>
+      <td>Job 1</td>
     </tr>
     <tr>
-      <td>Name 1</td>
-      <td>Name 2</td>
-      <td>Value 3</td>
-      <td>Value 4</td>
-      <td>Value 5</td>
+      <td>Ter 2</td>
+      <td>First Name 2</td>
+      <td>Last Name 2</td>
+      <td>Age 2</td>
+      <td>Job 2</td>
     </tr>
     <tr>
-      <td>Name 1</td>
-      <td>Name 2</td>
-      <td>Value 3</td>
-      <td>Value 4</td>
-      <td>Value 5</td>
+      <td>Ter 3</td>
+      <td>First Name 3</td>
+      <td>Last Name 3</td>
+      <td>Age 3</td>
+      <td>Job 3</td>
     </tr>
   </tbody>
 <% end %>

data/app/pb_kits/playbook/pb_table/docs/_table_header.md

@@ -1 +1,8 @@
-A kit that produces a `<th>` tag. You can also use the `sort_menu` prop to make the header a sortable link, just like <a href="https://playbook.powerapp.cloud/kits/filter#sort-only" target="_blank">our filter kit.</a>
+The `table_header` subcomponent creates `<th>` elements and optionally accepts:
+
+* `colspan` (number) for setting column span
+* `sort_menu` accepts sort options as an array of `item` objects.
+presence of `sort_menu` enables the sort link within the header
+* `sort_dropdown` (boolean) optionally declares that (true) clicking a header's sort link opens a dropdown of sort options, or (false) each sort link click cycles through available sort_menu items in the order they are passed
+  * passing a valid `colspan` will render sort options within a dropdown by default, without requiring `sort_dropdown` explicitly. Alternatively, the default sort dropdown can be prevented on headers with `colspan` by setting `sort_dropdown: false`, which reverts the column to sorting to multi-click default (each click of the sort link cycles through the available sort_menu items in the order they are passed)
+* `id` (string) is required for headers that have a dropdown (for popover reference); otherwise they are optional

data/app/pb_kits/playbook/pb_table/styles/_table_header.scss

@@ -1,4 +1,3 @@
-
 $text_align_values: (
   start: start,
   end: end,
@@ -22,6 +21,15 @@ $text_align_values: (
   }
 }
 
+.pb_th_link:hover {
+  background-color: rgba($primary, 0.03);
+  color: $primary !important;
+}
+
+.pb_th_link, .pb_th_nolink{
+  padding: $space_xxs;
+}
+
 [class^=pb_table] {
   thead {
     [class^=pb_th_active] {
@@ -29,3 +37,14 @@ $text_align_values: (
     }
   }
 }
+
+[class*="pb_table_header_dropdown"][class*="_vertical"] {
+  &[class*="_normal"] {
+    [class*="pb_nav_list_kit_item"][class*="pb_nav_list_item"] {
+      &[class*="_link"] {
+        border-left-width: 0px;
+        background-color: #fff !important;
+      }
+    }
+  }
+}

data/app/pb_kits/playbook/pb_table/table_header.html.erb

@@ -4,61 +4,35 @@
     class: object.classname,
     data: object.data,
     id: "pb-th#{object.id}") do %>
-  <% object.sort_menu.each do |item| %>
-    <% if item[:active] == true %>
-      <%= pb_rails("flex", props:{ align: object.align_content }) do %>
-        <%= content.presence || content_tag(:span, item[:item], class: "pb_th_active") %>
-        <span class="pb_th_active">
-          <%= pb_rails("icon", props: { icon: object.sort_icon(item[:direction]),
-                                        fixed_width: true,
-                                        classname: "pb_th_active",
-                                        padding_left: "xs" }) %>
-        </span>
-      <% end %>
-    <% end %>
-  <% end %>
-  <% if object.sort_menu.all? { |item| item[:active] == false } %>
-    <%= pb_rails("flex", props:{ align: object.align_content }) do %>
+  <% unless sorting_style? %>
+    <%= pb_rails("flex", props:{ align: object.align_content, justify: object.justify_sort_icon, classname: "pb_th_nolink" }) do %>
       <%= content.presence || object.text %>
-      <%= pb_rails("icon", props: { icon: "arrow-up-arrow-down",
-                                    fixed_width: true,
-                                    padding_left: "xs" }) %>
     <% end %>
   <% else %>
-    <%= content.presence || object.text %>
-  <% end %>
-  <% if object.sort_menu != [{}] && object.colspan > 1 %>
-    <%= pb_rails("popover", props: { classname: "pb_filter_sort_menu",
-                                    close_on_click: "outside",
-                                    trigger_element_id: "pb-th#{object.id}",
-                                    tooltip_id: "sort-filter-btn-tooltip#{object.id}",
-                                    position: object.placement ,
-                                    padding: 'none'}) do %>
-      <%= pb_rails("list") do %>
-        <% object.sort_menu.each do |item| %>
-          <%= pb_rails("list/item") do %>
-            <%= pb_rails("button", props: { variant: "link" ,
-                                            classname: "p-0",
-                                            text: item[:item],
-                                            link: item[:link],
-                                            icon: sort_icon(item[:direction]),
-                                            icon_right: true }) %>
+    <%= link_to next_link, style: link_style do %>
+      <%= pb_rails("flex", props:{ align: object.align_content, justify: object.justify_sort_icon, classname: "pb_th_link" }) do %>
+        <%= content.presence || object.text %>
+          <% if sorting_style? %>
+            <%= pb_rails("icon", props: { icon: object.sort_icon(active_item[:direction], active_item[:active]),
+                                          fixed_width: true,
+                                          classname: active_item.any? ? "pb_th_active" : "",
+                                          padding_left: "xs" }) %>
+        <% end %>
+      <% end %>
+    <% end %>
+    <% if use_dropdown_select %>
+      <%= pb_rails("popover", props: { classname: "pb_filter_sort_menu",
+                                      close_on_click: "outside",
+                                      trigger_element_id: "pb-th#{object.id}",
+                                      tooltip_id: "sort-filter-btn-tooltip#{object.id}",
+                                      position: object.placement ,
+                                      padding: 'none'}) do %>
+        <%= pb_rails("nav", props: {classname: "pb_table_header_dropdown"}) do %>
+          <% object.sort_menu.each do |item| %>
+            <%= pb_rails("nav/item", props: { text: item[:item], link: item[:link], icon_right: sort_icon(item[:direction], item[:active]), active: item[:active] }) %>
           <% end %>
         <% end %>
       <% end %>
     <% end %>
   <% end %>
 <% end %>
-<% if object.sort_menu != [{}] && object.colspan == 1 %>
-  <script>
-    document.addEventListener("DOMContentLoaded", function() {
-      var thId = `<%= "#pb-th#{object.id}" %>`
-      var firstLink = `<%= next_link %>`
-      var thElement = document.querySelector(thId);
-
-      thElement.addEventListener("click", function() {
-        window.location.href = firstLink;
-      });
-    });
-  </script>
-<% end %>