playbook_ui 13.20.0.pre.alpha.PBNTR225advancedtablefeedback2375 → 13.20.0

data/app/pb_kits/playbook/pb_table/styles/_striped.scss

@@ -1,7 +1,7 @@
 [class^=pb_table] {
   &.striped {
     tbody, .pb_table_tbody {
-      tr:nth-child(odd), .pb_table_tr:nth-child(odd) {
+      tr:nth-child(odd), .tr:nth-child(odd) {
         background-color: $bg_light;
       }
     }
@@ -10,7 +10,7 @@
   &.dark {
     &.striped {
       tbody, .pb_table_tbody {
-        tr:nth-child(odd), .pb_table_tr:nth-child(odd) {
+        tr:nth-child(odd), .tr:nth-child(odd) {
           background-color: $bg_dark;
         }
       }

data/app/pb_kits/playbook/pb_table/styles/_structure.scss

@@ -48,8 +48,7 @@
         }
       }
       &.data_table {
-        thead tr th,
-        .pb_table_thead .pb_table_tr .pb_table_th {
+        thead tr th {
           padding-top: $cell-pad-sm;
           padding-bottom: $cell-pad-sm;
           &:first-child {
@@ -59,8 +58,7 @@
             padding-right: $cell-pad-sm;
           }
         }
-        tbody tr td,
-        .pb_table_tbody .pb_table_tr .pb_table_td  {
+        tbody tr td {
           padding-top: $cell-pad-sm;
           padding-bottom: $cell-pad-sm;
           &:first-child {

data/app/pb_kits/playbook/pb_table/table_header.html.erb

@@ -1,57 +1,47 @@
-<% if object.tag == "table" %>  
-  <%= content_tag(:th,
-      colspan: object.colspan,
-      aria: object.aria,
-      class: object.classname,
-      data: object.data,
-      id: "pb-th#{object.id}" ) do %>
-    <% unless sorting_style? %>
-      <%= pb_rails("flex", props:{ align: object.align_content, justify: object.justify_sort_icon, classname: "pb_th_nolink" }) do %>
+<%= content_tag(:th,
+    colspan: object.colspan,
+    aria: object.aria,
+    class: object.classname,
+    data: object.data,
+    id: "pb-th#{object.id}" ) do %>
+  <% unless sorting_style? %>
+    <%= pb_rails("flex", props:{ align: object.align_content, justify: object.justify_sort_icon, classname: "pb_th_nolink" }) do %>
+      <%= content.presence || object.text %>
+    <% end %>
+  <% else %>
+    <%= link_to next_link, style: link_style do %>
+      <%= pb_rails("flex", props:{ align: object.align_content, justify: object.justify_sort_icon, classname: "pb_th_link" }) do %>
         <%= content.presence || object.text %>
-      <% end %>
-    <% else %>
-      <%= link_to next_link, style: link_style do %>
-        <%= pb_rails("flex", props:{ align: object.align_content, justify: object.justify_sort_icon, classname: "pb_th_link" }) do %>
-          <%= content.presence || object.text %>
-            <% if sorting_style? %>
-              <%= pb_rails("icon", props: { icon: object.sort_icon(active_item[:direction], active_item[:active]),
-                                            fixed_width: true,
-                                            classname: active_item.any? ? "pb_th_active" : "",
-                                            padding_left: "xs" }) %>
-          <% end %>
+          <% if sorting_style? %>
+            <%= pb_rails("icon", props: { icon: object.sort_icon(active_item[:direction], active_item[:active]),
+                                          fixed_width: true,
+                                          classname: active_item.any? ? "pb_th_active" : "",
+                                          padding_left: "xs" }) %>
         <% end %>
       <% end %>
-      <% if use_dropdown_select %>
-        <%= pb_rails("popover", props: { classname: "pb_filter_sort_menu",
-                                        close_on_click: "outside",
-                                        trigger_element_id: "pb-th#{object.id}",
-                                        tooltip_id: "sort-filter-btn-tooltip#{object.id}",
-                                        position: object.placement ,
-                                        padding: 'none'}) do %>
-          <%= pb_rails("nav", props: {classname: "pb_table_header_dropdown"}) do %>
-            <% object.sort_items.each do |sort_item| %>
-              <% item = active_or_first_item(sort_items_for(sort_item)) %>
-              <%= pb_rails("nav/item", props: {
-                text: item[:item],
-                link: next_link(sort_item: sort_item),
-                highlighted_border: false,
-                padding: "xs",
-                icon_right: sort_icon(item[:direction], item[:active]),
-                active: item[:active],
-                classname: "header_nav_item"
-              }) %>
-            <% end %>
+    <% end %>
+    <% if use_dropdown_select %>
+      <%= pb_rails("popover", props: { classname: "pb_filter_sort_menu",
+                                      close_on_click: "outside",
+                                      trigger_element_id: "pb-th#{object.id}",
+                                      tooltip_id: "sort-filter-btn-tooltip#{object.id}",
+                                      position: object.placement ,
+                                      padding: 'none'}) do %>
+        <%= pb_rails("nav", props: {classname: "pb_table_header_dropdown"}) do %>
+          <% object.sort_items.each do |sort_item| %>
+            <% item = active_or_first_item(sort_items_for(sort_item)) %>
+            <%= pb_rails("nav/item", props: {
+              text: item[:item],
+              link: next_link(sort_item: sort_item),
+              highlighted_border: false,
+              padding: "xs",
+              icon_right: sort_icon(item[:direction], item[:active]),
+              active: item[:active],
+              classname: "header_nav_item"
+            }) %>
           <% end %>
         <% end %>
       <% end %>
     <% end %>
   <% end %>
-<% else %>
-  <%= content_tag(:div,
-    aria: object.aria,
-    class: object.classname,
-    data: object.data,
-    id: object.id) do %>
-      <%= content.presence || object.text %>
-  <% end %>
-<% end %>
+<% end %>

data/app/pb_kits/playbook/pb_table/table_header.rb

@@ -23,16 +23,9 @@ module Playbook
                   default: ""
       prop :sort_dropdown, type: Playbook::Props::Boolean,
                            default: false
-      prop :tag, type: Playbook::Props::Enum,
-                 values: %w[table div],
-                 default: "table"
 
       def classname
-        generate_classname("pb_table_header_kit", align_class) + tag_class
-      end
-
-      def tag_class
-        " pb_table_th"
+        generate_classname("pb_table_header_kit", align_class)
       end
 
       def align_class

data/app/pb_kits/playbook/pb_table/table_row.html.erb

@@ -1,17 +1,7 @@
-<% if object.tag == "table" %>
-    <%= content_tag(:tr,
-      aria: object.aria,
-      class: object.classname,
-      data: object.data,
-      id: object.id) do %>
-      <%= content.presence %>
-    <% end %>
-<% else %>
-    <%= content_tag(:div,
-      aria: object.aria,
-      class: object.classname,
-      data: object.data,
-      id: object.id) do %>
-      <%= content.presence %>
-    <% end %>
-<% end %>
+<%= content_tag(:tr,
+    aria: object.aria,
+    class: object.classname,
+    data: object.data,
+    id: object.id) do %>
+  <%= content.presence %>
+<% end %>

data/app/pb_kits/playbook/pb_table/table_row.rb

@@ -5,21 +5,14 @@ module Playbook
     class TableRow < Playbook::KitBase
       prop :side_highlight_color, type: Playbook::Props::String,
                                   default: "none"
-      prop :tag, type: Playbook::Props::Enum,
-                 values: %w[table div],
-                 default: "table"
 
       def classname
-        generate_classname("pb_table_row_kit", side_highlight_class) + tag_class
+        generate_classname("pb_table_row_kit", side_highlight_class)
       end
 
       def side_highlight_class
         side_highlight_color.present? ? "side_highlight_#{side_highlight_color}" : nil
       end
-
-      def tag_class
-        " pb_table_tr"
-      end
     end
   end
 end

data/app/pb_kits/playbook/pb_text_input/_text_input.tsx

@@ -27,7 +27,7 @@ type TextInputProps = {
   required?: boolean,
   type: string,
   value: string | number,
-  children: React.ReactElement,
+  children: Node,
   addOn?: {
     icon?: string,
     alignment?: "right" | "left",
@@ -85,12 +85,8 @@ const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>
         icon={icon}
     />
   )
-
-  const childInput = children ? children.type === "input" : undefined
-
   const textInput = (
-    childInput ? React.cloneElement(children, { className: "text_input" }) :
-    (<input
+    <input
         {...domSafeProps(props)}
         className="text_input"
         disabled={disabled}
@@ -103,7 +99,7 @@ const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>
         required={required}
         type={type}
         value={value}
-    />)
+    />
   )
 
   const addOnInput = (
@@ -135,7 +131,7 @@ const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>
   )
 
   const render = (() => {
-    if (children && !childInput) return children
+    if(children) return children
     if (shouldShowAddOn) return addOnInput
 
     return textInput
@@ -148,7 +144,7 @@ const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>
         {...htmlProps}
         className={css}
     >
-      {label &&
+      {label && 
         <Caption
             className="pb_text_input_kit_label"
             text={label}

data/app/pb_kits/playbook/pb_text_input/docs/_text_input_add_on.jsx

@@ -58,16 +58,6 @@ const TextInputAddOn = (props) => {
             {...props}
         />
       </div>
-      <div>
-        <TextInput
-            addOn={{ icon: 'frog', alignment: 'right', border: true }}
-            label="Right-Aligned Add On With Child Input"
-            onChange={handleUpdateFourthInput}
-            {...props}
-        >
-          <input />
-        </TextInput>
-      </div>
       <div>
         <TextInput
             addOn={{ icon: 'percent', alignment: 'left', border: false }}
@@ -86,16 +76,6 @@ const TextInputAddOn = (props) => {
             {...props}
         />
       </div>
-      <div>
-        <TextInput
-            addOn={{ icon: 'frog', alignment: 'left', border: true }}
-            label="Left-Aligned Add On With Child Input"
-            onChange={handleUpdateFourthInput}
-            {...props}
-        >
-          <input />
-        </TextInput>
-      </div>
     </>
   )
 }

data/app/pb_kits/playbook/pb_user/docs/_user_props_table.md

@@ -7,5 +7,4 @@
 | **orientation** | `Orientation` | Changes the orientation of the User | `.horizontal` | `.horizontal` `.verticle` |
 | **size** | `UserAvatarSize` | Changes the size of the User | `.medium` | `.small` `.medium` `.large` |
 | **territory** | `String` | Adds the User's territory |  |  |
-| **title** | `String` | Adds a title |  |  |
-| **status** | `PBAvatar.PresenceStatus?` | An idicator for the current status of the user | `.none` | `.online` `.away` `.offline` |
+| **title** | `String` | Adds a title |  |  |

data/app/pb_kits/playbook/pb_user/docs/example.yml

@@ -23,5 +23,4 @@ examples:
   - user_vertical_size_swift: Vertical
   - user_text_only_swift: Text Only
   - user_size_swift: Horizontal Size
-  - user_presence_indicator_swift: Presence Indicator
   - user_props_table: ""