playbook_ui 12.38.0.pre.alpha.PLAYaddingdatapropselectkit1080 → 12.38.0.pre.alpha.audiencesalpha1083

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e534a0e0e952acf92b13ede8c1f7316960b4c33c5cbc139de313a5d99b0a0bb
-  data.tar.gz: 547c1ac1600076cea049ce2566a075146e83479899e6ca8c1bfffa43fcce9c9c
+  metadata.gz: '0139336c42fa16df313511160bd10201f796824318b208fe99b5265968627597'
+  data.tar.gz: 8f72c790da5e7b7f83cfe397aa3cd4d0e7d71fc8bd4da55a23cf4dece9e6e8db
 SHA512:
-  metadata.gz: b3f9f2f5f7c43f72ce2f35bb6c3d214575d90922039e847a736ea1517d5c11a903e25ac0601d7cd4155c9dd8b0915ef4990a88cf353d83d9ea60a7097bf48510
-  data.tar.gz: a8e93ed7c8f629d6b4d0c47b6ccd064f76b01f100993ca07aa06cc99f6e45c677e397c86b3ecc9e89322573b4d7ab6c0bee37f203fe99ec627c53b5efce884c3
+  metadata.gz: 92e5cca935e9ccfc18ddf59cc4be1d385bf4e9be299c5c4c10a0e79134a19d84c1bdde8b664c3953ebba73d1e02d7615ad4f8dffd413cf946a1ae2a1639380fd
+  data.tar.gz: 3cd03b617d9a1a09e8531e54a21c24d325c3afc0ba1e9dcf1fe6bddb7db0e08e62ab6932e03004ffb62a1f5fb6e89d848c94b1cc75d861ed40606560ebd9d76a

data/app/pb_kits/playbook/pb_select/docs/example.yml

@@ -11,7 +11,6 @@ examples:
   - select_error: Select w/ Error
   - select_inline: Select Inline
   - select_inline_compact: Select Inline Compact
-  - select_attributes: Select W/ Attributes
 
 
 

data/app/pb_kits/playbook/pb_select/select.html.erb

@@ -1,6 +1,6 @@
 <%= content_tag(:div,
-  aria: object.aria,
   data: object.data,
+  aria: object.aria,
   class: object.classnames) do %>
   <% if object.label %>
     <label class="pb_select_kit_label" for="<%= object.name %>">
@@ -19,7 +19,13 @@
           selected: object.selected,
           disabled: object.disabled_options,
         ),
-        object.all_attributes
+        id: object.id,
+        prompt: object.blank_selection,
+        disabled: object.disabled,
+        required: object.required,
+        multiple: object.multiple,
+        onchange: object.onchange,
+        include_blank: object.include_blank,
       )
       %>
       <%= pb_rails("body", props: { status: "negative", text: object.error }) %>

data/app/pb_kits/playbook/pb_select/select.rb

@@ -6,8 +6,6 @@ require "action_view"
 module Playbook
   module PbSelect
     class Select < Playbook::KitBase
-      prop :attributes, type: Playbook::Props::Hash,
-                        default: {}
       prop :blank_selection
       prop :compact, type: Playbook::Props::Boolean, default: false
       prop :disabled, type: Playbook::Props::Boolean, default: false
@@ -25,18 +23,6 @@ module Playbook
         classname + inline_class + compact_class
       end
 
-      def all_attributes
-        {
-          id: id,
-          prompt: blank_selection,
-          disabled: disabled,
-          required: required,
-          multiple: multiple,
-          onchange: onchange,
-          include_blank: include_blank,
-        }.merge(attributes)
-      end
-
       def classname
         generate_classname("pb_select", select_margin_bottom, separator: " ")
       end

data/lib/playbook/version.rb

@@ -2,5 +2,5 @@
 
 module Playbook
   PREVIOUS_VERSION = "12.38.0"
-  VERSION = "12.38.0.pre.alpha.PLAYaddingdatapropselectkit1080"
+  VERSION = "12.38.0.pre.alpha.audiencesalpha1083"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: playbook_ui
 version: !ruby/object:Gem::Version
-  version: 12.38.0.pre.alpha.PLAYaddingdatapropselectkit1080
+  version: 12.38.0.pre.alpha.audiencesalpha1083
 platform: ruby
 authors:
 - Power UX
@@ -1851,8 +1851,6 @@ files:
 - app/pb_kits/playbook/pb_select/_select.tsx
 - app/pb_kits/playbook/pb_select/docs/_description.md
 - app/pb_kits/playbook/pb_select/docs/_footer.md
-- app/pb_kits/playbook/pb_select/docs/_select_attributes.html.erb
-- app/pb_kits/playbook/pb_select/docs/_select_attributes.md
 - app/pb_kits/playbook/pb_select/docs/_select_blank.html.erb
 - app/pb_kits/playbook/pb_select/docs/_select_blank.jsx
 - app/pb_kits/playbook/pb_select/docs/_select_custom_select.html.erb

data/app/pb_kits/playbook/pb_select/docs/_select_attributes.html.erb

@@ -1,26 +0,0 @@
-<%= pb_rails("select", props: {
-  attributes: {
-    data: { options: "data_attribute" },
-  },
-  label: "Favorite Food",
-  name: "food",
-  options: [
-    {
-      value: "1",
-      value_text: "Burgers",
-    },
-    {
-      value: "2",
-      selected: true,
-      value_text: "Pizza",
-    },
-    {
-      value: "3",
-      value_text: "Tacos",
-    },
-    {
-      value: "4",
-      value_text: "BBQ",
-    },
-  ]
-}) %>

data/app/pb_kits/playbook/pb_select/docs/_select_attributes.md

@@ -1 +0,0 @@
-Inspect the element and notice the data-attribute being added to the `<select>` element