playbook_ui 10.18.1 → 10.18.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f142578a4f0c11786c87876c2ede359c72f96d89fbcb752f9e5938d2f34dbd55
-  data.tar.gz: e8d5692cee8e7e6bcc5882e344b602ec2b565171a063da4bd2596c8647b713fb
+  metadata.gz: 2e3cbc0cd92e9520cc384a83a63b0c7929db90e80ee3c14545f4cb59cea7e908
+  data.tar.gz: 3dbd612141159027a9da789d6a371cc8e8f2dccb9eaabff33f4c4ddea0c1e473
 SHA512:
-  metadata.gz: 1bd8c3eba4db831eb573503991d5217795dafb5bc908de7be90ddae604bfe12122ff588f86964764a7856fa910202687b91e08a45da0934f567f4d8f4c199d20
-  data.tar.gz: 745dc4d1bac54f13518d974f6a6ba7ff8817c9f3c98f49905b8ee708735eafd75fda8066255cb35ed1c2157ef8949b8d2f9ff2e4514ac1e0af617224ef9e827c
+  metadata.gz: e5a15bb11978d3ac1e8bc98c067cfc39ca9012e8e995e758d5debe9073db0dad4b63b2222c6bf687bc739c5dfaca5e249e12b2b89345c711284000d177f00ea7
+  data.tar.gz: f5f8ad98e52dde53cd3c634757aa6ffeb9c9e6d53a4081c3861e839d1ab6b210d26dd63691be86d9c946cc7c6b4760f006b772e5bb3924be97de70d19f320ac1

data/app/pb_kits/playbook/pb_button/_button.jsx

@@ -22,7 +22,7 @@ type ButtonPropTypes = {
   loading?: boolean,
   newWindow?: boolean,
   onClick?: EventHandler,
-  size?: 'sm' | 'md' | 'lg',
+  size: 'large' | 'medium' | 'small',
   text?: string,
   type: 'inline' | null,
   htmlType: string | 'button',
@@ -36,16 +36,16 @@ const buttonClassName = (props: ButtonPropTypes) => {
     disabled = false,
     fullWidth = false,
     loading = false,
+    size = null,
     type = 'inline',
     variant = 'primary',
-    size = null,
   } = props
 
   let className = 'pb_button_kit'
 
-  className += `${size !== null ? `_${size}` : ''}`
   className += `${variant !== null ? `_${variant}` : ''}`
   className += `${type !== null ? `_${type}` : ''}`
+  className += `${size !== null ? `_${size}` : ''}`
   className += `${fullWidth ? '_block' : ''}`
   className += disabled ? '_disabled' : '_enabled'
   className += loading ? '_loading' : ''

data/app/pb_kits/playbook/pb_button/_button.scss

@@ -1,24 +1,7 @@
 @import "./button_mixins";
 
-$pb_button_sizes: (
-  "sm":   0.75rem,
-  "md":   0.875rem,
-  "lg":   1.125rem,
-);
-
 [class^=pb_button_kit]{
   @include pb_button;
-  // Size =================
-  @each $name, $size in $pb_button_sizes {
-    &[class*=_#{$name}] {
-      font-size: $size;
-      padding: calc(#{$size} / 2) calc(#{$size} * 2.42) !important;
-    }
-  }
-  &[class*=_sm] {
-    min-height: 0;
-  }
-
   // Variants =================
   &[class*=_primary]  {
     @include pb_button_primary;

data/app/pb_kits/playbook/pb_button/button.rb

@@ -18,9 +18,6 @@ module Playbook
       prop :text
       prop :type
       prop :value
-      prop :size, type: Playbook::Props::Enum,
-                  values: ["sm", "md", "lg", nil],
-                  default: nil
 
       def options
         {
@@ -47,12 +44,12 @@ module Playbook
         link ? "a" : "button"
       end
 
+    private
+
       def classname
-        generate_classname("pb_button_kit", size, variant, full_width_class, disabled_class, loading_class)
+        generate_classname("pb_button_kit", variant, full_width_class, disabled_class, loading_class)
       end
 
-    private
-
       def disabled_class
         disabled ? "disabled" : "enabled"
       end

data/app/pb_kits/playbook/pb_button/button.test.js

@@ -89,16 +89,3 @@ test('click event', async () => {
 
   expect(screen.getByText('clicked button!')).toBeInTheDocument()
 })
-
-test('size prop', () => {
-  render(
-    <Button
-        data={{ testid: 'size-test' }}
-        size="sm"
-    />
-  )
-
-  const kit = screen.getByTestId('size-test')
-
-  expect(kit).toHaveClass('pb_button_kit_sm_primary_inline_enabled')
-})

data/app/pb_kits/playbook/pb_button/docs/example.yml

@@ -7,7 +7,6 @@ examples:
   - button_block_content: Button Block Content
   - button_accessibility: Button Accessibility Options
   - button_options: Button Additional Options
-  - button_size: Button Size
   react:
   - button_default: Button Variants
   - button_full_width: Button Full Width
@@ -16,4 +15,3 @@ examples:
   - button_block_content: Button Block Content
   - button_accessibility: Button Accessibility Options
   - button_options: Button Additional Options (onClick)
-  - button_size: Button Size

data/app/pb_kits/playbook/pb_button/docs/index.js

@@ -5,4 +5,3 @@ export { default as ButtonLoading } from './_button_loading.jsx'
 export { default as ButtonBlockContent } from './_button_block_content.jsx'
 export { default as ButtonAccessibility } from './_button_accessibility.jsx'
 export { default as ButtonOptions } from './_button_options.jsx'
-export { default as ButtonSize } from './_button_size.jsx'

data/lib/playbook/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Playbook
-  PREVIOUS_VERSION = "10.18.0"
-  VERSION = "10.18.1"
+  PREVIOUS_VERSION = "10.18.1"
+  VERSION = "10.18.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: playbook_ui
 version: !ruby/object:Gem::Version
-  version: 10.18.1
+  version: 10.18.2
 platform: ruby
 authors:
 - Power UX
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-19 00:00:00.000000000 Z
+date: 2022-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -424,9 +424,6 @@ files:
 - app/pb_kits/playbook/pb_button/docs/_button_loading.md
 - app/pb_kits/playbook/pb_button/docs/_button_options.html.erb
 - app/pb_kits/playbook/pb_button/docs/_button_options.jsx
-- app/pb_kits/playbook/pb_button/docs/_button_size.html.erb
-- app/pb_kits/playbook/pb_button/docs/_button_size.jsx
-- app/pb_kits/playbook/pb_button/docs/_button_size.md
 - app/pb_kits/playbook/pb_button/docs/_footer.md
 - app/pb_kits/playbook/pb_button/docs/example.yml
 - app/pb_kits/playbook/pb_button/docs/index.js

data/app/pb_kits/playbook/pb_button/docs/_button_size.html.erb

@@ -1,3 +0,0 @@
-<%= pb_rails("button", props: { text: "Button sm size", size: "sm" }) %>
-<%= pb_rails("button", props: { text: "Button md size", size: "md" }) %>
-<%= pb_rails("button", props: { text: "Button lg size", size: "lg" }) %>

data/app/pb_kits/playbook/pb_button/docs/_button_size.jsx

@@ -1,26 +0,0 @@
-import React from 'react'
-import { Button } from '../../'
-
-const ButtonSize = (props) => (
-  <div>
-    <Button
-        size="sm"
-        text="Button sm size"
-        {...props}
-    />
-    {' '}
-    <Button
-        size="md"
-        text="Button md size"
-        {...props}
-    />
-    {' '}
-    <Button
-        size="lg"
-        text="Button lg size"
-        {...props}
-    />
-  </div>
-)
-
-export default ButtonSize

data/app/pb_kits/playbook/pb_button/docs/_button_size.md

@@ -1 +0,0 @@
-By default button has the `md` size style, even if you don't explicitly pass a size prop.