platform_agent 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37665e6536aba2833b93dc0f111046ecd115a57c49e914301e2cf81921e7ae18
-  data.tar.gz: a3601b3632b89ea98e8b3e5a1f8ea10b325de7c566811aa4b93a6ae5e59dbf2f
+  metadata.gz: 3d74b253a83cbc24d9bf3f56d00f137480b2f348573ad2aefee43168a2d070d9
+  data.tar.gz: 51d3ebb73e993af09dbe54011b2d839d3d4c81a903a2043babb0ebb1f2c9a705
 SHA512:
-  metadata.gz: 62f9130310cc151af360e5720f53eb5319c156742e6b61c4ee1dc12c80e05c9e4e33c254cb07f48f72ffd69f8dbc763ee4798d98cb726f5c8b35c84300b4867d
-  data.tar.gz: 979a7288c0d77cdc4af9b121b32a188b3b0cb737bc498f6c4f20b1d5fb7fabfd137e34687a2077ed3d85318d0ee32ae0e26478b13d441b6279bd6eac9c145d03
+  metadata.gz: f787a7d083e66116c9fd29f484081701e663d12c9368768483d58fc39942a8535a62dd094d81da1cc8dd3dde09e0a5e0957cac3eceedca6eefea9d0fd0a7743d
+  data.tar.gz: 5ba2b2327ebf805ea7c1a62f45b0a994fe340367298af59783c269c68ccb50e99e7c40343fc6c7bc8770df32d30b23bfe68841138435574597c63e15c20ed86f

data/README.md

@@ -20,7 +20,7 @@ class ApplicationPlatform < PlatformAgent
 
   def windows_app?
     match?(/Electron/) && match?(/basecamp3/) && match?(/Windows/)
-  end  
+  end
 end
 
 module SetPlatform
@@ -47,8 +47,8 @@ end
 
 ## Maintenance Expectations
 
-This library is an extraction from Basecamp that's been sufficient in almost unaltered form for years. While contributions are always welcome, do not expect a lot of feature evolution beyond the basics. 
+This library is an extraction from Basecamp that's been sufficient in almost unaltered form for years. While contributions are always welcome, do not expect a lot of feature evolution beyond the basics.
 
 ## License
 
-Platform Agent is released under the [MIT License](https://opensource.org/licenses/MIT).
+Platform Agent is released under the [MIT License](https://opensource.org/licenses/MIT).

data/lib/platform_agent.rb

@@ -5,7 +5,7 @@ class PlatformAgent
     self.user_agent_string = user_agent_string
   end
 
-  delegate :browser, :version, :product, to: :user_agent
+  delegate :browser, :version, :product, :os, to: :user_agent
 
   def desktop?
     !mobile?
@@ -89,7 +89,7 @@ class PlatformAgent
 
   def app_version
     # App user-agent string is parsed into two separate UserAgent instances, it's the last one that contains the right version
-    user_agent.last.version if native?
+    user_agent.last.version if native_app?
   end
 
   def to_s
@@ -110,7 +110,7 @@ class PlatformAgent
     attr_accessor :user_agent_string
 
     def match?(pattern)
-      true if user_agent_string.to_s.match(pattern)
+      user_agent_string.to_s.match?(pattern)
     end
 
     def user_agent

data/platform_agent.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'platform_agent'
-  s.version  = '1.0.0'
+  s.version  = '1.0.1'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Parse user agent to deduce the platform.'

data/test/platform_agent_test.rb

@@ -5,7 +5,7 @@ require 'platform_agent'
 
 class BasecampAgent < PlatformAgent
   def ios_app?
-    match?(/BC3 iOS/)
+    match? /BC3 iOS/
   end
 
   def android_app?
@@ -18,7 +18,7 @@ class BasecampAgent < PlatformAgent
 
   def windows_app?
     match?(/Electron/) && match?(/basecamp3/) && match?(/Windows/)
-  end  
+  end
 end
 
 class PlatformAgentTest < ActiveSupport::TestCase

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: platform_agent
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-02 00:00:00.000000000 Z
+date: 2019-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -99,8 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Parse user agent to deduce the platform.