plan_my_stuff 0.7.0 → 0.8.0

data/app/controllers/plan_my_stuff/webhooks/github_controller.rb

@@ -5,7 +5,7 @@ require 'openssl'
 module PlanMyStuff
   module Webhooks
     class GithubController < ActionController::API
-      before_action :verify_signature!
+      before_action :verify_signature
 
       # POST /webhooks/github
       def create
@@ -29,7 +29,7 @@ module PlanMyStuff
         #
         # @return [void]
         #
-        def verify_signature!
+        def verify_signature
           body = request.body.read
           request.body.rewind
 
@@ -81,21 +81,15 @@ module PlanMyStuff
           end
         end
 
-        # Adds the issue to the pipeline project at "Started" the first
-        # time it is assigned. Re-assigns and additional assignees are
-        # ignored -- if the issue is already in the pipeline we do not
-        # touch its status.
+        # Adds the issue to the pipeline project at "Started" the first time it is assigned. Re-assigns and
+        # additional assignees are ignored -- if the issue is already in the pipeline we do not touch its status.
         #
         # Skipped paths (no project item is created):
-        #   - Issue is closed (assignment changes on a closed issue
-        #     must not alter the pipeline)
-        #   - Issue has pending approvals (creating + +take!+ would
-        #     either orphan an item or 500 on the approval guard)
+        #   - Issue is closed (assignment changes on a closed issue must not alter the pipeline)
+        #   - Issue has pending approvals (creating + +take!+ would either orphan an item or 500 on the approval guard)
         #
-        # GitHub already records the issue assignment (that's what
-        # triggered this webhook), so the gem does not call +assign!+
-        # on the project item -- that would clobber co-assignees on
-        # the underlying issue.
+        # GitHub already records the issue assignment (that's what triggered this webhook), so the gem does not
+        # call +assign!+ on the project item -- that would clobber co-assignees on the underlying issue.
         #
         # @return [void]
         #
@@ -123,21 +117,18 @@ module PlanMyStuff
             return
           end
 
-          number = PlanMyStuff::Pipeline.resolve_pipeline_project_number
+          number = PlanMyStuff::Pipeline.resolve_pipeline_project_number!
           project_item = PlanMyStuff::ProjectItem.create!(issue, project_number: number)
           PlanMyStuff::Pipeline.take!(project_item)
         end
 
-        # Removes the issue from the pipeline project when the LAST
-        # assignee is removed. If any assignees remain, the webhook is
-        # a no-op (only one of N was removed). If the issue isn't in
-        # the pipeline at all, also a no-op (logged at info).
+        # Removes the issue from the pipeline project when the LAST assignee is removed. If any assignees remain,
+        # the webhook is a no-op (only one of N was removed). If the issue isn't in the pipeline at all, also a
+        # no-op (logged at info).
         #
-        # Closed issues are skipped: assignment changes on a closed
-        # issue must not alter the pipeline. Items already on the
-        # release cycle (Ready for Release, Release in Progress,
-        # Completed) are also locked -- once on the release path an
-        # item should not come off via webhook.
+        # Closed issues are skipped: assignment changes on a closed issue must not alter the pipeline. Items
+        # already on the release cycle (Ready for Release, Release in Progress, Completed) are also locked --
+        # once on the release path an item should not come off via webhook.
         #
         # @return [void]
         #
@@ -145,7 +136,7 @@ module PlanMyStuff
           return if issue_params[:state] == 'closed'
 
           remaining_assignees = Array.wrap(issue_params[:assignees])
-          return if remaining_assignees.any?
+          return if remaining_assignees.present?
 
           issue_number = issue_params.fetch(:number)
           project_item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue_number)
@@ -169,16 +160,13 @@ module PlanMyStuff
           PlanMyStuff::Pipeline.remove!(project_item)
         end
 
-        # Handles GitHub's +projects_v2_item+ webhook event. Mirrors a dev
-        # dragging an item from "Submitted" to "Started" on the project
-        # board into a +Pipeline.take!+ call so the
-        # +plan_my_stuff.pipeline.started+ event fires.
+        # Handles GitHub's +projects_v2_item+ webhook event. Mirrors a dev dragging an item from "Submitted" to
+        # "Started" on the project board into a +Pipeline.take!+ call so the +plan_my_stuff.pipeline.started+
+        # event fires.
         #
-        # Only acts on +action: 'edited'+ where the Status single-select
-        # field changed on the pipeline project. No-ops when the new
-        # status is anything other than "Started", when the +from+ status
-        # is already "Started" (loop guard from +move_to!+ triggering
-        # another webhook), or when the item cannot be located on the
+        # Only acts on +action: 'edited'+ where the Status single-select field changed on the pipeline project.
+        # No-ops when the new status is anything other than "Started", when the +from+ status is already "Started"
+        # (loop guard from +move_to!+ triggering another webhook), or when the item cannot be located on the
         # pipeline project.
         #
         # @return [void]
@@ -189,7 +177,7 @@ module PlanMyStuff
           item_project_node_id = payload_params.dig(:projects_v2_item, :project_node_id)
           return if item_project_node_id.blank?
 
-          pipeline_number = PlanMyStuff::Pipeline.resolve_pipeline_project_number
+          pipeline_number = PlanMyStuff::Pipeline.resolve_pipeline_project_number!
           project = PlanMyStuff::Project.find(pipeline_number)
           return unless project.id == item_project_node_id
 
@@ -231,11 +219,9 @@ module PlanMyStuff
         def handle_pull_request
           action = payload_params.fetch(:action)
 
-          # Only PRs targeting +main+ drive pipeline transitions on
-          # open/draft/reopen. PRs into +production+ are deploy PRs
-          # (often auto-created as drafts) and must not bump items
-          # back to "Started". The +closed+ branch handles its own
-          # base-ref routing.
+          # Only PRs targeting +main+ drive pipeline transitions on open/draft/reopen. PRs into +production+ are
+          # deploy PRs (often auto-created as drafts) and must not bump items back to "Started". The +closed+
+          # branch handles its own base-ref routing.
           if %w[opened ready_for_review reopened converted_to_draft].include?(action)
             base_ref = pull_request_params.dig(:base, :ref)
             return unless base_ref == PlanMyStuff.configuration.main_branch
@@ -253,11 +239,9 @@ module PlanMyStuff
           end
         end
 
-        # Opening a PR as a draft is a soft "I've started working on this"
-        # signal. For each linked issue, when the issue is not yet in the
-        # pipeline, add it at "Started"; when the issue has no assignees,
-        # assign the PR author. Already-in-pipeline items are NOT moved
-        # (a draft open is not a status change).
+        # Opening a PR as a draft is a soft "I've started working on this" signal. For each linked issue, when
+        # the issue is not yet in the pipeline, add it at "Started"; when the issue has no assignees, assign the
+        # PR author. Already-in-pipeline items are NOT moved (a draft open is not a status change).
         #
         # @return [void]
         #
@@ -283,9 +267,8 @@ module PlanMyStuff
           end
         end
 
-        # Adds the issue to the pipeline at "Started". Skipped when the
-        # issue has pending approvals (Pipeline.take!'s guard would
-        # otherwise leave an orphan project item behind).
+        # Adds the issue to the pipeline at "Started". Skipped when the issue has pending approvals
+        # (Pipeline.take!'s guard would otherwise leave an orphan project item behind).
         #
         # @param issue [PlanMyStuff::Issue]
         #
@@ -297,7 +280,7 @@ module PlanMyStuff
             return
           end
 
-          number = PlanMyStuff::Pipeline.resolve_pipeline_project_number
+          number = PlanMyStuff::Pipeline.resolve_pipeline_project_number!
           project_item = PlanMyStuff::ProjectItem.create!(issue, project_number: number)
           PlanMyStuff::Pipeline.take!(project_item)
         end

data/app/jobs/plan_my_stuff/application_job.rb

@@ -1,9 +1,8 @@
 # frozen_string_literal: true
 
 module PlanMyStuff
-  # Base class for all PMS gem jobs. Subclasses +::ActiveJob::Base+ so
-  # the gem doesn't depend on the consuming app having an
-  # +ApplicationJob+ constant.
+  # Base class for all PMS gem jobs. Subclasses +::ActiveJob::Base+ so the gem doesn't depend on the consuming app
+  # having an +ApplicationJob+ constant.
   class ApplicationJob < ::ActiveJob::Base
   end
 end

data/app/jobs/plan_my_stuff/reminders_sweep_job.rb

@@ -1,28 +1,23 @@
 # frozen_string_literal: true
 
 module PlanMyStuff
-  # Daily-cadence sweep job for reminder dispatch + inactivity auto-close.
-  # Consuming apps enqueue it once; the job self-requeues after each
-  # perform so the schedule persists without requiring a cron/whenever
-  # setup. Queue-adapter-agnostic: runs through ActiveJob's
-  # +set(wait_until:).perform_later+ so any backend works.
+  # Daily-cadence sweep job for reminder dispatch + inactivity auto-close. Consuming apps enqueue it once; the job
+  # self-requeues after each perform so the schedule persists without requiring a cron/whenever setup.
+  # Queue-adapter-agnostic: runs through ActiveJob's +set(wait_until:).perform_later+ so any backend works.
   class RemindersSweepJob < PlanMyStuff::ApplicationJob
     queue_as :default
 
-    # Only try once per enqueue. Without this, Delayed-style adapters
-    # retry up to 25 times on error and our +around_perform+ +ensure+
-    # re-enqueues a follow-up run on every attempt, causing geometric
-    # duplicate pile-up. With +attempts: 1+, exactly one perform per
-    # +perform_later+; if it fails, the follow-up scheduled in +ensure+
-    # takes over tomorrow.
+    # Only try once per enqueue. Without this, Delayed-style adapters retry up to 25 times on error and our
+    # +around_perform+ +ensure+ re-enqueues a follow-up run on every attempt, causing geometric duplicate
+    # pile-up. With +attempts: 1+, exactly one perform per +perform_later+; if it fails, the follow-up scheduled
+    # in +ensure+ takes over tomorrow.
     retry_on StandardError, attempts: 1
 
     around_perform :requeue_for_next_run
 
     class << self
-      # Next sweep time. Default: 6:30am Eastern tomorrow (today if the
-      # current time is before 6:30am ET). Apps wanting a different
-      # cadence override this on a subclass.
+      # Next sweep time. Default: 6:30am Eastern tomorrow (today if the current time is before 6:30am ET). Apps
+      # wanting a different cadence override this on a subclass.
       #
       # @return [Time] UTC
       #
@@ -33,9 +28,8 @@ module PlanMyStuff
         target.utc
       end
 
-      # Schedules a sweep for +next_run+. Used by the after-perform
-      # self-requeue and the +plan_my_stuff:reminders:sweep+ rake task so
-      # both kick off runs on the same cadence (instead of "now").
+      # Schedules a sweep for +next_run+. Used by the after-perform self-requeue and the
+      # +plan_my_stuff:reminders:sweep+ rake task so both kick off runs on the same cadence (instead of "now").
       #
       # @param repo [Symbol, String]
       #
@@ -54,15 +48,14 @@ module PlanMyStuff
       @repo_arg = repo
       PlanMyStuff::Reminders::Sweep.new(repo: repo).call
       PlanMyStuff::Archive::Sweep.new(repo: repo).call
-      PlanMyStuff::Pipeline::CompletedSweep.perform
+      PlanMyStuff::Pipeline::CompletedSweep.perform!
     end
 
     private
 
-      # Runs inside +around_perform+. Re-enqueues the next run in an
-      # +ensure+ so a perform error still schedules the next one. Skips
-      # requeue when perform never captured a repo arg (deserialization
-      # error or direct +.perform+ call with missing kwargs).
+      # Runs inside +around_perform+. Re-enqueues the next run in an +ensure+ so a perform error still schedules
+      # the next one. Skips requeue when perform never captured a repo arg (deserialization error or direct
+      # +.perform+ call with missing kwargs).
       #
       # @return [void]
       #

data/app/views/plan_my_stuff/comments/edit.html.erb

@@ -1,8 +1,6 @@
 <h1>Edit Comment</h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%=
   render({

data/app/views/plan_my_stuff/comments/partials/_form.html.erb

@@ -1,3 +1,4 @@
+<%# locals: (issue:, comment:, support_user:) %>
 <%
   persisted = comment.persisted?
   url =

data/app/views/plan_my_stuff/issues/edit.html.erb

@@ -1,10 +1,8 @@
 <h1>Edit Issue #<%= @issue.number %></h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
-<%= render({ partial: 'plan_my_stuff/issues/partials/form', locals: { issue: @issue, support_user: @support_user } }) %>
+<%= render({ partial: 'plan_my_stuff/issues/partials/form', locals: { issue: @issue } }) %>
 
 <% if @support_user %>
   <hr>

data/app/views/plan_my_stuff/issues/index.html.erb

@@ -1,6 +1,6 @@
 <h1>Issues</h1>
 
-<% if @issues.any? %>
+<% if @issues.present? %>
   <table>
     <thead>
       <tr>
@@ -34,4 +34,4 @@
   <p>No issues found.</p>
 <% end %>
 <br>
-<%= link_to "New Issue", plan_my_stuff.new_issue_path(repo: @repo) %>
+<%= link_to('New Issue', plan_my_stuff.new_issue_path(repo: @repo)) %>

data/app/views/plan_my_stuff/issues/new.html.erb

@@ -1,7 +1,5 @@
 <h1>New Issue</h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
-<%= render({ partial: 'plan_my_stuff/issues/partials/form', locals: { issue: @issue, support_user: @support_user } }) %>
+<%= render({ partial: 'plan_my_stuff/issues/partials/form', locals: { issue: @issue } }) %>

data/app/views/plan_my_stuff/issues/partials/_approvals.html.erb

@@ -1,6 +1,8 @@
+<%# locals: (issue:, support_user:, current_user_id_local:) %>
 <%
   approvers = issue.approvers
   pending_count = issue.pending_approvals.size
+  rejected_count = issue.rejected_approvals.size
   current_user_id = current_user_id_local
 %>
 
@@ -12,7 +14,12 @@
       <% if issue.fully_approved? %>
         <p><strong>Fully approved</strong></p>
       <% else %>
-        <p><strong><%= pending_count %> of <%= approvers.size %> approval(s) pending</strong></p>
+        <p>
+          <strong><%= pending_count %> of <%= approvers.size %> approval(s) pending</strong>
+          <% if rejected_count.positive? %>
+            (<%= rejected_count %> rejected)
+          <% end %>
+        </p>
       <% end %>
 
       <ul>
@@ -24,6 +31,11 @@
               <% if approval.approved_at %>
                 at <%= approval.approved_at.iso8601 %>
               <% end %>
+            <% elsif approval.rejected? %>
+              rejected
+              <% if approval.rejected_at %>
+                at <%= approval.rejected_at.iso8601 %>
+              <% end %>
             <% else %>
               pending
             <% end %>
@@ -38,9 +50,18 @@
                   form: { style: 'display:inline' },
                 )
               %>
+              <%=
+                button_to(
+                  'Reject',
+                  plan_my_stuff.issue_approval_path(issue.number, approval.user_id, repo: issue.repo.full_name),
+                  method: :patch,
+                  params: { approval: { status: 'rejected' } },
+                  form: { style: 'display:inline' },
+                )
+              %>
             <% end %>
 
-            <% if approval.approved? && (approval.user_id == current_user_id || support_user) %>
+            <% if !approval.pending? && (approval.user_id == current_user_id || support_user) %>
               <%=
                 button_to(
                   'Revoke',

data/app/views/plan_my_stuff/issues/partials/_form.html.erb

@@ -1,3 +1,4 @@
+<%# locals: (issue:) %>
 <%
   persisted = issue.persisted?
   url =

data/app/views/plan_my_stuff/issues/partials/_labels.html.erb

@@ -1,4 +1,5 @@
-<% if issue.labels.any? %>
+<%# locals: (issue:) %>
+<% if issue.labels.present? %>
   <% issue.labels.each do |label| %>
     <span>
       <%= label %>

data/app/views/plan_my_stuff/issues/partials/_links.html.erb

@@ -1,14 +1,57 @@
+<%# locals: (issue:, support_user:) %>
 <%
   # read_only sections have no add form; remove_only sections allow X but
   # no add (blocking is created from the blocked side; duplicate_of is
   # created via mark_duplicate! and cleared by reopening on GitHub).
   sections = [
-    { type: 'parent',       label: 'Parent',       single: true,  add_form: true,  removable: true,  targets: [issue.parent].compact },
-    { type: 'sub_ticket',   label: 'Sub-tickets',  single: false, add_form: true,  removable: true,  targets: issue.sub_tickets },
-    { type: 'blocked_by',   label: 'Blocked by',   single: false, add_form: true,  removable: true,  targets: issue.blocked_by },
-    { type: 'blocking',     label: 'Blocking',     single: false, add_form: false, removable: false, targets: issue.blocking },
-    { type: 'related',      label: 'Related',      single: false, add_form: true,  removable: true,  targets: issue.related },
-    { type: 'duplicate_of', label: 'Duplicate of', single: true,  add_form: false, removable: false, targets: [issue.duplicate_of].compact },
+    {
+      type: 'parent',
+      label: 'Parent',
+      single: true,
+      add_form: true,
+      removable: true,
+      targets: [issue.parent].compact
+    },
+    {
+      type: 'sub_ticket',
+      label: 'Sub-tickets',
+      single: false,
+      add_form: true,
+      removable: true,
+      targets: issue.sub_tickets
+    },
+    {
+      type: 'blocked_by',
+      label: 'Blocked by',
+      single: false,
+      add_form: true,
+      removable: true,
+      targets: issue.blocked_by
+    },
+    {
+      type: 'blocking',
+      label: 'Blocking',
+      single: false,
+      add_form: false,
+      removable: false,
+      targets: issue.blocking
+    },
+    {
+      type: 'related',
+      label: 'Related',
+      single: false,
+      add_form: true,
+      removable: true,
+      targets: issue.related
+    },
+    {
+      type: 'duplicate_of',
+      label: 'Duplicate of',
+      single: true,
+      add_form: false,
+      removable: false,
+      targets: [issue.duplicate_of].compact
+    },
   ]
   visible_sections = support_user ? sections : sections.select { |s| s[:type] == 'related' }
 %>
@@ -18,7 +61,7 @@
   <% visible_sections.each do |section| %>
     <div>
       <h4><%= section[:label] %></h4>
-      <% if section[:targets].any? %>
+      <% if section[:targets].present? %>
         <ul>
           <% section[:targets].each do |target| %>
             <li>

data/app/views/plan_my_stuff/issues/partials/_viewers.html.erb

@@ -1,7 +1,8 @@
+<%# locals: (issue:) %>
 <h2>Manage Viewers</h2>
 
 <% viewers = issue.metadata.visibility_allowlist %>
-<% if viewers.any? %>
+<% if viewers.present? %>
   <ul>
     <% viewers.each do |viewer_id| %>
       <li>

data/app/views/plan_my_stuff/issues/show.html.erb

@@ -17,9 +17,12 @@
       <%= button_to('Mark waiting', plan_my_stuff.issue_waiting_path(@issue.number, repo: @issue.repo.full_name), method: :post) %>
     <% end %>
   <% end %>
-  <% if @support_user && @pipeline_enabled && @pipeline_item.nil? %>
+  <% if @support_user && @pipeline_enabled && @pipeline_item.nil? && @issue.assignees.blank? %>
     <%= button_to('Take', plan_my_stuff.issue_take_path(@issue.number, repo: @issue.repo.full_name), method: :post) %>
   <% end %>
+  <% if @support_user && @pipeline_enabled && @current_user_login.present? && @issue.assignees.include?(@current_user_login) %>
+    <%= button_to('Release', plan_my_stuff.issue_take_path(@issue.number, repo: @issue.repo.full_name), method: :delete) %>
+  <% end %>
   <% if @support_user %>
     <%= link_to('Start Testing Project', plan_my_stuff.new_testing_project_path(subject_url: @issue.html_url)) %>
   <% end %>
@@ -67,7 +70,7 @@
 
 <h2>Comments (<%= @comments.size %>)</h2>
 
-<% if @comments.any? %>
+<% if @comments.present? %>
   <% @comments.each do |comment| %>
     <div>
       <%= PlanMyStuff::Markdown.render(comment.body || '').html_safe %>

data/app/views/plan_my_stuff/partials/_flash.html.erb

@@ -0,0 +1,4 @@
+<%# locals: () %>
+<% if flash[:error].present? %>
+  <p role="alert" style="color: red;"><%= flash[:error] %></p>
+<% end %>

data/app/views/plan_my_stuff/projects/edit.html.erb

@@ -1,7 +1,5 @@
 <h1>Edit Project #<%= @project.number %></h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%= render({ partial: 'plan_my_stuff/projects/partials/form', locals: { project: @project } }) %>

data/app/views/plan_my_stuff/projects/index.html.erb

@@ -6,7 +6,7 @@
   <%= link_to('Testing', plan_my_stuff.projects_path(filter: 'testing')) %>
 </p>
 
-<% if @projects.any? %>
+<% if @projects.present? %>
   <ul>
     <% @projects.each do |project| %>
       <li>

data/app/views/plan_my_stuff/projects/new.html.erb

@@ -1,7 +1,5 @@
 <h1>New Project</h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%= render({ partial: 'plan_my_stuff/projects/partials/form', locals: { project: @project } }) %>

data/app/views/plan_my_stuff/projects/partials/_form.html.erb

@@ -1,3 +1,4 @@
+<%# locals: (project:) %>
 <%
   persisted = project.persisted?
   url =

data/app/views/plan_my_stuff/projects/show.html.erb

@@ -7,7 +7,7 @@
   <% end %>
 </p>
 
-<% if @statuses.any? %>
+<% if @statuses.present? %>
   <table>
     <thead>
       <tr>
@@ -43,7 +43,7 @@
                 <% end %>
 
                 <% assignees = item.field_values['Assignees'] || [] %>
-                <% if assignees.any? %>
+                <% if assignees.present? %>
                   <div>
                     <% assignees.each do |username| %>
                       <span>
@@ -57,7 +57,7 @@
                           ) do |form|
                         %>
                           <%= form.hidden_field(:username, value: username) %>
-                          <%= form.submit('×', title: "Unassign #{username}") %>
+                          <%= form.submit('x', title: "Unassign #{username}") %>
                         <% end %>
                       </span>
                     <% end %>
@@ -74,6 +74,16 @@
                   <%= form.text_field(:assignee, placeholder: 'GitHub username') %>
                   <%= form.submit('Assign') %>
                 <% end %>
+
+                <%=
+                  form_with(
+                    url: plan_my_stuff.project_item_path(@project.number, item.id),
+                    method: :delete,
+                    local: true,
+                  ) do |form|
+                %>
+                  <%= form.submit('Remove from project') %>
+                <% end %>
               </div>
             <% end %>
             <% if items.empty? %>

data/app/views/plan_my_stuff/testing_project_items/new.html.erb

@@ -1,8 +1,6 @@
 <h1>Add Item to <%= @project.title %></h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%=
   render({

data/app/views/plan_my_stuff/testing_project_items/results/new.html.erb

@@ -1,8 +1,6 @@
 <h1>Fail Item</h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%= form_with(
   url: plan_my_stuff.testing_project_item_result_path(@project_number, @item_id),

data/app/views/plan_my_stuff/testing_projects/edit.html.erb

@@ -1,7 +1,5 @@
 <h1>Edit Testing Project #<%= @project.number %></h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%= render({ partial: 'plan_my_stuff/testing_projects/partials/form', locals: { project: @project } }) %>

data/app/views/plan_my_stuff/testing_projects/new.html.erb

@@ -1,7 +1,5 @@
 <h1>New Testing Project</h1>
 
-<% if flash[:error].present? %>
-  <p style="color: red;"><%= flash[:error] %></p>
-<% end %>
+<%= render({ partial: 'plan_my_stuff/partials/flash' }) %>
 
 <%= render({ partial: 'plan_my_stuff/testing_projects/partials/form', locals: { project: @project } }) %>

data/app/views/plan_my_stuff/testing_projects/partials/_form.html.erb

@@ -1,3 +1,4 @@
+<%# locals: (project:) %>
 <%
   persisted = project.persisted?
   url =
@@ -20,17 +21,17 @@
 
   <div>
     <%= form.label(:subject_urls, 'Subject URLs (one per line)') %>
-    <%= form.text_area(:subject_urls, rows: 4, value: project.metadata.subject_urls.join("\n")) %>
+    <%= form.text_area(:subject_urls, rows: 4, value: Array.wrap(project.metadata&.subject_urls).join("\n")) %>
   </div>
 
   <div>
     <%= form.label(:due_date, 'Due Date') %>
-    <%= form.date_field(:due_date, value: project.metadata.due_date) %>
+    <%= form.date_field(:due_date, value: project.metadata&.due_date&.strftime('%F')) %>
   </div>
 
   <div>
     <%= form.label(:deadline_miss_reason, 'Deadline Miss Reason') %>
-    <%= form.text_field(:deadline_miss_reason, value: project.metadata.deadline_miss_reason) %>
+    <%= form.text_field(:deadline_miss_reason, value: project.metadata&.deadline_miss_reason) %>
   </div>
 
   <div>

data/app/views/plan_my_stuff/testing_projects/partials/_item.html.erb

@@ -1,3 +1,4 @@
+<%# locals: (item:, project:, statuses:) %>
 <div style="border: 1px solid black; margin: 1em; padding: 0.5em">
   <% if item.draft? %>
     <strong><%= item.title %></strong>