plan_my_stuff 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a70108268136db83554f3bda05e5ab384b1d2c6f1d8d05f4554cef037eeee8a8
-  data.tar.gz: 5c713eca795782628fab95c61c3d5876934d22b04e0c539e26d35369a376491b
+  metadata.gz: 69661ace546ff5f775e0e9fb5e4a153c3aca9e68da0b568e85238d8b66ef620a
+  data.tar.gz: e0698c727fe6c3f1e8e135d0a2b1860731188dc01496065e3622a0a1d6ef0c45
 SHA512:
-  metadata.gz: 253f04b4c10e8d1557d5915daa1a757d5678c717cd4b7b97d50450ed4e8417c05f044bbf97c235de17328a4fd3ee27f8a08bbaf1b874ce0dccd294760f370114
-  data.tar.gz: 331d2a9b48418722eb3049099817e390095c07deb70e59670ead47cbf98555bb2c44e12b1cdc9824abd28fd6795c80fa8aac124ea5779dd9262323a7bc96c10a
+  metadata.gz: 876ac7c9c1baf371e09d81535324ae9a35bcd1c3a30509931395e274a229fcf25397ba1377450cb6a8ad6465f0474174ea664579b59f0d407c9b83ee08523647
+  data.tar.gz: 89c4a1865f38c614c05d802c02d267b0ff2e83339da936403fac08f3d98476a6b87b722eecf422b5ee8f101f5db1ce75e8d3f836a3f54dd0ca86713df3146feb

data/CHANGELOG.md

@@ -1,5 +1,53 @@
 # Changelog
 
+## 0.6.0
+
+### Breaking
+
+- `Pipeline.submit!` removed; consuming apps that called it directly should switch to `ProjectItem.create!` + `Pipeline.take!`
+- `Pipeline::Status::SUBMITTED` and `Pipeline::Status::TESTING` constants removed; `Status::ALL` no longer includes them
+- `Pipeline.request_testing!` no longer moves the `Status` field — it now writes to a separate `Testing` single-select custom field on the pipeline project. The pipeline project must have a `Testing` field with `Testing` / `Not testing` options
+- Active pipeline status set is now `Started → In Review → Ready for Release → Release in Progress → Completed`
+
+### Added
+
+- `Pipeline::Testing` module (`FIELD_NAME`, `VALUES`)
+- `Pipeline::CompletedSweep` removes items from `Completed` after the configured TTL; driven by `RemindersSweepJob`
+- `BaseProjectItem#update_single_select_field!` instance method
+- `BaseProjectItem#updated_at` populated from GitHub's `updatedAt`
+- `Issue#assignees` public reader
+- `Pipeline.release_cycle_locked?` helper
+- New config: `pipeline_testing_field_name`, `pipeline_testing_values`, `pipeline_completion_purge_enabled` (default `true`), `pipeline_completion_ttl_hours` (default `24`)
+
+### Changed
+
+- Assigning a dev to an issue now creates the project item and lands it at `Started` (was `Submitted`)
+- Opening a PR as a draft adds the linked issue to the pipeline at `Started` and assigns the PR author when the issue has no assignees; already-pipelined items are not moved
+- The assignment webhook no longer calls `assign!` on the project item — GitHub already records the assignment, and `assign!` could clobber co-assignees
+
+### Removed
+
+- `Pipeline.submit!` (see Breaking)
+- `Pipeline::Status::SUBMITTED`, `Pipeline::Status::TESTING` (see Breaking)
+
+### Fixed
+
+- Closed issues no longer alter the pipeline on assign/unassign webhook events
+- Items at `Ready for Release`, `Release in Progress`, or `Completed` are no longer removed when an unassign webhook fires
+- Pending-approvals guard runs before `ProjectItem.create!` in the assignment flow so the webhook no longer leaves orphan items when `Pipeline.take!`'s approval guard would otherwise raise
+
+### Documented
+
+- `designs/pipeline_cleanup/plan.md` — full design + bug-to-fix mapping
+- `requirements/08_release_pipeline.md` updated to reflect the new flow
+- `requirements/tasks.md` — T-PC-001 added under Phase 14
+
+## 0.5.1
+
+### Fixed
+
+- AWS webhook rejected SNS `SubscriptionConfirmation` and `UnsubscribeConfirmation` messages with 401; now signature-verified, logged, and acked with 200
+
 ## 0.5.0
 
 ### Added

data/app/controllers/plan_my_stuff/webhooks/aws_controller.rb

@@ -3,13 +3,22 @@
 module PlanMyStuff
   module Webhooks
     class AwsController < ActionController::API
-      VALID_SNS_MESSAGE_TYPES = %w[Notification].freeze
+      VALID_SNS_MESSAGE_TYPES = %w[Notification SubscriptionConfirmation UnsubscribeConfirmation].freeze
 
       before_action :verify_signature!
 
       # POST /webhooks/aws
       def create
         config = PlanMyStuff.configuration
+        message_type = request.headers['x-amz-sns-message-type'].to_s
+
+        Rails.logger.info("[PlanMyStuff] SNS #{message_type}: #{sns_params.to_unsafe_h.inspect}")
+
+        unless message_type == 'Notification'
+          head(:ok)
+
+          return
+        end
 
         unless config.process_aws_webhooks
           head(:ok)

data/app/controllers/plan_my_stuff/webhooks/github_controller.rb

@@ -81,14 +81,27 @@ module PlanMyStuff
           end
         end
 
-        # Adds the issue to the pipeline project at "Submitted" the first
+        # Adds the issue to the pipeline project at "Started" the first
         # time it is assigned. Re-assigns and additional assignees are
         # ignored -- if the issue is already in the pipeline we do not
         # touch its status.
         #
+        # Skipped paths (no project item is created):
+        #   - Issue is closed (assignment changes on a closed issue
+        #     must not alter the pipeline)
+        #   - Issue has pending approvals (creating + +take!+ would
+        #     either orphan an item or 500 on the approval guard)
+        #
+        # GitHub already records the issue assignment (that's what
+        # triggered this webhook), so the gem does not call +assign!+
+        # on the project item -- that would clobber co-assignees on
+        # the underlying issue.
+        #
         # @return [void]
         #
         def handle_issue_assigned
+          return if issue_params[:state] == 'closed'
+
           issue_number = issue_params.fetch(:number)
           assignee_login = payload_params.dig(:assignee, :login)
 
@@ -96,14 +109,23 @@ module PlanMyStuff
 
           existing = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue_number)
           if existing.present?
-            Rails.logger.info("[PlanMyStuff] Issue ##{issue_number} already in pipeline project, skipping submit!")
+            Rails.logger.info("[PlanMyStuff] Issue ##{issue_number} already in pipeline project, skipping")
 
             return
           end
 
           repo = payload_params.dig(:repository, :full_name)
           issue = PlanMyStuff::Issue.find(issue_number, repo: repo)
-          PlanMyStuff::Pipeline.submit!(issue, assignee: assignee_login)
+
+          if issue.approvals_required? && !issue.fully_approved?
+            Rails.logger.info("[PlanMyStuff] Issue ##{issue_number} has pending approvals, skipping")
+
+            return
+          end
+
+          number = PlanMyStuff::Pipeline.resolve_pipeline_project_number
+          project_item = PlanMyStuff::ProjectItem.create!(issue, project_number: number)
+          PlanMyStuff::Pipeline.take!(project_item)
         end
 
         # Removes the issue from the pipeline project when the LAST
@@ -111,9 +133,17 @@ module PlanMyStuff
         # a no-op (only one of N was removed). If the issue isn't in
         # the pipeline at all, also a no-op (logged at info).
         #
+        # Closed issues are skipped: assignment changes on a closed
+        # issue must not alter the pipeline. Items already on the
+        # release cycle (Ready for Release, Release in Progress,
+        # Completed) are also locked -- once on the release path an
+        # item should not come off via webhook.
+        #
         # @return [void]
         #
         def handle_issue_unassigned
+          return if issue_params[:state] == 'closed'
+
           remaining_assignees = Array.wrap(issue_params[:assignees])
           return if remaining_assignees.any?
 
@@ -128,6 +158,14 @@ module PlanMyStuff
             return
           end
 
+          if PlanMyStuff::Pipeline.release_cycle_locked?(project_item)
+            Rails.logger.info(
+              "[PlanMyStuff] Issue ##{issue_number} on release cycle (#{project_item.status}), skipping remove!",
+            )
+
+            return
+          end
+
           PlanMyStuff::Pipeline.remove!(project_item)
         end
 
@@ -205,7 +243,7 @@ module PlanMyStuff
 
           case action
           when 'opened'
-            pull_request_params[:draft] ? handle_converted_to_draft : handle_ready_for_review
+            pull_request_params[:draft] ? handle_draft_opened : handle_ready_for_review
           when 'ready_for_review', 'reopened'
             handle_ready_for_review
           when 'converted_to_draft'
@@ -215,6 +253,29 @@ module PlanMyStuff
           end
         end
 
+        # Opening a PR as a draft is a soft "I've started working on this"
+        # signal. For each linked issue, when the issue is not yet in the
+        # pipeline, add it at "Started"; when the issue has no assignees,
+        # assign the PR author. Already-in-pipeline items are NOT moved
+        # (a draft open is not a status change).
+        #
+        # @return [void]
+        #
+        def handle_draft_opened
+          repo = payload_params.dig(:repository, :full_name)
+          pr_author = pull_request_params.dig(:user, :login)
+
+          each_linked_issue_number do |issue_number|
+            issue = PlanMyStuff::Issue.find(issue_number, repo: repo)
+
+            if PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue_number).nil?
+              ensure_in_pipeline_at_started(issue)
+            end
+
+            assign_pr_author(issue, pr_author) if pr_author.present? && issue.assignees.empty?
+          end
+        end
+
         # @return [void]
         def handle_ready_for_review
           each_linked_item do |item|
@@ -222,6 +283,34 @@ module PlanMyStuff
           end
         end
 
+        # Adds the issue to the pipeline at "Started". Skipped when the
+        # issue has pending approvals (Pipeline.take!'s guard would
+        # otherwise leave an orphan project item behind).
+        #
+        # @param issue [PlanMyStuff::Issue]
+        #
+        # @return [void]
+        #
+        def ensure_in_pipeline_at_started(issue)
+          if issue.approvals_required? && !issue.fully_approved?
+            Rails.logger.info("[PlanMyStuff] Issue ##{issue.number} has pending approvals, skipping pipeline add")
+            return
+          end
+
+          number = PlanMyStuff::Pipeline.resolve_pipeline_project_number
+          project_item = PlanMyStuff::ProjectItem.create!(issue, project_number: number)
+          PlanMyStuff::Pipeline.take!(project_item)
+        end
+
+        # @param issue [PlanMyStuff::Issue]
+        # @param pr_author [String]
+        #
+        # @return [void]
+        #
+        def assign_pr_author(issue, pr_author)
+          PlanMyStuff::Issue.update!(number: issue.number, repo: issue.repo, assignees: [pr_author])
+        end
+
         # @return [void]
         def handle_converted_to_draft
           each_linked_item do |item|
@@ -247,13 +336,7 @@ module PlanMyStuff
 
         # @yield [PlanMyStuff::ProjectItem]
         def each_linked_item
-          messages = fetch_commit_messages
-          numbers = PlanMyStuff::Pipeline::IssueLinker.extract_issue_numbers(
-            pull_request_params,
-            commit_messages: messages,
-          )
-
-          numbers.each do |issue_number|
+          each_linked_issue_number do |issue_number|
             item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue_number)
 
             if item
@@ -264,6 +347,17 @@ module PlanMyStuff
           end
         end
 
+        # @yield [Integer] linked issue number
+        def each_linked_issue_number(&)
+          messages = fetch_commit_messages
+          numbers = PlanMyStuff::Pipeline::IssueLinker.extract_issue_numbers(
+            pull_request_params,
+            commit_messages: messages,
+          )
+
+          numbers.each(&)
+        end
+
         # Fetches commit messages for the current PR via the GitHub API.
         #
         # @return [Array<String>] commit messages (empty on failure)

data/app/jobs/plan_my_stuff/reminders_sweep_job.rb

@@ -54,6 +54,7 @@ module PlanMyStuff
       @repo_arg = repo
       PlanMyStuff::Reminders::Sweep.new(repo: repo).call
       PlanMyStuff::Archive::Sweep.new(repo: repo).call
+      PlanMyStuff::Pipeline::CompletedSweep.perform
     end
 
     private

data/app/views/plan_my_stuff/issues/show.html.erb

@@ -17,7 +17,7 @@
       <%= button_to('Mark waiting', plan_my_stuff.issue_waiting_path(@issue.number, repo: @issue.repo.full_name), method: :post) %>
     <% end %>
   <% end %>
-  <% if @support_user && @pipeline_enabled && (@pipeline_item.nil? || @pipeline_item.status == PlanMyStuff::Pipeline.resolve_status_name(PlanMyStuff::Pipeline::Status::SUBMITTED)) %>
+  <% if @support_user && @pipeline_enabled && @pipeline_item.nil? %>
     <%= button_to('Take', plan_my_stuff.issue_take_path(@issue.number, repo: @issue.repo.full_name), method: :post) %>
   <% end %>
   <% if @support_user %>

data/lib/plan_my_stuff/base_project.rb

@@ -331,6 +331,7 @@ module PlanMyStuff
             repo: repo_name.present? ? PlanMyStuff::Repo.resolve(repo_name) : nil,
             status: extract_item_status(field_values),
             field_values: parse_field_values(field_values),
+            updated_at: item[:updatedAt],
             github_response: item,
           }
         end

data/lib/plan_my_stuff/base_project_item.rb

@@ -43,6 +43,8 @@ module PlanMyStuff
     attribute :state, :string
     # @return [String, nil]
     attribute :status, :string
+    # @return [Time, nil] GitHub's updatedAt timestamp
+    attribute :updated_at, :datetime
     # @return [Hash]
     attribute :field_values, default: -> { {} }
     # @return [PlanMyStuff::BaseProject, nil]
@@ -477,6 +479,22 @@ module PlanMyStuff
       )
     end
 
+    # Updates a single-select custom field on this item.
+    #
+    # @param field_name [String] single-select field name (e.g. "Testing")
+    # @param value [String] option name to select
+    #
+    # @return [Hash] mutation result
+    #
+    def update_single_select_field!(field_name, value)
+      self.class.update_single_select_field!(
+        project_number: project.number,
+        item_id: id,
+        field_name: field_name,
+        value: value,
+      )
+    end
+
     # Deletes this item from its parent project. Marks the in-memory
     # instance as destroyed so +destroyed?+ returns true and +persisted?+
     # returns false.

data/lib/plan_my_stuff/configuration.rb

@@ -164,12 +164,27 @@ module PlanMyStuff
     attr_accessor :production_commit_sha
 
     # Canonical status name to display alias map. Allows consuming apps to rename
-    # pipeline statuses (e.g. "Submitted" to "Triaged").
+    # pipeline statuses (e.g. "Started" to "In Progress").
     #
     # @return [Hash{String => String}]
     #
     attr_accessor :pipeline_statuses
 
+    # Display name for the +Testing+ single-select custom field on the
+    # pipeline project. Defaults to +"Testing"+.
+    #
+    # @return [String]
+    #
+    attr_accessor :pipeline_testing_field_name
+
+    # Map of canonical testing field option keys (+:active+, +:inactive+)
+    # to display labels. Allows consuming apps to rename the option labels
+    # without changing the canonical identifiers.
+    #
+    # @return [Hash{Symbol => String}]
+    #
+    attr_accessor :pipeline_testing_values
+
     # @return [String] branch name that PRs merge into for "Ready for release" transition
     attr_accessor :main_branch
 
@@ -281,6 +296,21 @@ module PlanMyStuff
     #
     attr_accessor :archived_label
 
+    # Whether the pipeline sweep removes aged-out +Completed+ items.
+    # Defaults to +true+. Set to +false+ to keep items in +Completed+
+    # indefinitely.
+    #
+    # @return [Boolean]
+    #
+    attr_accessor :pipeline_completion_purge_enabled
+
+    # Hours after a project item's last update at which the sweep removes
+    # it from the pipeline if its status is +Completed+. Defaults to +24+.
+    #
+    # @return [Integer]
+    #
+    attr_accessor :pipeline_completion_ttl_hours
+
     # Whether to process incoming AWS webhook events. Defaults to +Rails.env.production?+.
     #
     # @return [Boolean]
@@ -323,6 +353,8 @@ module PlanMyStuff
       @testing_custom_fields = {}
       @pipeline_enabled = true
       @pipeline_statuses = {}
+      @pipeline_testing_field_name = PlanMyStuff::Pipeline::Testing::FIELD_NAME
+      @pipeline_testing_values = PlanMyStuff::Pipeline::Testing::VALUES.dup
       @main_branch = 'main'
       @production_branch = 'production'
       @mount_groups = { webhooks: true, issues: true, projects: true }
@@ -338,6 +370,8 @@ module PlanMyStuff
       @archiving_enabled = true
       @archive_closed_after_days = 90
       @archived_label = 'archived'
+      @pipeline_completion_purge_enabled = true
+      @pipeline_completion_ttl_hours = 24
       @process_aws_webhooks = Rails.env.production?
       @sns_verifier_class = ::Aws::SNS::MessageVerifier if defined?(::Aws::SNS::MessageVerifier)
       @sns_verifier_error =

data/lib/plan_my_stuff/graphql/queries.rb

@@ -103,6 +103,7 @@ module PlanMyStuff
                 nodes {
                   id
                   type
+                  updatedAt
                   content {
                     ... on Issue {
                       id

data/lib/plan_my_stuff/issue.rb

@@ -689,6 +689,14 @@ module PlanMyStuff
       safe_read_field(github_response, :html_url)
     end
 
+    # GitHub assignees for this issue, by login.
+    #
+    # @return [Array<String>]
+    #
+    def assignees
+      extract_assignee_logins(github_response)
+    end
+
     # @return [Boolean]
     def pms_issue?
       metadata.schema_version.present?

data/lib/plan_my_stuff/pipeline/completed_sweep.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module PlanMyStuff
+  module Pipeline
+    # Removes pipeline project items that have been at +Completed+ for
+    # longer than the configured TTL.
+    #
+    # Driven by +RemindersSweepJob+ so the gem ships one scheduled
+    # entrypoint. Items are removed via +Pipeline.remove!+ so subscribers
+    # see the standard +plan_my_stuff.pipeline.removed+ event.
+    #
+    module CompletedSweep
+      module_function
+
+      # Runs the sweep. No-op when
+      # +configuration.pipeline_completion_purge_enabled+ is false.
+      #
+      # @param project_number [Integer, nil]
+      # @param now [Time]
+      #
+      # @return [Array<PlanMyStuff::ProjectItem>] removed items
+      #
+      def perform(project_number: nil, now: Time.current)
+        config = PlanMyStuff.configuration
+        return [] unless config.pipeline_completion_purge_enabled
+
+        number = PlanMyStuff::Pipeline.resolve_pipeline_project_number(project_number)
+        project = PlanMyStuff::Project.find(number)
+
+        completed_status = PlanMyStuff::Pipeline.resolve_status_name(
+          PlanMyStuff::Pipeline::Status::COMPLETED,
+        )
+        ttl = config.pipeline_completion_ttl_hours.hours
+
+        candidates = project.items.select do |item|
+          item.status == completed_status &&
+            item.updated_at.present? &&
+            item.updated_at + ttl < now
+        end
+
+        candidates.each { |item| PlanMyStuff::Pipeline.remove!(item) }
+        candidates
+      end
+    end
+  end
+end

data/lib/plan_my_stuff/pipeline/status.rb

@@ -10,20 +10,16 @@ module PlanMyStuff
     # but the canonical names here remain the internal identifiers.
     #
     module Status
-      SUBMITTED = 'Submitted'
       STARTED = 'Started'
       IN_REVIEW = 'In Review'
-      TESTING = 'Testing'
       READY_FOR_RELEASE = 'Ready for Release'
       RELEASE_IN_PROGRESS = 'Release in Progress'
       COMPLETED = 'Completed'
 
       # All statuses in pipeline order (frozen).
       ALL = [
-        SUBMITTED,
         STARTED,
         IN_REVIEW,
-        TESTING,
         READY_FOR_RELEASE,
         RELEASE_IN_PROGRESS,
         COMPLETED,

data/lib/plan_my_stuff/pipeline/testing.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module PlanMyStuff
+  module Pipeline
+    # Canonical names for the +Testing+ single-select custom field on the
+    # pipeline project. The field tracks testing progress orthogonally to
+    # the +Status+ field (testing can run alongside +In Review+).
+    #
+    # Consuming apps can override the field name via
+    # +PlanMyStuff.configuration.pipeline_testing_field_name+ and the
+    # option labels via +PlanMyStuff.configuration.pipeline_testing_values+.
+    # The canonical names here remain the internal identifiers.
+    #
+    module Testing
+      FIELD_NAME = 'Testing'
+
+      VALUES = {
+        active: 'Testing',
+        inactive: 'Not testing',
+      }.freeze
+    end
+  end
+end

data/lib/plan_my_stuff/pipeline.rb

@@ -1,8 +1,10 @@
 # frozen_string_literal: true
 
 require 'active_support/notifications'
+require_relative 'pipeline/completed_sweep'
 require_relative 'pipeline/issue_linker'
 require_relative 'pipeline/status'
+require_relative 'pipeline/testing'
 
 module PlanMyStuff
   # High-level orchestration layer for the release pipeline.
@@ -20,7 +22,7 @@ module PlanMyStuff
     # pending manager approvals. No-op for +nil+ issues or issues that
     # either have no approvers required or are fully approved.
     #
-    # Called at the top of every forward transition (+submit!+, +take!+,
+    # Called at the top of every forward transition (+take!+,
     # +mark_in_review!+, +request_testing!+,
     # +mark_ready_for_release!+). Batch / CI-driven transitions
     # (+start_deployment!+, +complete_deployment!+) and reverse
@@ -95,40 +97,14 @@ module PlanMyStuff
       result
     end
 
-    # Adds an issue to the pipeline project, moves it to "Submitted",
-    # and assigns the given developer.
-    #
-    # Called when an issue is assigned to a dev, NOT on issue creation.
-    # Un-triaged issues should not be in the pipeline.
-    #
-    # @param issue [PlanMyStuff::Issue]
-    # @param assignee [String] GitHub username
-    # @param project_number [Integer, nil]
-    #
-    # @return [PlanMyStuff::ProjectItem]
-    #
-    def submit!(issue, assignee:, project_number: nil)
-      guard_approvals!(issue)
-      number = resolve_pipeline_project_number(project_number)
-      project_item = PlanMyStuff::ProjectItem.create!(issue, project_number: number)
-
-      status = resolve_status_name(PlanMyStuff::Pipeline::Status::SUBMITTED)
-      project_item.move_to!(status)
-      project_item.assign!(assignee)
-
-      instrument(PlanMyStuff::Pipeline::Status::SUBMITTED, project_item)
-      project_item
-    end
-
     # Removes a project item from the pipeline project entirely.
     # Captures the prior status before deletion so subscribers can
     # decide whether the removal happened late in the lifecycle.
     #
     # Always fires +plan_my_stuff.pipeline.removed+. Additionally fires
     # +plan_my_stuff.pipeline.removed_late+ when +prior_status+ is past
-    # "Started" (i.e. anything other than "Submitted" or "Started",
-    # accounting for configured status aliases). +nil+ status is treated
-    # as not-late.
+    # "Started" (i.e. anything other than "Started", accounting for
+    # configured status aliases). +nil+ status is treated as not-late.
     #
     # @param project_item [PlanMyStuff::ProjectItem]
     #
@@ -164,12 +140,30 @@ module PlanMyStuff
     def late_removal?(prior_status)
       return false if prior_status.nil?
 
-      early_statuses = [
-        resolve_status_name(PlanMyStuff::Pipeline::Status::SUBMITTED),
-        resolve_status_name(PlanMyStuff::Pipeline::Status::STARTED),
+      started = resolve_status_name(PlanMyStuff::Pipeline::Status::STARTED)
+      prior_status != started
+    end
+
+    # Returns true when +project_item+ is at a release-cycle status
+    # ("Ready for Release", "Release in Progress", or "Completed").
+    # Honors configured status aliases.
+    #
+    # Used to lock items against webhook-driven removals once they
+    # enter the release path -- a stray unassign should not yank an
+    # item out of "Release in Progress".
+    #
+    # @param project_item [PlanMyStuff::BaseProjectItem]
+    #
+    # @return [Boolean]
+    #
+    def release_cycle_locked?(project_item)
+      locked_statuses = [
+        resolve_status_name(PlanMyStuff::Pipeline::Status::READY_FOR_RELEASE),
+        resolve_status_name(PlanMyStuff::Pipeline::Status::RELEASE_IN_PROGRESS),
+        resolve_status_name(PlanMyStuff::Pipeline::Status::COMPLETED),
       ]
 
-      early_statuses.exclude?(prior_status)
+      locked_statuses.include?(project_item.status)
     end
 
     # Moves a project item to "Started".
@@ -202,7 +196,9 @@ module PlanMyStuff
       result
     end
 
-    # Moves a project item to "Testing".
+    # Marks a project item as in testing by setting the +Testing+ custom
+    # single-select field to its active value. Does NOT change the item's
+    # +Status+ -- testing runs orthogonally to +In Review+.
     #
     # @param project_item [PlanMyStuff::ProjectItem]
     #
@@ -210,10 +206,19 @@ module PlanMyStuff
     #
     def request_testing!(project_item)
       guard_approvals!(project_item&.issue)
-      status = resolve_status_name(PlanMyStuff::Pipeline::Status::TESTING)
-      result = project_item.move_to!(status)
+      field_name = PlanMyStuff.configuration.pipeline_testing_field_name
+      value = PlanMyStuff.configuration.pipeline_testing_values.fetch(:active)
+      result = project_item.update_single_select_field!(field_name, value)
+
+      ActiveSupport::Notifications.instrument(
+        'plan_my_stuff.pipeline.testing',
+        project_item: project_item,
+        issue_number: project_item.number,
+        field_name: field_name,
+        value: value,
+        timestamp: Time.current,
+      )
 
-      instrument(PlanMyStuff::Pipeline::Status::TESTING, project_item)
       result
     end
 

data/lib/plan_my_stuff/test_helpers.rb

@@ -266,11 +266,6 @@ module PlanMyStuff
       expect_pms_action(:item_assigned, 'item to be assigned', **filters)
     end
 
-    # @param filters [Hash] attribute filters (e.g. assignee:, project_number:)
-    def expect_pms_pipeline_submitted(**filters)
-      expect_pms_action(:pipeline_submitted, 'pipeline submission', **filters)
-    end
-
     # @param filters [Hash] attribute filters (e.g. item_id:)
     def expect_pms_pipeline_taken(**filters)
       expect_pms_action(:pipeline_started, 'pipeline item to be taken', **filters)
@@ -612,36 +607,9 @@ module PlanMyStuff
       def stub_pipeline_methods!
         pipeline_mod = PlanMyStuff::Pipeline
         %i[
-          submit! take! mark_in_review! request_testing! mark_ready_for_release! start_deployment! complete_deployment!
+          take! mark_in_review! request_testing! mark_ready_for_release! start_deployment! complete_deployment!
         ].each { |m| save_original(pipeline_mod, m) }
 
-        pipeline_mod.define_singleton_method(:submit!) do |issue, assignee:, project_number: nil|
-          number =
-            project_number || PlanMyStuff.configuration.pipeline_project_number ||
-            PlanMyStuff.configuration.default_project_number
-
-          PlanMyStuff::TestHelpers.recorded_actions << {
-            type: :pipeline_submitted,
-            params: {
-              issue_number: issue.respond_to?(:number) ? issue.number : nil,
-              assignee: assignee,
-              project_number: number,
-            },
-          }
-
-          project = PlanMyStuff::TestHelpers.build_project(number: number || 1)
-          PlanMyStuff::ProjectItem.build(
-            {
-              id: "PVTI_fake_#{rand(10_000)}",
-              title: issue.respond_to?(:title) ? issue.title : 'Untitled',
-              number: issue.respond_to?(:number) ? issue.number : nil,
-              status: PlanMyStuff::Pipeline::Status::SUBMITTED,
-              field_values: {},
-            },
-            project: project,
-          )
-        end
-
         pipeline_mod.define_singleton_method(:take!) do |project_item|
           PlanMyStuff::TestHelpers.recorded_actions << {
             type: :pipeline_started,
@@ -667,14 +635,23 @@ module PlanMyStuff
         end
 
         pipeline_mod.define_singleton_method(:request_testing!) do |project_item|
+          field_name = PlanMyStuff.configuration.pipeline_testing_field_name
+          value = PlanMyStuff.configuration.pipeline_testing_values.fetch(:active)
+
           PlanMyStuff::TestHelpers.recorded_actions << {
             type: :pipeline_testing,
             params: {
               item_id: project_item.respond_to?(:id) ? project_item.id : nil,
               issue_number: project_item.respond_to?(:number) ? project_item.number : nil,
+              field_name: field_name,
+              value: value,
             },
           }
 
+          if project_item.respond_to?(:field_values) && project_item.field_values.is_a?(Hash)
+            project_item.field_values[field_name] = value
+          end
+
           nil
         end
 

data/lib/plan_my_stuff/version.rb

@@ -3,7 +3,7 @@
 module PlanMyStuff
   module VERSION
     MAJOR = 0
-    MINOR = 5
+    MINOR = 6
     TINY = 0
 
     # Set PRE to nil unless it's a pre-release (beta, rc, etc.)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: plan_my_stuff
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Brands Insurance
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-04-24 00:00:00.000000000 Z
+date: 2026-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -130,8 +130,10 @@ files:
 - lib/plan_my_stuff/metadata_parser.rb
 - lib/plan_my_stuff/notifications.rb
 - lib/plan_my_stuff/pipeline.rb
+- lib/plan_my_stuff/pipeline/completed_sweep.rb
 - lib/plan_my_stuff/pipeline/issue_linker.rb
 - lib/plan_my_stuff/pipeline/status.rb
+- lib/plan_my_stuff/pipeline/testing.rb
 - lib/plan_my_stuff/project.rb
 - lib/plan_my_stuff/project_item.rb
 - lib/plan_my_stuff/project_item_metadata.rb