plan_my_stuff 0.24.0 → 0.26.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1cf33c92cfa763f5ace87a1419cf8c7369f27e8adc10d1c092c044b99d151a4a
-  data.tar.gz: 3b2a482534b9f9094d550385c064f50f4dc37db3c2a6361e4aa899d4b4dc5713
+  metadata.gz: 6561200ae8220464aa3e705f21ae4d6695a4c3ae3db222677bb1deddddcd37b7
+  data.tar.gz: 98d519079e5c203741de10ce667341246d20335253033357a5d3ae8e1b48feee
 SHA512:
-  metadata.gz: ef36dbcfb77d4c3763d2165993c50fb9f4f7e8b0729a1efc1d63fb9155abb039bf9db92fb59a49d3302ebfec024bafc19dd15b54be84a2d7919040405a10803f
-  data.tar.gz: beae8f4926a95e4a47786c4ffefc886300f255466d7e08a7e607f444e91883e920b3bf60d666d33b539eed2dac7a1241f64cd23ae42ebe292a8a113ce150de8d
+  metadata.gz: 8c78d58f9322827d0483389f56dd82d02786929b851cfc6bf81bdc11973f7cdb06e3866b12c40054d4db71f44a24f5c817fd41213b374cf96eeec75e4c384b44
+  data.tar.gz: 9b1464ab72de0568958a73d75bb79f4d7e4095bbebc9e97dcf5f97445c79eace14f83d65da99de36f61c10f5ca37e178e5ffb2ef59afa941cad8f49b3ba56be2

data/CHANGELOG.md

@@ -1,5 +1,36 @@
 # Changelog
 
+## 0.26.0
+
+### Added
+
+- `PlanMyStuff::Issue#awaiting_reply?` - returns `true` when the issue's `Issue Status` field is `Waiting on Reply`.
+- `config.issue_field_names` (canonical field name => consumer field name) and `config.issue_field_values` (canonical
+  field name => `{ canonical value => consumer value }`) let a consuming org rename the native Issue Fields / option
+  labels the gem refers to internally. Translation runs via the new `PlanMyStuff::IssueFieldTranslation` module:
+  canonical => consumer on writes and filters (`set_issue_fields!`, `Issue.list` / `.count` `issue_fields:` +
+  `priority_list:`), consumer => canonical on reads (`Issue#issue_fields`), so internal comparisons like
+  `awaiting_reply?` / `priority_list?` keep working regardless of the org's naming. Unmapped names / values pass
+  through unchanged (identity fallback, mirroring `config.pipeline_statuses`).
+
+### Changed
+
+- The waiting/inactivity lifecycle methods now write the native `Issue Status` issue field alongside their existing
+  label/metadata changes (gated on `config.issue_fields_enabled`): `enter_waiting_on_user!` sets `Waiting on Reply`,
+  `clear_waiting_on_user!` sets `Open`, and `reopen_by_reply!` sets `Reopened`. No-op when `issue_fields_enabled` is
+  `false`.
+
+## 0.25.0
+
+### Added
+
+- `PlanMyStuff::Pipeline.clear_testing!(project_item, user: nil)` - reverses `request_testing!` by writing the
+  `:inactive` Testing field value. Fires `pipeline_testing_cleared.plan_my_stuff` with `field_name`, `value`,
+  `user` payload.
+- `PlanMyStuff::Issues::TestingsController` + `POST/DELETE /issues/:issue_id/testing` route (gated on
+  `config.pipeline_enabled`). Backs new "Request testing" / "Clear testing" buttons on the issue show view
+  (closes #52).
+
 ## 0.24.0
 
 ### Added

data/CONFIGURATION.md

@@ -214,6 +214,8 @@ config.issue_types = {
 | Option | Type | Default | Description |
 |---|---|---|---|
 | `issue_fields_enabled` | `Boolean` | `true` | Whether the Issue Fields public preview is wired up for the org. |
+| `issue_field_names` | `Hash{String => String}` | `{}` | Canonical Issue Field name => the consumer org's field name. |
+| `issue_field_values` | `Hash` | `{}` | Per field: canonical value => consumer value (single-select labels). |
 
 GitHub Issue Fields are structured per-issue metadata (text, number, date, or single-select)
 configured once at the org level. The preview is rolling out org-by-org. Leave this flag at its
@@ -229,6 +231,27 @@ With the flag off:
 config.issue_fields_enabled = false   # org not admitted to the preview yet
 ```
 
+`issue_field_names` and `issue_field_values` let a consuming org rename the native Issue Fields (and their
+single-select option labels) the gem refers to internally, the same way `pipeline_statuses` aliases pipeline
+statuses. Translation is bidirectional via `PlanMyStuff::IssueFieldTranslation`: canonical => consumer on writes and
+filters, consumer => canonical on reads, so internal comparisons (`awaiting_reply?`, `priority_list?`) keep working.
+Unmapped names / values pass through unchanged.
+
+```ruby
+config.issue_field_names = {
+  'Issue Status' => 'Status',
+  'Priority'     => 'Prio',
+}
+config.issue_field_values = {
+  'Issue Status' => {
+    'Submitted'        => 'Triaged',
+    'Waiting on Reply' => 'Awaiting Customer',
+    'Open'             => 'Open',
+    'Reopened'         => 'Reopened',
+  },
+}
+```
+
 ## Release pipeline
 
 | Option | Type | Default | Description |
@@ -392,6 +415,7 @@ Controllable keys (with gem defaults):
 | `:'issues/closures'` | `plan_my_stuff/issues/closures` |
 | `:'issues/viewers'` | `plan_my_stuff/issues/viewers` |
 | `:'issues/takes'` | `plan_my_stuff/issues/takes` |
+| `:'issues/testings'` | `plan_my_stuff/issues/testings` |
 | `:'issues/waitings'` | `plan_my_stuff/issues/waitings` |
 | `:'issues/links'` | `plan_my_stuff/issues/links` |
 | `:'issues/approvals'` | `plan_my_stuff/issues/approvals` |

data/app/controllers/plan_my_stuff/issues/closures_controller.rb

@@ -12,7 +12,11 @@ module PlanMyStuff
       # POST /issues/:issue_id/closure
       def create
         issue = PlanMyStuff::Issue.find(params[:issue_id])
-        issue.update!(state: :closed)
+        to_update = {}
+        if PlanMyStuff.configuration.issue_fields_enabled
+          to_update[:issue_fields] = { 'Issue Status' => 'Fixed' }
+        end
+        issue.update!(state: :closed, **to_update)
 
         yield(issue) if block_given?
         return if performed?
@@ -28,7 +32,11 @@ module PlanMyStuff
       # DELETE /issues/:issue_id/closure
       def destroy
         issue = PlanMyStuff::Issue.find(params[:issue_id])
-        issue.update!(state: :open)
+        to_update = {}
+        if PlanMyStuff.configuration.issue_fields_enabled
+          to_update[:issue_fields] = { 'Issue Status' => 'Reopened' }
+        end
+        issue.update!(state: :open, **to_update)
 
         yield(issue) if block_given?
         return if performed?

data/app/controllers/plan_my_stuff/issues/testings_controller.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+module PlanMyStuff
+  module Issues
+    # Toggles the pipeline +Testing+ custom field on an issue's project item via
+    # +PlanMyStuff::Pipeline.request_testing!+ and +PlanMyStuff::Pipeline.clear_testing!+. Backs the "Request testing" /
+    # "Clear testing" buttons on the mounted issue show view.
+    #
+    # POST   /issues/:issue_id/testing -> create  (flips +Testing+ to its active value)
+    # DELETE /issues/:issue_id/testing -> destroy (flips +Testing+ back to inactive)
+    #
+    class TestingsController < PlanMyStuff::ApplicationController
+      before_action :require_support_user
+
+      # POST /issues/:issue_id/testing
+      def create
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
+        project_item = find_project_item!(issue)
+
+        PlanMyStuff::Pipeline.request_testing!(project_item, user: pms_current_user)
+
+        yield(project_item) if block_given?
+        return if performed?
+
+        flash[:success] = "Issue ##{issue.number} marked as in testing."
+        redirect_to(plan_my_stuff.issue_path(issue))
+      rescue ArgumentError, PlanMyStuff::Error => e
+        pms_handle_rescue(e)
+        flash[:error] = e.message
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
+      end
+
+      # DELETE /issues/:issue_id/testing
+      def destroy
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
+        project_item = find_project_item!(issue)
+
+        PlanMyStuff::Pipeline.clear_testing!(project_item, user: pms_current_user)
+
+        yield(project_item) if block_given?
+        return if performed?
+
+        flash[:success] = "Issue ##{issue.number} testing cleared."
+        redirect_to(plan_my_stuff.issue_path(issue))
+      rescue ArgumentError, PlanMyStuff::Error => e
+        pms_handle_rescue(e)
+        flash[:error] = e.message
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
+      end
+
+      private
+
+        # Redirects non-support users back to the issue page. Mirrors +Issues::TakesController+'s authorization check.
+        #
+        # @return [void]
+        #
+        def require_support_user
+          return if support_user?
+
+          redirect_to_unauthorized(
+            plan_my_stuff.issue_path(params[:issue_id]),
+          )
+        end
+
+        # Looks up the pipeline project item for the issue, raising if missing. Defensive against a stale view (button
+        # rendered before the item was removed) or a race with another tab removing the issue from the pipeline.
+        #
+        # @raise [PlanMyStuff::Error] if the issue is not in the pipeline
+        #
+        # @param issue [PlanMyStuff::Issue]
+        #
+        # @return [PlanMyStuff::ProjectItem]
+        #
+        def find_project_item!(issue)
+          project_item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue.number)
+          return project_item if project_item.present?
+
+          raise(PlanMyStuff::Error, "Issue ##{issue.number} is not in the pipeline.")
+        end
+    end
+  end
+end

data/app/views/plan_my_stuff/issues/show.html.erb

@@ -20,9 +20,24 @@
   <% if @support_user && @pipeline_enabled && @pipeline_item.nil? && @issue.assignees.blank? %>
     <%= button_to('Take', plan_my_stuff.issue_take_path(@issue), method: :post) %>
   <% end %>
-  <% if @support_user && @pipeline_enabled && @current_user_login.present? && @issue.assignees.include?(@current_user_login) %>
+  <%
+    show_unassign =
+      @support_user &&
+      @pipeline_enabled &&
+      @current_user_login.present? &&
+      @issue.assignees.include?(@current_user_login)
+  %>
+  <% if show_unassign %>
     <%= button_to('Unassign', plan_my_stuff.issue_take_path(@issue), method: :delete) %>
   <% end %>
+  <% if @support_user && @pipeline_enabled && @pipeline_item.present? %>
+    <% testing_value = @pipeline_item.field_values[PlanMyStuff.configuration.pipeline_testing_field_name] %>
+    <% if testing_value == PlanMyStuff.configuration.pipeline_testing_values[:active] %>
+      <%= button_to('Clear testing', plan_my_stuff.issue_testing_path(@issue), method: :delete) %>
+    <% else %>
+      <%= button_to('Request testing', plan_my_stuff.issue_testing_path(@issue), method: :post) %>
+    <% end %>
+  <% end %>
   <% if @support_user %>
     <%= link_to('Start Testing Project', plan_my_stuff.new_testing_project_path(subject_url: @issue.html_url)) %>
   <% end %>

data/config/routes.rb

@@ -15,6 +15,11 @@ PlanMyStuff::Engine.routes.draw do
           only: %i[create destroy],
           controller: config.controller_for(:'issues/takes'),
         )
+        resource(
+          :testing,
+          only: %i[create destroy],
+          controller: config.controller_for(:'issues/testings'),
+        )
       end
       resources :comments, only: %i[create edit update], controller: config.controller_for(:comments)
       resources :labels, only: %i[create destroy], controller: config.controller_for(:labels)

data/lib/generators/plan_my_stuff/install/templates/initializer.rb

@@ -193,6 +193,27 @@ PlanMyStuff.configure do |config|
   #
   # config.issue_fields_enabled = false
 
+  # Rename the native Issue Fields the gem refers to internally to whatever your
+  # org actually calls them. Keys are the gem's canonical names; values are your
+  # org's field names. Applied on reads, writes, and filters; unmapped names pass
+  # through unchanged.
+  # config.issue_field_names = {
+  #   'Issue Status' => 'Status',
+  #   'Priority'     => 'Prio',
+  # }
+
+  # Rename single-select option labels, nested by canonical field name. Keys are
+  # the gem's canonical values; values are your org's option labels. Unmapped
+  # fields / values pass through unchanged.
+  # config.issue_field_values = {
+  #   'Issue Status' => {
+  #     'Submitted'        => 'Triaged',
+  #     'Waiting on Reply' => 'Awaiting Customer',
+  #     'Open'             => 'Open',
+  #     'Reopened'         => 'Reopened',
+  #   },
+  # }
+
   # --------------------------------------------------------------------------
   # Boot behavior
   # --------------------------------------------------------------------------
@@ -348,6 +369,7 @@ PlanMyStuff.configure do |config|
   #   :'issues/closures'                => 'plan_my_stuff/issues/closures'
   #   :'issues/viewers'                 => 'plan_my_stuff/issues/viewers'
   #   :'issues/takes'                   => 'plan_my_stuff/issues/takes'
+  #   :'issues/testings'                => 'plan_my_stuff/issues/testings'
   #   :'issues/waitings'                => 'plan_my_stuff/issues/waitings'
   #   :'issues/links'                   => 'plan_my_stuff/issues/links'
   #   :'issues/approvals'               => 'plan_my_stuff/issues/approvals'

data/lib/plan_my_stuff/configuration.rb

@@ -18,6 +18,7 @@ module PlanMyStuff
       'issues/closures': 'plan_my_stuff/issues/closures',
       'issues/viewers': 'plan_my_stuff/issues/viewers',
       'issues/takes': 'plan_my_stuff/issues/takes',
+      'issues/testings': 'plan_my_stuff/issues/testings',
       'issues/waitings': 'plan_my_stuff/issues/waitings',
       'issues/links': 'plan_my_stuff/issues/links',
       'issues/approvals': 'plan_my_stuff/issues/approvals',
@@ -196,6 +197,23 @@ module PlanMyStuff
     #
     attr_accessor :pipeline_testing_values
 
+    # Canonical Issue Field name to consumer field name map. Lets a consuming org rename the native issue fields the
+    # gem refers to internally (e.g. +"Issue Status"+ -> +"Status"+) without touching gem code. Applied via
+    # +PlanMyStuff::IssueFieldTranslation+ on reads, writes, and filters; unmapped names pass through unchanged.
+    #
+    # @return [Hash{String => String}]
+    #
+    attr_accessor :issue_field_names
+
+    # Canonical Issue Field value translations, nested by canonical field name:
+    # +{ 'Issue Status' => { 'Waiting on Reply' => 'Awaiting Customer', ... } }+. Lets a consuming org rename
+    # single-select option labels without touching gem code. Applied via +PlanMyStuff::IssueFieldTranslation+;
+    # unmapped fields / values pass through unchanged.
+    #
+    # @return [Hash{String => Hash{String => String}}]
+    #
+    attr_accessor :issue_field_values
+
     # @return [String] branch name that PRs merge into for "Ready for release" transition
     attr_accessor :main_branch
 
@@ -403,6 +421,8 @@ module PlanMyStuff
       @pipeline_statuses = {}
       @pipeline_testing_field_name = PlanMyStuff::Pipeline::Testing::FIELD_NAME
       @pipeline_testing_values = PlanMyStuff::Pipeline::Testing::VALUES.dup
+      @issue_field_names = {}
+      @issue_field_values = {}
       @main_branch = 'main'
       @production_branch = 'production'
       @mount_groups = { webhooks: true, issues: true, projects: true }

data/lib/plan_my_stuff/issue.rb

@@ -108,6 +108,11 @@ module PlanMyStuff
           raise(PlanMyStuff::IssueFieldsNotEnabledError)
         end
 
+        if issue_fields.present?
+          issue_fields = issue_fields.to_h.transform_keys(&:to_s)
+          issue_fields['Issue Status'] = 'Submitted' if issue_fields['Issue Status'].blank?
+        end
+
         if body.blank?
           raise(PlanMyStuff::ValidationError.new('body must be present', field: :body, expected_type: :string))
         end
@@ -356,7 +361,7 @@ module PlanMyStuff
         field_pairs = []
         field_pairs.concat(build_issue_field_filter_pairs(issue_fields)) if issue_fields.present?
         if priority_list && PlanMyStuff.configuration.issue_fields_enabled
-          field_pairs << 'priority-list:Yes'
+          field_pairs.concat(build_issue_field_filter_pairs('Priority List' => 'Yes'))
         end
         params[:issue_field_values] = field_pairs.join(',') if field_pairs.present?
 
@@ -428,7 +433,7 @@ module PlanMyStuff
         field_pairs = []
         field_pairs.concat(build_issue_field_filter_pairs(issue_fields)) if issue_fields.present?
         if priority_list && PlanMyStuff.configuration.issue_fields_enabled
-          field_pairs << 'priority-list:Yes'
+          field_pairs.concat(build_issue_field_filter_pairs('Priority List' => 'Yes'))
         end
         qualifiers += field_pairs.map { |pair| "field.#{pair}" }
 
@@ -644,11 +649,13 @@ module PlanMyStuff
         #
         def build_issue_field_filter_pairs(hash)
           hash.flat_map do |name, value|
-            slug = field_filter_slug(name)
+            slug = field_filter_slug(PlanMyStuff::IssueFieldTranslation.consumer_field_name(name))
             case value
             when nil then []
             when Range then range_field_filter_pairs(slug, value)
-            else ["#{slug}:#{format_field_filter_value(value)}"]
+            else
+              consumer_value = PlanMyStuff::IssueFieldTranslation.consumer_value(name, value)
+              ["#{slug}:#{format_field_filter_value(consumer_value)}"]
             end
           end
         end
@@ -1028,7 +1035,13 @@ module PlanMyStuff
       raise(PlanMyStuff::IssueFieldsNotEnabledError) unless PlanMyStuff.configuration.issue_fields_enabled
 
       fields_by_name = PlanMyStuff::IssueField.list(org: repo.organization).index_by { |field| field.name.downcase }
-      inputs = updates.map { |name, value| build_issue_field_input(fields_by_name, name, value) }
+      inputs = updates.map do |name, value|
+        build_issue_field_input(
+          fields_by_name,
+          PlanMyStuff::IssueFieldTranslation.consumer_field_name(name),
+          PlanMyStuff::IssueFieldTranslation.consumer_value(name, value),
+        )
+      end
 
       PlanMyStuff.client.graphql(
         PlanMyStuff::GraphQL::Queries::SET_ISSUE_FIELD_VALUES,

data/lib/plan_my_stuff/issue_extractions/waiting.rb

@@ -3,6 +3,11 @@
 module PlanMyStuff
   module IssueExtractions
     module Waiting
+      # @return [Boolean]
+      def awaiting_reply?
+        issue_fields['Issue Status'] == 'Waiting on Reply'
+      end
+
       # Marks the issue as waiting on an end-user reply. Sets +metadata.waiting_on_user_at+ to now, (re)computes
       # +metadata.next_reminder_at+, and adds the configured +waiting_on_user_label+ to the issue. Called from
       # +Comment.create!+ when a support user posts a comment with +waiting_on_reply: true+, and from the
@@ -19,6 +24,11 @@ module PlanMyStuff
         PlanMyStuff::Label.ensure!(repo: repo, name: label)
         PlanMyStuff::Label.add!(issue: self, labels: [label], user: user) if labels.exclude?(label)
 
+        to_update = {}
+        if PlanMyStuff.configuration.issue_fields_enabled
+          to_update[:issue_fields] = { 'Issue Status' => 'Waiting on Reply' }
+        end
+
         self.class.update!(
           number: number,
           repo: repo,
@@ -26,6 +36,7 @@ module PlanMyStuff
             waiting_on_user_at: PlanMyStuff.format_time(now),
             next_reminder_at: format_next_reminder_at(from: now),
           },
+          **to_update,
         )
         reload
       end
@@ -42,6 +53,11 @@ module PlanMyStuff
 
         PlanMyStuff::Label.remove!(issue: self, labels: [label]) if labels.include?(label)
 
+        to_update = {}
+        if PlanMyStuff.configuration.issue_fields_enabled
+          to_update[:issue_fields] = { 'Issue Status' => 'Open' }
+        end
+
         self.class.update!(
           number: number,
           repo: repo,
@@ -50,6 +66,7 @@ module PlanMyStuff
             next_reminder_at:
               metadata.waiting_on_approval_at ? PlanMyStuff.format_time(metadata.next_reminder_at) : nil,
           },
+          **to_update,
         )
         reload
       end
@@ -67,11 +84,17 @@ module PlanMyStuff
         inactive_label = PlanMyStuff.configuration.user_inactive_label
         PlanMyStuff::Label.remove!(issue: self, labels: [inactive_label]) if labels.include?(inactive_label)
 
+        to_update = {}
+        if PlanMyStuff.configuration.issue_fields_enabled
+          to_update[:issue_fields] = { 'Issue Status' => 'Reopened' }
+        end
+
         self.class.update!(
           number: number,
           repo: repo,
           state: :open,
           metadata: { closed_by_inactivity: false },
+          **to_update,
         )
         reload
 

data/lib/plan_my_stuff/issue_field_translation.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+module PlanMyStuff
+  # Translates between the canonical Issue Field names / values the gem refers to internally (e.g. +"Issue Status"+,
+  # +"Waiting on Reply"+) and the names / values a consuming org actually uses on GitHub. Driven by
+  # +config.issue_field_names+ (canonical field name => consumer field name) and +config.issue_field_values+
+  # (canonical field name => { canonical value => consumer value }).
+  #
+  # Outbound (canonical -> consumer) translation happens on writes and filters; inbound (consumer -> canonical) on
+  # reads, so internal comparisons like +issue_fields['Issue Status'] == 'Waiting on Reply'+ keep working regardless of
+  # how the org named the field or option. Unconfigured names / values pass through unchanged (identity fallback,
+  # mirroring +config.pipeline_statuses+).
+  module IssueFieldTranslation
+    module_function
+
+    # @param canonical [String, Symbol] canonical field name
+    #
+    # @return [String] the consumer's field name, or the canonical name when unmapped
+    #
+    def consumer_field_name(canonical)
+      PlanMyStuff.configuration.issue_field_names.fetch(canonical.to_s, canonical.to_s)
+    end
+
+    # @param consumer [String] the consumer's field name (as GitHub returns it)
+    #
+    # @return [String] the canonical field name, or the consumer name when unmapped
+    #
+    def canonical_field_name(consumer)
+      PlanMyStuff.configuration.issue_field_names.invert.fetch(consumer, consumer)
+    end
+
+    # Translates a canonical value to the consumer's value for the given canonical field. Non-String values (numbers,
+    # dates, +nil+) pass through untouched -- only single-select / text labels are translatable.
+    #
+    # @param canonical_field [String, Symbol] canonical field name
+    # @param value [Object, nil] canonical value
+    #
+    # @return [Object, nil] the consumer's value, or the input when unmapped / non-String
+    #
+    def consumer_value(canonical_field, value)
+      return value unless value.is_a?(String)
+
+      value_map(canonical_field).fetch(value, value)
+    end
+
+    # Translates a consumer value back to the canonical value for the given canonical field.
+    #
+    # @param canonical_field [String, Symbol] canonical field name
+    # @param value [Object, nil] consumer value
+    #
+    # @return [Object, nil] the canonical value, or the input when unmapped / non-String
+    #
+    def canonical_value(canonical_field, value)
+      return value unless value.is_a?(String)
+
+      value_map(canonical_field).invert.fetch(value, value)
+    end
+
+    # @param canonical_field [String, Symbol]
+    #
+    # @return [Hash{String => String}] canonical-value => consumer-value map for the field (empty when unconfigured)
+    #
+    def value_map(canonical_field)
+      PlanMyStuff.configuration.issue_field_values.fetch(canonical_field.to_s, {})
+    end
+  end
+end

data/lib/plan_my_stuff/issue_field_value_set.rb

@@ -6,7 +6,8 @@ module PlanMyStuff
   # as +Date+, number fields as +Float+, single-select fields as the option name +String+, and
   # text fields as the raw +String+.
   #
-  # Access is by field display name; string and symbol keys both work. Iteration yields
+  # Access is by canonical field name (consumer names / values are reverse-translated via
+  # +PlanMyStuff::IssueFieldTranslation+ on construction); string and symbol keys both work. Iteration yields
   # +[name, value]+ pairs in the order GitHub returned them.
   class IssueFieldValueSet
     include Enumerable
@@ -19,7 +20,10 @@ module PlanMyStuff
       # @return [PlanMyStuff::IssueFieldValueSet]
       #
       def from_graphql(nodes)
-        pairs = Array.wrap(nodes).map { |node| [node.dig(:field, :name), coerce(node)] }
+        pairs = Array.wrap(nodes).map do |node|
+          canonical_name = PlanMyStuff::IssueFieldTranslation.canonical_field_name(node.dig(:field, :name))
+          [canonical_name, PlanMyStuff::IssueFieldTranslation.canonical_value(canonical_name, coerce(node))]
+        end
         new(pairs.to_h)
       end
 

data/lib/plan_my_stuff/pipeline.rb

@@ -200,6 +200,25 @@ module PlanMyStuff
       result
     end
 
+    # Reverses +request_testing!+ by flipping the +Testing+ custom single-select field back to its inactive value.
+    # Not approval-gated -- the forward transition (+request_testing!+) was already gated, so clearing should always
+    # succeed (matches +remove!+).
+    #
+    # @param project_item [PlanMyStuff::ProjectItem]
+    # @param user [Object, nil] actor forwarded to the +pipeline_testing_cleared.plan_my_stuff+ payload
+    #
+    # @return [Hash] mutation result
+    #
+    def clear_testing!(project_item, user: nil)
+      field_name = PlanMyStuff.configuration.pipeline_testing_field_name
+      value = PlanMyStuff.configuration.pipeline_testing_values.fetch(:inactive)
+      result = project_item.update_single_select_field!(field_name, value)
+
+      instrument('testing_cleared', project_item, field_name: field_name, value: value, user: user)
+
+      result
+    end
+
     # Moves a project item to "Ready for Release".
     #
     # @param project_item [PlanMyStuff::ProjectItem]

data/lib/plan_my_stuff/version.rb

@@ -3,7 +3,7 @@
 module PlanMyStuff
   module VERSION
     MAJOR = 0
-    MINOR = 24
+    MINOR = 26
     TINY = 0
 
     # Set PRE to nil unless it's a pre-release (beta, rc, etc.)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: plan_my_stuff
 version: !ruby/object:Gem::Version
-  version: 0.24.0
+  version: 0.26.0
 platform: ruby
 authors:
 - Brands Insurance
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-05-21 00:00:00.000000000 Z
+date: 2026-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -61,6 +61,7 @@ files:
 - app/controllers/plan_my_stuff/issues/closures_controller.rb
 - app/controllers/plan_my_stuff/issues/links_controller.rb
 - app/controllers/plan_my_stuff/issues/takes_controller.rb
+- app/controllers/plan_my_stuff/issues/testings_controller.rb
 - app/controllers/plan_my_stuff/issues/viewers_controller.rb
 - app/controllers/plan_my_stuff/issues/waitings_controller.rb
 - app/controllers/plan_my_stuff/issues_controller.rb
@@ -133,6 +134,7 @@ files:
 - lib/plan_my_stuff/issue_extractions/viewers.rb
 - lib/plan_my_stuff/issue_extractions/waiting.rb
 - lib/plan_my_stuff/issue_field.rb
+- lib/plan_my_stuff/issue_field_translation.rb
 - lib/plan_my_stuff/issue_field_value_set.rb
 - lib/plan_my_stuff/issue_metadata.rb
 - lib/plan_my_stuff/label.rb