plan_my_stuff 0.17.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe4f92dc92eca010b6fc7f53f4ce7701c6852420c9a537fdf0902e591c3309ad
-  data.tar.gz: b167fd42a3b5a37fc897bebf8f3696ed2cd863ac7049359445a329d9a7861988
+  metadata.gz: 15988155f3d1798b5b0f43cbb1597f7e8b7ed881feb3db2504da7ecd74ab9c59
+  data.tar.gz: 35f298dce675a86ca15153a354411c23806e8420374fe5eb4fd7d2c392e0ed9d
 SHA512:
-  metadata.gz: 746332e19a507f81dc0ee902a87664dcb0a55e3170d688d878b14faf508bfb67cc5dd3236a4961c6b15768fd47e7489b6b0cdbe5bdd5d328bcf9836f805d561d
-  data.tar.gz: 26a20b3318c99f34360bba90eee5698242f4043043991bf53d59e55b2507516452a5094c14366b19f6f53a140ff0b8a41f326a7048c13c4077f447eb2a083513
+  metadata.gz: 838ebf5cb77a3467fb291d76acd9b2ded4cc40d88e65673ca41374324736c6cdc11e5bbc0ed7e04eaf0c0bb5ac4f799c3052379cdc87edcd7343dc30be370059
+  data.tar.gz: b30d829c2255b61485c72d639992f1095f9726b7e6d8952114eef2e44c91f1016c0f05bd3abd238faf0be83a37c8b75ef492208351d33cbbe1f2f689270e7614

data/CHANGELOG.md

@@ -1,5 +1,35 @@
 # Changelog
 
+## 0.19.0
+
+### Added
+
+- Every controller action now yields its primary object to a block when subclassed, so consumers can do
+  `super do |obj| ... end` to wedge in audit-log / instrumentation without rewriting the action. Webhook
+  controllers yield `(payload, result)`. See [CONFIGURATION.md](CONFIGURATION.md).
+
+## 0.18.0
+
+### Breaking
+
+- `PMS::Issue#to_param` now returns `"Nickname-number"` (e.g. `"Rawr-1234"`) instead of the default ActiveModel id.
+  Single-issue URLs change from `/issues/1234?repo=rawr` to `/issues/Rawr-1234`. Consuming apps using
+  `youtrack_issue_path(@issue)` work natively; any hand-rolled URLs that passed `@issue.number` plus a `repo:`
+  query param must switch to `@issue` (or `@issue.to_param`). The mounted engine's controllers and views have
+  been updated to the new shape, as has the markdown link embedded in the GitHub issue body via
+  `Issue#user_link`.
+
+### Added
+
+- `config.repo_nicknames` (default `{}`) -- Symbol-keyed map from repo key to the human-readable label used as
+  the `Issue#to_param` prefix. Missing keys fall back to `key.to_s.titleize`, so `:rawr` -> `"Rawr"` is free;
+  only divergent ones (e.g. `safety: 'Compliance'`) need an entry.
+- `Configuration#repo_nickname_for(key)` accessor, `Repo#nickname`, and `Repo.from_nickname!` for the inverse
+  lookup used by `Issue.from_param`.
+- `Issue#to_param` and `Issue.from_param` -- the latter parses `"Nickname-1234"` back into `[Repo, Integer]`.
+- `Issue.find` first arg now accepts a nickname-id String (e.g. `"Rawr-1234"`) in addition to Integer / digit-
+  String + `repo:` kwarg. The nickname form ignores `repo:`.
+
 ## 0.17.0
 
 ### Added

data/CONFIGURATION.md

@@ -37,13 +37,17 @@ config.organization = 'YourOrg'
 |---|---|---|---|
 | `repos` | `Hash{Symbol => String}` | `{}` | Named repo configs mapping a key to an `Org/Repo` string. |
 | `default_repo` | `Symbol, nil` | `nil` | Repo key used when callers omit the `repo:` param. |
+| `repo_nicknames` | `Hash{Symbol => String}` | `{}` | `Issue#to_param` prefix override (default `key.titleize`). |
 
 ```ruby
 config.repos = { element: 'YourOrg/Element', underwriter: 'YourOrg/Underwriter' }
 config.default_repo = :element
+config.repo_nicknames = { safety: 'Compliance' } # :element -> "Element", :underwriter -> "Underwriter" come free
 ```
 
-`repos` can be mutated via `config.repos[:key] = '...'` or set via `config.repos = { key: 'MyOrg/MyRepo' }`
+`repos` can be mutated via `config.repos[:key] = '...'` or set via `config.repos = { key: 'MyOrg/MyRepo' }`.
+`Issue#to_param` then returns `"Element-1234"` / `"Compliance-567"`, encoding both repo and number in a single
+URL segment so `youtrack_issue_path(@issue)` works without a `repo:` query param.
 
 ## Projects
 
@@ -370,6 +374,54 @@ Controllable keys (with gem defaults):
 | `:'webhooks/github'` | `plan_my_stuff/webhooks/github` |
 | `:'webhooks/aws'` | `plan_my_stuff/webhooks/aws` |
 
+### Customizing per-action behavior
+
+Every mounted route resolves its controller through `config.controller_for(key)`. Subclass a gem controller in your
+own app and register it to wedge in `before_action`s, authentication, or response tweaks - no monkey patching:
+
+```ruby
+# app/controllers/my_app/issues_controller.rb
+class MyApp::IssuesController < PMS::IssuesController
+  before_action :authenticate_user!
+  before_action :authorize_ticket_access
+end
+```
+
+```ruby
+# config/initializers/plan_my_stuff.rb
+PlanMyStuff.configure do |config|
+  config.controllers[:issues] = 'my_app/issues'
+end
+```
+
+For per-action side effects (audit log, metrics, notifications) without rewriting the action, yielding actions
+pass their primary object to an optional block on the happy path. Call `super do |obj| ... end` from a subclass:
+
+```ruby
+class MyApp::IssuesController < PMS::IssuesController
+  def create
+    super do |issue|
+      AuditLog.record(actor: current_user, action: :issue_created, target: issue)
+    end
+  end
+
+  def update
+    super do |issue|
+      AuditLog.record(actor: current_user, action: :issue_updated, target: issue)
+    end
+  end
+end
+```
+
+Contract:
+
+- The yield fires on the happy path, after the model load / write succeeds and before the gem's default
+  `flash[:success]` + `redirect_to`. Error branches, `not_found`, and authorization redirects do not yield.
+- Read actions (`index`, `show`, `new`, `edit`) yield before the implicit render; `index` yields the collection,
+  the rest yield the single object.
+- If your block calls `render` or `redirect_to`, the gem's default response is skipped (the action checks
+  `performed?`), so you can fully replace the response from the block.
+
 ### Parent controller
 
 | Option | Type | Default | Description |

data/README.md

@@ -787,34 +787,6 @@ All routes are under the engine's mount point. Each group can be disabled via `c
 
 ## Controller overrides
 
-Every mounted route resolves its controller through `config.controller_for(key)`, which looks up `config.controllers[key]` and falls back to the gem default. Subclass a gem controller in your own app and register it to wedge in before_actions, authentication, or response tweaks — no monkey patching.
-
-```ruby
-# app/controllers/my_app/issues_controller.rb
-class MyApp::IssuesController < PMS::IssuesController
-  before_action :authenticate_user!
-  before_action :authorize_ticket_access
-end
-```
-
-```ruby
-# config/initializers/plan_my_stuff.rb
-PlanMyStuff.configure do |config|
-  config.controllers['issues'] = 'my_app/issues'
-end
-```
-
-Overridable keys (see `PMS::Configuration::DEFAULT_CONTROLLERS`):
-
-```text
-issues                         issues/closures
-comments                       issues/viewers
-labels                         issues/takes
-projects                       issues/waitings
-project_items                  issues/links
-testing_projects               issues/approvals
-testing_project_items          project_items/statuses
-webhooks/github                project_items/assignments
-webhooks/aws                   testing_project_items/results
-```
+See [CONFIGURATION.md](CONFIGURATION.md#controller-overrides) for the full walkthrough including subclassing,
+per-route registration, and the per-action block hook.
 

data/app/controllers/plan_my_stuff/comments_controller.rb

@@ -4,9 +4,9 @@ module PlanMyStuff
   class CommentsController < PlanMyStuff::ApplicationController
     # POST /issues/:issue_id/comments
     def create
-      @issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+      @issue = PlanMyStuff::Issue.find(params[:issue_id])
 
-      PlanMyStuff::Comment.create!(
+      comment = PlanMyStuff::Comment.create!(
         issue: @issue,
         body: comment_params[:body],
         user: pms_current_user,
@@ -14,12 +14,15 @@ module PlanMyStuff
         waiting_on_reply: comment_params[:waiting_on_reply] == '1',
       )
 
+      yield(comment) if block_given?
+      return if performed?
+
       flash[:success] = 'Comment was successfully created.'
-      redirect_to(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+      redirect_to(plan_my_stuff.issue_path(@issue))
     rescue PlanMyStuff::LockedIssueError => e
       pms_handle_rescue(e)
       flash[:error] = 'This issue is locked; no new comments can be posted.'
-      redirect_to(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+      redirect_to(plan_my_stuff.issue_path(@issue))
     end
 
     # GET /issues/:issue_id/comments/:id/edit
@@ -27,9 +30,14 @@ module PlanMyStuff
       load_comment
       return unless @comment
       return redirect_to_issue if issue_body_comment?
-      return if can_edit?(@comment)
 
-      redirect_to_unauthorized(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+      unless can_edit?(@comment)
+        redirect_to_unauthorized(plan_my_stuff.issue_path(@issue))
+
+        return
+      end
+
+      yield(@comment) if block_given?
     end
 
     # PATCH/PUT /issues/:issue_id/comments/:id
@@ -39,7 +47,7 @@ module PlanMyStuff
       return redirect_to_issue if issue_body_comment?
 
       unless can_edit?(@comment)
-        redirect_to_unauthorized(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+        redirect_to_unauthorized(plan_my_stuff.issue_path(@issue))
 
         return
       end
@@ -49,8 +57,11 @@ module PlanMyStuff
 
       @comment.update!(**update_attrs, user: pms_current_user)
 
+      yield(@comment) if block_given?
+      return if performed?
+
       flash[:success] = 'Comment was successfully updated.'
-      redirect_to(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+      redirect_to(plan_my_stuff.issue_path(@issue))
     rescue PlanMyStuff::StaleObjectError => e
       pms_handle_rescue(e)
       flash.now[:error] = 'Comment was modified by someone else. Please review the latest changes and try again.'
@@ -69,7 +80,7 @@ module PlanMyStuff
       # @return [void]
       #
       def load_comment
-        @issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        @issue = PlanMyStuff::Issue.find(params[:issue_id])
         @comment = PlanMyStuff::Comment.find(params[:id].to_i, issue: @issue)
       end
 
@@ -96,7 +107,7 @@ module PlanMyStuff
 
       # @return [void]
       def redirect_to_issue
-        redirect_to(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+        redirect_to(plan_my_stuff.issue_path(@issue))
       end
   end
 end

data/app/controllers/plan_my_stuff/issues/approvals_controller.rb

@@ -23,9 +23,12 @@ module PlanMyStuff
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.request_approvals!(user_ids: user_ids, user: pms_current_user)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Approvers were successfully added.'
         redirect_to(show_path)
       rescue PlanMyStuff::AuthorizationError, PlanMyStuff::ValidationError => e
@@ -44,7 +47,7 @@ module PlanMyStuff
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         caller_id = pms_current_user.present? ? PlanMyStuff::UserResolver.user_id(pms_current_user) : nil
 
         case status
@@ -71,6 +74,9 @@ module PlanMyStuff
           flash[:success] = 'Response revoked.'
         end
 
+        yield(issue) if block_given?
+        return if performed?
+
         redirect_to(show_path)
       rescue PlanMyStuff::AuthorizationError, PlanMyStuff::ValidationError => e
         pms_handle_rescue(e)
@@ -85,9 +91,12 @@ module PlanMyStuff
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.remove_approvers!(user_ids: [params[:id].to_i], user: pms_current_user)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Approver was successfully removed.'
         redirect_to(show_path)
       rescue PlanMyStuff::AuthorizationError, PlanMyStuff::ValidationError => e
@@ -105,7 +114,7 @@ module PlanMyStuff
 
         # @return [String]
         def show_path
-          plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo])
+          plan_my_stuff.issue_path(params[:issue_id])
         end
     end
   end

data/app/controllers/plan_my_stuff/issues/closures_controller.rb

@@ -11,28 +11,34 @@ module PlanMyStuff
     class ClosuresController < PlanMyStuff::ApplicationController
       # POST /issues/:issue_id/closure
       def create
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.update!(state: :closed)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Issue was successfully closed.'
-        redirect_to(plan_my_stuff.issue_path(issue.number, repo: issue.repo.full_name))
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue PlanMyStuff::Error, ArgumentError => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
 
       # DELETE /issues/:issue_id/closure
       def destroy
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.update!(state: :open)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Issue was successfully reopened.'
-        redirect_to(plan_my_stuff.issue_path(issue.number, repo: issue.repo.full_name))
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue PlanMyStuff::Error, ArgumentError => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
     end
   end

data/app/controllers/plan_my_stuff/issues/links_controller.rb

@@ -21,38 +21,44 @@ module PlanMyStuff
       def create
         type = link_params[:type].to_s
         unless dispatch_allowed?(type, :add)
-          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id]))
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         link = add_link(issue, type)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = "Linked #{link}"
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue PlanMyStuff::ValidationError, ActiveModel::ValidationError, ArgumentError => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
 
       # DELETE /issues/:issue_id/links/:id
       def destroy
         type, repo, number = parse_composite_id(params[:id])
         unless dispatch_allowed?(type, :remove)
-          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id]))
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         remove_link(issue, type, repo: repo, number: number)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = "Unlinked #{repo}##{number}"
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue PlanMyStuff::ValidationError, ActiveModel::ValidationError, ArgumentError => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
 
       private

data/app/controllers/plan_my_stuff/issues/takes_controller.rb

@@ -11,37 +11,35 @@ module PlanMyStuff
 
       # POST /issues/:issue_id/take
       def create
-        issue_number = params[:issue_id].to_i
-        repo = params[:repo]
-
-        issue = PlanMyStuff::Issue.find(issue_number, repo: repo)
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         guard_already_taken!(issue)
 
-        project_item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue_number)
+        project_item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue.number)
         project_item ||= add_to_pipeline(issue)
 
         PlanMyStuff::Pipeline.take!(project_item)
         assign_current_user(project_item)
-        flash[:success] ||= "Issue ##{issue_number} taken."
 
-        redirect_to(plan_my_stuff.issue_path(issue_number, repo: repo))
+        yield(project_item) if block_given?
+        return if performed?
+
+        flash[:success] ||= "Issue ##{issue.number} taken."
+
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue ArgumentError, PlanMyStuff::Error => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(issue_number, repo: repo))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
 
       # DELETE /issues/:issue_id/take
       def destroy
-        issue_number = params[:issue_id].to_i
-        repo = params[:repo]
-
-        issue = PlanMyStuff::Issue.find(issue_number, repo: repo)
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         login = current_user_login
         guard_release!(issue, login)
 
         remaining = issue.assignees - [login]
-        project_item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue_number)
+        project_item = PlanMyStuff::Pipeline::IssueLinker.find_project_item(issue.number)
 
         if project_item.present?
           if remaining.empty?
@@ -54,12 +52,16 @@ module PlanMyStuff
           issue.update!(assignees: remaining)
         end
 
-        flash[:success] = "Issue ##{issue_number} released."
-        redirect_to(plan_my_stuff.issue_path(issue_number, repo: repo))
+        yielded = project_item.presence || issue
+        yield(yielded) if block_given?
+        return if performed?
+
+        flash[:success] = "Issue ##{issue.number} released."
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue ArgumentError, PlanMyStuff::Error => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(issue_number, repo: repo))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
 
       private
@@ -72,7 +74,7 @@ module PlanMyStuff
           return if support_user?
 
           redirect_to_unauthorized(
-            plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]),
+            plan_my_stuff.issue_path(params[:issue_id]),
           )
         end
 

data/app/controllers/plan_my_stuff/issues/viewers_controller.rb

@@ -12,44 +12,50 @@ module PlanMyStuff
       # POST /issues/:issue_id/viewers
       def create
         unless support_user?
-          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id]))
           return
         end
 
         viewer_ids = parse_viewer_ids(params[:viewer_ids])
         if viewer_ids.blank?
           flash[:error] = 'No valid viewer IDs provided.'
-          redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id]))
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.add_viewers!(user_ids: viewer_ids, user: pms_current_user)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Viewers were successfully added.'
-        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id]))
       rescue PlanMyStuff::Error, Octokit::Error => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id]))
       end
 
       # DELETE /issues/:issue_id/viewers/:id
       def destroy
         unless support_user?
-          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id]))
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.remove_viewers!(user_ids: [params[:id].to_i], user: pms_current_user)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Viewer was successfully removed.'
-        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id]))
       rescue PlanMyStuff::Error, Octokit::Error => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.edit_issue_path(params[:issue_id]))
       end
     end
   end

data/app/controllers/plan_my_stuff/issues/waitings_controller.rb

@@ -12,37 +12,43 @@ module PlanMyStuff
       # POST /issues/:issue_id/waiting
       def create
         unless support_user?
-          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id]))
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.enter_waiting_on_user!(user: pms_current_user)
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Issue marked as waiting on user reply.'
-        redirect_to(plan_my_stuff.issue_path(issue.number, repo: issue.repo.full_name))
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue PlanMyStuff::Error, ArgumentError => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
 
       # DELETE /issues/:issue_id/waiting
       def destroy
         unless support_user?
-          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+          redirect_to_unauthorized(plan_my_stuff.issue_path(params[:issue_id]))
           return
         end
 
-        issue = PlanMyStuff::Issue.find(params[:issue_id].to_i, repo: params[:repo])
+        issue = PlanMyStuff::Issue.find(params[:issue_id])
         issue.clear_waiting_on_user!
 
+        yield(issue) if block_given?
+        return if performed?
+
         flash[:success] = 'Waiting-on-user state cleared.'
-        redirect_to(plan_my_stuff.issue_path(issue.number, repo: issue.repo.full_name))
+        redirect_to(plan_my_stuff.issue_path(issue))
       rescue PlanMyStuff::Error, ArgumentError => e
         pms_handle_rescue(e)
         flash[:error] = e.message
-        redirect_to(plan_my_stuff.issue_path(params[:issue_id], repo: params[:repo]))
+        redirect_to(plan_my_stuff.issue_path(params[:issue_id]))
       end
     end
   end

data/app/controllers/plan_my_stuff/issues_controller.rb

@@ -17,11 +17,15 @@ module PlanMyStuff
         page: @page,
         per_page: @per_page,
       )
+
+      yield(@issues) if block_given?
     end
 
     # GET /issues/new
     def new
       @issue = PlanMyStuff::Issue.new
+
+      yield(@issue) if block_given?
     end
 
     # POST /issues
@@ -33,8 +37,11 @@ module PlanMyStuff
         user: pms_current_user,
       )
 
+      yield(@issue) if block_given?
+      return if performed?
+
       flash[:success] = 'Issue was successfully created.'
-      redirect_to(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+      redirect_to(plan_my_stuff.issue_path(@issue))
     rescue PlanMyStuff::ValidationError => e
       pms_handle_rescue(e)
       @issue = PlanMyStuff::Issue.new(title: issue_params[:title], body: issue_params[:body])
@@ -44,22 +51,26 @@ module PlanMyStuff
 
     # GET /issues/:id
     def show
-      @issue = PlanMyStuff::Issue.find(params[:id].to_i, repo: params[:repo])
+      @issue = PlanMyStuff::Issue.find(params[:id])
       @comments = filter_visible_comments(@issue.comments)
       @current_user_id = pms_current_user.present? ? PlanMyStuff::UserResolver.user_id(pms_current_user) : nil
       @current_user_login = PlanMyStuff.configuration.github_login_for[@current_user_id]
       @pipeline_enabled = PlanMyStuff.configuration.pipeline_enabled
       @pipeline_item = load_pipeline_item(@issue.number) if @pipeline_enabled
+
+      yield(@issue) if block_given?
     end
 
     # GET /issues/:id/edit
     def edit
-      @issue = PlanMyStuff::Issue.find(params[:id].to_i, repo: params[:repo])
+      @issue = PlanMyStuff::Issue.find(params[:id])
+
+      yield(@issue) if block_given?
     end
 
     # PATCH/PUT /issues/:id
     def update
-      @issue = PlanMyStuff::Issue.find(params[:id].to_i, repo: params[:repo])
+      @issue = PlanMyStuff::Issue.find(params[:id])
 
       @issue.update!(
         title: issue_params[:title],
@@ -67,8 +78,11 @@ module PlanMyStuff
         labels: parse_labels(issue_params[:labels]),
       )
 
+      yield(@issue) if block_given?
+      return if performed?
+
       flash[:success] = 'Issue was successfully updated.'
-      redirect_to(plan_my_stuff.issue_path(@issue.number, repo: @issue.repo.full_name))
+      redirect_to(plan_my_stuff.issue_path(@issue))
     rescue PlanMyStuff::StaleObjectError => e
       pms_handle_rescue(e)
       flash.now[:error] = 'Issue was modified by someone else. Please review the latest changes and try again.'