plaid 1.6.2 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4864e541a4a65b4efa8e8194f91d066c7b3f694a
-  data.tar.gz: afc22186ed84145fcf742b90b0f6d8a15c7e9817
+  metadata.gz: d25165794e04320e2ff48da2cd6dd25cfd7785ca
+  data.tar.gz: 6e6d8ba0faba8261f5e4b2376171af77f885b038
 SHA512:
-  metadata.gz: 8f50e3280a8334d136c9c5187fcd083a312c46d60d940b46396037ea5bb19670891a7d7d0d10e614cda75dd84046dabbc93dd6b1ad66ab2cd15827057c837a99
-  data.tar.gz: 05d0ebae9c38cf82206a1add734ff56f410adf70aa2aa66bf6b64146cc73652113aa2b226a88a025d11ecd4e2957752cfe4f12bf5e28e4160a6710aa614bda47
+  metadata.gz: 6d9bca2a99a8dc10859bca3cf7a9bcd0fd79eb9395e5a45001b69d09bdc2a2eaa94eabe931fd13c09ac8ddd2e5f2eace878044493d3d2c10570e7d7204462110
+  data.tar.gz: 1d15b40c36f65d1b765ff67b2a4df978a784e676c7275c204227ed7faaf93fb37a88722b1e65be269c0afb0bfa5205c67a708d25ae1aa83e920f045ded9592ff

data/PUBLISHING.md

@@ -0,0 +1,21 @@
+# Publishing
+
+The module is published to the [rubygems.org][1] under the gem name [plaid][2].
+
+The publishing process is handled by [rake][3].
+
+After updating the package version, run:
+
+```console
+$ rake spec
+$ rake build
+$ rake release
+```
+
+See the [semantic versioning][4] guidelines to determine what level of release to publish.
+
+[1]: https://rubygems.org
+[2]: https://rubygems.org/gems/plaid
+[3]: https://github.com/ruby/rake
+[4]: http://semver.org
+

data/README.md

@@ -6,7 +6,7 @@ Ruby bindings for the Plaid API
 
 This version is a beta version that contains failing tests for the new 'info' endpoint. While these have been tested individually on real accounts the tests here will fail with the test accounts supplied. These will be updated soon with test credentials.
 
-Latest stable version: **1.6.2**
+Latest stable version: **1.7.0**
 
 This version removes the need to use 'type' in each additional call.
 

data/lib/plaid/models/account.rb

@@ -4,7 +4,7 @@ module Plaid
 
     def initialize(hash)
       @id   = hash['_id']
-      @name = hash['name']
+      @name = hash['meta']['name'] if hash['meta']
       @type = hash['type']
       @meta = hash['meta']
       @institution_type  = hash['institution_type']

data/lib/plaid/models/institution.rb

@@ -1,14 +1,15 @@
 module Plaid
   class Institution
-    attr_accessor :id, :credentials, :name, :type, :has_mfa, :mfa
+    attr_accessor :id, :name, :type, :has_mfa, :mfa, :credentials, :products
 
     def initialize(fields = {})
       @id = fields['id']
-      @credentials = fields['credentials']
       @name = fields['name']
       @type = fields['type']
       @has_mfa = fields['has_mfa']
       @mfa = fields['mfa']
+      @credentials = fields['credentials']
+      @products = fields['products']
     end
 
     # API: semi-private

data/lib/plaid/models/user.rb

@@ -173,7 +173,7 @@ module Plaid
         end
       end if res['transactions']
 
-      self.pending_mfa_questions = ''
+      self.pending_mfa_questions = {}
       self.information = Information.new(res['info']) if res['info']
       self.api_res = 'success'
 

data/lib/plaid/version.rb

@@ -1,3 +1,3 @@
 module Plaid
-  VERSION = '1.6.2'
+  VERSION = '1.7.0'
 end

data/spec/{config_spec.rb → plaid/config_spec.rb}

@@ -56,12 +56,12 @@ describe 'Plaid.config' do
   context 'has invalid dev keys' do
     let(:secret) { 'test_bad' }
     let(:environment_location) { dev_url }
-    it { expect { user }.to raise_error }
+    it { expect { user }.to raise_error(Plaid::Unauthorized, 'secret or client_id invalid') }
   end
 
   context 'has invalid production keys' do
     let(:secret) { 'test_bad' }
     let(:environment_location) { prod_url }
-    it { expect { user }.to raise_error }
+    it { expect { user }.to raise_error(Plaid::Unauthorized, 'secret or client_id invalid') }
   end
 end

data/spec/{account_spec.rb → plaid/models/account_spec.rb}

@@ -10,7 +10,7 @@ describe Plaid::Account do
       end
     end
 
-    with_results('name' => 'Name') do it { expect(subject.name).to eql('Name') } end
+    with_results('meta' => {'name' => 'Name'}) do it { expect(subject.name).to eql('Name') } end
     with_results('_id' =>  'ID')   do it { expect(subject.id).to   eql('ID') }   end
     with_results('type' => 'Type') do it { expect(subject.type).to eql('Type') } end
     with_results('type' => 'STyp') do it { expect(subject.type).to eql('STyp') } end
@@ -29,5 +29,9 @@ describe Plaid::Account do
     with_results('numbers' => {}) do
       it { expect(subject.numbers).to eql({}) }
     end
+
+    with_results({}) do
+      it { expect(subject.name).to eq nil } # doesn't blow up if 'meta' is missing
+    end
   end
 end

data/spec/{category_spec.rb → plaid/models/category_spec.rb}

@@ -10,7 +10,7 @@ describe Plaid::Category do
   end
 
   context 'when category is not found' do
-    it { expect { Plaid.category('dumb_cat') }.to raise_error }
+    it { expect { Plaid.category('dumb_cat') }.to raise_error(Plaid::NotFound, 'unable to find category') }
   end
 
 end

data/spec/{institution_spec.rb → plaid/models/institution_spec.rb}

@@ -1,7 +1,11 @@
 describe Plaid::Institution do
   context 'when a single institution is found' do
     let(:institution) { Plaid.institution('5301a93ac140de84910000e0') }
+
     it { expect(institution).to be_kind_of(Plaid::Institution) }
+    it { expect(institution.mfa).to be_kind_of(Array) }
+    it { expect(institution.products).to be_kind_of(Array) }
+    it { expect(institution.credentials).to be_kind_of(Hash) }
   end
 
   context 'when all institutions are found' do
@@ -10,6 +14,6 @@ describe Plaid::Institution do
   end
 
   context 'when institution is not found' do
-    it { expect { Plaid.institution('dumb_bank') }.to raise_error }
+    it { expect { Plaid.institution('dumb_bank') }.to raise_error(Plaid::NotFound, 'unable to find institution') }
   end
 end

data/spec/{user_spec.rb → plaid/models/user_spec.rb}

@@ -37,7 +37,7 @@ describe Plaid::User do
     context 'enters incorrect credentials for MFA auth' do
       let(:mfa_user) { user.mfa_authentication('tomato') }
       let(:mfa_bad)  { mfa_user; Plaid.add_user('connect', 'plaid_test', 'plaid_good', 'bofa') }
-      it { expect { mfa_bad.mfa_authentication('bad') }.to raise_error }
+      it { expect { mfa_bad.mfa_authentication('bad') }.to raise_error(Plaid::RequestFailed, 'invalid mfa') }
     end
 
     context 'requests list of MFA credentials' do
@@ -143,7 +143,7 @@ describe Plaid::User do
     let(:info_user) { Plaid.add_user('info', 'plaid_test', 'plaid_good', 'wells') }
 
     context 'updates information correctly' do
-      it { expect { subject.get_info }.to raise_error }
+      it { expect { subject.get_info }.to raise_error(Plaid::Unauthorized, 'client_id missing') }
     end
   end
 
@@ -167,6 +167,6 @@ describe Plaid::User do
 
   # This stuff needs to be tested and rewritten. Have already
   # surfaced up a bug in it
-  pending "#populate_user"
+  pending '#populate_user'
 
 end

data/spec/plaid_spec.rb

@@ -28,13 +28,12 @@ describe Plaid do
 
         context 'when account is locked' do
           let(:password) { 'plaid_locked' }
-          it "raises a locked error" do
-            expect { user }.to raise_error { |error|
-              expect(error).to be_a(Plaid::RequestFailed)
+
+          it 'raises a locked error' do
+            expect { user }.to raise_error(Plaid::RequestFailed) { |error|
               expect(error.code).to eq(1205)
             }
           end
-
         end
 
         context 'with connection options' do
@@ -90,12 +89,12 @@ describe Plaid do
 
         context 'using incorrect password' do
           let(:password) { 'plaid_bad' }
-          it { expect { user }.to raise_error }
+          it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid credentials') }
         end
 
         context 'using incorrect username' do
           let(:username) { 'plaid_bad' }
-          it { expect { user }.to raise_error }
+          it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid credentials') }
         end
       end
 
@@ -104,12 +103,12 @@ describe Plaid do
 
         context 'using incorrect password' do
           let(:password) { 'plaid_bad' }
-          it { expect { user }.to raise_error }
+          it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid credentials') }
         end
 
         context 'using incorrect username' do
           let(:username) { 'plaid_bad' }
-          it { expect { user }.to raise_error }
+          it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid credentials') }
         end
       end
 
@@ -118,12 +117,12 @@ describe Plaid do
 
         context 'using incorrect password' do
           let(:password) { 'plaid_bad' }
-          it { expect { user }.to raise_error }
+          it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid credentials') }
         end
 
         context 'using incorrect username' do
           let(:username) { 'plaid_bad' }
-          it { expect { user }.to raise_error }
+          it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid credentials') }
         end
       end
     end
@@ -141,7 +140,7 @@ describe Plaid do
 
       context 'using incorrect PIN' do
         let(:pin) { '0000' }
-        it { expect { user }.to raise_error }
+        it { expect { user }.to raise_error(Plaid::RequestFailed, 'invalid pin') }
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: plaid
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.7.0
 platform: ruby
 authors:
 - Justin Crites
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-16 00:00:00.000000000 Z
+date: 2015-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -107,6 +107,7 @@ files:
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
+- PUBLISHING.md
 - README.md
 - Rakefile
 - lib/plaid.rb
@@ -122,16 +123,16 @@ files:
 - lib/plaid/models/user.rb
 - lib/plaid/version.rb
 - plaid.gemspec
-- spec/account_spec.rb
-- spec/category_spec.rb
-- spec/config_spec.rb
-- spec/connection_spec.rb
-- spec/institution_spec.rb
-- spec/plaid_error_spec.rb
+- spec/plaid/config_spec.rb
+- spec/plaid/connection_spec.rb
+- spec/plaid/error_spec.rb
+- spec/plaid/models/account_spec.rb
+- spec/plaid/models/category_spec.rb
+- spec/plaid/models/institution_spec.rb
+- spec/plaid/models/transaction_spec.rb
+- spec/plaid/models/user_spec.rb
 - spec/plaid_spec.rb
 - spec/spec_helper.rb
-- spec/transaction_spec.rb
-- spec/user_spec.rb
 homepage: https://github.com/plaid/plaid-ruby
 licenses:
 - MIT
@@ -157,13 +158,13 @@ signing_key:
 specification_version: 4
 summary: Ruby bindings for Plaid
 test_files:
-- spec/account_spec.rb
-- spec/category_spec.rb
-- spec/config_spec.rb
-- spec/connection_spec.rb
-- spec/institution_spec.rb
-- spec/plaid_error_spec.rb
+- spec/plaid/config_spec.rb
+- spec/plaid/connection_spec.rb
+- spec/plaid/error_spec.rb
+- spec/plaid/models/account_spec.rb
+- spec/plaid/models/category_spec.rb
+- spec/plaid/models/institution_spec.rb
+- spec/plaid/models/transaction_spec.rb
+- spec/plaid/models/user_spec.rb
 - spec/plaid_spec.rb
 - spec/spec_helper.rb
-- spec/transaction_spec.rb
-- spec/user_spec.rb