pivotal-tracker 0.5.1 → 0.5.3

data/spec/fixtures/project.xml

@@ -2,6 +2,8 @@
 <project>
   <id>102622</id>
   <name>Pivotal Tracker API Gem</name>
+  <first_iteration_start_time type="datetime">2011/12/05 06:00:00 UTC</first_iteration_start_time>
+  <current_iteration_number type="integer">4</current_iteration_number>
   <iteration_length type="integer">1</iteration_length>
   <week_start_day>Monday</week_start_day>
   <point_scale>0,1,2,3</point_scale>

data/spec/fixtures/projects.xml

@@ -5,6 +5,8 @@
     <name>Pivotal Tracker API Gem</name>
     <iteration_length type="integer">1</iteration_length>
     <week_start_day>Monday</week_start_day>
+    <first_iteration_start_time type="datetime">2011/12/05 06:00:00 UTC</first_iteration_start_time>
+    <current_iteration_number type="integer">4</current_iteration_number>
     <point_scale>0,1,2,3</point_scale>
     <account>Jon</account>
     <velocity_scheme>Average of 3 iterations</velocity_scheme>
@@ -55,6 +57,8 @@
     <name>Pivotal Tracker API Gem Target Project</name>
     <iteration_length type="integer">1</iteration_length>
     <week_start_day>Monday</week_start_day>
+    <first_iteration_start_time type="datetime">2011/12/05 06:00:00 UTC</first_iteration_start_time>
+    <current_iteration_number type="integer">4</current_iteration_number>
     <point_scale>0,1,2,3</point_scale>
     <account>Jon</account>
     <velocity_scheme>Average of 3 iterations</velocity_scheme>

data/spec/fixtures/stale_fish.yml

@@ -112,6 +112,13 @@
       request_type: GET
       update_method: StaleFishFixtures.update_iterations_backlog_fixture
       last_updated_at: 2010-07-29T20:15:15+01:00
+  - iterations_current_backlog:
+      file: 'iterations_current_backlog.xml'
+      update_interval: 2.weeks
+      check_against: http://www.pivotaltracker.com/services/v3/projects/102622/iterations/current_backlog
+      request_type: GET
+      update_method: StaleFishFixtures.update_iterations_current_backlog_fixture
+      last_updated_at: 2010-07-29T20:15:14+01:00
   - iterations_all:
       file: 'iterations_all.xml'
       update_interval: 2.weeks
@@ -133,3 +140,15 @@
       request_type: POST
       update_method: StaleFishFixtures.create_new_story
       last_updated_at: 2010-07-29T20:15:17+01:00
+  - bugs:
+      file: 'bugs.xml'
+      update_interval: nil
+      check_against: http://www.pivotaltracker.com/services/v3/projects/102622/stories?filter=story_type%3Abug
+      request_type: GET
+      last_updated_at: 
+  - features:
+      file: 'features.xml'
+      update_interval: nil
+      check_against: http://www.pivotaltracker.com/services/v3/projects/102622/stories?filter=story_type%3Afeature
+      request_type: GET
+      last_updated_at: 

data/spec/{unit/pivotal-tracker → pivotal-tracker}/activity_spec.rb

@@ -23,8 +23,8 @@ describe PivotalTracker::Activity do
   context "with a specified occurred since date filter" do
     it "should correctly url encode the occurred since date filter in the API call" do
       PivotalTracker::Client.stub!(:connection).and_return connection = double("Client Connection")
-      connection.should_receive(:[]).with("/activities?limit=100&occurred_since_date=2010/07/29%2019:13:00%20+00:00")
-        .and_return double("Connection", :get => '<blah></blah>')
+      url = "/activities?limit=100&occurred_since_date=2010/07/29%2019:13:00%20+00:00"
+      connection.should_receive(:[]).with(url).and_return double("Connection", :get => '<blah></blah>')
       PivotalTracker::Activity.all nil, :limit => 100, :occurred_since_date => DateTime.parse("2010/7/29 19:13:00 UTC")
     end
   end

data/spec/{unit/pivotal-tracker → pivotal-tracker}/attachment_spec.rb

@@ -53,7 +53,7 @@ describe PivotalTracker::Attachment do
 
     it "should return an attachment object with a pending status" do
       FakeWeb.allow_net_connect = true
-      resource = @target_story.upload_attachment(File.dirname(__FILE__) + '/../../../LICENSE')
+      resource = @target_story.upload_attachment(File.dirname(__FILE__) + '/../../LICENSE')
       FakeWeb.allow_net_connect = @orig_net_lock
       resource.should be_a(PivotalTracker::Attachment)
       resource.status.should == 'Pending'

data/spec/pivotal-tracker/client_spec.rb

@@ -0,0 +1,148 @@
+require "spec_helper"
+
+describe PivotalTracker::Client do
+
+  describe ".connection" do
+
+    context "with no existing token" do
+
+      before do
+        PivotalTracker::Client.token = nil
+      end
+
+      it "raises a NoToken exception" do
+        lambda { PivotalTracker::Client.connection }.should raise_error(PivotalTracker::Client::NoToken)
+      end
+
+      describe "after setting a new token" do
+
+        before do
+          PivotalTracker::Client.token = "anewtoken"
+        end
+
+        it "called to RestClient::Resource using the new token" do
+          RestClient::Resource.should_receive(:new).
+              with(PivotalTracker::Client.api_url, :headers => { 'X-TrackerToken' => "anewtoken", 'Content-Type' => 'application/xml' })
+
+          PivotalTracker::Client.connection
+        end
+
+        it "returned the connection for the new token" do
+          @resource = Object.new
+
+          RestClient::Resource.should_receive(:new).
+              with(PivotalTracker::Client.api_url, :headers => { 'X-TrackerToken' => "anewtoken", 'Content-Type' => 'application/xml' }).
+              and_return(@resource)
+
+          PivotalTracker::Client.connection.should == @resource
+
+          # We need to clear the connections or it causes later spec failures
+          PivotalTracker::Client.clear_connections
+        end
+
+      end
+
+    end
+
+    context "with an existing token" do
+
+      before do
+        PivotalTracker::Client.token = "abc123"
+      end
+
+      it "returned a RestClient::Resource using the token" do
+        @resource = Object.new
+
+        RestClient::Resource.should_receive(:new).
+            with(PivotalTracker::Client.api_url, :headers => { 'X-TrackerToken' => "abc123", 'Content-Type' => 'application/xml' }).
+            and_return(@resource)
+
+        PivotalTracker::Client.connection.should == @resource
+      end
+
+      describe "after setting a new token" do
+
+        before do
+          PivotalTracker::Client.token = "anewtoken"
+        end
+
+        it "called to RestClient::Resource using the new token" do
+          RestClient::Resource.should_receive(:new).
+              with(PivotalTracker::Client.api_url, :headers => { 'X-TrackerToken' => "anewtoken", 'Content-Type' => 'application/xml' })
+
+          PivotalTracker::Client.connection
+        end
+
+        it "returned the connection for the new token" do
+          @resource = Object.new
+
+          RestClient::Resource.should_receive(:new).
+              with(PivotalTracker::Client.api_url, :headers => { 'X-TrackerToken' => "anewtoken", 'Content-Type' => 'application/xml' }).
+              and_return(@resource)
+
+          PivotalTracker::Client.connection.should == @resource
+        end
+
+      end
+
+    end
+  end
+
+  describe ".tracker_host" do
+    it "returns www.pivotaltracker.com by default" do
+      PivotalTracker::Client.tracker_host.should == 'www.pivotaltracker.com'
+    end
+  end
+
+  describe ".tracker_host=" do
+    it "sets the tracker_host" do
+      tracker_host_url = 'http://some_other_tracker_tracker_host_url'
+      PivotalTracker::Client.tracker_host = tracker_host_url
+      PivotalTracker::Client.tracker_host.should == tracker_host_url
+      PivotalTracker::Client.tracker_host = nil
+    end
+  end
+
+  describe "#api_ssl_url" do
+    context "when not passed a username and password" do
+      before do
+        PivotalTracker::Client.tracker_host = nil
+        PivotalTracker::Client.use_ssl      = true
+      end
+      it "returns https://www.pivotaltracker.com/services/v3" do
+        PivotalTracker::Client.api_ssl_url.should == 'https://www.pivotaltracker.com/services/v3'
+      end
+    end
+    context "when passed a username and password" do
+      before do
+        PivotalTracker::Client.tracker_host = nil
+        PivotalTracker::Client.use_ssl      = false
+      end
+      it "returns https://USER:PASSWORD@www.pivotaltracker.com/services/v3" do
+        PivotalTracker::Client.api_ssl_url('USER', 'PASSWORD').should == 'https://USER:PASSWORD@www.pivotaltracker.com/services/v3'
+      end
+    end
+  end
+
+  describe "#api_url" do
+    context "when not passed a username and password" do
+      before do
+        PivotalTracker::Client.tracker_host = nil
+        PivotalTracker::Client.use_ssl      = true
+      end
+      it "returns https://www.pivotaltracker.com/services/v3" do
+        PivotalTracker::Client.api_ssl_url.should == 'https://www.pivotaltracker.com/services/v3'
+      end
+    end
+    context "when passed a username and password" do
+      before do
+        PivotalTracker::Client.tracker_host = nil
+        PivotalTracker::Client.use_ssl      = false
+      end
+      it "returns https://www.pivotaltracker.com/services/v3" do
+        PivotalTracker::Client.api_ssl_url('user', 'password').should == 'https://user:password@www.pivotaltracker.com/services/v3'
+      end
+    end
+  end
+
+end

data/spec/{unit/pivotal-tracker → pivotal-tracker}/iteration_spec.rb

@@ -48,6 +48,18 @@ describe PivotalTracker::Iteration do
       @iterations.first.should be_a(PivotalTracker::Iteration)
     end
   end
+  
+  describe ".current_backlog" do
+    before do
+      @iterations = PivotalTracker::Iteration.current_backlog(@project)
+    end
+
+    it "should return an array of Iterations for the given Project" do
+      @iterations.should be_a(Array)
+      @iterations.first.should be_a(PivotalTracker::Iteration)
+    end
+  end
+  
 
 end
 

data/spec/{unit/pivotal-tracker → pivotal-tracker}/project_spec.rb

@@ -13,7 +13,7 @@ describe PivotalTracker::Project do
 
     it "should be a project instance" do
       @projects.first.should be_a(PivotalTracker::Project)
-    end
+    end        
   end
 
   context ".find" do
@@ -32,6 +32,14 @@ describe PivotalTracker::Project do
     it "should have false for use_https" do
       @project.use_https.should be_false
     end
+    
+    it "should have first_iteration_start_time attribute" do
+      @project.respond_to?(:first_iteration_start_time).should be_true
+    end
+     
+    it "should have current_iteration_number attribute" do  
+      @project.respond_to?(:current_iteration_number).should be_true
+    end
   end
 
   context ".stories" do
@@ -67,7 +75,7 @@ describe PivotalTracker::Project do
 
     context "on failure" do
       before do
-        FakeWeb.register_uri(:post, "http://www.pivotaltracker.com/services/v3/projects",
+        FakeWeb.register_uri(:post, "#{PivotalTracker::Client.api_url}/projects",
                              :body   => %{<?xml version="1.0" encoding="UTF-8"?>
              <errors>
                <error>error#1 message</error>

data/spec/{unit/pivotal-tracker → pivotal-tracker}/story_spec.rb

@@ -10,6 +10,20 @@ describe PivotalTracker::Story do
       @project.stories.all.should be_a(Array)
       @project.stories.all.first.should be_a(PivotalTracker::Story)
     end
+
+    it "should allow filtering" do
+      @project.stories.all(:story_type => ['bug']).should be_a(Array)
+      @project.stories.all(:story_type => ['feature']).should be_a(Array)
+    end
+
+    it "should cache stories" do
+      count = @project.stories.all.count
+      @project.stories.all.count.should == count
+      bugs_count = @project.stories.all(:story_type => ['bug']).count
+      bugs_count.should_not == count
+      @project.stories.all(:story_type => ['bug']).count.should == bugs_count
+    end
+
   end
 
   context ".find" do
@@ -25,7 +39,7 @@ describe PivotalTracker::Story do
 
     context "on failure" do
       before do
-        FakeWeb.register_uri(:post, "http://www.pivotaltracker.com/services/v3/projects/#{@project.id}/stories",
+        FakeWeb.register_uri(:post, "#{PivotalTracker::Client.api_url}/projects/#{@project.id}/stories",
           :body => %{<?xml version="1.0" encoding="UTF-8"?>
              <errors>
                <error>error#1 message</error>
@@ -52,43 +66,69 @@ describe PivotalTracker::Story do
       @story.attachments.first.should be_a(PivotalTracker::Attachment)
     end
   end
+  
+  context ".move" do
+    let(:project_id) { @project.id }
+    let(:top_story_id) {4460598}
+    let(:bottom_story_id) {4459994}
+    let(:top_story) { @project.stories.find(top_story_id) }
+    let(:bottom_story) { @project.stories.find(bottom_story_id) }
+    
+    it "should return the moved story when moved before" do      
+      expected_uri = "#{PivotalTracker::Client.api_url}/projects/#{project_id}/stories/#{top_story_id}/moves?move\[move\]=before&move\[target\]=#{bottom_story_id}"
+      FakeWeb.register_uri(:post, expected_uri, :body => %{<story><id type="integer">#{top_story_id}</id></story>})
+      @moved_story = top_story.move(:before, bottom_story)
+      @moved_story.should be_a(PivotalTracker::Story)
+      @moved_story.id.should be(top_story_id)
+    end
+    
+    it "should return the moved story when moved after" do
+      expected_uri = "#{PivotalTracker::Client.api_url}/projects/#{project_id}/stories/#{bottom_story_id}/moves?move\[move\]=after&move\[target\]=#{top_story_id}"
+      FakeWeb.register_uri(:post, expected_uri, :body => %{<story><id type="integer">#{bottom_story_id}</id></story>})
+      @moved_story = bottom_story.move(:after, top_story)
+      @moved_story.should be_a(PivotalTracker::Story)
+      @moved_story.id.should be(bottom_story_id)
+    end
+    
+    it "should raise an error when trying to move in an invalid position" do
+      expect { top_story.move(:next_to, bottom_story) }.to raise_error(ArgumentError)
+    end
+  end
 
   context ".move_to_project" do
-    before(:each) do
-      pending
-      @orig_net_lock = FakeWeb.allow_net_connect?
-      FakeWeb.allow_net_connect = true
-      @target_project = PivotalTracker::Project.find(103014)
-      @movable_story = @project.stories.find(4490874)
+    let(:expected_uri) {"#{PivotalTracker::Client.api_url}/projects/#{project_id}/stories/#{story_id}"}
+    let(:project_id) { @project.id }
+    let(:movable_story) { @project.stories.find(4459994) }
+    let(:story_id) { movable_story.id }
+    let(:target_project) { PivotalTracker::Project.new(:id => 103014) }
+
+    before do
+      FakeWeb.register_uri(:put, expected_uri, :body => %{<?xml version="1.0" encoding="UTF-8"?>
+                                                       <story>
+                                                         <project_id type="integer">#{target_project.id}</project_id>
+                                                       </story>})
     end
 
     it "should return an updated story from the target project when passed a PivotalTracker::Story" do
-      target_story = @target_project.stories.find(4477972)
-      response = @movable_story.move_to_project(target_story)
+      target_story = PivotalTracker::Story.new(:project_id => target_project.id)
+      response = movable_story.move_to_project(target_story)
+      response.should_not be_nil
       response.project_id.should == target_story.project_id
     end
 
     it "should return an updated story from the target project when passed a PivotalTracker::Project" do
-      response = @movable_story.move_to_project(@target_project)
-      response.project_id.should == @target_project.id
+      response = movable_story.move_to_project(target_project)
+      response.project_id.should == target_project.id
     end
 
     it "should return an updated story from the target project when passed a String" do
-      response = @movable_story.move_to_project('103014')
-      response.project_id.should == 103014
+      response = movable_story.move_to_project(target_project.id.to_s)
+      response.project_id.should == target_project.id
     end
 
     it "should return an updated story from the target project when passed an Integer"do
-      response = @movable_story.move_to_project(103014)
-      response.project_id.should == 103014
-    end
-
-    after (:each) do
-      pending
-      @movable_story = @target_project.stories.find(4490874)
-      response = @movable_story.move_to_project(102622)
-      FakeWeb.allow_net_connect = @orig_net_lock
-      response.project_id.should == 102622
+      response = movable_story.move_to_project(target_project.id.to_i)
+      response.project_id.should == target_project.id
     end
   end
 

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'bundler'
+require 'fileutils'
 
 Bundler.require(:default, :runtime, :test)
 $LOAD_PATH.unshift(File.dirname(__FILE__))
@@ -8,12 +9,13 @@ require 'pivotal-tracker'
 require 'rspec'
 require 'rspec/autorun'
 
-PROJECT_ID = ENV['PROJECT_ID'] || "102622"
+PROJECT_ID = ENV['PROJECT_ID'] || 102622
 TOKEN = '8358666c5a593a3c82cda728c8a62b63'
 
 PivotalTracker::Client.token = TOKEN
 
-# tm: hack StaleFish
+# tm: hack StaleFish to prevent it from accessing real API which slows down the test.
+#   Fixtures should be upated manually.
 module StaleFish
   class Fixture
     def is_stale?
@@ -26,13 +28,19 @@ end
 # in ./support/ and its subdirectories.
 Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
 
-StaleFish.setup(File.join(File.dirname(__FILE__), 'fixtures', 'stale_fish.yml'))
 
 RSpec.configure do |config|
-  # config.include(Rack::Test::Methods)
+  # Give StaleFish temporary file which is ignored by git
+  org_stale_fish_config = File.join(File.dirname(__FILE__), 'fixtures', 'stale_fish.yml')
+  tmp_stale_fish_config = File.join(File.dirname(__FILE__), 'fixtures', 'stale_fish-tmp.yml')
+  FileUtils.copy_file org_stale_fish_config, tmp_stale_fish_config, :remove_destination => true
+  StaleFish.setup(tmp_stale_fish_config)
 
   config.before :suite do
     StaleFish.update_stale
   end
 
+  config.before :each do
+    PivotalTracker::Client.clear_connections
+  end
 end