pivotal-tracker-api 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d076ef0979ef0aebf4912f3aa3ed0b340ae56617
-  data.tar.gz: a06ea8d52ffa481d0a90c044be227566e972f2ea
+  metadata.gz: 560e9d8e7bd5655593e3cd8b1d42411305ad29c2
+  data.tar.gz: eeb4255fb00eb9bfffaf6ac4d473c0e3af93ccf8
 SHA512:
-  metadata.gz: 854894d31492f4758ae51c1ed4c389d29e8f1d06d676474611b053160b6c46f845120ce07fa10121a3332d6ef67f416b0662009ac497d488fe856e75683344fc
-  data.tar.gz: 7682da2fd003458cb6dfb7ff655af03d0bc5555eec82b01ac2ab4c730899a35db28b087f691bee4e38b28d41835a1439265f561858289811a370db41d2bafc5d
+  metadata.gz: 1bf81cf50034cfbd2f5bef545cfc323c84bf28c1b2ae7851504d67286313a048676dd4bbb0139811ca78bf6445976f207a0cb85564f5ce6e62a132c90d0ca92b
+  data.tar.gz: d7b52ae07c22aa081f8e18480f6b8187b81df6f05b0649adae915c8a21fb57be159733db4fca4eecdf12011f0012aedca81b03c87286e2381dab04893812059a

data/VERSION

@@ -1 +1 @@
-0.1.5
+0.1.6

data/lib/pivotal-tracker-api/comment.rb

@@ -4,7 +4,8 @@ module Scorer
     attr_accessor :story, :project_id, :story_id, :id, :text, :author, :created_at, :updated_at, :file_attachments
 
     def self.fields
-      ['person', 'text', 'updated_at', 'id', 'created_at', 'story_id', 'file_attachments']
+      ["person(#{Scorer::Person.fields.join(',')})", 'text', 'updated_at', 'id',
+       'created_at', 'story_id', 'file_attachments']
     end
 
     def self.parse_json_comments(json_comments, story)

data/lib/pivotal-tracker-api/iteration.rb

@@ -7,20 +7,10 @@ module Scorer
       update_attributes(attributes)
     end
 
-    def self.parse_json_iteration_with_comments(json_iteration)
-      parse_iteration(json_iteration, true)
-    end
-
     def self.parse_json_iteration(json_iteration)
-      parse_iteration(json_iteration, false)
-    end
-
-    protected
-
-    def self.parse_iteration(json_iteration, with_comments)
       new({
         project_id: json_iteration[:project_id].to_i,
-        stories: parse_stories(json_iteration[:stories], json_iteration[:project_id].to_i, with_comments),
+        stories: parse_stories(json_iteration[:stories], json_iteration[:project_id].to_i),
         story_ids: json_iteration[:story_ids],
         number: json_iteration[:number],
         team_strength: json_iteration[:team_strength],
@@ -30,11 +20,13 @@ module Scorer
       })
     end
 
-    def self.parse_stories(stories, project_id, with_comments)
+    protected
+
+    def self.parse_stories(stories, project_id)
       story_ids = Array.new
       stories.each { |story| story_ids << story[:id].to_i if !story[:id].nil? }
       project = PivotalService.one_project(project_id)
-      PivotalService.stories(project, true, with_comments, story_ids, Scorer::Story.fields)
+      PivotalService.stories(project, true, story_ids, Scorer::Story.fields)
     end
 
     def update_attributes(attrs)

data/lib/pivotal-tracker-api/person.rb

@@ -3,6 +3,10 @@ module Scorer
 
     attr_accessor :name, :id, :initials, :email, :username
 
+    def self.fields
+      ['name', 'id', 'initials', 'email', 'username']
+    end
+
     def initialize(attributes={})
       update_attributes(attributes)
     end

data/lib/pivotal-tracker-api/pivotal_service.rb

@@ -33,7 +33,7 @@ class PivotalService
       Scorer::Activity.parse_json_activity(json_activity, project_id)
     end
 
-    def iterations(project_id, scope, get_comments, fields=[], limit=1, offset=1)
+    def iterations(project_id, scope, fields=[], limit=1, offset=1)
       return @iteration if !@iteration.nil? && @iteration.project_id == project_id
 
       api_url = "/projects/#{project_id}/iterations?"
@@ -46,20 +46,15 @@ class PivotalService
       api_url = append_fields(api_url, fields)
       response = Scorer::Client.get_with_caching(api_url)
       json_iterations = JSON.parse(response, {:symbolize_names => true})
-      if get_comments
-        @iteration = Scorer::Iteration.parse_json_iteration_with_comments(json_iterations[0])
-      else
-        @iteration = Scorer::Iteration.parse_json_iteration(json_iterations[0])
-      end
-      @iteration
+      @iteration = Scorer::Iteration.parse_json_iteration(json_iterations[0])
     end
 
-    def all_stories(project_label, project, get_comments, fields=[])
+    def all_stories(project_label, project, fields=[])
       api_url = append_fields('/projects' + "/#{project.id}/stories", fields)
       api_url = api_url + "&with_label=#{project_label}&with_state=unstarted&limit=100"
       response = Scorer::Client.get(api_url)
       json_stories = JSON.parse(response, {:symbolize_names => true})
-      Scorer::Story.parse_json_stories(json_stories, project.id, get_comments)
+      Scorer::Story.parse_json_stories(json_stories, project.id)
     end
 
     def one_story(project_label, project, fields=[])
@@ -70,7 +65,7 @@ class PivotalService
       Scorer::Story.parse_json_story(json_story, project.id)
     end
 
-    def stories(project, should_cache, get_comments, ids=[], fields=[])
+    def stories(project, should_cache, ids=[], fields=[])
       @stories = Array.new
       api_url = append_fields('/projects' + "/#{project.id}/stories", fields)
       api_url = api_url.rindex('?fields=') ? "#{api_url}&filter=id%3A" : "#{api_url}?filter=id%3A"
@@ -82,7 +77,7 @@ class PivotalService
           response = Scorer::Client.get(api_url)
         end
         json_story = JSON.parse(response, {:symbolize_names => true})
-        @stories << Scorer::Story.parse_json_story(json_story[0], project.id, get_comments)
+        @stories << Scorer::Story.parse_json_story(json_story[0], project.id)
       else
         story_ids = ''
         ids.each do |id|
@@ -95,7 +90,7 @@ class PivotalService
           response = Scorer::Client.get(api_url)
         end
         json_stories = JSON.parse(response, {:symbolize_names => true})
-        @stories = Scorer::Story.parse_json_stories(json_stories, project.id, get_comments)
+        @stories = Scorer::Story.parse_json_stories(json_stories, project.id)
       end
     end
 

data/lib/pivotal-tracker-api/story.rb

@@ -14,10 +14,10 @@ module Scorer
       ['url', 'name', 'description', 'story_type',
        'estimate', 'current_state', 'requested_by',
        'owned_by', 'labels', 'integration_id',
-       'deadline', 'comments', 'tasks']
+       'deadline', "comments(#{Scorer::Comment.fields.join(',')})", 'tasks']
     end
 
-    def self.parse_json_story(json_story, project_id, get_comments)
+    def self.parse_json_story(json_story, project_id)
       requested_by = json_story[:requested_by][:name] if !json_story[:requested_by].nil?
       story_id = json_story[:id].to_i
       estimate = json_story[:estimate] ? json_story[:estimate].to_i : -1
@@ -39,11 +39,7 @@ module Scorer
         deadline: json_story[:deadline]
       })
 
-      if get_comments
-        parsed_story.comments = get_story_comments(project_id, parsed_story)
-      else
-        parsed_story.comments = Scorer::Comment.parse_json_comments(json_story[:comments], parsed_story)
-      end
+      parsed_story.comments = Scorer::Comment.parse_json_comments(json_story[:comments], parsed_story)
       parsed_story.has_attachments = false
       if !parsed_story.comments.nil? && parsed_story.comments.count > 0
         parsed_story.comments.each do |note|
@@ -57,18 +53,14 @@ module Scorer
       parsed_story
     end
 
-    def self.parse_json_stories(json_stories, project_id, get_comments)
+    def self.parse_json_stories(json_stories, project_id)
       stories = Array.new
       json_stories.each do |story|
-        stories << parse_json_story(story, project_id, get_comments)
+        stories << parse_json_story(story, project_id)
       end
       stories
     end
 
-    def self.get_story_comments(project_id, story)
-      PivotalService.comments(project_id, story, Scorer::Comment.fields)
-    end
-
     def self.parse_tasks(tasks, story)
       parsed_tasks = Array.new
       if tasks

data/pivotal-tracker-api.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: pivotal-tracker-api 0.1.5 ruby lib
+# stub: pivotal-tracker-api 0.1.6 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "pivotal-tracker-api"
-  s.version = "0.1.5"
+  s.version = "0.1.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["jfox"]
-  s.date = "2014-01-31"
+  s.date = "2014-02-01"
   s.description = "A ruby gem to communicate with the Picotal Tracker API v5"
   s.email = "atljeremy@me.com"
   s.extra_rdoc_files = [

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pivotal-tracker-api
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - jfox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-31 00:00:00.000000000 Z
+date: 2014-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client