pitchfork 0.15.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a36b331190b5554261852d4a7da0f2e074723cdd1d7ad33a2274a0a532f7ea46
-  data.tar.gz: bb8ade8d07f6669d1f1e1d55500951d7a27057bf03aa7043caa55dfd8813728b
+  metadata.gz: 96240978a658c76297ea22353c5851d80bee9f033a74420b025d9941e32476be
+  data.tar.gz: fb90757e6e6a86e31e43bfed1589ed8ecf95c5f3d6f7cbe9802e10f588dd68b8
 SHA512:
-  metadata.gz: 3ef8b8ef5217c5b4cc6a63313151ef2d5c1cb823e25caa99f851def3a24e2ad62527db30c06102acea7cdf0638f9627668b931135a093d31ea99fe30c5ae141c
-  data.tar.gz: 5b92506d1725596b4fb772dd4d0ebe850daf574787d94573083bf0dc3e3e245d5cbde07c7bc7fb85ceb936e33c01c9a71b44aa25c8752b7c4ca325af80ab1957
+  metadata.gz: bcfffa4d9e8cb3e92c3dbd89d5a3c32577e5170a039d0e3fd71d5b57b408c6d2cadaf2bb42009cc14714de75b60c42fe3e0273d01bf8f9d49777e09f4d137e2a
+  data.tar.gz: d663cbd0e73221ab8dff5dafb2696293cb2552d2026ae6faa0a4c4d28c61ae672d6745c1de5b52baaa5062c4d08ed2d0945ac0986e05cc20e62f713bb8fda84a

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Unreleased
 
+# 0.16.0
+
+- Use `exit!` for exiting the middle process when forking a new worker or mold. 
+  This skips `at_exit` and finalizer hooks, which shouldn't be needed.
+
 # 0.15.0
 
 - Encode pure ASCII strings in Rack env as UTF-8, as allowed by the rack spec.

data/lib/pitchfork/http_server.rb

@@ -1173,9 +1173,8 @@ module Pitchfork
           w.close
           # We need to wait(2) so that the middle process doesn't end up a zombie.
           # The process only call fork again an exit so it should be pretty fast.
-          # However it might need to execute some `Process._fork` or `at_exit` callbacks,
-          # as well as Ruby's cleanup procedure to run finalizers etc, and there is a risk
-          # of deadlock.
+          # However it might need to execute some `Process._fork` callbacks,
+          # so there is a risk of deadlock.
           # So in case it takes more than 5 seconds to exit, we kill it.
           # TODO: rather than to busy loop here, we handle it in the worker/mold loop
           process_wait_with_timeout(middle_pid, FORK_TIMEOUT)
@@ -1196,7 +1195,12 @@ module Pitchfork
           end
           w.puts(pid)
           w.close
-          exit
+
+          # We use exit! to skip `at_exit` and finalizers.
+          # These will be ran when both the parent and child exit, this middle process
+          # is just an implementation detail and running these hooks here is more likely
+          # to cause issues than being actually needed.
+          exit!
         end
       else
         Pitchfork.clean_fork(&block)

data/lib/pitchfork/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Pitchfork
-  VERSION = "0.15.0"
+  VERSION = "0.16.0"
   module Const
     UNICORN_VERSION = '6.1.0'
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pitchfork
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.16.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-24 00:00:00.000000000 Z
+date: 2024-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack