pippi 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 896e82f6e2cf4dab869124c38159fada16b72b97
-  data.tar.gz: ed2e62b742ffdc6a750c80d52a1e83ee00347ae1
+  metadata.gz: bd4bb5e3d9e8a7c1b97def8b8c81a3ebc1bcf6b1
+  data.tar.gz: ba99f8da56b5dcdb9a73989b377e76e9b1f006c0
 SHA512:
-  metadata.gz: b97e79a1af7f290e69acb952ebf5fe1a35155b42ceda4b946c8a0bb44ae26c6da7459d4e86b57a315176fafb051b9ca3dbdd55d9aac0e0d538dc188a84e95f57
-  data.tar.gz: 423bcbabce73b144fd9ecab55847cf0cf80380d9f02ecc4969af16389bb60a74f5bc3fe13e2db3e2a82fc2b03ae427f7ec3eaebd0b08196e06b4153f82a44500
+  metadata.gz: 5f59f05b8883eae2a0781097494d5a73cb25a25c673d593de4d011605012642763473c7ea7b6b95c592bcfde0d889bd171b7e2da3a78d4de120a82a685bb772e
+  data.tar.gz: e85313fc90ffaddc56a566e6a2016cd85e22ce5f8c506474c3e22cde50b8f0fc2a254b139e9df66a93b9285599a005a1f04107fdae418fd10dedc9a65aff4d30

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.0.8 (2014-12-04)
+
+ * [NEW] Added SelectFollowedByAny
+ * [FIXED] False positives reduced
+
 ## 0.0.7 (2014-12-01)
 
  * [FIXED] Support for Ruby 2.0

data/README.md

@@ -141,6 +141,22 @@ Instead, consider doing this:
 [1,2,3].reverse_each {|x| x+1 }
 ```
 
+#### SelectFollowedByAny
+
+Don't use select followed by any?; use any? with a block instead
+
+For example, rather than doing this:
+
+```ruby
+[1,2,3].select {|x| x > 1 }.any?
+```
+
+Instead, consider doing this:
+
+```ruby
+[1,2,3].any? {|x| x > 1 }
+```
+
 #### SelectFollowedByEmpty
 
 Don't use select followed by empty?; use none? instead
@@ -330,6 +346,7 @@ rm -rf pippi_debug.log pippi.log .bundle/gems/pippi-0.0.1/ .bundle/cache/pippi-0
 * Tie off Changelog notes
 * Regenerate docs with `pippi:generate_docs`, copy and paste that into README
 * Commit, push
+* Tag the release
 * `bundle exec gem build pippi.gemspec`
 * `gem push pippi-x.gem`
 * Update pippi_demo

data/doc/docs.md

@@ -16,6 +16,22 @@ Instead, consider doing this:
 [1,2,3].reverse_each {|x| x+1 }
 ```
 
+#### SelectFollowedByAny
+
+Don't use select followed by any?; use any? with a block instead
+
+For example, rather than doing this:
+
+```ruby
+[1,2,3].select {|x| x > 1 }.any?
+```
+
+Instead, consider doing this:
+
+```ruby
+[1,2,3].any? {|x| x > 1 }
+```
+
 #### SelectFollowedByEmpty
 
 Don't use select followed by empty?; use none? instead
@@ -50,7 +66,7 @@ Instead, consider doing this:
 
 #### SelectFollowedBySelect
 
-Don't use select followed by select; use a single select instead
+Don't use consecutive select blocks; use a single select instead
 
 For example, rather than doing this:
 

data/lib/pippi/check_set_mapper.rb

@@ -22,6 +22,7 @@ module Pippi
         "basic" => [
           "SelectFollowedByFirst",
           "SelectFollowedBySize",
+          "SelectFollowedByAny",
           "SelectFollowedByEmpty",
           "ReverseFollowedByEach",
           "SelectFollowedBySelect"

data/lib/pippi/checks/check.rb

@@ -11,7 +11,7 @@ module Pippi::Checks
     end
 
     def method_names_that_indicate_this_is_being_used_as_a_collection
-      [:collect!, :compact!, :flatten!, :map!, :reject!, :reverse!, :rotate!, :select!, :shuffle!, :slice!, :sort!, :sort_by!, :uniq!, :collect, :compact, :flatten, :map, :reject, :reverse, :rotate, :select, :shuffle, :slice, :sort, :sort_by, :uniq]
+      [:collect!, :compact!, :flatten!, :map!, :reject!, :reverse!, :rotate!, :select!, :shuffle!, :slice!, :sort!, :sort_by!, :uniq!, :collect, :compact, :first, :flatten, :join, :last, :map, :reject, :reverse, :rotate, :select, :shuffle, :slice, :sort, :sort_by, :uniq]
     end
 
     def add_problem
@@ -19,9 +19,8 @@ module Pippi::Checks
       ctx.report.add(Pippi::Problem.new(line_number: problem_location.lineno, file_path: problem_location.path, check_class: self.class))
     end
 
-    def clear_fault_proc(clz)
+    def clear_fault_proc(clz, problem_location)
       proc do |*args, &blk|
-        problem_location = caller_locations.find { |c| c.to_s !~ /byebug|lib\/pippi\/checks/ }
         clz.clear_fault(problem_location.lineno, problem_location.path)
         super(*args, &blk)
       end

data/lib/pippi/checks/select_followed_by_any.rb

@@ -0,0 +1,56 @@
+module Pippi::Checks
+
+  class SelectFollowedByAny < Check
+
+    module MyAny
+      def any?(&blk)
+        self.class._pippi_check_select_followed_by_any.add_problem
+        problem_location = caller_locations.find { |c| c.to_s !~ /byebug|lib\/pippi\/checks/ }
+        self.class._pippi_check_select_followed_by_any.method_names_that_indicate_this_is_being_used_as_a_collection.each do |this_means_its_ok_sym|
+          define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_any.clear_fault_proc(self.class._pippi_check_select_followed_by_any, problem_location))
+        end
+        super
+      end
+    end
+
+    module MySelect
+      def select(&blk)
+        result = super
+        if self.class._pippi_check_select_followed_by_any.nil?
+          # Ignore Array subclasses since select or any may have difference meanings
+          # elsif defined?(ActiveRecord::Relation) && self.class.kind_of?(ActiveRecord::Relation) # maybe also this
+        else
+          result.extend MyAny
+          self.class._pippi_check_select_followed_by_any.array_mutator_methods.each do |this_means_its_ok_sym|
+            result.define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_any.its_ok_watcher_proc(MyAny, :any?))
+          end
+        end
+        result
+      end
+    end
+
+    def decorate
+      Array.class_exec(self) do |my_check|
+        @_pippi_check_select_followed_by_any = my_check
+        def self._pippi_check_select_followed_by_any
+          @_pippi_check_select_followed_by_any
+        end
+        prepend MySelect
+      end
+    end
+
+    class Documentation
+      def description
+        "Don't use select followed by any?; use any? with a block instead"
+      end
+      def sample
+        "[1,2,3].select {|x| x > 1 }.any?"
+      end
+      def instead_use
+        "[1,2,3].any? {|x| x > 1 }"
+      end
+    end
+
+  end
+
+end

data/lib/pippi/checks/select_followed_by_empty.rb

@@ -5,8 +5,9 @@ module Pippi::Checks
     module MyEmpty
       def empty?(&blk)
         self.class._pippi_check_select_followed_by_empty.add_problem
+        problem_location = caller_locations.find { |c| c.to_s !~ /byebug|lib\/pippi\/checks/ }
         self.class._pippi_check_select_followed_by_empty.method_names_that_indicate_this_is_being_used_as_a_collection.each do |this_means_its_ok_sym|
-          define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_empty.clear_fault_proc(self.class._pippi_check_select_followed_by_empty))
+          define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_empty.clear_fault_proc(self.class._pippi_check_select_followed_by_empty, problem_location))
         end
         super
       end

data/lib/pippi/checks/select_followed_by_size.rb

@@ -3,8 +3,9 @@ module Pippi::Checks
     module MySize
       def size
         self.class._pippi_check_select_followed_by_size.add_problem
+        problem_location = caller_locations.find { |c| c.to_s !~ /byebug|lib\/pippi\/checks/ }
         self.class._pippi_check_select_followed_by_size.method_names_that_indicate_this_is_being_used_as_a_collection.each do |this_means_its_ok_sym|
-          define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_size.clear_fault_proc(self.class._pippi_check_select_followed_by_size))
+          define_singleton_method(this_means_its_ok_sym, self.class._pippi_check_select_followed_by_size.clear_fault_proc(self.class._pippi_check_select_followed_by_size, problem_location))
         end
         super()
       end

data/lib/pippi/version.rb

@@ -1,3 +1,3 @@
 module Pippi
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

data/lib/pippi.rb

@@ -13,6 +13,7 @@ require 'pippi/checks/reverse_followed_by_each'
 require 'pippi/checks/select_followed_by_first'
 require 'pippi/checks/select_followed_by_size'
 require 'pippi/checks/select_followed_by_empty'
+require 'pippi/checks/select_followed_by_any'
 require 'pippi/checks/select_followed_by_select'
 require 'pippi/checks/assert_with_nil'
 require 'pippi/checks/debug_check'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pippi
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-02 00:00:00.000000000 Z
+date: 2014-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -74,6 +74,7 @@ files:
 - lib/pippi/checks/debug_check.rb
 - lib/pippi/checks/map_followed_by_flatten.rb
 - lib/pippi/checks/reverse_followed_by_each.rb
+- lib/pippi/checks/select_followed_by_any.rb
 - lib/pippi/checks/select_followed_by_empty.rb
 - lib/pippi/checks/select_followed_by_first.rb
 - lib/pippi/checks/select_followed_by_select.rb